Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in mlx5_vdpa_add_mac_vlan_rules()

2023-01-27 Thread Michael S. Tsirkin
ngliang ; virtualization@lists.linux- > > foundation.org; jasow...@redhat.com > > Subject: Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in > > mlx5_vdpa_add_mac_vlan_rules() > > > > On Wed, Jan 04, 2023 at 11:41:31AM +, Eli Cohen wrote: > > > I see these patches

Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in mlx5_vdpa_add_mac_vlan_rules()

2023-01-09 Thread Jason Wang
On Wed, Jan 4, 2023 at 3:42 PM Yang Yingliang wrote: > > The local variable 'rule' is not used anymore, fix return value > check after calling mlx5_add_flow_rules(). > > Fixes: 8b14d56c6128 ("vdpa/mlx5: Add RX counters to debugfs") > Signed-off-by: Yang Yingliang Acked-by: Jason Wang Thanks >

Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in mlx5_vdpa_add_mac_vlan_rules()

2023-01-04 Thread Michael S. Tsirkin
On Wed, Jan 04, 2023 at 11:41:31AM +, Eli Cohen wrote: > I see these patches were not sent yet. > Michael/Yang Yinglliang, isn't it better to send a fixed patch instead of > sending the original and fix on top of it? depends on the severity of the fix. in this case it seems to leak uninitiali