Re: [virtio-dev] Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On 18/11/2016 05:07, Michael S. Tsirkin wrote: > On Fri, Nov 18, 2016 at 12:32:06PM +0900, Namhyung Kim wrote: >> Btw I prefer using the kvmtool for my kernel work since it's much more >> simpler.. > > Up to you but then you should extend that to support 1.0 spec. > I strongly object to adding

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On 18/11/2016 04:32, Namhyung Kim wrote: >> In addition, the firmware will need to reserve a few KB of RAM for the error >> log >> address range (I checked a real system and it reserves 8KB). The first eight >> bytes are needed for the record identifier interface, because there's no such >>

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Fri, Nov 18, 2016 at 12:32:06PM +0900, Namhyung Kim wrote: > Btw I prefer using the kvmtool for my kernel work since it's much more > simpler.. > > Thanks, > Namhyung Up to you but then you should extend that to support 1.0 spec. I strongly object to adding to the list of legacy interfaces we

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi, Thanks for your detailed information, On Wed, Nov 16, 2016 at 07:10:36AM -0500, Paolo Bonzini wrote: > > Not sure how independent ERST is from ACPI and other specs. It looks > > like referencing UEFI spec at least. > > It is just the format of error records that comes from the UEFI spec >

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

> Not sure how independent ERST is from ACPI and other specs. It looks > like referencing UEFI spec at least. It is just the format of error records that comes from the UEFI spec (include/linux/cper.h) but you can ignore it, I think. It should be handled by tools on the host side. For you, the

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi, On Tue, Nov 15, 2016 at 11:38 PM, Paolo Bonzini wrote: > > > On 15/11/2016 15:36, Namhyung Kim wrote: >> Hi, >> >> On Tue, Nov 15, 2016 at 10:57:29AM +0100, Paolo Bonzini wrote: >>> >>> >>> On 15/11/2016 06:06, Michael S. Tsirkin wrote: On Tue, Nov 15, 2016 at

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Tue, Nov 15, 2016 at 02:50:11PM +0900, Namhyung Kim wrote: > On Tue, Nov 15, 2016 at 07:06:28AM +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > > > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > > > [SNIP] > > > > >

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On 15/11/2016 15:36, Namhyung Kim wrote: > Hi, > > On Tue, Nov 15, 2016 at 10:57:29AM +0100, Paolo Bonzini wrote: >> >> >> On 15/11/2016 06:06, Michael S. Tsirkin wrote: >>> On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: Hi Michael, On Thu, Nov 10, 2016 at

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi, On Tue, Nov 15, 2016 at 10:57:29AM +0100, Paolo Bonzini wrote: > > > On 15/11/2016 06:06, Michael S. Tsirkin wrote: > > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > >> Hi Michael, > >> > >> On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > >>> On Sat,

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On 15/11/2016 06:06, Michael S. Tsirkin wrote: > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: >> Hi Michael, >> >> On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: >>> On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: The virtio pstore driver

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Tue, Nov 15, 2016 at 07:06:28AM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > > [SNIP] > > > > +struct virtio_pstore_fileinfo { > > > > + __virtio64

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote: > Hi Michael, > > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > > On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > > > The virtio pstore driver provides interface to the pstore subsystem so > > >

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi Michael, On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote: > On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > >

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi Stefan, On Thu, Sep 22, 2016 at 12:57:44PM +0100, Stefan Hajnoczi wrote: > On Sun, Sep 04, 2016 at 11:38:58PM +0900, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > > machine.

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Sun, Sep 04, 2016 at 11:38:58PM +0900, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hello Michael, Thanks for your detailed review. Btw are you ok with the overall direction of the patch? On Tue, Sep 13, 2016 at 06:19:41PM +0300, Michael S. Tsirkin wrote: > On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Sun, Sep 4, 2016 at 7:38 AM, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi Michael, On Wed, Aug 31, 2016 at 05:54:04PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 31, 2016 at 05:08:00PM +0900, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > >

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Wed, Aug 31, 2016 at 05:08:00PM +0900, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Tue, Jul 19, 2016 at 10:43 PM, Namhyung Kim wrote: > The other one is the file management on the host side. I am thinking > of a simple way that the log file is splitted when it exceeds the half > of the allowed max size. It would be configurable and might allow >

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Tue, Jul 19, 2016 at 10:43 PM, Namhyung Kim wrote: > Hi Kees, > > On Mon, Jul 18, 2016 at 10:50:06AM -0700, Kees Cook wrote: >> On Sun, Jul 17, 2016 at 10:50 PM, Namhyung Kim wrote: >> > Hello, >> > >> > On Sun, Jul 17, 2016 at 10:12:26PM -0700, Kees

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hi Kees, On Mon, Jul 18, 2016 at 10:50:06AM -0700, Kees Cook wrote: > On Sun, Jul 17, 2016 at 10:50 PM, Namhyung Kim wrote: > > Hello, > > > > On Sun, Jul 17, 2016 at 10:12:26PM -0700, Kees Cook wrote: > >> On Sun, Jul 17, 2016 at 9:37 PM, Namhyung Kim

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Sun, Jul 17, 2016 at 10:50 PM, Namhyung Kim wrote: > Hello, > > On Sun, Jul 17, 2016 at 10:12:26PM -0700, Kees Cook wrote: >> On Sun, Jul 17, 2016 at 9:37 PM, Namhyung Kim wrote: >> > The virtio pstore driver provides interface to the pstore subsystem

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

Hello, On Mon, Jul 18, 2016 at 09:54:39AM +0200, Cornelia Huck wrote: > On Mon, 18 Jul 2016 13:37:39 +0900 > Namhyung Kim wrote: > > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Mon, 18 Jul 2016 17:29:55 +0900 Namhyung Kim wrote: > On Mon, Jul 18, 2016 at 09:54:39AM +0200, Cornelia Huck wrote: > > On Mon, 18 Jul 2016 13:37:39 +0900 > > Namhyung Kim wrote: > > > +#define VIRT_PSTORE_ORDER2 > > > +#define

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Mon, 18 Jul 2016 13:37:39 +0900 Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the >

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

On Sun, Jul 17, 2016 at 9:37 PM, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest