Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Xuan Zhuo
On Thu, 29 Dec 2022 12:08:23 +0800, Jason Wang wrote: > On Thu, Dec 29, 2022 at 11:49 AM Xuan Zhuo wrote: > > > > On Thu, 29 Dec 2022 11:22:13 +0800, Jason Wang wrote: > > > On Thu, Dec 29, 2022 at 10:10 AM Xuan Zhuo > > > wrote: > > > > > > > > On Wed, 28 Dec 2022 19:41:13 +0800, Jason Wang

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Jason Wang
On Thu, Dec 29, 2022 at 11:49 AM Xuan Zhuo wrote: > > On Thu, 29 Dec 2022 11:22:13 +0800, Jason Wang wrote: > > On Thu, Dec 29, 2022 at 10:10 AM Xuan Zhuo > > wrote: > > > > > > On Wed, 28 Dec 2022 19:41:13 +0800, Jason Wang > > > wrote: > > > > On Wed, Dec 28, 2022 at 4:34 PM Xuan Zhuo >

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Xuan Zhuo
On Thu, 29 Dec 2022 11:22:13 +0800, Jason Wang wrote: > On Thu, Dec 29, 2022 at 10:10 AM Xuan Zhuo wrote: > > > > On Wed, 28 Dec 2022 19:41:13 +0800, Jason Wang wrote: > > > On Wed, Dec 28, 2022 at 4:34 PM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 27 Dec 2022 01:58:22 -0500, "Michael S.

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Jason Wang
On Thu, Dec 29, 2022 at 10:10 AM Xuan Zhuo wrote: > > On Wed, 28 Dec 2022 19:41:13 +0800, Jason Wang wrote: > > On Wed, Dec 28, 2022 at 4:34 PM Xuan Zhuo > > wrote: > > > > > > On Tue, 27 Dec 2022 01:58:22 -0500, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Dec 27, 2022 at 12:33:53PM

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Xuan Zhuo
On Wed, 28 Dec 2022 19:41:13 +0800, Jason Wang wrote: > On Wed, Dec 28, 2022 at 4:34 PM Xuan Zhuo wrote: > > > > On Tue, 27 Dec 2022 01:58:22 -0500, "Michael S. Tsirkin" > > wrote: > > > On Tue, Dec 27, 2022 at 12:33:53PM +0800, Jason Wang wrote: > > > > On Tue, Dec 27, 2022 at 10:25 AM Xuan

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Xuan Zhuo
On Wed, 28 Dec 2022 19:43:56 +0800, Jason Wang wrote: > On Wed, Dec 28, 2022 at 4:40 PM Xuan Zhuo wrote: > > > > On Tue, 27 Dec 2022 12:33:53 +0800, Jason Wang wrote: > > > On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Jason Wang
On Wed, Dec 28, 2022 at 4:40 PM Xuan Zhuo wrote: > > On Tue, 27 Dec 2022 12:33:53 +0800, Jason Wang wrote: > > On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo > > wrote: > > > > > > On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang > > > wrote: > > > > We used to busy waiting on the cvq command this

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Jason Wang
On Wed, Dec 28, 2022 at 4:34 PM Xuan Zhuo wrote: > > On Tue, 27 Dec 2022 01:58:22 -0500, "Michael S. Tsirkin" > wrote: > > On Tue, Dec 27, 2022 at 12:33:53PM +0800, Jason Wang wrote: > > > On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo > > > wrote: > > > > > > > > On Mon, 26 Dec 2022 15:49:08

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Xuan Zhuo
On Tue, 27 Dec 2022 12:33:53 +0800, Jason Wang wrote: > On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo wrote: > > > > On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang wrote: > > > We used to busy waiting on the cvq command this tends to be > > > problematic since: > > > > > > 1) CPU could wait for

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-28 Thread Xuan Zhuo
On Tue, 27 Dec 2022 01:58:22 -0500, "Michael S. Tsirkin" wrote: > On Tue, Dec 27, 2022 at 12:33:53PM +0800, Jason Wang wrote: > > On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo > > wrote: > > > > > > On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang > > > wrote: > > > > We used to busy waiting on

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-27 Thread Jason Wang
在 2022/12/27 17:31, Michael S. Tsirkin 写道: On Tue, Dec 27, 2022 at 05:17:20PM +0800, Jason Wang wrote: In particular, we will also directly break the device. It's kind of hardening for malicious devices. ATM no amount of hardening can prevent a malicious hypervisor from blocking the guest.

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-27 Thread Michael S. Tsirkin
On Tue, Dec 27, 2022 at 05:17:20PM +0800, Jason Wang wrote: > > > > In particular, we will also directly break the device. > > > It's kind of hardening for malicious devices. > > ATM no amount of hardening can prevent a malicious hypervisor from > > blocking the guest. Recovering when a hardware

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-27 Thread Jason Wang
在 2022/12/27 14:58, Michael S. Tsirkin 写道: On Tue, Dec 27, 2022 at 12:33:53PM +0800, Jason Wang wrote: On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo wrote: On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang wrote: We used to busy waiting on the cvq command this tends to be problematic since: 1)

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-26 Thread Michael S. Tsirkin
On Tue, Dec 27, 2022 at 12:33:53PM +0800, Jason Wang wrote: > On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo wrote: > > > > On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang wrote: > > > We used to busy waiting on the cvq command this tends to be > > > problematic since: > > > > > > 1) CPU could wait

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-26 Thread Jason Wang
On Tue, Dec 27, 2022 at 10:25 AM Xuan Zhuo wrote: > > On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang wrote: > > We used to busy waiting on the cvq command this tends to be > > problematic since: > > > > 1) CPU could wait for ever on a buggy/malicous device > > 2) There's no wait to terminate the

Re: [PATCH 4/4] virtio-net: sleep instead of busy waiting for cvq command

2022-12-26 Thread Xuan Zhuo
On Mon, 26 Dec 2022 15:49:08 +0800, Jason Wang wrote: > We used to busy waiting on the cvq command this tends to be > problematic since: > > 1) CPU could wait for ever on a buggy/malicous device > 2) There's no wait to terminate the process that triggers the cvq >command > > So this patch