Re: [PATCH net-next V3] virtio_net: ethtool tx napi configuration
On 2018年10月11日 13:34, David Miller wrote: From: Jason Wang Date: Tue, 9 Oct 2018 10:06:26 +0800 Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. Interrupt moderation is currently not supported, so these accept and display the default settings of 0 usec and 1 frame. Toggle tx napi through setting tx-frames. So as to not interfere with possible future interrupt moderation, value 1 means tx napi while value 0 means not. Only allow the switching when device is down for simplicity. Link: https://patchwork.ozlabs.org/patch/948149/ Suggested-by: Jason Wang Signed-off-by: Willem de Bruijn Signed-off-by: Jason Wang --- Changes from V2: - only allow the switching when device is done - remove unnecessary global variable and initialization Changes from V1: - try to synchronize with datapath to allow changing mode when interface is up. - use tx-frames 0 as to disable tx napi while tx-frames 1 to enable tx napi Applied, with... + bool running = netif_running(dev); this unused variable removed. My bad, thanks for the fixup. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH net-next V3] virtio_net: ethtool tx napi configuration
From: Jason Wang Date: Tue, 9 Oct 2018 10:06:26 +0800 > Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. > Interrupt moderation is currently not supported, so these accept and > display the default settings of 0 usec and 1 frame. > > Toggle tx napi through setting tx-frames. So as to not interfere > with possible future interrupt moderation, value 1 means tx napi while > value 0 means not. > > Only allow the switching when device is down for simplicity. > > Link: https://patchwork.ozlabs.org/patch/948149/ > Suggested-by: Jason Wang > Signed-off-by: Willem de Bruijn > Signed-off-by: Jason Wang > --- > Changes from V2: > - only allow the switching when device is done > - remove unnecessary global variable and initialization > Changes from V1: > - try to synchronize with datapath to allow changing mode when > interface is up. > - use tx-frames 0 as to disable tx napi while tx-frames 1 to enable tx napi Applied, with... > + bool running = netif_running(dev); this unused variable removed. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
