Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Toshiaki Makita
On 2018/08/03 14:07, Jason Wang wrote: > On 2018年08月03日 12:04, Tonghao Zhang wrote: >> On Fri, Aug 3, 2018 at 11:43 AM Jason Wang  wrote: >>> >>> On 2018年08月03日 11:24, Tonghao Zhang wrote: On Fri, Aug 3, 2018 at 11:07 AM Jason Wang  wrote: > On 2018年08月03日 10:51, Tonghao Zhang wrote:

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Jason Wang
On 2018年08月03日 12:04, Tonghao Zhang wrote: On Fri, Aug 3, 2018 at 11:43 AM Jason Wang wrote: On 2018年08月03日 11:24, Tonghao Zhang wrote: On Fri, Aug 3, 2018 at 11:07 AM Jason Wang wrote: On 2018年08月03日 10:51, Tonghao Zhang wrote: On Thu, Aug 2, 2018 at 5:23 PM Jason Wang wrote: On

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Toshiaki Makita
On 2018/08/03 13:14, Tonghao Zhang wrote: > On Fri, Aug 3, 2018 at 11:40 AM Toshiaki Makita > wrote: >> >> On 2018/08/03 12:24, Tonghao Zhang wrote: >>> On Fri, Aug 3, 2018 at 11:07 AM Jason Wang wrote: On 2018年08月03日 10:51, Tonghao Zhang wrote: > On Thu, Aug 2, 2018 at 5:23 PM Jason

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Tonghao Zhang
On Fri, Aug 3, 2018 at 11:40 AM Toshiaki Makita wrote: > > On 2018/08/03 12:24, Tonghao Zhang wrote: > > On Fri, Aug 3, 2018 at 11:07 AM Jason Wang wrote: > >> On 2018年08月03日 10:51, Tonghao Zhang wrote: > >>> On Thu, Aug 2, 2018 at 5:23 PM Jason Wang wrote: > On 2018年08月02日 16:41, Toshiaki

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Tonghao Zhang
On Fri, Aug 3, 2018 at 11:43 AM Jason Wang wrote: > > > > On 2018年08月03日 11:24, Tonghao Zhang wrote: > > On Fri, Aug 3, 2018 at 11:07 AM Jason Wang wrote: > >> > >> > >> On 2018年08月03日 10:51, Tonghao Zhang wrote: > >>> On Thu, Aug 2, 2018 at 5:23 PM Jason Wang wrote: > > On

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Jason Wang
On 2018年08月03日 11:32, Toshiaki Makita wrote: On 2018/08/03 12:07, Jason Wang wrote: On 2018年08月02日 17:23, Jason Wang wrote: No need to enable rx virtqueue, if we are sure handle_rx() will be called soon. If we disable rx virtqueue in handle_tx and don't send packets from guest

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Toshiaki Makita
On 2018/08/03 12:24, Tonghao Zhang wrote: > On Fri, Aug 3, 2018 at 11:07 AM Jason Wang wrote: >> On 2018年08月03日 10:51, Tonghao Zhang wrote: >>> On Thu, Aug 2, 2018 at 5:23 PM Jason Wang wrote: On 2018年08月02日 16:41, Toshiaki Makita wrote: > On 2018/08/02 17:18, Jason Wang wrote: >>

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Toshiaki Makita
On 2018/08/03 12:07, Jason Wang wrote: > On 2018年08月02日 17:23, Jason Wang wrote: >>> >> No need to enable rx virtqueue, if we are sure handle_rx() will be >> called soon. > If we disable rx virtqueue in handle_tx and don't send packets from > guest anymore(handle_tx is not

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Tonghao Zhang
On Fri, Aug 3, 2018 at 11:07 AM Jason Wang wrote: > > > > On 2018年08月03日 10:51, Tonghao Zhang wrote: > > On Thu, Aug 2, 2018 at 5:23 PM Jason Wang wrote: > >> > >> > >> On 2018年08月02日 16:41, Toshiaki Makita wrote: > >>> On 2018/08/02 17:18, Jason Wang wrote: > On 2018年08月01日 17:52, Tonghao

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Jason Wang
On 2018年08月03日 10:51, Tonghao Zhang wrote: On Thu, Aug 2, 2018 at 5:23 PM Jason Wang wrote: On 2018年08月02日 16:41, Toshiaki Makita wrote: On 2018/08/02 17:18, Jason Wang wrote: On 2018年08月01日 17:52, Tonghao Zhang wrote: +static void vhost_net_busy_poll_check(struct vhost_net *net, +

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Jason Wang
On 2018年08月02日 17:23, Jason Wang wrote: No need to enable rx virtqueue, if we are sure handle_rx() will be called soon. If we disable rx virtqueue in handle_tx and don't send packets from guest anymore(handle_tx is not called), so we can wake up for sock rx. so the network is broken. Not

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Tonghao Zhang
On Thu, Aug 2, 2018 at 5:23 PM Jason Wang wrote: > > > > On 2018年08月02日 16:41, Toshiaki Makita wrote: > > On 2018/08/02 17:18, Jason Wang wrote: > >> On 2018年08月01日 17:52, Tonghao Zhang wrote: > +static void vhost_net_busy_poll_check(struct vhost_net *net, > +

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Jason Wang
On 2018年08月02日 17:57, Toshiaki Makita wrote: On 2018/08/02 18:23, Jason Wang wrote: On 2018年08月02日 16:41, Toshiaki Makita wrote: On 2018/08/02 17:18, Jason Wang wrote: On 2018年08月01日 17:52, Tonghao Zhang wrote: +static void vhost_net_busy_poll_check(struct vhost_net *net, + 

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Toshiaki Makita
On 2018/08/02 18:23, Jason Wang wrote: > On 2018年08月02日 16:41, Toshiaki Makita wrote: >> On 2018/08/02 17:18, Jason Wang wrote: >>> On 2018年08月01日 17:52, Tonghao Zhang wrote: > +static void vhost_net_busy_poll_check(struct vhost_net *net, > +   struct

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Jason Wang
On 2018年08月02日 16:41, Toshiaki Makita wrote: On 2018/08/02 17:18, Jason Wang wrote: On 2018年08月01日 17:52, Tonghao Zhang wrote: +static void vhost_net_busy_poll_check(struct vhost_net *net, + struct vhost_virtqueue *rvq, +

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Toshiaki Makita
On 2018/08/02 17:18, Jason Wang wrote: > On 2018年08月01日 17:52, Tonghao Zhang wrote: >>> +static void vhost_net_busy_poll_check(struct vhost_net *net, >>> + struct vhost_virtqueue *rvq, >>> + struct vhost_virtqueue *tvq, >>> +

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-02 Thread Jason Wang
On 2018年08月01日 17:52, Tonghao Zhang wrote: + + cpu_relax(); + } + + preempt_enable(); + + if (!rx) + vhost_net_enable_vq(net, vq); No need to enable rx virtqueue, if we are sure handle_rx() will be called soon. If we disable rx virtqueue in handle_tx and

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-01 Thread Tonghao Zhang
On Wed, Aug 1, 2018 at 2:01 PM Jason Wang wrote: > > > > On 2018年08月01日 11:00, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > Factor out generic busy polling logic and will be > > used for in tx path in the next patch. And with the patch, > > qemu can set differently the

Re: [PATCH net-next v7 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-08-01 Thread Jason Wang
On 2018年08月01日 11:00, xiangxia.m@gmail.com wrote: From: Tonghao Zhang Factor out generic busy polling logic and will be used for in tx path in the next patch. And with the patch, qemu can set differently the busyloop_timeout for rx queue. In the handle_tx, the busypoll will