Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Michael S. Tsirkin
On Wed, Oct 13, 2021 at 02:52:38PM +0200, Cornelia Huck wrote: > On Wed, Oct 13 2021, "Michael S. Tsirkin" wrote: > > > On Wed, Oct 13, 2021 at 01:23:50PM +0200, Christian Borntraeger wrote: > >> Can we get this kernel patch queued for 5.15 and stable without waiting > >> for the QEMU patch >

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Cornelia Huck
On Wed, Oct 13 2021, "Michael S. Tsirkin" wrote: > On Wed, Oct 13, 2021 at 01:23:50PM +0200, Christian Borntraeger wrote: >> Can we get this kernel patch queued for 5.15 and stable without waiting for >> the QEMU patch >> as we have a regression with 4.14? > > Probably. Still trying to decide

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Michael S. Tsirkin
On Wed, Oct 13, 2021 at 02:44:08PM +0200, Halil Pasic wrote: > On Wed, 13 Oct 2021 08:24:53 -0400 > "Michael S. Tsirkin" wrote: > > > > > OK this looks good! How about a QEMU patch to make it spec compliant on > > > > BE? > > > > > > Who is going to do that? Halil? you? Conny? > > > >

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Halil Pasic
On Wed, 13 Oct 2021 08:24:53 -0400 "Michael S. Tsirkin" wrote: > > > OK this looks good! How about a QEMU patch to make it spec compliant on > > > BE? > > > > Who is going to do that? Halil? you? Conny? > > Halil said he'll do it... Right, Halil? I can do it but not right away. Maybe in a

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Michael S. Tsirkin
On Wed, Oct 13, 2021 at 01:23:50PM +0200, Christian Borntraeger wrote: > > > Am 13.10.21 um 12:10 schrieb Michael S. Tsirkin: > > On Mon, Oct 11, 2021 at 07:39:21AM +0200, Halil Pasic wrote: > > > The virtio specification virtio-v1.1-cs01 states: "Transitional devices > > > MUST detect Legacy

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Christian Borntraeger
Am 13.10.21 um 12:10 schrieb Michael S. Tsirkin: On Mon, Oct 11, 2021 at 07:39:21AM +0200, Halil Pasic wrote: The virtio specification virtio-v1.1-cs01 states: "Transitional devices MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not been acknowledged by the driver."

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Michael S. Tsirkin
On Mon, Oct 11, 2021 at 07:39:21AM +0200, Halil Pasic wrote: > The virtio specification virtio-v1.1-cs01 states: "Transitional devices > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not > been acknowledged by the driver." This is exactly what QEMU as of 6.1 > has done

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-11 Thread Cornelia Huck
On Mon, Oct 11 2021, Halil Pasic wrote: > The virtio specification virtio-v1.1-cs01 states: "Transitional devices > MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not > been acknowledged by the driver." This is exactly what QEMU as of 6.1 > has done relying solely on