RE: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
> -Original Message- > From: Denis V. Lunev [mailto:d...@openvz.org] > Sent: Monday, October 12, 2015 6:46 AM > To: Eric Blake > Cc: Gleb Natapov ; qemu-de...@nongnu.org; > virtualization@lists.linux-foundation.org; rka...@virtuozzo.com; Paolo > Bonzini ; Andrey Smetanin > ; Vitaly Kuznetsov ; KY > Srinivasan > Subject: Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit > > On 10/12/2015 04:42 PM, Eric Blake wrote: > > On 10/09/2015 07:39 AM, Denis V. Lunev wrote: > >> From: Andrey Smetanin > >> > >> A new vcpu exit is introduced to notify the userspace of the > >> changes in Hyper-V synic configuraion triggered by guest writing to the > > s/configuraion/configuration/ > > Is 'synic' intended? Is it short for something (if so, spelling it out > > may help)? > > > > > >> +++ b/Documentation/virtual/kvm/api.txt > >> @@ -3331,6 +3331,12 @@ the userspace IOAPIC should process the EOI > and retrigger the interrupt if > >> it is still asserted. Vector is the LAPIC interrupt vector for which the > >> EOI was received. > >> > >> + /* KVM_EXIT_HYPERV */ > >> +struct kvm_hyperv_exit hyperv; > >> +Indicates that the VCPU's exits into userspace to process some tasks > > s/VCPU's/VCPU/ > > > >> +related with Hyper-V emulation. Currently used to synchronize modified > >> +Hyper-V synic state with userspace. > > Again, is 'synic' intended? Hmm, I see it throughout the patch, so it > > looks intentional, but I keep trying to read it as a typo for 'sync'. > > > this is not a typo :) Yes; the Hyper-V public functional spec has chosen this name; it stands for Synthetic Interrupt Controller. K. Y ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
On Mon, Oct 12, 2015 at 07:42:42AM -0600, Eric Blake wrote: > On 10/09/2015 07:39 AM, Denis V. Lunev wrote: > > From: Andrey Smetanin > > > > A new vcpu exit is introduced to notify the userspace of the > > changes in Hyper-V synic configuraion triggered by guest writing to the > Again, is 'synic' intended? Hmm, I see it throughout the patch, so it > looks intentional, but I keep trying to read it as a typo for 'sync'. I tend to mistype it as 'cynic' as better matching what it is ;) Note taken, we'll address that in the next round, thanks. Roman. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
On 12/10/2015 15:42, Eric Blake wrote: > > +related with Hyper-V emulation. Currently used to synchronize modified > > +Hyper-V synic state with userspace. > > Again, is 'synic' intended? Hmm, I see it throughout the patch, so it > looks intentional, but I keep trying to read it as a typo for 'sync'. It's synthetic interrupt controller, but indeed it's a bit obscure. Perhaps we can change it in the docs to "Hyper-V synthetic interrupt state". Paolo ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
On 10/12/2015 04:42 PM, Eric Blake wrote: On 10/09/2015 07:39 AM, Denis V. Lunev wrote: From: Andrey Smetanin A new vcpu exit is introduced to notify the userspace of the changes in Hyper-V synic configuraion triggered by guest writing to the s/configuraion/configuration/ Is 'synic' intended? Is it short for something (if so, spelling it out may help)? +++ b/Documentation/virtual/kvm/api.txt @@ -3331,6 +3331,12 @@ the userspace IOAPIC should process the EOI and retrigger the interrupt if it is still asserted. Vector is the LAPIC interrupt vector for which the EOI was received. + /* KVM_EXIT_HYPERV */ +struct kvm_hyperv_exit hyperv; +Indicates that the VCPU's exits into userspace to process some tasks s/VCPU's/VCPU/ +related with Hyper-V emulation. Currently used to synchronize modified +Hyper-V synic state with userspace. Again, is 'synic' intended? Hmm, I see it throughout the patch, so it looks intentional, but I keep trying to read it as a typo for 'sync'. this is not a typo :) this is an abbreviation for synthetic interrupt controller, pls compare with this ./arch/x86/include/uapi/asm/hyperv.h: * Basic SynIC MSRs (HV_X64_MSR_SCONTROL through HV_X64_MSR_EOM Though there is some sense in the question itself. I think that it would be better to keep naming it SynIC as in the original kernel code. Den ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
On 10/12/2015 07:42 AM, Eric Blake wrote: > On 10/09/2015 07:39 AM, Denis V. Lunev wrote: >> From: Andrey Smetanin >> >> A new vcpu exit is introduced to notify the userspace of the >> changes in Hyper-V synic configuraion triggered by guest writing to the > > s/configuraion/configuration/ > Is 'synic' intended? Is it short for something (if so, spelling it out > may help)? Ah, I see it now from patch 1/2: SYNthetic Interrupt Controller. >> +related with Hyper-V emulation. Currently used to synchronize modified >> +Hyper-V synic state with userspace. > > Again, is 'synic' intended? Hmm, I see it throughout the patch, so it > looks intentional, but I keep trying to read it as a typo for 'sync'. Don't know if SynIC would make it any easier to read? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
On 10/09/2015 07:39 AM, Denis V. Lunev wrote: > From: Andrey Smetanin > > A new vcpu exit is introduced to notify the userspace of the > changes in Hyper-V synic configuraion triggered by guest writing to the s/configuraion/configuration/ Is 'synic' intended? Is it short for something (if so, spelling it out may help)? > +++ b/Documentation/virtual/kvm/api.txt > @@ -3331,6 +3331,12 @@ the userspace IOAPIC should process the EOI and > retrigger the interrupt if > it is still asserted. Vector is the LAPIC interrupt vector for which the > EOI was received. > > + /* KVM_EXIT_HYPERV */ > +struct kvm_hyperv_exit hyperv; > +Indicates that the VCPU's exits into userspace to process some tasks s/VCPU's/VCPU/ > +related with Hyper-V emulation. Currently used to synchronize modified > +Hyper-V synic state with userspace. Again, is 'synic' intended? Hmm, I see it throughout the patch, so it looks intentional, but I keep trying to read it as a typo for 'sync'. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
