Re: [RFC PATCH V3 0/5] Hi:

2019-01-16 Thread Jason Wang
On 2019/1/8 下午6:12, Jason Wang wrote: On 2019/1/7 下午10:47, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 02:58:08PM +0800, Jason Wang wrote: On 2019/1/5 上午5:41, Michael S. Tsirkin wrote: On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: This series tries to access virtqueue

Re: __get_user slower than get_user (was Re: [RFC PATCH V3 0/5] Hi:)

2019-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2019 at 8:31 PM Michael S. Tsirkin wrote: > > Linus, given that you just changed all users of access_ok anyway, do > you still think that the access_ok() conversion to return a speculation > sanitized pointer or NULL is too big a conversion? I didn't actually change a single

__get_user slower than get_user (was Re: [RFC PATCH V3 0/5] Hi:)

2019-01-08 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 02:44:24PM -0800, Dan Williams wrote: > On Mon, Jan 7, 2019 at 2:25 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 07, 2019 at 01:39:15PM -0800, Dan Williams wrote: > > > On Mon, Jan 7, 2019 at 6:11 AM Michael S. Tsirkin wrote: > > > > > > > > On Sun, Jan 06, 2019 at

Re: [RFC PATCH V3 0/5] Hi:

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:11, Michael S. Tsirkin wrote: On Sun, Jan 06, 2019 at 11:15:20PM -0800, Dan Williams wrote: On Sun, Jan 6, 2019 at 8:17 PM Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: On Mon, Jan 07,

Re: [RFC PATCH V3 0/5] Hi:

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:47, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 02:58:08PM +0800, Jason Wang wrote: On 2019/1/5 上午5:41, Michael S. Tsirkin wrote: On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: This series tries to access virtqueue metadata through kernel virtual address

Re: [RFC PATCH V3 0/5] Hi:

2019-01-08 Thread Jason Wang
On 2019/1/7 下午10:37, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 02:50:17PM +0800, Jason Wang wrote: On 2019/1/7 下午12:17, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at

Re: [RFC PATCH V3 0/5] Hi:

2019-01-07 Thread Dan Williams
On Mon, Jan 7, 2019 at 2:25 PM Michael S. Tsirkin wrote: > > On Mon, Jan 07, 2019 at 01:39:15PM -0800, Dan Williams wrote: > > On Mon, Jan 7, 2019 at 6:11 AM Michael S. Tsirkin wrote: > > > > > > On Sun, Jan 06, 2019 at 11:15:20PM -0800, Dan Williams wrote: > > > > On Sun, Jan 6, 2019 at 8:17 PM

Re: [RFC PATCH V3 0/5] Hi:

2019-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 02:58:08PM +0800, Jason Wang wrote: > > On 2019/1/5 上午5:41, Michael S. Tsirkin wrote: > > On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: > > > This series tries to access virtqueue metadata through kernel virtual > > > address instead of copy_user() friends

Re: [RFC PATCH V3 0/5] Hi:

2019-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 02:50:17PM +0800, Jason Wang wrote: > > On 2019/1/7 下午12:17, Michael S. Tsirkin wrote: > > On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: > > > On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: > > > > On Mon, Jan 07, 2019 at 10:19:03AM +0800, Jason Wang wrote: >

Re: [RFC PATCH V3 0/5] Hi:

2019-01-07 Thread Michael S. Tsirkin
On Sun, Jan 06, 2019 at 11:15:20PM -0800, Dan Williams wrote: > On Sun, Jan 6, 2019 at 8:17 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: > > > > > > On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: > > > > On Mon, Jan 07, 2019 at 10:19:03AM +0800,

Re: [RFC PATCH V3 0/5] Hi:

2019-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 01:39:15PM -0800, Dan Williams wrote: > On Mon, Jan 7, 2019 at 6:11 AM Michael S. Tsirkin wrote: > > > > On Sun, Jan 06, 2019 at 11:15:20PM -0800, Dan Williams wrote: > > > On Sun, Jan 6, 2019 at 8:17 PM Michael S. Tsirkin wrote: > > > > > > > > On Mon, Jan 07, 2019 at

Re: [RFC PATCH V3 0/5] Hi:

2019-01-07 Thread Dan Williams
On Mon, Jan 7, 2019 at 6:11 AM Michael S. Tsirkin wrote: > > On Sun, Jan 06, 2019 at 11:15:20PM -0800, Dan Williams wrote: > > On Sun, Jan 6, 2019 at 8:17 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: > > > > > > > > On 2019/1/7 上午11:28,

Re: [RFC PATCH V3 0/5] Hi:

2019-01-06 Thread Dan Williams
On Sun, Jan 6, 2019 at 8:17 PM Michael S. Tsirkin wrote: > > On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: > > > > On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: > > > On Mon, Jan 07, 2019 at 10:19:03AM +0800, Jason Wang wrote: > > > > On 2019/1/3 上午4:47, Michael S. Tsirkin wrote: >

Re: [RFC PATCH V3 0/5] Hi:

2019-01-06 Thread Jason Wang
On 2019/1/5 上午5:41, Michael S. Tsirkin wrote: On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: This series tries to access virtqueue metadata through kernel virtual address instead of copy_user() friends since they had too much overheads like checks, spec barriers or even hardware

Re: [RFC PATCH V3 0/5] Hi:

2019-01-06 Thread Jason Wang
On 2019/1/7 下午12:17, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 10:19:03AM +0800, Jason Wang wrote: On 2019/1/3 上午4:47, Michael S. Tsirkin wrote: On Sat, Dec 29, 2018 at

Re: [RFC PATCH V3 0/5] Hi:

2019-01-06 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 11:53:41AM +0800, Jason Wang wrote: > > On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: > > On Mon, Jan 07, 2019 at 10:19:03AM +0800, Jason Wang wrote: > > > On 2019/1/3 上午4:47, Michael S. Tsirkin wrote: > > > > On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: >

Re: [RFC PATCH V3 0/5] Hi:

2019-01-06 Thread Jason Wang
On 2019/1/7 上午11:28, Michael S. Tsirkin wrote: On Mon, Jan 07, 2019 at 10:19:03AM +0800, Jason Wang wrote: On 2019/1/3 上午4:47, Michael S. Tsirkin wrote: On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: This series tries to access virtqueue metadata through kernel virtual address

Re: [RFC PATCH V3 0/5] Hi:

2019-01-06 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 10:19:03AM +0800, Jason Wang wrote: > > On 2019/1/3 上午4:47, Michael S. Tsirkin wrote: > > On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: > > > This series tries to access virtqueue metadata through kernel virtual > > > address instead of copy_user() friends

Re: [RFC PATCH V3 0/5] Hi:

2019-01-06 Thread Jason Wang
On 2019/1/3 上午4:47, Michael S. Tsirkin wrote: On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: This series tries to access virtqueue metadata through kernel virtual address instead of copy_user() friends since they had too much overheads like checks, spec barriers or even hardware

Re: [RFC PATCH V3 0/5] Hi:

2019-01-04 Thread Michael S. Tsirkin
On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: > This series tries to access virtqueue metadata through kernel virtual > address instead of copy_user() friends since they had too much > overheads like checks, spec barriers or even hardware feature > toggling. I think it's a

Re: [RFC PATCH V3 0/5] Hi:

2019-01-02 Thread Michael S. Tsirkin
On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: > This series tries to access virtqueue metadata through kernel virtual > address instead of copy_user() friends since they had too much > overheads like checks, spec barriers or even hardware feature > toggling. Will review, thanks! One