Re: [patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines

2009-07-24 Thread Jörn Engel
On Tue, 21 July 2009 01:46:41 +0200, Arnd Bergmann wrote: On Friday 17 July 2009, Greg Kroah-Hartman wrote: @@ -43,7 +43,7 @@ typedef struct _RING_BUFFER { // volatile u32 InterruptMask; // Ring data starts here + RingDataStartOffset !!! DO NOT place any fields below this

Re: [patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines

2009-07-24 Thread Jörn Engel
On Fri, 24 July 2009 14:50:25 -0700, Stephen Hemminger wrote: On Fri, 24 Jul 2009 23:32:19 +0200 Jörn Engel jo...@logfs.org wrote: On Tue, 21 July 2009 01:46:41 +0200, Arnd Bergmann wrote: The data structure is actually packed already, the attribute does not make it better and

Re: [patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines

2009-07-24 Thread Stephen Hemminger
On Fri, 24 Jul 2009 23:32:19 +0200 Jörn Engel jo...@logfs.org wrote: On Tue, 21 July 2009 01:46:41 +0200, Arnd Bergmann wrote: On Friday 17 July 2009, Greg Kroah-Hartman wrote: @@ -43,7 +43,7 @@ typedef struct _RING_BUFFER { // volatile u32 InterruptMask; // Ring data

Re: [patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines

2009-07-20 Thread Arnd Bergmann
On Friday 17 July 2009, Greg Kroah-Hartman wrote: @@ -43,7 +43,7 @@ typedef struct _RING_BUFFER { // volatile u32 InterruptMask; // Ring data starts here + RingDataStartOffset !!! DO NOT place any fields below this !!! u8 Buffer[0]; -} STRUCT_PACKED RING_BUFFER;