Re: bug in virtio network driver?

2007-08-30 Thread Christian Borntraeger
Am Mittwoch, 29. August 2007 schrieb Rusty Russell: On Tue, 2007-08-21 at 18:02 +0200, Christian Borntraeger wrote: Am Dienstag, 21. August 2007 schrieb Rusty Russell: The only reason that we don't do it in skb_xmit_done() is because kfree_skb() isn't supposed to be called from an

Re: bug in virtio network driver?

2007-08-29 Thread Rusty Russell
On Tue, 2007-08-21 at 18:02 +0200, Christian Borntraeger wrote: Am Dienstag, 21. August 2007 schrieb Rusty Russell: The only reason that we don't do it in skb_xmit_done() is because kfree_skb() isn't supposed to be called from an interrupt. But there's dev_kfree_skb_any() which can be

Re: bug in virtio network driver?

2007-08-21 Thread Arnd Bergmann
On Tuesday 21 August 2007, Rusty Russell wrote: One solution would be to use the xmit_done interrupt. Unfortunately this would require additional locking as multiple interrupts can happen at two or more cpus. Do you have any better ideas? The only reason that we don't do it in

Re: bug in virtio network driver?

2007-08-21 Thread Christian Borntraeger
Am Dienstag, 21. August 2007 schrieb Rusty Russell: The only reason that we don't do it in skb_xmit_done() is because kfree_skb() isn't supposed to be called from an interrupt. But there's dev_kfree_skb_any() which can be used. Ok, I now hacked something that works but I really dont like the

Re: bug in virtio network driver?

2007-08-21 Thread Rusty Russell
On Tue, 2007-08-21 at 17:06 +0200, Arnd Bergmann wrote: On Tuesday 21 August 2007, Rusty Russell wrote: One solution would be to use the xmit_done interrupt. Unfortunately this would require additional locking as multiple interrupts can happen at two or more cpus. Do you have