Re: [Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-06-01 Thread Chad Smith
type fixed Rewrote my last hidden comment fixing typo All said, I think this patch handles most use cases, hotpluggedeth0 will match any newly attached eth0 that is present on the system during boot (and mark that device RequiredForOnline=yes if 50-cloud-init.yaml doesn't match because of a

Re: [Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-06-01 Thread Chad Smith
> What happens when you remove the original eth0 and replace it? Does the boot > happen promptly, or does it stall on the 50-cloud-init.yaml interface? > > Would it be simpler just to suppress the original cloud-init netplan config? > > Apart from that I think it looks fine, but I'm not an

[Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-05-31 Thread Chad Smith
The proposal to merge lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm has been updated. Description changed to: Azure images deliver a script /usr/local/sbin/ephemeral_eth.sh which is called from udev add rules on nic hotplug events for

[Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-05-31 Thread Chad Smith
The proposal to merge lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm has been updated. Commit message changed to: Update Azure's nic hotplug script to use static /etc/netplan/90-hotplug-azure.yaml Also avoid appending unnecessary

[Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-05-31 Thread Chad Smith
The proposal to merge lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm has been updated. Commit message changed to: Update Azure's nic hotplug script to use static /etc/netplan/90-hotplug-azure.yaml Also avoid either appending

Re: [Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-05-31 Thread Chad Smith
OK I changed up the approach here after some good testing on Azure (attaching new nics, detatching original eth0 nic, reattaching nics etc). systemd does let us pass inverted matches per https://www.freedesktop.org/software/systemd/man/systemd.network.html#Name= Per Daniel's suggestion, we

[Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-05-31 Thread Chad Smith
The proposal to merge lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm has been updated. Description changed to: Azure images deliver a script /usr/local/sbin/ephemeral_eth.sh which is called from udev add rules on nic hotplug events for

[Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

2018-05-31 Thread Chad Smith
The proposal to merge lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm has been updated. Description changed to: WIP: I think I targeted the wrong branch, will resubmit tomorrow diff should be http://paste.ubuntu.com/p/Kx8YrXv7cp/ Azure

[Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:vmbuilder

2018-05-31 Thread Chad Smith
The proposal to merge lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:vmbuilder has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug/+merge/347174 -- Your team

[Vmbuilder] [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:vmbuilder

2018-05-30 Thread Chad Smith
The proposal to merge lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:vmbuilder has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug/+merge/347174 -- Your