Diff comments:
> === modified file 'templates/img-extra-nets.tmpl'
> --- templates/img-extra-nets.tmpl 2017-08-22 19:29:36 +
> +++ templates/img-extra-nets.tmpl 2018-06-01 02:30:12 +
> @@ -5,6 +5,7 @@
> # vi: ts=4 noexpandtab syntax=sh
>
>
type fixed Rewrote my last hidden comment fixing typo
All said, I think this patch handles most use cases, hotpluggedeth0 will match
any newly attached eth0 that is present on the system during boot (and mark
that device RequiredForOnline=yes if 50-cloud-init.yaml doesn't match because
of a
Review: Approve
OK, I'm sold. Thanks Chad.
--
https://code.launchpad.net/~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug/+merge/347212
Your team VMBuilder is requested to review the proposed merge of
lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into
Review: Approve
Thanks for this work, Chad, and the testing/investigation you've done; it's
much appreciated!
This looks good to me, and I'm happy to be able to move to just configuration
rather than having extra code on the image. netplan FTW!
--
> What happens when you remove the original eth0 and replace it? Does the boot
> happen promptly, or does it stall on the 50-cloud-init.yaml interface?
>
> Would it be simpler just to suppress the original cloud-init netplan config?
>
> Apart from that I think it looks fine, but I'm not an
5 matches
Mail list logo
