Re: [PATCH] Update Module::Load to 0.12 (Was Re: Module::Load 0.12 wanna be (was Re: [patch@31735] Module-load/require fixes for VMS))

2007-09-14 Thread Craig A. Berry
At 2:03 PM +0200 9/14/07, Jos I. Boumans wrote: >On 11 Sep 2007, at 02:58, John E. Malmberg wrote: >>This passed all tests for me with [EMAIL PROTECTED] Me too, with 31855. >Attached patch updates module::load to 0.12, incorporating the fixes >John sent for VMS. Thanks, applied as #31869. -- __

[PATCH] Update Module::Load to 0.12 (Was Re: Module::Load 0.12 wanna be (was Re: [patch@31735] Module-load/require fixes for VMS))

2007-09-14 Thread Jos I. Boumans
On 11 Sep 2007, at 02:58, John E. Malmberg wrote: This passed all tests for me with [EMAIL PROTECTED] Attached patch updates module::load to 0.12, incorporating the fixes John sent for VMS. Changes for 0.12Sun Sep 9 11:11:08 2007 * Fix for UNI

Re: Module::Load 0.12 wanna be (was Re: [patch@31735] Module-load/require fixes for VMS)

2007-09-10 Thread John E. Malmberg
Jos I. Boumans wrote: On Aug 25, 2007, at 5:11 AM, John E. Malmberg wrote: So are you saying I should roll back #31746: http://public.activestate.com/cgi-bin/perlbrowse/p/31746 and apply Jos's patch instead? No. Joe's patch works around the issue for all versions of Perl only for the CPAN

Module::Load::Conditional 0.18 wannabe (was Re: [patch@31735] Module-load/require fixes for VMS)

2007-09-09 Thread Jos I. Boumans
Hi Guys, On Aug 21, 2007, at 4:55 AM, John E. Malmberg wrote: --- /rsync_root/perl/lib/Module/Load/Conditional/t/ 01_Module_Load_Conditional.t Fri Aug 17 05:56:59 2007 +++ lib/Module/Load/Conditional/t/01_Module_Load_Conditional.t Mon Aug 20 20:08:03 2007 @@ -54,8 +54,9 @@ @rv_path =

Module::Load 0.12 wanna be (was Re: [patch@31735] Module-load/require fixes for VMS)

2007-09-09 Thread Jos I. Boumans
On Aug 25, 2007, at 5:11 AM, John E. Malmberg wrote: So are you saying I should roll back #31746: http://public.activestate.com/cgi-bin/perlbrowse/p/31746 and apply Jos's patch instead? No. Joe's patch works around the issue for all versions of Perl only for the CPAN module. It does not w

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-24 Thread John E. Malmberg
Craig A. Berry wrote: At 8:31 AM -0500 8/24/07, John E. Malmberg wrote: Jos I. Boumans wrote: Since MLC uses Module::Load, wouldn't it just be an easier fix to always unixify paths on VMS? How does this patch look for you? --- local/oss/module-load/lib/Module/Load.pm(revision 2064) ++

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-24 Thread Craig A. Berry
At 8:31 AM -0500 8/24/07, John E. Malmberg wrote: >Jos I. Boumans wrote: >>Since MLC uses Module::Load, wouldn't it just be an easier fix to always >>unixify paths on VMS? >> >>How does this patch look for you? >> >>--- local/oss/module-load/lib/Module/Load.pm(revision 2064) >>+++ local/oss/

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-24 Thread John E. Malmberg
Jos I. Boumans wrote: On 21 Aug 2007, at 04:55, John E. Malmberg wrote: The load conditional code does a require using the VMS format, and since it does not match the key in UNIX format, modules can be loaded twice. This showed up by causing the extract tests to emit diagnostics about rou

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-24 Thread Jos I. Boumans
On 21 Aug 2007, at 04:55, John E. Malmberg wrote: The load conditional code does a require using the VMS format, and since it does not match the key in UNIX format, modules can be loaded twice. This showed up by causing the extract tests to emit diagnostics about routines being overridden.

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-22 Thread John E. Malmberg
Jos I. Boumans wrote: Hi, On 21 Aug 2007, at 04:55, John E. Malmberg wrote: In pp_ctl.c, on VMS, normally the path used for the %INC key is in UNIX filename syntax, however if require is given a VMS format filename, it stores it as the %INC key. The load conditional code does a require us

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-22 Thread Jos I. Boumans
Hi, On 21 Aug 2007, at 04:55, John E. Malmberg wrote: In pp_ctl.c, on VMS, normally the path used for the %INC key is in UNIX filename syntax, however if require is given a VMS format filename, it stores it as the %INC key. The load conditional code does a require using the VMS format, and

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-22 Thread Jerry D. Hedden
> Also, if possible, please Cc the module maintainer (if you know who > they are of course ;) on such changes. FYI, this info is maintained in perl-current/Porting/Maintainers.pl

RE: [patch@31735] Module-load/require fixes for VMS

2007-08-22 Thread Steve Hay
Craig A. Berry wrote: > Thanks, applied as #31746. Steve, give us a holler if we broke Win32 > again (hopefully not). It tested out ok on VMS and Mac OS X. All OK here, thanks.

Re: [patch@31735] Module-load/require fixes for VMS

2007-08-22 Thread Craig A. Berry
At 9:55 PM -0500 8/20/07, John E. Malmberg wrote: >In pp_ctl.c, on VMS, normally the path used for the %INC key is in UNIX >filename syntax, however if require is given a VMS format filename, it stores >it as the %INC key. > >The load conditional code does a require using the VMS format, and sinc