Re: patch@26253 lib/File/Spec/VMS.pm

2005-12-08 Thread Craig A. Berry
At 10:39 PM -0500 12/5/05, John E. Malmberg wrote: The canonpath() routine still has a bug where it does not ignore characters preceded by a '^' when it is searching for directory fragments to remove. In particular, '^.' is a period character in a directory specification, not a '^' character

Re: patch@26253 lib/File/Spec/VMS.pm

2005-12-07 Thread John E. Malmberg
Ken Williams wrote: On Dec 6, 2005, at 11:46 AM, John E. Malmberg wrote: Ken Williams wrote: I was thinking we could add those as TODO tests, but I was unaware of the problems with VAX legacy stuff. There are some bugs that are in the legacy stuff that I am concerned if I change the

Re: patch@26253 lib/File/Spec/VMS.pm

2005-12-06 Thread Ken Williams
Hi John, Thanks for the patch, I've applied it. Could I trouble you to also add a few tests to Spec.t to exercise these dead bugs? Thanks, -Ken On Dec 5, 2005, at 9:39 PM, John E. Malmberg wrote: In abs2rel() fix handling of directory trees so that the test $file =

Re: patch@26253 lib/File/Spec/VMS.pm

2005-12-06 Thread John E. Malmberg
Ken Williams wrote: Hi John, Thanks for the patch, I've applied it. Could I trouble you to also add a few tests to Spec.t to exercise these dead bugs? Someone already did with a recent change to Spec.t, which made them show up as failed at the same time I made a significant change to

Re: patch@26253 lib/File/Spec/VMS.pm

2005-12-06 Thread Ken Williams
On Dec 6, 2005, at 11:46 AM, John E. Malmberg wrote: Ken Williams wrote: Hi John, Thanks for the patch, I've applied it. Could I trouble you to also add a few tests to Spec.t to exercise these dead bugs? Someone already did with a recent change to Spec.t, which made them show up as

patch@26253 lib/File/Spec/VMS.pm

2005-12-05 Thread John E. Malmberg
In abs2rel() fix handling of directory trees so that the test $file = File::Spec::VMS-abs2rel('[t1.t2.t3]file', '[t1.t2.t3]') returns 'file' instead of an empty string. In canonpath(), fix case where '[]' was totally optimized away instead of just returning '[]'. $file =