Revised: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-14 Thread John E. Malmberg
Craig A. Berry wrote: The attached provides the special handling needed for C compiler defines in ExtUtils::CBuilder. This is against blead but I'm hoping the right number after -p supplied to patch will apply cleanly to the CPAN version (which is separately maintained, right?). This patch

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-13 Thread Craig A. Berry
At 12:01 AM -0500 3/13/06, John E. Malmberg wrote: Craig A. Berry wrote: The attached provides the special handling needed for C compiler defines in ExtUtils::CBuilder. This is against blead but I'm hoping the right number after -p supplied to patch will apply cleanly to the CPAN version (which is

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-13 Thread John E. Malmberg
Craig A. Berry wrote: At 12:01 AM -0500 3/13/06, John E. Malmberg wrote: Craig A. Berry wrote: The attached provides the special handling needed for C compiler defines in ExtUtils::CBuilder. This is against blead but I'm hoping the right number after -p supplied to patch will apply cleanly

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-13 Thread Ken Williams
BTW, is there a regression test that could have exposed this issue? -Ken On Mar 12, 2006, at 7:37 PM, Ken Williams wrote: Thanks Craig. Yup, CBuilder is separately maintained, the nexus for development is often the Module::Build list. I'll apply this patch and make a new release. -Ken

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-13 Thread Craig Berry
On Monday, March 13, 2006, at 04:06PM, Ken Williams [EMAIL PROTECTED] wrote: BTW, is there a regression test that could have exposed this issue? -Ken It did show up in a number of the Module::Build failures, such as xs.t. Anything compiling XS-generated C would hit it since the version is

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-13 Thread Ken Williams
On Mar 13, 2006, at 5:12 PM, Craig Berry wrote: On Monday, March 13, 2006, at 04:06PM, Ken Williams [EMAIL PROTECTED] wrote: BTW, is there a regression test that could have exposed this issue? -Ken It did show up in a number of the Module::Build failures, such as xs.t. Anything

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-13 Thread John E. Malmberg
Craig A. Berry wrote: At 12:01 AM -0500 3/13/06, John E. Malmberg wrote: Craig A. Berry wrote: The attached provides the special handling needed for C compiler defines in ExtUtils::CBuilder. This is against blead but I'm hoping the right number after -p supplied to patch will apply cleanly

[PATCH] VMS-specific arg_defines for CBuilder

2006-03-12 Thread Craig A. Berry
The attached provides the special handling needed for C compiler defines in ExtUtils::CBuilder. This is against blead but I'm hoping the right number after -p supplied to patch will apply cleanly to the CPAN version (which is separately maintained, right?). ---

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-12 Thread Ken Williams
Thanks Craig. Yup, CBuilder is separately maintained, the nexus for development is often the Module::Build list. I'll apply this patch and make a new release. -Ken On Mar 12, 2006, at 6:01 PM, Craig A. Berry wrote: The attached provides the special handling needed for C compiler

Re: [PATCH] VMS-specific arg_defines for CBuilder

2006-03-12 Thread John E. Malmberg
Craig A. Berry wrote: The attached provides the special handling needed for C compiler defines in ExtUtils::CBuilder. This is against blead but I'm hoping the right number after -p supplied to patch will apply cleanly to the CPAN version (which is separately maintained, right?). I just applied