> On 17 Jun 2019, at 23:40, Jon Loeliger via Lists.Fd.Io > <jdl=netgate....@lists.fd.io> wrote: > > On Mon, Jun 17, 2019 at 3:43 PM Damjan Marion <dmar...@me.com > <mailto:dmar...@me.com>> wrote: > >> On 17 Jun 2019, at 22:41, Jon Loeliger <j...@netgate.com >> <mailto:j...@netgate.com>> wrote: >> >> On Mon, Jun 17, 2019 at 3:33 PM Damjan Marion <dmar...@me.com >> <mailto:dmar...@me.com>> wrote: >> >> I tried to be as much descriptive as possible in those messages, but looks >> like I failed :( >> >> Damjan, >> >> No problem. I am working on some improvements. >> >> For example, fixing these problems: >> >> $ echo "Consolidate IPv6 link-local-address functions." | sed -e >> 's/\(.*\):.*/\1/' >> Consolidate IPv6 link-local-address functions. >> >> $ echo "foo: bar: baz: Consolidate IPv6 link-local-address functions." | >> sed -e 's/\(.*\):.*/\1/' >> foo: bar: baz > > Your commit message needs to be: > > foo bar baz: consolidate... > > Damjan, > > I think there will be unexpected complications with this approach. Consider > this: > > $ echo "docs: fix http:/foo.example.com:8080/fred > <http://foo.example.com:8080/fred> use." | sed -e 's/\(.*\):.*/\1/' > docs: fix http:/foo.example.com <http://foo.example.com/> > > That won't match "docs:", nor any other valid I: word in any case where there > is an > additional colon later in the subject line. It will also allow false > positives like this > subject: "whanged on ip stuff: it was messed up". > > Historically, these things have been keywords individually terminated by a > colon, as > I gave in my example. Once the collection of keywords is gathered, strip the > trailing > colons for validity comparisons. > > Just a thought.
Is this better? https://gerrit.fd.io/r/20410
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13403): https://lists.fd.io/g/vpp-dev/message/13403 Mute This Topic: https://lists.fd.io/mt/32096793/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
