Re: [vpp-dev] session_lookup: holes in fib_index_to_table_index?

2020-04-23 Thread Florin Coras
Hi Andreas, I just merged your patch. Thanks for the fix! Regards, Florin > On Apr 23, 2020, at 12:53 AM, Andreas Schultz > wrote: > > ok, I have to retract my initial assertion that this is not a problem. Indeed > for IPv4 the breakage is not visible, but IPv6 in anything other than >

Re: [vpp-dev] Regarding lookup in vppinfra/hash.c

2020-04-23 Thread Dave Barach via lists.fd.io
Ack. If all else fails, suggest a quick peek at the assembly code. From: vpp-dev@lists.fd.io On Behalf Of Peng Xia Sent: Thursday, April 23, 2020 12:15 AM To: Peng Xia Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Regarding lookup in vppinfra/hash.c Sorry, I was confused with the later lines.

Re: [vpp-dev] VPP nat ipfix logging problem, need to use thread-specific vlib_main_t?

2020-04-23 Thread Elias Rudberg
Hello, There was a merge conflict for my previous fix for this. Now I made a new one, it's essentially the same thing, just avoiding the merge conflict: https://gerrit.fd.io/r/c/vpp/+/26659 Please have a look at that one and merge if it seems ok. Based on our experience from the past few weeks

Re: [vpp-dev] session_lookup: holes in fib_index_to_table_index?

2020-04-23 Thread Andreas Schultz
ok, I have to retract my initial assertion that this is not a problem. Indeed for IPv4 the breakage is not visible, but IPv6 in anything other than fib_index zero is not usable. The uninitialized entries in the IPv6 fib_index_to_table_index point to a *IPv4* session table. Of course that does not

[vpp-dev] session_lookup: holes in fib_index_to_table_index?

2020-04-23 Thread Andreas Schultz
Hi, While trying to troubleshoot a session problem, I've come across session_table_get_or_alloc: https://gerrit.fd.io/r/gitweb?p=vpp.git;a=blob;f=src/vnet/session/session_lookup.c;h=4de6fdbe547499fcd256e387370cc5bf0c810206;hb=refs/heads/master#l158 To me it looks like this function could leave