Re: [vpp-dev] Please include Fixes: tag for regression fix

We can also add fixline to git to get the formatted output i.e. vpp$ git fixline 3effb4e6 Fixes: 3effb4e63068 ("memif: integrate with new tx infra") One can add the following to .gitconfig file: fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' -br Mohsin From: on behalf of

Re: [vpp-dev] Query regarding packet validation checks in ip6_local

Hi Pankaj, I’ll leave the hop-by-hop questions to others that are more familiar with the code. As for the length check being done only on the else branch, ip6_tcp_udp_icmp_validate_checksum needs to compute the length so I’m guessing the expectation is that the checksum validation will fail

[vpp-dev] Query regarding packet validation checks in ip6_local

Hi, In file vnet/ip/ip6_forward.c(VPP 21.01), function ip6_local_inline(), the node's packet processing has the following check: if (PREDICT_FALSE (need_csum)) { flags = ip6_tcp_udp_icmp_validate_checksum (vm, b[0]); good_l4_csum = flags & VNET_BUFFER_F_L4_CHECKSUM_CORRECT; error =

Re: [vpp-dev] det44 plugin

Hi Ben, Thank you for pointing out the issue. Indeed it looks like the node runs just once. I will provide a patch shortly. Best regards, Filip Varga -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Ben McKeegan Sent: Monday, November 1, 2021 7:24 PM To: vpp-dev@lists.fd.io

Re: [vpp-dev] Please include Fixes: tag for regression fix

We should probably extend checkstyle to reject patch if there is “Type: fix” and there is no “Fixes: *”. We can have special case “Fixes: unknown” to willingly bypass this check…. — Damjan > On 02.11.2021., at 18:17, steven luong via lists.fd.io > wrote: > > Folks, > > In case you

[vpp-dev] Please include Fixes: tag for regression fix

Folks, In case you don’t already know, there is a tag called Fixes in the commit message which allows one to specify if the current patch fixes a regression. See an example usage in https://gerrit.fd.io/r/c/vpp/+/34212 When you commit a patch which fixes a known regression, please make use of

Re: [vpp-dev] VPP binary API to make interface state up

You are setting the “mp->flags = 0;” as (IF_STATUS_API_FLAG_LINK_UP & IF_STATUS_API_FLAG_ADMIN_UP == 0) To ‘UP’ the interface: u32 flags = IF_STATUS_API_FLAG_ADMIN_UP; mp->flags = clib_host_to_net_u32 (flags); To ‘DOWN’ the interface: u32 flags = 0; mp->flags = clib_host_to_net_u32

[vpp-dev] VPP binary API to make interface state up

HI, I am trying to implement the following vppctl command through C API. vpp version 20.09. *vppctl set int ip addr host-eth3 10.22.6.20/24 vppctl set int state host-eth3 up* First command i.e. to plumb the IP works fine through the program attached but to make the

Re: [vpp-dev] Bihash is considered thread-safe but probably shouldn't

Dear Nick, As the code comment suggests, we tiptoe right up to the line to extract performance. Have you tried e.g. ISOLCPUS, thread priority, or some other expedients to make the required assumptions true? It’s easy enough to change the code in various ways so this use-case cannot