Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-21 Thread Andrew Yourtchenko
Aie, seems I wrote the reply but got distracted and didn’t hit “send”.. sorry for that… thanks Matt and Fan for clarification, indeed I missed the forest behind the lot of trees! Please feel free to do the cherrypicks for these 4 into stable/2202 within pre-RC2 window., i will merge them.

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Fan Zhang
Thanks Matthew to point this out. To add a bit more detail here Wireguard data-path encryption and decryption uses aad size of 0. Hence we have to add new async AEAD op ID to represent this aad size. Regards, Fan From: Matthew Smith Sent: Wednesday, January 19, 2022 4:36 PM To: Andrew 

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Matthew Smith via lists.fd.io
Hi Andrew, The change in crypto.h that you called out as being whitespace-only actually changes more than whitespace... It also appends '_ (CHACHA20_POLY1305, "chacha20-poly1305", 32, 16, 0)' to foreach_crypto_aead_async_alg. -Matt On Wed, Jan 19, 2022 at 10:21 AM Andrew  Yourtchenko wrote:

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Fan Zhang
Hi Andrew, Thanks a mil! Will address them ASAP. Regards, Fan > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of Andrew > Yourtchenko > Sent: Wednesday, January 19, 2022 4:21 PM > To: Zhang, Roy Fan > Cc: vpp-dev ; Andrew Yourtchenko (ayourtch) > ; Kinsella, Ray ; Oginski,

Re: [vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Andrew Yourtchenko
Hi Fan, With my release manager hat on: the first three patches are solely contained (minus seemingly whitespace change in 34660? can it be avoided ?) within wireguard plugin, which has "experimental" status, with which I would be happy to err on the side of keeping the velocity - so once the

[vpp-dev] Is it too late for Wireguard patches getting in for VPP22.02?

2022-01-19 Thread Fan Zhang
Hi, Sorry for the late notice, but we have a bunch of patches waiting to be reviewed/merged if possible for VPP22.02. The patches do 2 things * Optimizing wireguard performance by introducing burst processing of packets and chacha-poly encryption/decryption. * Adding async mode to