Re: [vpp-dev] Macros to support prefetch w/o code copy.

2019-07-12 Thread Christian Hopps
> On Jul 12, 2019, at 9:53 AM, Damjan Marion wrote: > >>> 5. you should consider using vlib_buffer_enqueue_to_next() instead of >>> vlib_get_next_frame/vlib_put_next_frame scheme >> >> Can you help me understand this? I may be reading the code wrong but >> vlib_buffer_enqueue_to_next()

Re: [vpp-dev] Macros to support prefetch w/o code copy.

2019-07-12 Thread Damjan Marion via Lists.Fd.Io
> On 12 Jul 2019, at 15:40, Christian Hopps wrote: > > Thanks for the review.. I have a comments and a question inline... > >> On Jul 12, 2019, at 9:11 AM, Damjan Marion wrote: >> >>> ... >> >> Hi Cristian, >> >> You are not fist one trying to do that, few of us did and we all failed :).

Re: [vpp-dev] Macros to support prefetch w/o code copy.

2019-07-12 Thread Christian Hopps
Thanks for the review.. I have a comments and a question inline... > On Jul 12, 2019, at 9:11 AM, Damjan Marion wrote: > >> ... > > Hi Cristian, > > You are not fist one trying to do that, few of us did and we all failed :). :) > Few comments: > > 1. It is going to be painful to use "perf

Re: [vpp-dev] Macros to support prefetch w/o code copy.

2019-07-12 Thread Damjan Marion via Lists.Fd.Io
> > On 12 Jul 2019, at 06:14, Christian Hopps wrote: > > [re-sending w/o extra email addresses] > > Hi vpp-dev, > > So I'm writing a plugin to support IPTFS > (https://tools.ietf.org/html/draft-hopps-ipsecme-iptfs-01), and during this > process I've written a macro to support prefetching

[vpp-dev] Macros to support prefetch w/o code copy.

2019-07-11 Thread Christian Hopps
[re-sending w/o extra email addresses] Hi vpp-dev, So I'm writing a plugin to support IPTFS (https://tools.ietf.org/html/draft-hopps-ipsecme-iptfs-01), and during this process I've written a macro to support prefetching the second half of N (where N is power of 2) buffers and acting on the