Hi Chore,
Thank you for the patch, I have merged it.
/neale
De : au nom de emma sdi
Date : mercredi 26 juin 2019 à 07:06
À : Damjan Marion
Cc : vpp-dev
Objet : Re: [vpp-dev] NAT dose not exist in MAINTAINERS file
Hi Dear VPP
Would you please take a look at https://gerrit.fd.io/r/#/c
Hi Dear VPP
Would you please take a look at https://gerrit.fd.io/r/#/c/20325/ and merge
this commit. previously Damjan told me to amend my commit and add nat in
MAINTAINERS file but I did it in another commit independently.
Thanks
Chore
On Tue, Jun 25, 2019 at 5:01 PM Damjan Marion wrote:
>
Dear Emma,
This is exact reason why we introduced commit checks. It will help us to keep
MAINTAINERS file up to date, without this check nobody will notice that nat is
missing there.
Ole is our nat guy, please amend your patch with MAINTAINERS update and add Ole
as maintainer...
—
Damjan
>
Hi Dear VPP
Why NAT dose not exist in MAINTAINERS file?! as you know, during build
phase, commit message subject is inspected inside MAINTAINERS file. so how
could be possible a succeeded commit in NAT plug-in?
Thanks
Chore
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this