Re: [vpp-dev] RFC: vlib_global_main_t

2021-03-12 Thread Damjan Marion via lists.fd.io
Thanks, let me polish it a bit and will submit for review…. > On 12.03.2021., at 10:32, Andrew  Yourtchenko wrote: > > +1, great idea! > > --a > >> On 11 Mar 2021, at 15:36, Damjan Marion via lists.fd.io >> wrote: >> >>  >> >> Guys, >> >> I found that having both global and thread

Re: [vpp-dev] RFC: vlib_global_main_t

2021-03-12 Thread Andrew Yourtchenko
+1, great idea! --a > On 11 Mar 2021, at 15:36, Damjan Marion via lists.fd.io > wrote: > >  > > Guys, > > I found that having both global and thread data in vlib_main_t is confusing > to many people and also bug prone. > > I wonder if there is sense in. moving global data to new

Re: [vpp-dev] RFC: vlib_global_main_t

2021-03-12 Thread Ole Troan
> I found that having both global and thread data in vlib_main_t is confusing > to many people and also bug prone. > > I wonder if there is sense in. moving global data to new vlib_global_main_t? > > I submitted RFC patch and would like to hear what people think about that…. > >

Re: [vpp-dev] RFC: vlib_global_main_t

2021-03-11 Thread Florin Coras
t;http://lists.fd.io/> > Sent: Thursday, March 11, 2021 9:36 AM > To: vpp-dev mailto:vpp-dev@lists.fd.io>> > Subject: [vpp-dev] RFC: vlib_global_main_t > > > > Guys, > > I found that having both global and thread data in vlib_main_t is confusing > to man

Re: [vpp-dev] RFC: vlib_global_main_t

2021-03-11 Thread Dave Barach
Looks like a win to me... -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Thursday, March 11, 2021 9:36 AM To: vpp-dev Subject: [vpp-dev] RFC: vlib_global_main_t Guys, I found that having both global and thread data in vlib_main_t

[vpp-dev] RFC: vlib_global_main_t

2021-03-11 Thread Damjan Marion via lists.fd.io
Guys, I found that having both global and thread data in vlib_main_t is confusing to many people and also bug prone. I wonder if there is sense in. moving global data to new vlib_global_main_t? I submitted RFC patch and would like to hear what people think about that….