Re: [vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

2019-06-28 Thread guangwei
Thanks, I have a look at the patch, I think the same action should take at state FIN_WAIT_1 and FIN_WAIT_2 . At 2019-06-29 00:53:15, "Florin Coras" wrote: Hi, Well, yes. VPP tcp won’t send out of order fins because it waits for all the data to be acked before sending the fin. Still,

Re: [vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

2019-06-28 Thread Florin Coras
Hi, Well, yes. VPP tcp won’t send out of order fins because it waits for all the data to be acked before sending the fin. Still, others may do it, so here’s a quick fix for that [1]. Thanks, Florin [1] https://gerrit.fd.io/r/c/20403/ > On Jun 28, 2019, at

[vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

2019-06-28 Thread guangwei
I think the FIN is reported to session layer only when it's indeed all the data which allowed in SEQ window has received, but from code, when the packet flaged with FIN no matter whether it's a Out-Of-Order segment or not , no matter whether it's data all in the allowed window or not, the stack