Re: [vpp-dev] forge committer

2019-11-05 Thread Ole Troan
Tetsuya-san, > Happy to hear you again. I will meet you at next IETF. Look forward to that! I'm sure I owe you a beer. > All commits were already completed on our different repository in GitHub. > There is no in progress commit and so I don’t think I can use the squash…. I > tried to do “git

Re: [vpp-dev] forge committer

2019-11-05 Thread Tetsuya Murakami
, >> Tetsuya >> >>> On Nov 5, 2019, at 4:14 AM, Dave Barach (dbarach) wrote: >>> >>> Make sure that you’re pushing a single, flattened commit which you created. >>> Worst-case, ask Filip to push the patch. >>> >>> HTH... Dave >

Re: [vpp-dev] forge committer

2019-11-05 Thread Ole Troan
Sent: Monday, November 4, 2019 7:38 PM >> To: Dave Barach (dbarach) >> Cc: satoru.matsush...@gmail.com Satoru ; >> vpp-dev@lists.fd.io >> Subject: Re: [vpp-dev] forge committer >> >> Hi Dave, >> >> Thank you. >> >> I tried but still

Re: [vpp-dev] forge committer

2019-11-05 Thread Tetsuya Murakami
o: Dave Barach (dbarach) > Cc: satoru.matsush...@gmail.com Satoru ; > vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] forge committer > > Hi Dave, > > Thank you. > > I tried but still I faced the following issue. When executing the “git commit > -s”, I added

Re: [vpp-dev] forge committer

2019-11-05 Thread Dave Barach via Lists.Fd.Io
: [vpp-dev] forge committer Hi Dave, Thank you. I tried but still I faced the following issue. When executing the “git commit -s”, I added additional “Signed-off-by: ” in the commit log. But when doing the “git review”, still I am seeing the following issue… remote: Processing changes: refs: 1

Re: [vpp-dev] forge committer

2019-11-04 Thread Tetsuya Murakami
nal “Signed-off-by: ” lines in the > commit log. > > From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> <mailto:vpp-dev@lists.fd.io>> On Behalf Of Satoru > Sent: Saturday, November 2, 2019 10:21 PM > To: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> >

Re: [vpp-dev] forge committer

2019-11-04 Thread Dave Barach via Lists.Fd.Io
+1, that works too. From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Monday, November 4, 2019 5:37 AM To: Satoru Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] forge committer > On 3 Nov 2019, at 03:20, Satoru > mailto:satoru.matsush...@gmail.com&g

Re: [vpp-dev] forge committer

2019-11-04 Thread Dave Barach via Lists.Fd.Io
Please add folks as additional “Signed-off-by: ” lines in the commit log. From: vpp-dev@lists.fd.io On Behalf Of Satoru Sent: Saturday, November 2, 2019 10:21 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] forge committer Hello vpp-dev community, We are planning to contribute some plugin

Re: [vpp-dev] forge committer

2019-11-04 Thread Damjan Marion via Lists.Fd.Io
> On 3 Nov 2019, at 03:20, Satoru wrote: > > Hello vpp-dev community, > > We are planning to contribute some plugin and PR to be reviewed in the vpp > gerrit. The PR includes commits from several people and would like to keep > the commit log. It seems that we need forge committer for the

[vpp-dev] forge committer

2019-11-02 Thread Satoru
Hello vpp-dev community, We are planning to contribute some plugin and PR to be reviewed in the vpp gerrit. The PR includes commits from several people and would like to keep the commit log. It seems that we need forge committer for the PR. So the question here is where we can request to get