Re: [vpp-dev] tests - attach debug option available

2021-03-18 Thread Klement Sekera via lists.fd.io
I like the theory, but untangling VppTestCase seems like too much effort, which I will spend elsewhere. This is a quick and usable solution which doesn’t disrupt it too much. Klement > On 18 Mar 2021, at 20:20, Paul Vinciguerra wrote: > > Hi Klement, > > I disagree with the implementation.

Re: [vpp-dev] tests - attach debug option available

2021-03-18 Thread Paul Vinciguerra
Hi Klement, I disagree with the implementation. Naveen proposed similar functionality a while back. I objected to that for the same reason. It does not make sense to use a testcase written to popen an instance of vpp, then mock out the vpp instance with dummy values and conditionally check and

[vpp-dev] tests - attach debug option available

2021-03-16 Thread Klement Sekera via lists.fd.io
Hi all, I implemented a new debug option for make test called ‘attach’. This has been requested a couple of times over the last few months and while it has some drawbacks, it also has advantages. It’s not merged yet. https://gerrit.fd.io/r/c/vpp/+/31663 As always make test-help is full of