Re: [vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-11-03 Thread Florin Coras
Thanks, merged! Regards, Florin > On Nov 3, 2022, at 12:33 AM, 张东亚 wrote: > > Hi, > > I have made a patch and submit it to gerrit for review. > > https://gerrit.fd.io/r/c/vpp/+/37567 > > I have run against vpp unit test for session feature and no

Re: [vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-11-03 Thread Zhang Dongya
Hi, I have made a patch and submit it to gerrit for review. https://gerrit.fd.io/r/c/vpp/+/37567 I have run against vpp unit test for session feature and no regression found yet. Florin Coras 于2022年11月1日周二 23:42写道: > Hi, > > Will you be pushing the fix or should I do it? > > Regards, >

Re: [vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-10-25 Thread Florin Coras
Hi, Apologies, I missed your original point and only though about the large bitmap we create at startup. So yes, go for s->session_index + 1. Regards, Florin > On Oct 24, 2022, at 9:11 PM, Zhang Dongya wrote: > > Hi, > > Can you elaborate a bit on that, If session index is 64, if we do not

Re: [vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-10-24 Thread Zhang Dongya
Hi, Can you elaborate a bit on that, If session index is 64, if we do not increase by 1, it will only make one 64B vec for the bitmap, which may not hold the session index. Florin Coras 于2022年10月25日周二 01:14写道: > Hi, > > Could you replace s->session_index by s->session_index ? : 1 in the patch?

Re: [vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-10-24 Thread Florin Coras
Hi, Could you replace s->session_index by s->session_index ? : 1 in the patch? Regards, Florin > On Oct 24, 2022, at 12:23 AM, Zhang Dongya wrote: > > Hi list, > > Recently I am testing my TCP application in a plugin, what I did is to > initiate a TCP client in my plugin, however, when I

[vpp-dev] weird crash when allocate new ho_session_alloc in debug image

2022-10-24 Thread Zhang Dongya
Hi list, Recently I am testing my TCP application in a plugin, what I did is to initiate a TCP client in my plugin, however, when I build the debug image and test, the vpp will crash and complaint about out of memory. After doing some research, it seems the following code may cause the crash: