Re: [vpp-dev] Coding Preference Question

2017-02-23 Thread Burt Silverman
​Spend some time with C++ and it becomes more obvious that ~0 and -1 are the same thing: 0 is an integer, and ~0 is also an integer, with the bits flipped, and -1 is an integer with the same bit pattern as ~0. So if the intent is to have an unsigned int with the same bit pattern as ~0 or -1, the w

Re: [vpp-dev] Coding Preference Question

2017-02-23 Thread Dave Barach (dbarach)
If the value could be construed as a pool index - e.g. a sw_if_index - I always use u32 and ~0... Thanks… Dave From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jon Loeliger Sent: Thursday, February 23, 2017 5:03 PM To: vpp-dev Subject: [vpp-dev] Coding Prefer

[vpp-dev] Coding Preference Question

2017-02-23 Thread Jon Loeliger
VPPers, As a general rule, do you guys prefer to use: 1) An integer (i32) and -1 as a flag case, or 2) An unsigned integer (u32) and ~0 as the flag case? If it matters, this is for an API value. Thanks, jdl ___ vpp-dev mailing list vpp-dev@lis

[vpp-dev] vpp csit functional test failures, not obviously related to the patches involved

2017-02-23 Thread Dave Barach (dbarach)
For example: https://gerrit.fd.io/r/#/c/5498 Thanks... Dave 13:54:14.203 TRACE exec_command on ('10.30.51.236', 22): sudo -S rm -f /tmp/qga.sock 13:54:14.306 TRACE exec_command on ('10.30.51.236', 22) took 0.106814861298 seconds 13:54:14.306 TRACE chan_recv/_stderr took 0.0

Re: [vpp-dev] Loopback Interface Names

2017-02-23 Thread Burt Silverman
​No problem, Jon. Your original note suggests 2 problems, one in paragraphs 1-3, and the second problem being "not following PRCL". My understanding is that John Lo's note eliminates the first problem as being interesting, so that leaves the latter being in the "interesting" bucket. And like you sa

Re: [vpp-dev] Loopback Interface Names

2017-02-23 Thread Jon Loeliger
On Thu, Feb 23, 2017 at 9:25 AM, Burt Silverman wrote: > > ​I am arriving a bit late to the party; I just wanted to point out that > the current user interface is similar to that of the Linux losetup command > for Linux loop devices. Here is a silly example to demonstrate: > Hi Burt, At the ris

Re: [vpp-dev] Loopback Interface Names

2017-02-23 Thread Burt Silverman
​I am arriving a bit late to the party; I just wanted to point out that the current user interface is similar to that of the Linux losetup command for Linux loop devices. Here is a silly example to demonstrate: burts@burtvb:~$ sudo losetup -f junk3.c [sudo] password for burts: losetup: junk3.c: Wa

Re: [vpp-dev] Loopback Interface Names

2017-02-23 Thread Jon Loeliger
On Thu, Feb 23, 2017 at 8:53 AM, Dave Barach (dbarach) wrote: > > >>> Especially in multi-core situations, some care is required. I’m > generally a fan of setting interfaces admin-down, vs. actually deleting > them. > Ah, I see. Check. (So, for lack of atomic_inc() or visible locking of some f

Re: [vpp-dev] "TCP Shortcuts" for containers

2017-02-23 Thread Sukhomlinov, Vadim
Florin, thanks a lot! In the vpp / src/scripts/vnet/uri/tcp-setup.sh there is a code to setup network topology with namespaces: ip netns add vppns1 ip link add veth_vpp1 type veth peer name vpp1 ip link set dev vpp1 up ip link set dev veth_vpp1 up netns vppns1 ip netns exec vppns1

Re: [vpp-dev] Loopback Interface Names

2017-02-23 Thread Dave Barach (dbarach)
Inline... Thanks… Dave From: Jon Loeliger [mailto:j...@netgate.com] Sent: Thursday, February 23, 2017 9:27 AM To: Dave Barach (dbarach) Cc: vpp-dev Subject: Re: [vpp-dev] Loopback Interface Names Dave, Thanks for taking the time to help me here! On Wed, Feb 22, 2017 at 4:47 PM, Dave Barach (

Re: [vpp-dev] Loopback Interface Names

2017-02-23 Thread Jon Loeliger
Dave, Thanks for taking the time to help me here! On Wed, Feb 22, 2017 at 4:47 PM, Dave Barach (dbarach) wrote: > You would certainly have to rewrite vnet_create_loopback_interface(...) a > little bit. That’s not necessarily a bad thing. > Yeah, I figured as much on that front... :-) I'm not

Re: [vpp-dev] VPP Wiki Release Plan Snigglet

2017-02-23 Thread Jon Loeliger
On Thu, Feb 23, 2017 at 2:04 AM, Jong Hahn (jonhahn) wrote: > Hi Jon, > > Per below, I updated the wiki and the Jira link. > > Thanks, > > Jong > > > Jong, Thank you! jdl ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinf

Re: [vpp-dev] SNAT Future API Questions

2017-02-23 Thread Jon Loeliger
On Wed, Feb 22, 2017 at 11:28 PM, Matus Fabian -X (matfabia - PANTHEON TECHNOLOGIES at Cisco) wrote: > Hi, > > > > There is currently work on dump API for SNAT runtime data (users and > sessions). It will be finished in next few days. > > > > Matus > Matus, That is awesome news! Thank you! j

Re: [vpp-dev] dpdk sw crypto- build error

2017-02-23 Thread Nicolau, Radu
If the issue appears on Ubuntu and other Debian based distros then the root of the problem is libtool, which is patched to set link_all_deplibs=no in the libtool script, effectively making libtool ignore library dependencies – the dependency_libs section in the .la files. A quick workaround is

Re: [vpp-dev] "TCP Shortcuts" for containers

2017-02-23 Thread Florin Coras
Hi Vadim, Code is still under development. We plan to merge the TCP stack and the shared memory FIFO code prior to 17.04 FC0. In the mean time, you can check a draft of what’s been done until now here [1]. Note however that most of the code is still in a state of flux. HTH, Florin [1] http

Re: [vpp-dev] VPP Wiki Release Plan Snigglet

2017-02-23 Thread Jong Hahn (jonhahn)
Hi Jon, Per below, I updated the wiki and the Jira link. Thanks, Jong From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Jon Loeliger Sent: Wednesday, February 22, 2017 12:44 PM To: vpp-dev Subject: [vpp-dev] VPP Wiki Release Plan Snigglet Hi Folks, Over on the