date:20171110

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger

Chris,

On Fri, Nov 10, 2017 at 8:27 PM, Luke, Chris  wrote:

> If you’re wondering where the tests are:
>
>
>
> $ ls test/*acl*
>
> test/test_acl_plugin_conns.py  test/test_acl_plugin_macip.py
>
> test/test_acl_plugin_l2l3.py   test/test_acl_plugin.py
>

Ah, excellent!


> Chris.
>

Thanks!

jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Luke, Chris

Since the tests reside in the same repo and they’re run from the checkout copy 
of the patch, you should be able to simply update the tests in the same patch 
that changes the result codes, without need for backward compatibility.

If you’re wondering where the tests are:

$ ls test/*acl*
test/test_acl_plugin_conns.py  test/test_acl_plugin_macip.py
test/test_acl_plugin_l2l3.py   test/test_acl_plugin.py

Chris.

From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of Jon Loeliger
Sent: Friday, November 10, 2017 19:17
To: Andrew Yourtchenko 
Cc: vpp-dev 
Subject: Re: [vpp-dev] ACL Build/Test Issues

On Fri, Nov 10, 2017 at 5:54 PM, Andrew Yourtchenko 
> wrote:
Hi Jon,

On 10 Nov 2017, at 23:11, Jon Loeliger 
> wrote:
Folks,

Every error from the ACL implementation is -1.  Generically bad.
Without regard for what might be more useful to an upper-layer UI.

When we discussed with the openstack folks the way they are treating errors was 
all as catastrophic, but yes more distinction would be better, so thanks a lot 
for taking care of it!

Happy to try to help. :-)

So I submitted a patch to help this situation some.
https://gerrit.fd.io/r/#/c/9383/

I have built and tested it locally, but it fails the Verify Tests because
it has a test that is expecting a hard-coded -1 return from some tests.
Returning a -6 wasn't good enough.

First, this is draconian for no really good reason.  Second, it should be
fixed.  Third, I would do that except I am stupid and need a clue where
or how to fix this situation so the tests are less draconian.  (Can we
get a "less than 0" test instead of "equal to -1"?)

Yeah. So we would need to first submit new test(s) that pass on both current 
and new code and then the new code itself... wanna take a shot at it  or should 
I ?

I don't even know where I would begin on that front, except
to say the test should maybe be " actual < 0" for now.
Oh, and, it's pretty clear why the Verify failed, despite the Jenkins job
saying it was unable to determine a cause.  Um, double blerg.

Alas, this one I leave to someone else to comment on :)

I hear that!

jdl

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger

On Fri, Nov 10, 2017 at 5:54 PM, Andrew Yourtchenko 
wrote:

> Hi Jon,
>
> On 10 Nov 2017, at 23:11, Jon Loeliger  wrote:
>
> Folks,
>
> Every error from the ACL implementation is -1.  Generically bad.
> Without regard for what might be more useful to an upper-layer UI.
>
>
> When we discussed with the openstack folks the way they are treating
> errors was all as catastrophic, but yes more distinction would be better,
> so thanks a lot for taking care of it!
>

Happy to try to help. :-)

So I submitted a patch to help this situation some.
> https://gerrit.fd.io/r/#/c/9383/
>
> I have built and tested it locally, but it fails the Verify Tests because
> it has a test that is expecting a hard-coded -1 return from some tests.
> Returning a -6 wasn't good enough.
>
> First, this is draconian for no really good reason.  Second, it should be
> fixed.  Third, I would do that except I am stupid and need a clue where
> or how to fix this situation so the tests are less draconian.  (Can we
> get a "less than 0" test instead of "equal to -1"?)
>
>
> Yeah. So we would need to first submit new test(s) that pass on both
> current and new code and then the new code itself... wanna take a shot at
> it  or should I ?
>

I don't even know where I would begin on that front, except
to say the test should maybe be " actual < 0" for now.

> Oh, and, it's pretty clear why the Verify failed, despite the Jenkins job
> saying it was unable to determine a cause.  Um, double blerg.
>
>
> Alas, this one I leave to someone else to comment on :)
>

I hear that!

jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] make test-all

2017-11-10 Thread Brian Brooks

Should "make test-all" pass?

Thanks,
Brian

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Andrew Yourtchenko

Hi Jon,

> On 10 Nov 2017, at 23:11, Jon Loeliger  wrote:
> 
> Folks,
> 
> Every error from the ACL implementation is -1.  Generically bad.
> Without regard for what might be more useful to an upper-layer UI.

When we discussed with the openstack folks the way they are treating errors was 
all as catastrophic, but yes more distinction would be better, so thanks a lot 
for taking care of it!

> 
> So I submitted a patch to help this situation some.
> https://gerrit.fd.io/r/#/c/9383/
> 
> I have built and tested it locally, but it fails the Verify Tests because
> it has a test that is expecting a hard-coded -1 return from some tests.
> Returning a -6 wasn't good enough.
> 
> First, this is draconian for no really good reason.  Second, it should be
> fixed.  Third, I would do that except I am stupid and need a clue where
> or how to fix this situation so the tests are less draconian.  (Can we
> get a "less than 0" test instead of "equal to -1"?)

Yeah. So we would need to first submit new test(s) that pass on both current 
and new code and then the new code itself... wanna take a shot at it  or should 
I ?

> 
> Oh, and, it's pretty clear why the Verify failed, despite the Jenkins job
> saying it was unable to determine a cause.  Um, double blerg.

Alas, this one I leave to someone else to comment on :)

—a


> 
> Any help for the weary here?
> 
> Thanks,
> jdl
> 
> 
> 21:21:43 ERROR: ACL create/delete test
> 21:21:43 
> --
> 21:21:43 Traceback (most recent call last):
> 21:21:43   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/test_acl_plugin.py", line 
> 563, in test_0001_acl_create
> 21:21:43 tag=":", expected_retval=-1)
> 21:21:43   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
> 2483, in acl_add_replace
> 21:21:43 expected_retval=expected_retval)
> 21:21:43   File 
> "/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py", line 
> 167, in api
> 21:21:43 raise UnexpectedApiReturnValueError(msg)
> 21:21:43 UnexpectedApiReturnValueError: API call failed, expected -1 return 
> value instead of -6 in acl_add_replace_reply(_0=936, context=33, 
> acl_index=432, retval=-6)
> 21:21:43 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] ACL Build/Test Issues

2017-11-10 Thread Jon Loeliger

Folks,

Every error from the ACL implementation is -1.  Generically bad.
Without regard for what might be more useful to an upper-layer UI.

So I submitted a patch to help this situation some.
https://gerrit.fd.io/r/#/c/9383/

I have built and tested it locally, but it fails the Verify Tests because
it has a test that is expecting a hard-coded -1 return from some tests.
Returning a -6 wasn't good enough.

First, this is draconian for no really good reason.  Second, it should be
fixed.  Third, I would do that except I am stupid and need a clue where
or how to fix this situation so the tests are less draconian.  (Can we
get a "less than 0" test instead of "equal to -1"?)

Oh, and, it's pretty clear why the Verify failed, despite the Jenkins job
saying it was unable to determine a cause.  Um, double blerg.

Any help for the weary here?

Thanks,
jdl


*21:21:43* ERROR: ACL create/delete test*21:21:43*
--*21:21:43*
Traceback (most recent call last):*21:21:43*   File
"/w/workspace/vpp-verify-master-ubuntu1604/test/test_acl_plugin.py",
line 563, in test_0001_acl_create*21:21:43* tag=":",
expected_retval=-1)*21:21:43*   File
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py",
line 2483, in acl_add_replace*21:21:43*
expected_retval=expected_retval)*21:21:43*   File
"/w/workspace/vpp-verify-master-ubuntu1604/test/vpp_papi_provider.py",
line 167, in api*21:21:43* raise
UnexpectedApiReturnValueError(msg)*21:21:43*
UnexpectedApiReturnValueError: API call failed, expected -1 return
value instead of -6 in acl_add_replace_reply(_0=936, context=33,
acl_index=432, retval=-6)*21:21:43*
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Neale Ranns (nranns)


Hi Chris,

Thank you. Please let me know if the build remains on strike ☺

/neale

-Original Message-
From: "Luke, Chris" 
Date: Friday, 10 November 2017 at 14:53
To: "Neale Ranns (nranns)" , Chris Luke , 
"vpp-dev@lists.fd.io" 
Subject: RE: [vpp-dev] FW: Coverity build failed with 18 errors

Thanks Neale; merged. Hopefully normal service will be resumed on this 
afternoons run! :)

Chris.

> -Original Message-
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On
> Behalf Of Neale Ranns (nranns)
> Sent: Friday, November 10, 2017 7:33
> To: Chris Luke ; vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] FW: Coverity build failed with 18 errors
> 
> Hi Chris,
> 
> And this one for VOM:
>   https://gerrit.fd.io/r/#/c/9374/
> 
> /neale
> 
> -Original Message-
> From:  on behalf of "Neale Ranns (nranns)"
> 
> Date: Friday, 10 November 2017 at 11:59
> To: Chris Luke , "vpp-dev@lists.fd.io"  d...@lists.fd.io>
> Subject: Re: [vpp-dev] FW: Coverity build failed with 18 errors
> 
> 
> Hi Chris,
> 
> I just pushed:
>   https://gerrit.fd.io/r/#/c/9370/
> to fix the use of integer types in BIER.
> 
> I’ll look at the VOM ones too.
> 
> /neale
> 
> 
> -Original Message-
> From:  on behalf of Chris Luke
> 
> Date: Thursday, 9 November 2017 at 22:05
> To: "vpp-dev@lists.fd.io" 
> Subject: [vpp-dev] FW: Coverity build failed with 18 errors
> 
> FYI, Coverity has just failed to build because of issues in BIER 
(and maybe
> VOM); some of these may have existed a while, because these all 
seem
> to be
> warnings and Coverity fails a build based on number of rejected 
build
> units
> exceeding a % threshold. Likely BIER was merged and triggered the
> threshold.
> 
> I note that BIER is using C99 stdint types; Coverity appears to 
be fussy
> about how these get defined (missing include?); also we agreed 
here on
> this
> list just a few weeks ago that VPP uses its own typedefs for 
specified-
> width
> integers (u64 etc) so we should not be using such C99 types 
anyway.
> 
> For those interested, the Coverity build log is available at
> https://vpp.flirble.org/coverity/20171109/build-log.txt though 
please
> don't
> ask me to interpret it!
> 
> Chris.
> 
> -Original Message-
> From: VPP [mailto:v...@brae.flirble.org]
> Sent: Thursday, November 9, 2017 15:29
> To: chr...@flirble.org
> Subject: Coverity build failed with 18 errors
> 
> Coverity build failed with 18 errors.
> 
> Latest commit: v18.01-rc0-251-g75e974b
> 
> Error counts from cov-int/build-log.txt:
> 84205:[ERROR] [104291] EXECUTING: /bin/sed s|:*$||
> 84459:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/fib/fib_path.c".
> 91374:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask.c".
> 91462:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask_db.c".
> 91532:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_entry.c".
> 91700:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_output.c".
> 91775:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_table.c".
> 91828:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_lookup.c".
> 91840:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask.c".
> 91847:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask_db.c".
> 91954:[ERROR] 5 errors detected in the compilation of
> "../../../src/vnet/bier/bier_types.c".
> 91982:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_entry.c".
> 92104:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_output.c".
> 92160:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_table.c".
> 92396:[ERROR] 1 error detected in the compilation of
>

Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Luke, Chris

Thanks Neale; merged. Hopefully normal service will be resumed on this 
afternoons run! :)

Chris.

> -Original Message-
> From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On
> Behalf Of Neale Ranns (nranns)
> Sent: Friday, November 10, 2017 7:33
> To: Chris Luke ; vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] FW: Coverity build failed with 18 errors
> 
> Hi Chris,
> 
> And this one for VOM:
>   https://gerrit.fd.io/r/#/c/9374/
> 
> /neale
> 
> -Original Message-
> From:  on behalf of "Neale Ranns (nranns)"
> 
> Date: Friday, 10 November 2017 at 11:59
> To: Chris Luke , "vpp-dev@lists.fd.io"  d...@lists.fd.io>
> Subject: Re: [vpp-dev] FW: Coverity build failed with 18 errors
> 
> 
> Hi Chris,
> 
> I just pushed:
>   https://gerrit.fd.io/r/#/c/9370/
> to fix the use of integer types in BIER.
> 
> I’ll look at the VOM ones too.
> 
> /neale
> 
> 
> -Original Message-
> From:  on behalf of Chris Luke
> 
> Date: Thursday, 9 November 2017 at 22:05
> To: "vpp-dev@lists.fd.io" 
> Subject: [vpp-dev] FW: Coverity build failed with 18 errors
> 
> FYI, Coverity has just failed to build because of issues in BIER (and 
> maybe
> VOM); some of these may have existed a while, because these all seem
> to be
> warnings and Coverity fails a build based on number of rejected build
> units
> exceeding a % threshold. Likely BIER was merged and triggered the
> threshold.
> 
> I note that BIER is using C99 stdint types; Coverity appears to be 
> fussy
> about how these get defined (missing include?); also we agreed here on
> this
> list just a few weeks ago that VPP uses its own typedefs for 
> specified-
> width
> integers (u64 etc) so we should not be using such C99 types anyway.
> 
> For those interested, the Coverity build log is available at
> https://vpp.flirble.org/coverity/20171109/build-log.txt though please
> don't
> ask me to interpret it!
> 
> Chris.
> 
> -Original Message-
> From: VPP [mailto:v...@brae.flirble.org]
> Sent: Thursday, November 9, 2017 15:29
> To: chr...@flirble.org
> Subject: Coverity build failed with 18 errors
> 
> Coverity build failed with 18 errors.
> 
> Latest commit: v18.01-rc0-251-g75e974b
> 
> Error counts from cov-int/build-log.txt:
> 84205:[ERROR] [104291] EXECUTING: /bin/sed s|:*$||
> 84459:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/fib/fib_path.c".
> 91374:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask.c".
> 91462:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask_db.c".
> 91532:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_entry.c".
> 91700:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_output.c".
> 91775:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_table.c".
> 91828:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_lookup.c".
> 91840:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask.c".
> 91847:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_fmask_db.c".
> 91954:[ERROR] 5 errors detected in the compilation of
> "../../../src/vnet/bier/bier_types.c".
> 91982:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_entry.c".
> 92104:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_output.c".
> 92160:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_table.c".
> 92396:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_lookup.c".
> 92796:[ERROR] 5 errors detected in the compilation of
> "../../../src/vnet/bier/bier_types.c".
> 93191:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_test.c".
> 93644:[ERROR] 1 error detected in the compilation of
> "../../../src/vnet/bier/bier_test.c".
> 
> Probable error information from the compiler:
> 84180:"/home/vpp/dev/fdio/coverity/vpp/build-
> data/../src/vnet/bier/bier_fmas
> k.h",
> 84181-  line 57: error #20: identifier "uint32_t" is undefined
> 84182-  uint32_t bfmb_count;
> 84183-  ^
> --
> 84428:"/home/vpp/dev/fdio/coverity/vpp/build-
> data/../src/vnet/bier/bier_fmas
>

Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Neale Ranns (nranns)

Hi Chris,

And this one for VOM:
  https://gerrit.fd.io/r/#/c/9374/

/neale

-Original Message-
From:  on behalf of "Neale Ranns (nranns)" 

Date: Friday, 10 November 2017 at 11:59
To: Chris Luke , "vpp-dev@lists.fd.io" 
Subject: Re: [vpp-dev] FW: Coverity build failed with 18 errors


Hi Chris,

I just pushed:
  https://gerrit.fd.io/r/#/c/9370/
to fix the use of integer types in BIER.

I’ll look at the VOM ones too.

/neale
 

-Original Message-
From:  on behalf of Chris Luke 

Date: Thursday, 9 November 2017 at 22:05
To: "vpp-dev@lists.fd.io" 
Subject: [vpp-dev] FW: Coverity build failed with 18 errors

FYI, Coverity has just failed to build because of issues in BIER (and 
maybe
VOM); some of these may have existed a while, because these all seem to 
be
warnings and Coverity fails a build based on number of rejected build 
units
exceeding a % threshold. Likely BIER was merged and triggered the 
threshold.

I note that BIER is using C99 stdint types; Coverity appears to be fussy
about how these get defined (missing include?); also we agreed here on 
this
list just a few weeks ago that VPP uses its own typedefs for 
specified-width
integers (u64 etc) so we should not be using such C99 types anyway.

For those interested, the Coverity build log is available at
https://vpp.flirble.org/coverity/20171109/build-log.txt though please 
don't
ask me to interpret it!

Chris.

-Original Message-
From: VPP [mailto:v...@brae.flirble.org] 
Sent: Thursday, November 9, 2017 15:29
To: chr...@flirble.org
Subject: Coverity build failed with 18 errors

Coverity build failed with 18 errors.

Latest commit: v18.01-rc0-251-g75e974b

Error counts from cov-int/build-log.txt:
84205:[ERROR] [104291] EXECUTING: /bin/sed s|:*$||
84459:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/fib/fib_path.c".
91374:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask.c".
91462:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask_db.c".
91532:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_entry.c".
91700:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_output.c".
91775:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_table.c".
91828:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_lookup.c".
91840:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask.c".
91847:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask_db.c".
91954:[ERROR] 5 errors detected in the compilation of
"../../../src/vnet/bier/bier_types.c".
91982:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_entry.c".
92104:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_output.c".
92160:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_table.c".
92396:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_lookup.c".
92796:[ERROR] 5 errors detected in the compilation of
"../../../src/vnet/bier/bier_types.c".
93191:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_test.c".
93644:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_test.c".

Probable error information from the compiler:

84180:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_fmas
k.h",
84181-  line 57: error #20: identifier "uint32_t" is undefined
84182-  uint32_t bfmb_count;
84183-  ^
--

84428:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_fmas
k.h",
84429-  line 57: error #20: identifier "uint32_t" is undefined
84430-  uint32_t bfmb_count;
84431-  ^
--

87392:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_bit_
string
87393-  .h", line 56: warning #20: identifier "uint16_t" is
undefined
87394-  uint16_t index;
87395-  ^
--

87397:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_bit_
string

Re: [vpp-dev] FW: Coverity build failed with 18 errors

2017-11-10 Thread Neale Ranns (nranns)


Hi Chris,

I just pushed:
  https://gerrit.fd.io/r/#/c/9370/
to fix the use of integer types in BIER.

I’ll look at the VOM ones too.

/neale
 

-Original Message-
From:  on behalf of Chris Luke 
Date: Thursday, 9 November 2017 at 22:05
To: "vpp-dev@lists.fd.io" 
Subject: [vpp-dev] FW: Coverity build failed with 18 errors

FYI, Coverity has just failed to build because of issues in BIER (and maybe
VOM); some of these may have existed a while, because these all seem to be
warnings and Coverity fails a build based on number of rejected build units
exceeding a % threshold. Likely BIER was merged and triggered the threshold.

I note that BIER is using C99 stdint types; Coverity appears to be fussy
about how these get defined (missing include?); also we agreed here on this
list just a few weeks ago that VPP uses its own typedefs for specified-width
integers (u64 etc) so we should not be using such C99 types anyway.

For those interested, the Coverity build log is available at
https://vpp.flirble.org/coverity/20171109/build-log.txt though please don't
ask me to interpret it!

Chris.

-Original Message-
From: VPP [mailto:v...@brae.flirble.org] 
Sent: Thursday, November 9, 2017 15:29
To: chr...@flirble.org
Subject: Coverity build failed with 18 errors

Coverity build failed with 18 errors.

Latest commit: v18.01-rc0-251-g75e974b

Error counts from cov-int/build-log.txt:
84205:[ERROR] [104291] EXECUTING: /bin/sed s|:*$||
84459:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/fib/fib_path.c".
91374:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask.c".
91462:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask_db.c".
91532:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_entry.c".
91700:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_output.c".
91775:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_table.c".
91828:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_lookup.c".
91840:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask.c".
91847:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_fmask_db.c".
91954:[ERROR] 5 errors detected in the compilation of
"../../../src/vnet/bier/bier_types.c".
91982:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_entry.c".
92104:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_output.c".
92160:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_table.c".
92396:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_lookup.c".
92796:[ERROR] 5 errors detected in the compilation of
"../../../src/vnet/bier/bier_types.c".
93191:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_test.c".
93644:[ERROR] 1 error detected in the compilation of
"../../../src/vnet/bier/bier_test.c".

Probable error information from the compiler:
84180:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_fmas
k.h",
84181-  line 57: error #20: identifier "uint32_t" is undefined
84182-  uint32_t bfmb_count;
84183-  ^
--
84428:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_fmas
k.h",
84429-  line 57: error #20: identifier "uint32_t" is undefined
84430-  uint32_t bfmb_count;
84431-  ^
--
87392:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_bit_
string
87393-  .h", line 56: warning #20: identifier "uint16_t" is
undefined
87394-  uint16_t index;
87395-  ^
--
87397:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_bit_
string
87398-  .h", line 72: warning #20: identifier "uint16_t" is
undefined
87399-  uint16_t index;
87400-  ^
--
87402:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_bit_
string
87403-  .h", line 87: warning #20: identifier "uint16_t" is
undefined
87404-  uint16_t index;
87405-  ^
--
87423:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_bit_
string
87424-  .h", line 54: warning #1563: function
"bier_bit_string_is_zero" not
87425-  emitted, consider modeling it or review parse diagnostics to
improve
87426-  fidelity
--
87430:"/home/vpp/dev/fdio/coverity/vpp/build-data/../src/vnet/bier/bier_bit_
string
87431-  .h", line 69:

Re: [vpp-dev] ACL Build/Test Issues

Re: [vpp-dev] ACL Build/Test Issues

Re: [vpp-dev] ACL Build/Test Issues

[vpp-dev] make test-all

Re: [vpp-dev] ACL Build/Test Issues

[vpp-dev] ACL Build/Test Issues

Re: [vpp-dev] FW: Coverity build failed with 18 errors

Re: [vpp-dev] FW: Coverity build failed with 18 errors

Re: [vpp-dev] FW: Coverity build failed with 18 errors

Re: [vpp-dev] FW: Coverity build failed with 18 errors

10 matches

Site Navigation

Mail list logo

Footer information