Re: [vpp-dev] GTPu

2018-06-19 Thread Kingwel Xie
Hi, My colleague Liu Anhua has done the patch: https://gerrit.fd.io/r/#/c/13134/ Couldn’t add Chengqiang as reviewer, gerrit says he/she can not be identified. Regards, Kingwel From: Ni, Hongjun Sent: Friday, June 08, 2018 5:54 PM To: Edward Warnicke ; Kingwel Xie ; vpp-dev@lists.fd.io Cc:

Re: [vpp-dev] Verify consistently failing

2018-06-19 Thread Ed Kern via Lists.Fd.Io
I think what Ed meant to do is to speedup verify job without realizing that test framework does a local install of vpp_papi package which is part of the source tree. this is correct. So having cached virtualenv is a bad idea as we see already. dont agree…caching internal bits is certainly

Re: [vpp-dev] vpp project patch verification broken

2018-06-19 Thread Ole Troan
Hi Ed, > On 19 Jun 2018, at 17:24, Ed Kern (ejk) wrote: > > > >> On Jun 19, 2018, at 7:33 AM, Ole Troan wrote: >> >> Dave, et al, >> >> Yes, all these are indications of the verify job running a different (and >> cached) version of the Python VPP package than the one in build tree. > >

Re: [vpp-dev] How to disable assert in VPP

2018-06-19 Thread Damjan Marion
ASSERT will not cause crash in production image, as it is excluded from production builds. However if ASSERT condition was met than it is good probability that VPP will crash shortly after or start to misbehave. > On 19 Jun 2018, at 04:28, chetan bhasin wrote: > > Actually assert is fine if

Re: [vpp-dev] vpp project patch verification broken

2018-06-19 Thread Ed Kern via Lists.Fd.Io
On Jun 19, 2018, at 7:33 AM, Ole Troan mailto:otr...@employees.org>> wrote: Dave, et al, Yes, all these are indications of the verify job running a different (and cached) version of the Python VPP package than the one in build tree. yup it certainly is... That stopped working as soon as I

Re: [vpp-dev] vpp project patch verification broken

2018-06-19 Thread Ole Troan
Dave, et al, Yes, all these are indications of the verify job running a different (and cached) version of the Python VPP package than the one in build tree. That stopped working as soon as I changed the in-tree one (and the caching system picking up and apparently being stuck with a broken

[vpp-dev] vpp project patch verification broken

2018-06-19 Thread Dave Barach via Lists.Fd.Io
See, for example, https://gerrit.fd.io/r/#/c/13061. This failure is almost certainly unrelated to the patch. We need to fix this 90 seconds ago. Thanks... Dave 13:02:17 == 13:02:17 ERROR: IP ACL test 13:02:17

Re: [vpp-dev] How to disable assert in VPP

2018-06-19 Thread chetan bhasin
Actually assert is fine if we are doing QA testing but if we deploy build at customer site we don't expect there would be a crash, even in error condition, error code should be return and that code needs to be handled properly. Thanks, Chetan Bhasin On Tue, Jun 19, 2018, 14:32 Ray Kinsella

Re: [vpp-dev] Verify consistently failing

2018-06-19 Thread Klement Sekera via Lists.Fd.Io
Hi, I created a debugging patch set https://gerrit.fd.io/r/#/c/13122/ which hints that there is something fishy going on with the python virtualenv. Per https://jenkins.fd.io/job/vpp-verify-master-ubuntu1604/12067/consol e:  10:21:46 make -C test TEST_DIR=/w/workspace/vpp-verify-master-

Re: [vpp-dev] How to disable assert in VPP

2018-06-19 Thread Ray Kinsella
Ok - there something we are missing here. Why would you want to do this? Ray K On 15/06/2018 10:11, chetan bhasin wrote: Hi , For deployment , we want to replace assert with error log. Is there a way in VPP to do that? Thanks, Chetan -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all

[vpp-dev] Verify consistently failing

2018-06-19 Thread Ole Troan
Seems like my patch https://gerrit.fd.io/r/#/c/13013/ broke the verification job. I provided a fix, but for some strange reason it seems like the verifiy build is stuck with the broken version of the vpp_papi package. This problem seems to persist even after I reverted 13013 with