date:20200925

Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized

2020-09-25 Thread Heckman, Steve

OK, thanks.

I must have just missed it...

-Steve

From: Yichen Wang (yicwang) 
Sent: Friday, September 25, 2020 4:09 PM
To: Heckman, Steve ; vpp-dev@lists.fd.io 

Subject: Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used 
uninitialized

You need this: https://gerrit.fd.io/r/c/vpp/+/29084, and merged in stable/2009 
already. Regards, Yichen  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  
‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌ 
 ‌  ‌  ‌
External (yicw...@cisco.com)
Report This 
Email
  FAQ  Protection by 
INKY


You need this: 
https://gerrit.fd.io/r/c/vpp/+/29084,
 and merged in stable/2009 already.



Regards,

Yichen



From:  on behalf of "Heckman, Steve" 

Date: Friday, September 25, 2020 at 1:04 PM
To: "vpp-dev@lists.fd.io" 
Subject: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used 
uninitialized



I had been building in the master branch fine for a while. We need 20.09, so I 
saw that the branch was available and checked it out.



I ran onto this building on Ubuntu Focal (20.04):



$ git fetch

remote: Enumerating objects: 60, done.

remote: Counting objects: 100% (55/55), done.

remote: Compressing objects: 100% (28/28), done.

remote: Total 30 (delta 26), reused 6 (delta 2), pack-reused 0

Unpacking objects: 100% (30/30), 3.05 KiB | 283.00 KiB/s, done.

From https://github.com/FDio/vpp

   561ae5d17..277d402be  master  -> origin/master

   df143bf70..a26b40af9  stable/2009 -> origin/stable/2009

$ make pkg-deb

make[1]: Entering directory '/home/labuser/Development/git/vpp/build-root'

 Arch for platform 'vpp' is native 

 Finding source for external 

 Makefile fragment found in 
/home/labuser/Development/git/vpp/build-data/packages/external.mk 

 Source found in /home/labuser/Development/git/vpp/build 

 Arch for platform 'vpp' is native 

 Finding source for vpp 

 Makefile fragment found in 
/home/labuser/Development/git/vpp/build-data/packages/vpp.mk 

 Source found in /home/labuser/Development/git/vpp/src 

 Configuring external: nothing to do 

 Building external: nothing to do 

 Installing external: nothing to do 

 Configuring vpp: nothing to do 

 Building vpp in 
/home/labuser/Development/git/vpp/build-root/build-vpp-native/vpp 

[11/18] Building C object 
plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o

FAILED: plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o

ccache /usr/lib/ccache/gcc-9 -DHAVE_FCNTL64 -DHAVE_GETCPU -DHAVE_MEMFD_CREATE 
-Dwireguard_plugin_EXPORTS -I/home/labuser/Development/git/vpp/src -I. 
-Iinclude -I/home/labuser/Development/git/vpp/src/plugins -Iplugins 
-Wno-address-of-packed-member -g -fPIC -Werror -Wall -march=corei7 
-mtune=corei7-avx  -O2 -fstack-protector -DFORTIFY_SOURCE=2 -fno-common  -fPIC 
-MD -MT plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o 
-MF plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o.d 
-o plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o   -c 
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c

/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c: In 
function 'wg_handshake_handoff_fn':

/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:112:12:
 error: 'peeri' may be used uninitialized in this function 
[-Werror=maybe-uninitialized]

  112 |t->peer = peeri;

  |^~~

/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:82:15:
 note: 'peeri' was declared here

   82 |   index_t peeri;

  |   ^

cc1: all warnings being treated as errors

[12/18] Linking C shared library lib/libvnet.so.20.09

ninja: build stopped: subcommand failed.

make[1]: *** [Makefile:693: vpp-build] Error 1

make[1]: Leaving directory '/home/labuser/Development/git/vpp/build-root'

make: *** [Makefile:560: pkg-deb] Error 2



Anyone else see that?



Thanks,
Steve Heckman

Distinguished Software Engineer

Commscope, Inc.

Lowell, Ma







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

[vpp-dev] vnet_classify_add_del_table API?

2020-09-25 Thread hemant via lists.fd.io

In the classify API mentioned in the subject of this email, I could use an
example with tables to understand table_index, next_table_index, and
miss_next_index.  I know VPP maintains an index for a table.

 

Say, the tables are invoked in this order for this example:

 

Ethernet-input, ip4-iput, pkt_filter4 (my new table), rewrite 

 

If table_index is that of pkt_filter4, I suppose, next_table_index is
rewrite?  I am not sure what is miss_next_index which is invoked if
pkt_filter4 incurs a miss.

 

Thanks,

 

Hemant

 



smime.p7s
Description: S/MIME cryptographic signature

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17534): https://lists.fd.io/g/vpp-dev/message/17534
Mute This Topic: https://lists.fd.io/mt/77126788/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] [vpp-committers] VPP committers: VPP PTL vote

2020-09-25 Thread John Lo (loj) via lists.fd.io

+1   -John

From: vpp-committ...@lists.fd.io  On Behalf Of Dave 
Barach via lists.fd.io
Sent: Friday, September 25, 2020 3:14 PM
To: vpp-committ...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: [vpp-committers] VPP committers: VPP PTL vote

Folks,

The self-nomination period closed yesterday. We had one self-nomination, from 
Damjan Marion. At this point, we can proceed with a vote.

I'm sure that Damjan will do a great job, so let me start:

Damjan Marion as VPP PTL: +1

Please vote +1, 0, -1. For once, the "reply-all" button is everyone's friend.

Thanks... Dave

-Original Message-
From: d...@barachs.net 
mailto:d...@barachs.net>>
Sent: Thursday, September 17, 2020 10:32 AM
To: 'vpp-dev@lists.fd.io' mailto:vpp-dev@lists.fd.io>>; 
't...@lists.fd.io' mailto:t...@lists.fd.io>>
Subject: Happy Trails to Me...

Folks,

I'm departing the employment rolls towards the end of next month. Although I 
intend to remain active in the fd.io vpp community as a coder, committer, and 
resident greybeard, it's time for the community to pick a new PTL.

According to the project governance document, 
https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf:

3.2.3.1 Project Technical Leader Candidates Candidates for the project's PTL 
will be derived from the Committers of the Project. Candidates must 
self-nominate.

I'd like to invite any interested vpp project committer to self-nominate for 
the PTL role. Please email vpp-dev@lists.fd.io.

Let's close the self-nomination period in one week: more specifically, by 5pm 
EDT on Thursday, September 24, 2020; committer vote to follow thereafter.

I'll be glad to answer unicast questions about the PTL role from eligible 
committers.

Thanks... Dave

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17533): https://lists.fd.io/g/vpp-dev/message/17533
Mute This Topic: https://lists.fd.io/mt/77125879/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Silly programmer trick #47...

2020-09-25 Thread Dave Barach via lists.fd.io

Please don't be this person:

static clib_error_t *
my_cli_command_fn (vlib_main_t * vm,
   unformat_input_t * input,
   vlib_cli_command_t * cmd)
{
  while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
{
  if (unformat (input, "mystuff"))
  else
 return (clib_error_return (0, "unknown input '%U'",
format_unformat_error, input));
}
  return (NULL);
}
/* *INDENT-OFF* */
VLIB_CLI_COMMAND (my_command, static) =
{
  .path = "my command",
  .function = my_cli_command_fn,
};

Commands coded like this work fine when typed one at a time, but they blow 
chunks when scripted...

Script:
my command mystuff
comment { ouch my_cli_command_fn ate the word comment and threw up! }

Instead, wrap the while(...) loop with the unformat_line_input guitar lick:

  elib_error_t *e = 0;
  /* Get a line of input. */
  if (!unformat_user (input, unformat_line_input, line_input))
return 0;

  while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
{
  if (unformat (line_input, "mystuff"))
;
  else {
e = clib_error_return (0, "unknown input '%U'",
  format_unformat_error, input);
goto done;
  }
}


done:
  unformat_free (line_input);
  return e;

Thanks... Dave

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17532): https://lists.fd.io/g/vpp-dev/message/17532
Mute This Topic: https://lists.fd.io/mt/77125668/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized

2020-09-25 Thread Yichen Wang via lists.fd.io

You need this: https://gerrit.fd.io/r/c/vpp/+/29084, and merged in stable/2009 
already.

Regards,
Yichen

From:  on behalf of "Heckman, Steve" 

Date: Friday, September 25, 2020 at 1:04 PM
To: "vpp-dev@lists.fd.io" 
Subject: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used 
uninitialized

I had been building in the master branch fine for a while. We need 20.09, so I 
saw that the branch was available and checked it out.

I ran onto this building on Ubuntu Focal (20.04):

$ git fetch
remote: Enumerating objects: 60, done.
remote: Counting objects: 100% (55/55), done.
remote: Compressing objects: 100% (28/28), done.
remote: Total 30 (delta 26), reused 6 (delta 2), pack-reused 0
Unpacking objects: 100% (30/30), 3.05 KiB | 283.00 KiB/s, done.
From https://github.com/FDio/vpp
   561ae5d17..277d402be  master  -> origin/master
   df143bf70..a26b40af9  stable/2009 -> origin/stable/2009

$ make pkg-deb
make[1]: Entering directory '/home/labuser/Development/git/vpp/build-root'
 Arch for platform 'vpp' is native 
 Finding source for external 
 Makefile fragment found in 
/home/labuser/Development/git/vpp/build-data/packages/external.mk 
 Source found in /home/labuser/Development/git/vpp/build 
 Arch for platform 'vpp' is native 
 Finding source for vpp 
 Makefile fragment found in 
/home/labuser/Development/git/vpp/build-data/packages/vpp.mk 
 Source found in /home/labuser/Development/git/vpp/src 
 Configuring external: nothing to do 
 Building external: nothing to do 
 Installing external: nothing to do 
 Configuring vpp: nothing to do 
 Building vpp in 
/home/labuser/Development/git/vpp/build-root/build-vpp-native/vpp 
[11/18] Building C object 
plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o
FAILED: plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o
ccache /usr/lib/ccache/gcc-9 -DHAVE_FCNTL64 -DHAVE_GETCPU -DHAVE_MEMFD_CREATE 
-Dwireguard_plugin_EXPORTS -I/home/labuser/Development/git/vpp/src -I. 
-Iinclude -I/home/labuser/Development/git/vpp/src/plugins -Iplugins 
-Wno-address-of-packed-member -g -fPIC -Werror -Wall -march=corei7 
-mtune=corei7-avx  -O2 -fstack-protector -DFORTIFY_SOURCE=2 -fno-common  -fPIC 
-MD -MT plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o 
-MF plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o.d 
-o plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o   -c 
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c: In 
function 'wg_handshake_handoff_fn':
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:112:12:
 error: 'peeri' may be used uninitialized in this function 
[-Werror=maybe-uninitialized]
  112 |t->peer = peeri;
  |^~~
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:82:15:
 note: 'peeri' was declared here
   82 |   index_t peeri;
  |   ^
cc1: all warnings being treated as errors
[12/18] Linking C shared library lib/libvnet.so.20.09
ninja: build stopped: subcommand failed.
make[1]: *** [Makefile:693: vpp-build] Error 1
make[1]: Leaving directory '/home/labuser/Development/git/vpp/build-root'
make: *** [Makefile:560: pkg-deb] Error 2

Anyone else see that?

Thanks,
Steve Heckman
Distinguished Software Engineer
Commscope, Inc.
Lowell, Ma




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17531): https://lists.fd.io/g/vpp-dev/message/17531
Mute This Topic: https://lists.fd.io/mt/77124338/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized

2020-09-25 Thread Heckman, Steve

I had been building in the master branch fine for a while. We need 20.09, so I 
saw that the branch was available and checked it out.

I ran onto this building on Ubuntu Focal (20.04):

$ git fetch
remote: Enumerating objects: 60, done.
remote: Counting objects: 100% (55/55), done.
remote: Compressing objects: 100% (28/28), done.
remote: Total 30 (delta 26), reused 6 (delta 2), pack-reused 0
Unpacking objects: 100% (30/30), 3.05 KiB | 283.00 KiB/s, done.
>From https://github.com/FDio/vpp
   561ae5d17..277d402be  master  -> origin/master
   df143bf70..a26b40af9  stable/2009 -> origin/stable/2009

$ make pkg-deb
make[1]: Entering directory '/home/labuser/Development/git/vpp/build-root'
 Arch for platform 'vpp' is native 
 Finding source for external 
 Makefile fragment found in 
/home/labuser/Development/git/vpp/build-data/packages/external.mk 
 Source found in /home/labuser/Development/git/vpp/build 
 Arch for platform 'vpp' is native 
 Finding source for vpp 
 Makefile fragment found in 
/home/labuser/Development/git/vpp/build-data/packages/vpp.mk 
 Source found in /home/labuser/Development/git/vpp/src 
 Configuring external: nothing to do 
 Building external: nothing to do 
 Installing external: nothing to do 
 Configuring vpp: nothing to do 
 Building vpp in 
/home/labuser/Development/git/vpp/build-root/build-vpp-native/vpp 
[11/18] Building C object 
plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o
FAILED: plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o
ccache /usr/lib/ccache/gcc-9 -DHAVE_FCNTL64 -DHAVE_GETCPU -DHAVE_MEMFD_CREATE 
-Dwireguard_plugin_EXPORTS -I/home/labuser/Development/git/vpp/src -I. 
-Iinclude -I/home/labuser/Development/git/vpp/src/plugins -Iplugins 
-Wno-address-of-packed-member -g -fPIC -Werror -Wall -march=corei7 
-mtune=corei7-avx  -O2 -fstack-protector -DFORTIFY_SOURCE=2 -fno-common  -fPIC 
-MD -MT plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o 
-MF plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o.d 
-o plugins/wireguard/CMakeFiles/wireguard_plugin.dir/wireguard_handoff.c.o   -c 
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c: In 
function 'wg_handshake_handoff_fn':
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:112:12:
 error: 'peeri' may be used uninitialized in this function 
[-Werror=maybe-uninitialized]
  112 |t->peer = peeri;
  |^~~
/home/labuser/Development/git/vpp/src/plugins/wireguard/wireguard_handoff.c:82:15:
 note: 'peeri' was declared here
   82 |   index_t peeri;
  |   ^
cc1: all warnings being treated as errors
[12/18] Linking C shared library lib/libvnet.so.20.09
ninja: build stopped: subcommand failed.
make[1]: *** [Makefile:693: vpp-build] Error 1
make[1]: Leaving directory '/home/labuser/Development/git/vpp/build-root'
make: *** [Makefile:560: pkg-deb] Error 2

Anyone else see that?

Thanks,
Steve Heckman
Distinguished Software Engineer
Commscope, Inc.
Lowell, Ma




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17530): https://lists.fd.io/g/vpp-dev/message/17530
Mute This Topic: https://lists.fd.io/mt/77124338/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-committers] [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Edward Warnicke

+1

On Fri, Sep 25, 2020 at 2:44 PM Dave Wallace  wrote:

> +1
>
> On 9/25/20 3:13 PM, Dave Barach via lists.fd.io wrote:
>
> Folks,
>
>
>
> The self-nomination period closed yesterday. We had one self-nomination,
> from Damjan Marion. At this point, we can proceed with a vote.
>
>
>
> I’m sure that Damjan will do a great job, so let me start:
>
>
>
> Damjan Marion as VPP PTL: +1
>
>
>
> Please vote +1, 0, -1. For once, the “reply-all” button is everyone’s
> friend.
>
>
>
> Thanks... Dave
>
>
>
> -Original Message-
> From: d...@barachs.net  
> Sent: Thursday, September 17, 2020 10:32 AM
> To: 'vpp-dev@lists.fd.io'  ; '
> t...@lists.fd.io'  
> Subject: Happy Trails to Me...
>
>
>
> Folks,
>
>
>
> I’m departing the employment rolls towards the end of next month. Although
> I intend to remain active in the fd.io vpp community as a coder,
> committer, and resident greybeard, it’s time for the community to pick a
> new PTL.
>
>
>
> According to the project governance document,
> https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf:
>
>
>
>
> 3.2.3.1 Project Technical Leader Candidates Candidates for the project’s
> PTL will be derived from the Committers of the Project. Candidates must
> self-nominate.
>
>
>
> I'd like to invite any interested vpp project committer to self-nominate
> for the PTL role. Please email vpp-dev@lists.fd.io.
>
>
>
> Let's close the self-nomination period in one week: more specifically, by
> 5pm EDT on Thursday, September 24, 2020; committer vote to follow
> thereafter.
>
>
>
> I'll be glad to answer unicast questions about the PTL role from eligible
> committers.
>
>
>
> Thanks... Dave
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17529): https://lists.fd.io/g/vpp-dev/message/17529
Mute This Topic: https://lists.fd.io/mt/77124156/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Dave Wallace


+1

On 9/25/20 3:13 PM, Dave Barach via lists.fd.io wrote:


Folks,

The self-nomination period closed yesterday. We had one 
self-nomination, from Damjan Marion. At this point, we can proceed 
with a vote.


I’m sure that Damjan will do a great job, so let me start:

Damjan Marion as VPP PTL: +1

Please vote +1, 0, -1. For once, the “reply-all” button is everyone’s 
friend.


Thanks... Dave

-Original Message-
From: d...@barachs.net 
Sent: Thursday, September 17, 2020 10:32 AM
To: 'vpp-dev@lists.fd.io' ; 't...@lists.fd.io' 


Subject: Happy Trails to Me...

Folks,

I’m departing the employment rolls towards the end of next month. 
Although I intend to remain active in the fd.io vpp community as a 
coder, committer, and resident greybeard, it’s time for the community 
to pick a new PTL.


According to the project governance document, 
https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf:


3.2.3.1 Project Technical Leader Candidates Candidates for the 
project’s PTL will be derived from the Committers of the Project. 
Candidates must self-nominate.


I'd like to invite any interested vpp project committer to 
self-nominate for the PTL role. Please email vpp-dev@lists.fd.io 
.


Let's close the self-nomination period in one week: more specifically, 
by 5pm EDT on Thursday, September 24, 2020; committer vote to follow 
thereafter.


I'll be glad to answer unicast questions about the PTL role from 
eligible committers.


Thanks... Dave







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17528): https://lists.fd.io/g/vpp-dev/message/17528
Mute This Topic: https://lists.fd.io/mt/77123394/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Paul Vinciguerra

+1

On Fri, Sep 25, 2020 at 3:14 PM Dave Barach via lists.fd.io  wrote:

> Folks,
>
>
>
> The self-nomination period closed yesterday. We had one self-nomination,
> from Damjan Marion. At this point, we can proceed with a vote.
>
>
>
> I’m sure that Damjan will do a great job, so let me start:
>
>
>
> Damjan Marion as VPP PTL: +1
>
>
>
> Please vote +1, 0, -1. For once, the “reply-all” button is everyone’s
> friend.
>
>
>
> Thanks... Dave
>
>
>
> -Original Message-
> From: d...@barachs.net 
> Sent: Thursday, September 17, 2020 10:32 AM
> To: 'vpp-dev@lists.fd.io' ; 't...@lists.fd.io' <
> t...@lists.fd.io>
> Subject: Happy Trails to Me...
>
>
>
> Folks,
>
>
>
> I’m departing the employment rolls towards the end of next month. Although
> I intend to remain active in the fd.io vpp community as a coder,
> committer, and resident greybeard, it’s time for the community to pick a
> new PTL.
>
>
>
> According to the project governance document,
> https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf:
>
>
>
>
> 3.2.3.1 Project Technical Leader Candidates Candidates for the project’s
> PTL will be derived from the Committers of the Project. Candidates must
> self-nominate.
>
>
>
> I'd like to invite any interested vpp project committer to self-nominate
> for the PTL role. Please email vpp-dev@lists.fd.io.
>
>
>
> Let's close the self-nomination period in one week: more specifically, by
> 5pm EDT on Thursday, September 24, 2020; committer vote to follow
> thereafter.
>
>
>
> I'll be glad to answer unicast questions about the PTL role from eligible
> committers.
>
>
>
> Thanks... Dave
>
>
>
>
>
>
>
>
>
>
>
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17527): https://lists.fd.io/g/vpp-dev/message/17527
Mute This Topic: https://lists.fd.io/mt/77123394/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Florin Coras

+1

Florin

> On Sep 25, 2020, at 12:13 PM, Dave Barach via lists.fd.io 
>  wrote:
> 
> Folks,
>
> The self-nomination period closed yesterday. We had one self-nomination, from 
> Damjan Marion. At this point, we can proceed with a vote.
>
> I’m sure that Damjan will do a great job, so let me start:
>
> Damjan Marion as VPP PTL: +1
>
> Please vote +1, 0, -1. For once, the “reply-all” button is everyone’s friend.
>
> Thanks... Dave
>
> -Original Message-
> From: d...@barachs.net   > 
> Sent: Thursday, September 17, 2020 10:32 AM
> To: 'vpp-dev@lists.fd.io '  >; 't...@lists.fd.io ' 
> mailto:t...@lists.fd.io>>
> Subject: Happy Trails to Me...
>
> Folks,
>
> I’m departing the employment rolls towards the end of next month. Although I 
> intend to remain active in the fd.io  vpp community as a 
> coder, committer, and resident greybeard, it’s time for the community to pick 
> a new PTL.
>
> According to the project governance document, 
> https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf 
> : 
>
> 3.2.3.1 Project Technical Leader Candidates Candidates for the project’s PTL 
> will be derived from the Committers of the Project. Candidates must 
> self-nominate.
>
> I'd like to invite any interested vpp project committer to self-nominate for 
> the PTL role. Please email vpp-dev@lists.fd.io .
>
> Let's close the self-nomination period in one week: more specifically, by 5pm 
> EDT on Thursday, September 24, 2020; committer vote to follow thereafter.
>
> I'll be glad to answer unicast questions about the PTL role from eligible 
> committers.
>
> Thanks... Dave
>
>
>
>
>
>
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17526): https://lists.fd.io/g/vpp-dev/message/17526
Mute This Topic: https://lists.fd.io/mt/77123394/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Matthew Smith via lists.fd.io

+1


On Fri, Sep 25, 2020 at 2:14 PM Dave Barach via lists.fd.io  wrote:

> Folks,
>
>
>
> The self-nomination period closed yesterday. We had one self-nomination,
> from Damjan Marion. At this point, we can proceed with a vote.
>
>
>
> I’m sure that Damjan will do a great job, so let me start:
>
>
>
> Damjan Marion as VPP PTL: +1
>
>
>
> Please vote +1, 0, -1. For once, the “reply-all” button is everyone’s
> friend.
>
>
>
> Thanks... Dave
>
>
>
> -Original Message-
> From: d...@barachs.net 
> Sent: Thursday, September 17, 2020 10:32 AM
> To: 'vpp-dev@lists.fd.io' ; 't...@lists.fd.io' <
> t...@lists.fd.io>
> Subject: Happy Trails to Me...
>
>
>
> Folks,
>
>
>
> I’m departing the employment rolls towards the end of next month. Although
> I intend to remain active in the fd.io vpp community as a coder,
> committer, and resident greybeard, it’s time for the community to pick a
> new PTL.
>
>
>
> According to the project governance document,
> https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf:
>
>
>
>
> 3.2.3.1 Project Technical Leader Candidates Candidates for the project’s
> PTL will be derived from the Committers of the Project. Candidates must
> self-nominate.
>
>
>
> I'd like to invite any interested vpp project committer to self-nominate
> for the PTL role. Please email vpp-dev@lists.fd.io.
>
>
>
> Let's close the self-nomination period in one week: more specifically, by
> 5pm EDT on Thursday, September 24, 2020; committer vote to follow
> thereafter.
>
>
>
> I'll be glad to answer unicast questions about the PTL role from eligible
> committers.
>
>
>
> Thanks... Dave
>
>
>
>
>
>
>
>
>
>
>
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17525): https://lists.fd.io/g/vpp-dev/message/17525
Mute This Topic: https://lists.fd.io/mt/77123394/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Ole Troan

+1

Best regards,
Ole

> On 25 Sep 2020, at 21:14, Dave Barach via lists.fd.io 
>  wrote:
> 
> 
> Folks,
>
> The self-nomination period closed yesterday. We had one self-nomination, from 
> Damjan Marion. At this point, we can proceed with a vote.
>
> I’m sure that Damjan will do a great job, so let me start:
>
> Damjan Marion as VPP PTL: +1
>
> Please vote +1, 0, -1. For once, the “reply-all” button is everyone’s friend.
>
> Thanks... Dave
>
> -Original Message-
> From: d...@barachs.net  
> Sent: Thursday, September 17, 2020 10:32 AM
> To: 'vpp-dev@lists.fd.io' ; 't...@lists.fd.io' 
> 
> Subject: Happy Trails to Me...
>
> Folks,
>
> I’m departing the employment rolls towards the end of next month. Although I 
> intend to remain active in the fd.io vpp community as a coder, committer, and 
> resident greybeard, it’s time for the community to pick a new PTL.
>
> According to the project governance document, 
> https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf: 
>
> 3.2.3.1 Project Technical Leader Candidates Candidates for the project’s PTL 
> will be derived from the Committers of the Project. Candidates must 
> self-nominate.
>
> I'd like to invite any interested vpp project committer to self-nominate for 
> the PTL role. Please email vpp-dev@lists.fd.io.
>
> Let's close the self-nomination period in one week: more specifically, by 5pm 
> EDT on Thursday, September 24, 2020; committer vote to follow thereafter.
>
> I'll be glad to answer unicast questions about the PTL role from eligible 
> committers.
>
> Thanks... Dave
>
>
>
>
>
>
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17524): https://lists.fd.io/g/vpp-dev/message/17524
Mute This Topic: https://lists.fd.io/mt/77123394/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] [EXTERNAL] [vpp-committers] VPP committers: VPP PTL vote

2020-09-25 Thread Chris Luke

+1

From: vpp-committ...@lists.fd.io  On Behalf Of Dave 
Barach via lists.fd.io
Sent: Friday, September 25, 2020 15:14
To: vpp-committ...@lists.fd.io
Cc: vpp-dev@lists.fd.io
Subject: [EXTERNAL] [vpp-committers] VPP committers: VPP PTL vote

Folks,

The self-nomination period closed yesterday. We had one self-nomination, from 
Damjan Marion. At this point, we can proceed with a vote.

I'm sure that Damjan will do a great job, so let me start:

Damjan Marion as VPP PTL: +1

Please vote +1, 0, -1. For once, the "reply-all" button is everyone's friend.

Thanks... Dave

-Original Message-
From: d...@barachs.net 
mailto:d...@barachs.net>>
Sent: Thursday, September 17, 2020 10:32 AM
To: 'vpp-dev@lists.fd.io' mailto:vpp-dev@lists.fd.io>>; 
't...@lists.fd.io' mailto:t...@lists.fd.io>>
Subject: Happy Trails to Me...

Folks,

I'm departing the employment rolls towards the end of next month. Although I 
intend to remain active in the fd.io vpp community as a coder, committer, and 
resident greybeard, it's time for the community to pick a new PTL.

According to the project governance document, 
https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf:

3.2.3.1 Project Technical Leader Candidates Candidates for the project's PTL 
will be derived from the Committers of the Project. Candidates must 
self-nominate.

I'd like to invite any interested vpp project committer to self-nominate for 
the PTL role. Please email vpp-dev@lists.fd.io.

Let's close the self-nomination period in one week: more specifically, by 5pm 
EDT on Thursday, September 24, 2020; committer vote to follow thereafter.

I'll be glad to answer unicast questions about the PTL role from eligible 
committers.

Thanks... Dave

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17523): https://lists.fd.io/g/vpp-dev/message/17523
Mute This Topic: https://lists.fd.io/mt/77123583/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Andrew Yourtchenko

+1.

--a

> On 25 Sep 2020, at 21:14, Dave Barach via lists.fd.io 
>  wrote:
> 
> 
> Folks,
>
> The self-nomination period closed yesterday. We had one self-nomination, from 
> Damjan Marion. At this point, we can proceed with a vote.
>
> I’m sure that Damjan will do a great job, so let me start:
>
> Damjan Marion as VPP PTL: +1
>
> Please vote +1, 0, -1. For once, the “reply-all” button is everyone’s friend.
>
> Thanks... Dave
>
> -Original Message-
> From: d...@barachs.net 
> Sent: Thursday, September 17, 2020 10:32 AM
> To: 'vpp-dev@lists.fd.io' ; 't...@lists.fd.io' 
> 
> Subject: Happy Trails to Me...
>
> Folks,
>
> I’m departing the employment rolls towards the end of next month. Although I 
> intend to remain active in the fd.io vpp community as a coder, committer, and 
> resident greybeard, it’s time for the community to pick a new PTL.
>
> According to the project governance document, 
> https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf: 
>
> 3.2.3.1 Project Technical Leader Candidates Candidates for the project’s PTL 
> will be derived from the Committers of the Project. Candidates must 
> self-nominate.
>
> I'd like to invite any interested vpp project committer to self-nominate for 
> the PTL role. Please email vpp-dev@lists.fd.io.
>
> Let's close the self-nomination period in one week: more specifically, by 5pm 
> EDT on Thursday, September 24, 2020; committer vote to follow thereafter.
>
> I'll be glad to answer unicast questions about the PTL role from eligible 
> committers.
>
> Thanks... Dave
>
>
>
>
>
>
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17522): https://lists.fd.io/g/vpp-dev/message/17522
Mute This Topic: https://lists.fd.io/mt/77123394/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] VPP committers: VPP PTL vote

2020-09-25 Thread Dave Barach via lists.fd.io

Folks,

The self-nomination period closed yesterday. We had one self-nomination, from 
Damjan Marion. At this point, we can proceed with a vote.

I'm sure that Damjan will do a great job, so let me start:

Damjan Marion as VPP PTL: +1

Please vote +1, 0, -1. For once, the "reply-all" button is everyone's friend.

Thanks... Dave



-Original Message-
From: d...@barachs.net 
Sent: Thursday, September 17, 2020 10:32 AM
To: 'vpp-dev@lists.fd.io' ; 't...@lists.fd.io' 

Subject: Happy Trails to Me...



Folks,



I'm departing the employment rolls towards the end of next month. Although I 
intend to remain active in the fd.io vpp community as a coder, committer, and 
resident greybeard, it's time for the community to pick a new PTL.



According to the project governance document, 
https://fd.io/docs/tsc/FD.IO-Technical-Community-Document-12-12-2017.pdf:



3.2.3.1 Project Technical Leader Candidates Candidates for the project's PTL 
will be derived from the Committers of the Project. Candidates must 
self-nominate.



I'd like to invite any interested vpp project committer to self-nominate for 
the PTL role. Please email vpp-dev@lists.fd.io.



Let's close the self-nomination period in one week: more specifically, by 5pm 
EDT on Thursday, September 24, 2020; committer vote to follow thereafter.



I'll be glad to answer unicast questions about the PTL role from eligible 
committers.



Thanks... Dave












-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17521): https://lists.fd.io/g/vpp-dev/message/17521
Mute This Topic: https://lists.fd.io/mt/77123394/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

2020-09-25 Thread RaviKiran Veldanda

Thanks Florin, I am seeing maximum 12G with 1.5kB Datagrams. Not able to 
achieve 20Gbps.
I will explore the option you provided.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17520): https://lists.fd.io/g/vpp-dev/message/17520
Mute This Topic: https://lists.fd.io/mt/77078709/21656
Mute #vnet:https://lists.fd.io/g/vpp-dev/mutehashtag/vnet
Mute #vppcom:https://lists.fd.io/g/vpp-dev/mutehashtag/vppcom
Mute #txbuff:https://lists.fd.io/g/vpp-dev/mutehashtag/txbuff
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

2020-09-25 Thread Florin Coras

Hi Ravi, 

At this time, there’s no option to pin connected udp sessions to workers, 
instead we default to worker 1. You could try changing the logic here [1] to 
select a random thread for each connection. We’re not doing that because 
whenever we receive return traffic we pin the session to the worker selected by 
rss to be sure the same worker is used for rx and tx. 

I was asking about the max throughput you want to achieve because one udp 
session with 1.5kB datagrams should be able to go above 20Gbps. At least that’s 
what I’m seeing in my testbed with ldp + iperf3 -l 1460 -b 40g.

Regards,
Florin

[1] https://git.fd.io/vpp/tree/src/vnet/udp/udp.c#n377

> On Sep 25, 2020, at 9:46 AM, RaviKiran Veldanda  wrote:
> 
> Thanks Florin for your response
> Please find my answers below
> 1> I opened the UDP sessions with vppcom_session_connect and these are always 
> for TX and it will not receive any data. 
> 2> No there is no sent traffic on these. I can try this part.
> 3> Actually the throughput as you know depends on different factors like 
> cores and etc, we have 100G card but we have our own application has limit. 
> So i cannot answer what maximum we can push. 
> 4> Coming to the dropped the Input Queues are getting filled with traffic.
> Connection State Rx-f Tx-f [1:0][U] 
> 2001:5b0::1150:b883:31f:178:98f8:2035OPENED 0 7999863 [1:1][U] 
> 2001:5b0::1150:b883:31f:178:98f8:5100OPENED 0 7999863 [1:2][U] 
> 2001:5b0::1150:b883:31f:178:98f8:1160OPENED 0 7999863 [1:3][U] 
> 2001:5b0::1150:b883:31f:178:98f8:3442OPENED 0 7999863 [1:4][U] 
> 2001:5b0::1150:b883:31f:178:98f8:1220OPENED 0 7999863 [1:5][U] 
> 2001:5b0::1150:b883:31f:178:98f8:3303OPENED 0 7999863 [1:6][U] 
> 2001:5b0::1150:b883:31f:178:98f8:5397OPENED 0 0 [1:7][U] 
> 2001:5b0::1150:b883:31f:178:98f8:2545OPENED 0 0 [1:8][U] 
> 2001:5b0::1150:b883:31f:178:98f8:4097OPENED 0 0 [1:9][U] 
> 2001:5b0::1150:b883:31f:178:98f8:3618OPENED 0 0 [1:10][U] 
> 2001:5b0::1150:b883:31f:178:98f8:141OPENED 0 0 [1:11][U] 
> 2001:5b0::1150:b883:31f:178:98f8:465OPENED 0 0 Thread 1: active sessions 
> 12 
> 
> The Interface Counters doesn't have drops, RX FIFO and TX-FIFO
> rx-fifo-size 800 tx-fifo-size 800
> 
> Please let me know is there any other method to distribute these TX Flows or 
> increase the throughput.
> //Ravi 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17519): https://lists.fd.io/g/vpp-dev/message/17519
Mute This Topic: https://lists.fd.io/mt/77078709/21656
Mute #vnet:https://lists.fd.io/g/vpp-dev/mutehashtag/vnet
Mute #vppcom:https://lists.fd.io/g/vpp-dev/mutehashtag/vppcom
Mute #txbuff:https://lists.fd.io/g/vpp-dev/mutehashtag/txbuff
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

2020-09-25 Thread RaviKiran Veldanda

Thanks Florin for your response
Please find my answers below
1> I opened the UDP sessions with vppcom_session_connect and these are always 
for TX and it will not receive any data.
2> No there is no sent traffic on these. I can try this part.
3> Actually the throughput as you know depends on different factors like cores 
and etc, we have 100G card but we have our own application has limit. So i 
cannot answer what maximum we can push.
4> Coming to the dropped the Input Queues are getting filled with traffic.
*Connection State Rx-f Tx-f [1:0][U] 
2001:5b0::1150:b883:31f:178:98f8:2035OPENED 0 7999863 [1:1][U] 
2001:5b0::1150:b883:31f:178:98f8:5100OPENED 0 7999863 [1:2][U] 
2001:5b0::1150:b883:31f:178:98f8:1160OPENED 0 7999863 [1:3][U] 
2001:5b0::1150:b883:31f:178:98f8:3442OPENED 0 7999863 [1:4][U] 
2001:5b0::1150:b883:31f:178:98f8:1220OPENED 0 7999863 [1:5][U] 
2001:5b0::1150:b883:31f:178:98f8:3303OPENED 0 7999863 [1:6][U] 
2001:5b0::1150:b883:31f:178:98f8:5397OPENED 0 0 [1:7][U] 
2001:5b0::1150:b883:31f:178:98f8:2545OPENED 0 0 [1:8][U] 
2001:5b0::1150:b883:31f:178:98f8:4097OPENED 0 0 [1:9][U] 
2001:5b0::1150:b883:31f:178:98f8:3618OPENED 0 0 [1:10][U] 
2001:5b0::1150:b883:31f:178:98f8:141OPENED 0 0 [1:11][U] 
2001:5b0::1150:b883:31f:178:98f8:465OPENED 0 0 Thread 1: active sessions 12*

The Interface Counters doesn't have drops, RX FIFO and TX-FIFO
rx-fifo-size 800 tx-fifo-size 800

Please let me know is there any other method to distribute these TX Flows or 
increase the throughput.
//Ravi

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17518): https://lists.fd.io/g/vpp-dev/message/17518
Mute This Topic: https://lists.fd.io/mt/77078709/21656
Mute #vnet:https://lists.fd.io/g/vpp-dev/mutehashtag/vnet
Mute #vppcom:https://lists.fd.io/g/vpp-dev/mutehashtag/vppcom
Mute #txbuff:https://lists.fd.io/g/vpp-dev/mutehashtag/txbuff
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Possible missing build dependency on debian testing distributions?

2020-09-25 Thread Andrew Yourtchenko

Hi Chuan,

https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pushing

Feel free to push a patch contributing a fix. :-)

--a

> On 25 Sep 2020, at 17:46, Chuan Han via lists.fd.io 
>  wrote:
> 
> 
> Hi, vpp experts, 
> 
> I was building the latest vpp code on a debian testing based system. I hit 
> the following errors when running: make install-ext-deps
> 
> Package libelf was not found in the pkg-config search path.   
>   
>   
> Perhaps you should add the directory containing `libelf.pc'   
>   
>   
> to the PKG_CONFIG_PATH environment variable   
>   
>No 
> package 'libelf' found
>   
>  
> btf.c:17:10: fatal error: gelf.h: No such file or directory   
>   
>   
>17 | #include  
>   
>   
>   |  ^~~~ 
>   
>   
> compilation terminated.   
> 
> I have to install a missing package before I can build successfully.
> 
> sudo apt-get install libelf-dev
> 
> Does this mean vpp makefile shall be updated so that libelf-dev is installed 
> by default for all debian distributions?
> 
> https://github.com/FDio/vpp/blob/master/Makefile#L98
> 
> If so, can someone update the makefile? 
> 
> Thanks.
> Chuan
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17517): https://lists.fd.io/g/vpp-dev/message/17517
Mute This Topic: https://lists.fd.io/mt/77082190/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Possible missing build dependency on debian testing distributions?

2020-09-25 Thread Chuan Han via lists.fd.io

Hi, vpp experts,

I was building the latest vpp code on a debian testing based system. I hit
the following errors when running: make install-ext-deps

Package libelf was not found in the pkg-config search path.



Perhaps you should add the directory containing `libelf.pc'



to the PKG_CONFIG_PATH environment variable


   No package 'libelf' found



btf.c:17:10: fatal error: gelf.h: No such file or directory



   17 | #include 



  |  ^~~~



compilation terminated.

I have to install a missing package before I can build successfully.

sudo apt-get install libelf-dev

Does this mean vpp makefile shall be updated so that libelf-dev is
installed by default for all debian distributions?

https://github.com/FDio/vpp/blob/master/Makefile#L98

If so, can someone update the makefile?

Thanks.
Chuan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17516): https://lists.fd.io/g/vpp-dev/message/17516
Mute This Topic: https://lists.fd.io/mt/77082190/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

2020-09-25 Thread Florin Coras

Hi Ravi, 

I assume you’re using vppcom_session_connect to open those udp sessions? If the 
listeners receive incoming data, make sure you also set the 
VPPCOM_ATTR_SET_CONNECTED on the listener with vppcom_session_attr() before 
calling listen.

By default udp sessions are opened on thread 1 and stay there until they 
receive return traffic. Hence the sessions you have on thread 1, which I assume 
never received returned traffic. If some was sent, probably it was dropped 
somewhere in the network or on rx and since udp is unreliable the sessions are 
stuck there. So, if possible, make sure you sessions exchange some data before 
you saturate the links. 

Finally, the output lower doesn’t show any congestion. What sort of throughput 
are you trying to push through the sessions and how do the interface counters 
look like? Is lots of data dropped on tx? What’s the size of the fifos?

Regards,
Florin

> On Sep 25, 2020, at 5:57 AM, RaviKiran Veldanda  wrote:
> 
> Hi Team,
> We are planning to use VPP for throughput enhancement with our Applications. 
> However I found a bottleneck in TX side.
> So our application is placed like this
> VPP RX Interface--> VPP Memif --> Our Application --> VPPCOM UDP session --> 
> VPP TX Interface.
> The RX part we are not seeing issue and we could able to reach expected 
> throughput. However with TX we are suffering to push same amount of traffic 
> out.
> After further investigation I found, the TX sessions are only on Worker 1, 
> These are not getting distributed among other threads,
> vpp# show sess verbose
> ConnectionState  Rx-f  
> Tx-f
> [0:0][U] 2001:5b0::1150:b883:31f:178:98f8:7428LISTEN 0 0
> [0:1][U] 2001:5b0::1150:b883:31f:678:98f8:7428LISTEN 0 0
> [0:2][U] 2001:5b0::1150:b883:31f:378:98f8:7428LISTEN 0 0
> [0:3][U] 2001:5b0::1150:b883:31f:278:98f8:7428LISTEN 0 0
> [0:4][U] 2001:5b0::1150:b883:31f:578:98f8:7428LISTEN 0 0
> [0:5][U] 2001:5b0::1150:b883:31f:478:98f8:7428LISTEN 0 0
> Thread 0: active sessions 6
>
> ConnectionState  Rx-f  
> Tx-f
> [1:0][U] 2001:5b0::1150:b883:31f:178:98f8:2194OPENED 0 0
> [1:1][U] 2001:5b0::1150:b883:31f:178:98f8:2753OPENED 0 0
> [1:2][U] 2001:5b0::1150:b883:31f:178:98f8:5163OPENED 0 0
> [1:3][U] 2001:5b0::1150:b883:31f:178:98f8:6022OPENED 0 0
> [1:4][U] 2001:5b0::1150:b883:31f:178:98f8:1272OPENED 0 0
> [1:5][U] 2001:5b0::1150:b883:31f:178:98f8:1222OPENED 0 0
> [1:6][U] 2001:5b0::1150:b883:31f:178:98f8:3080OPENED 0 0
> [1:7][U] 2001:5b0::1150:b883:31f:178:98f8:8598OPENED 0 0
> [1:8][U] 2001:5b0::1150:b883:31f:178:98f8:2764OPENED 0 0
> [1:9][U] 2001:5b0::1150:b883:31f:178:98f8:1567OPENED 0 0
> [1:10][U] 2001:5b0::1150:b883:31f:178:98f8:243OPENED 0 0
> [1:11][U] 2001:5b0::1150:b883:31f:178:98f8:458OPENED 0 0
> Thread 1: active sessions 12
> Thread 2: no sessions
>
> ConnectionState  Rx-f  
> Tx-f
> [3:0][U] 2001:5b0::1150:b883:31f:178:98f8:7428OPENED 0 0
> [3:1][U] 2001:5b0::1150:b883:31f:678:98f8:7428OPENED 0 0
> Thread 3: active sessions 2
>
> ConnectionState  Rx-f  
> Tx-f
> [4:0][U] 2001:5b0::1150:b883:31f:278:98f8:7428OPENED 0 0
> [4:1][U] 2001:5b0::1150:b883:31f:578:98f8:7428OPENED 0 0
> Thread 4: active sessions 2
> Thread 5: no sessions
>
> ConnectionState  Rx-f  
> Tx-f
> [6:0][U] 2001:5b0::1150:b883:31f:378:98f8:7428OPENED 0 0
> [6:1][U] 2001:5b0::1150:b883:31f:478:98f8:7428OPENED 0 0
> Thread 6: active sessions 2
> 
> That is creating Bottleneck, Please find our RX placement,
>
> vpp# show interface rx-placement
> Thread 1 (vpp_wk_0):
>   node memif-input:
> memif15/0 queue 0 (polling)
> memif16/0 queue 0 (polling)
> Thread 2 (vpp_wk_1):
>   node memif-input:
> memif2/0 queue 0 (polling)
> memif4/0 queue 0 (polling)
> Thread 3 (vpp_wk_2):
>   node memif-input:
> memif3/0 queue 0 (polling)
> memif14/0 queue 0 (polling)
>   node dpdk-input:
> HundredGigabitEthernet12/0/0 queue 2 (polling)
> Thread 4 (vpp_wk_3):
>   node memif-input:
> memif1/0 queue 0 (polling)
> memif12/0 queue 0 (polling)
>   node dpdk-input:
> HundredGigabitEthernet12/0/0 queue 3 (polling)
> Thread 5 (vpp_wk_4):
>   node memif-input:
> memif11/0 queue 0 (polling)
> memif13/0 queue 0 (polling)
>   node dpdk-input:
> HundredGigabitEthernet12/0/0 queue 0 (polling)
> Thread 6

Re: [vpp-dev] The gratuitous ARP issue

2020-09-25 Thread Jinlei Li

Hi neale,


I just verified and I think it is fixed, thanks alot!


Regards
Jinlei







At 2020-09-24 23:01:14, "Neale Ranns via lists.fd.io" 
 wrote:

 

Hi Jinlei,

 

Thank you for the info. I have updated the UT to reflect this and the problem 
was seen. I have fixed the issue and updated the patch.

 

/neale

 

From: Jerry Li 
Date: Wednesday 23 September 2020 at 17:42
To: "Neale Ranns (nranns)" 
Cc: "vpp-dev@lists.fd.io" 
Subject: Re:Re: [vpp-dev] The gratuitous ARP issue

 

 

Hi neale,

 

I think you should first add the ip neigbor entry to pg2 first, and then send 
garp to pg1 with mac of pg2 remote host. 

Otherwise I think the enty will not be generated by garp it self.

 

Regards

Jinlei

 

At 2020-09-23 19:28:36, "Neale Ranns via lists.fd.io" 
 wrote:

 

Hi Jinlei,

 

I created this UT case:

  https://gerrit.fd.io/r/c/vpp/+/29035

 

which IIUC re-creates your setup. But, as I would expect, the GARPs are dropped 
because the IP subnet is not on link. Please verify if it matches your setup.

 

/neale

 

From: Jerry Li 
Date: Tuesday 22 September 2020 at 04:02
To: "Neale Ranns (nranns)" 
Cc: "vpp-dev@lists.fd.io" 
Subject: Re:Re: [vpp-dev] The gratuitous ARP issue

 

Hi neale,

 

Thanks for your reply.

 

Attached the pcaps file for my test.

I tried to set the Opcode of arp packet as request(1) or reply(2), both the 
same occurs on vpp.

 

Regards

Jinlei.

At 2020-09-21 22:39:46, "Neale Ranns via lists.fd.io" 
 wrote:

Hi Jinlei,

 

Could you please send me a pcap capture of the grat-arp that VPP receives. Then 
I can duplicate the case in the UT.

 

Thanks,

neale

 

From:  on behalf of Jinlei Li 
Date: Saturday 19 September 2020 at 11:56
To: "vpp-dev@lists.fd.io" 
Subject: [vpp-dev] The gratuitous ARP issue

 

Hi guys,

During my test environment, I have two physical interfaces in the same 
broadcast domain, and they are configured with IPs of different subnet.

I tried to ping 10.161.26.23 first, and I can see its’s mac address by “show ip 
neighbor”

 

But if 10.161.26.23 send a gratuitous ARP broadcast, the other interface can 
also see this item(like the following picture). 

I think this is not expected, and I tried same scenario on linux, this arp item 
will not be seen on another interface.

I find This problem occurs on both v20.01 and v20.05. Can any one help to check 
this issue?

Regards

Jinlei








 







 






 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17513): https://lists.fd.io/g/vpp-dev/message/17513
Mute This Topic: https://lists.fd.io/mt/76951004/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Reminder: VPP 20.09 Release date is 30 september 2020

2020-09-25 Thread Andrew Yourtchenko

Hello all,

Just a small reminder that upcoming Wednesday 30 September 2020 is the
day of the 20.09 VPP release, as per our release plan [0], and it is
fast approaching.

If you have any unfinished business on stable/2009 (tests,
troubleshooting, fixes etc), please let me know today or on Monday so
we can coordinate.

Same goes about the draft Release Notes in [1] - I would like to
finish the review for them on Monday.

Thanks for all the preparations, everyone!

--a /* your friendly 20.09 release manager */

[0] https://wiki.fd.io/view/Projects/vpp/Release_Plans/Release_Plan_20.09
[1] https://gerrit.fd.io/r/c/vpp/+/28794

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17512): https://lists.fd.io/g/vpp-dev/message/17512
Mute This Topic: https://lists.fd.io/mt/77080256/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] ACL- IN and OUT interface

2020-09-25 Thread sachinpp777

[Edited Message Follows]

Hello Team,

Is there option to specify IN and OUT interface(sw_index) in ACL along with ACE?

pseudo rule - drop src x.x.x.x dst y.y.y.y when in-interface is x1 and out 
interface is x2 -> like iptables

Regards,
Sachin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17511): https://lists.fd.io/g/vpp-dev/message/17511
Mute This Topic: https://lists.fd.io/mt/77080154/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] ACL- IN and OUT interface

2020-09-25 Thread sachinpp777

Hello Team,

Is there option to specify IN and OUT interface(sw_index) in ACL along with ACE?

pseudo rule - drop src x.x.x.x dst y.y.y.y when in-interface is x1 and out 
interface is x2

Regards,
Sachin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17511): https://lists.fd.io/g/vpp-dev/message/17511
Mute This Topic: https://lists.fd.io/mt/77080154/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] range match

2020-09-25 Thread hemant via lists.fd.io

I am porting a P4 table key of match type as range to VPP.  I found the VPP
API here:

 

https://github.com/FDio/vpp/blob/5b755e2f9fce239b5280ac1e5e21f835464fa017/sr
c/vnet/ip/ip_source_and_port_range_check.h#L128

 

Incidentally, a range can be converted into tcam (value, mask) pair.  If VPP
is ever interested in simulating a tcam or converting range to tcam pair, my
company has C source code below.  This code was contributed to the p4
compiler repo to convert P4 Ranges used in P4 Parser to tcam entries.

 

https://github.com/hesingh/range-to-tcam-val-mask/blob/master/range-to-tcam.
cpp

 

Hemant

 



smime.p7s
Description: S/MIME cryptographic signature

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17510): https://lists.fd.io/g/vpp-dev/message/17510
Mute This Topic: https://lists.fd.io/mt/77080104/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] pkt validation

2020-09-25 Thread hemant via lists.fd.io

Dave,

 

Yes, that helps totally.

 

Thanks!

 

Hemant

 

From: Dave Barach (dbarach)  
Sent: Friday, September 25, 2020 6:36 AM
To: hem...@mnkcg.com; vpp-dev@lists.fd.io
Subject: RE: [vpp-dev] pkt validation

 

Here's a strategy: Use "show run" to identify graph nodes which are active
when passing traffic. Nodes of interest will have names like
"ethernet-input," "ip4-input", etc.

 

Obviously, the string "ethernet-input" string comes from "somewhere". In
particular:

 

/* *INDENT-OFF* */

VLIB_REGISTER_NODE (ethernet_input_node) = {

  .name = "ethernet-input",

  /* Takes a vector of packets. */



};

 

You'll find a companion function declaration:

 

VLIB_NODE_FN (ethernet_input_node) (vlib_main_t * vm,

  vlib_node_runtime_t * node,

  vlib_frame_t * frame)

{

  vnet_main_t *vnm = vnet_get_main ();

  u32 *from = vlib_frame_vector_args (frame);

  u32 n_packets = frame->n_vectors;

 

  ethernet_input_trace (vm, node, frame);

 

  if (frame->flags & ETH_INPUT_FRAME_F_SINGLE_SW_IF_IDX)

{

  ethernet_input_frame_t *ef = vlib_frame_scalar_args (frame);

  int ip4_cksum_ok = (frame->flags & ETH_INPUT_FRAME_F_IP4_CKSUM_OK) !=
0;

  vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm,
ef->hw_if_index);

  eth_input_single_int (vm, node, hi, from, n_packets, ip4_cksum_ok);

}

  else

ethernet_input_inline (vm, node, from, n_packets,

ETHERNET_INPUT_VARIANT_ETHERNET);

  return n_packets;

}

 

That's the actual graph node dispatch function. At that point, it's a matter
of "using the Force and reading the Source..."

 

HTH... Dave 

 

 

From: vpp-dev@lists.fd.io   mailto:vpp-dev@lists.fd.io> > On Behalf Of hemant via lists.fd.io
Sent: Thursday, September 24, 2020 8:06 PM
To: vpp-dev@lists.fd.io  
Subject: [vpp-dev] pkt validation

 

Does VPP, in its ethernet, IP, and IPv6 input, include stock code to check
for malformed packet? Any pointer to such code would help so that I can look
at other code as well.

 

Thanks,

 

Hemant



smime.p7s
Description: S/MIME cryptographic signature

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17509): https://lists.fd.io/g/vpp-dev/message/17509
Mute This Topic: https://lists.fd.io/mt/77070037/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

2020-09-25 Thread RaviKiran Veldanda

Hi Team,
We are planning to use VPP for throughput enhancement with our Applications. 
However I found a bottleneck in TX side.
So our application is placed like this
VPP RX Interface--> VPP Memif --> Our Application --> VPPCOM UDP session --> 
VPP TX Interface.
The RX part we are not seeing issue and we could able to reach expected 
throughput. However with TX we are suffering to push same amount of traffic out.
After further investigation I found, the TX sessions are only on Worker 1, 
These are not getting distributed among other threads,
vpp# show sess verbose
Connection                                        State          Rx-f      Tx-f
[0:0][U] 2001:5b0::1150:b883:31f:178:98f8:7428LISTEN         0         0
[0:1][U] 2001:5b0::1150:b883:31f:678:98f8:7428LISTEN         0         0
[0:2][U] 2001:5b0::1150:b883:31f:378:98f8:7428LISTEN         0         0
[0:3][U] 2001:5b0::1150:b883:31f:278:98f8:7428LISTEN         0         0
[0:4][U] 2001:5b0::1150:b883:31f:578:98f8:7428LISTEN         0         0
[0:5][U] 2001:5b0::1150:b883:31f:478:98f8:7428LISTEN         0         0
Thread 0: active sessions 6

Connection                                        State          Rx-f      Tx-f
*[1:0][U] 2001:5b0::1150:b883:31f:178:98f8:2194OPENED         0         0*
*[1:1][U] 2001:5b0::1150:b883:31f:178:98f8:2753OPENED         0         0*
*[1:2][U] 2001:5b0::1150:b883:31f:178:98f8:5163OPENED         0         0*
*[1:3][U] 2001:5b0::1150:b883:31f:178:98f8:6022OPENED         0         0*
*[1:4][U] 2001:5b0::1150:b883:31f:178:98f8:1272OPENED         0         0*
*[1:5][U] 2001:5b0::1150:b883:31f:178:98f8:1222OPENED         0         0*
*[1:6][U] 2001:5b0::1150:b883:31f:178:98f8:3080OPENED         0         0*
*[1:7][U] 2001:5b0::1150:b883:31f:178:98f8:8598OPENED         0         0*
*[1:8][U] 2001:5b0::1150:b883:31f:178:98f8:2764OPENED         0         0*
*[1:9][U] 2001:5b0::1150:b883:31f:178:98f8:1567OPENED         0         0*
*[1:10][U] 2001:5b0::1150:b883:31f:178:98f8:243OPENED         0         0*
*[1:11][U] 2001:5b0::1150:b883:31f:178:98f8:458OPENED         0         0*
Thread 1: active sessions 12
Thread 2: no sessions

Connection                                        State          Rx-f      Tx-f
[3:0][U] 2001:5b0::1150:b883:31f:178:98f8:7428OPENED         0         0
[3:1][U] 2001:5b0::1150:b883:31f:678:98f8:7428OPENED         0         0
Thread 3: active sessions 2

Connection                                        State          Rx-f      Tx-f
[4:0][U] 2001:5b0::1150:b883:31f:278:98f8:7428OPENED         0         0
[4:1][U] 2001:5b0::1150:b883:31f:578:98f8:7428OPENED         0         0
Thread 4: active sessions 2
Thread 5: no sessions

Connection                                        State          Rx-f      Tx-f
[6:0][U] 2001:5b0::1150:b883:31f:378:98f8:7428OPENED         0         0
[6:1][U] 2001:5b0::1150:b883:31f:478:98f8:7428OPENED         0         0
Thread 6: active sessions 2

That is creating Bottleneck, Please find our RX placement,

vpp# show interface rx-placement
Thread 1 (vpp_wk_0):
node memif-input:
memif15/0 queue 0 (polling)
memif16/0 queue 0 (polling)
Thread 2 (vpp_wk_1):
node memif-input:
memif2/0 queue 0 (polling)
memif4/0 queue 0 (polling)
Thread 3 (vpp_wk_2):
node memif-input:
memif3/0 queue 0 (polling)
memif14/0 queue 0 (polling)
node dpdk-input:
HundredGigabitEthernet12/0/0 queue 2 (polling)
Thread 4 (vpp_wk_3):
node memif-input:
memif1/0 queue 0 (polling)
memif12/0 queue 0 (polling)
node dpdk-input:
HundredGigabitEthernet12/0/0 queue 3 (polling)
Thread 5 (vpp_wk_4):
node memif-input:
memif11/0 queue 0 (polling)
memif13/0 queue 0 (polling)
node dpdk-input:
HundredGigabitEthernet12/0/0 queue 0 (polling)
Thread 6 (vpp_wk_5):
node memif-input:
memif5/0 queue 0 (polling)
memif6/0 queue 0 (polling)
node dpdk-input:
HundredGigabitEthernet12/0/0 queue 1 (polling)
vpp#

We made sure the RX queues are on not on worker 1 and 0, there is slight 
improvement but not upto the mark,
So our question is,
1> How can we distribute these TX sessions among different workers?
2> Or How can we attain maximum with one thread?
Thanks in advance for reading and answering

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17508): https://lists.fd.io/g/vpp-dev/message/17508
Mute This Topic: https://lists.fd.io/mt/77078709/21656
Mute #vnet:https://lists.fd.io/g/vpp-dev/mutehashtag/vnet
Mute #vppcom:https://lists.fd.io/g/vpp-dev/mutehashtag/vppcom
Mute #txbuff:https://lists.fd.io/g/vpp-dev/mutehashtag/txbuff
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] pkt validation

2020-09-25 Thread Dave Barach via lists.fd.io

Here's a strategy: Use "show run" to identify graph nodes which are active when 
passing traffic. Nodes of interest will have names like "ethernet-input," 
"ip4-input", etc.

Obviously, the string "ethernet-input" string comes from "somewhere". In 
particular:

/* *INDENT-OFF* */
VLIB_REGISTER_NODE (ethernet_input_node) = {
  .name = "ethernet-input",
  /* Takes a vector of packets. */

};

You'll find a companion function declaration:

VLIB_NODE_FN (ethernet_input_node) (vlib_main_t * vm,
  vlib_node_runtime_t * node,
  vlib_frame_t * frame)
{
  vnet_main_t *vnm = vnet_get_main ();
  u32 *from = vlib_frame_vector_args (frame);
  u32 n_packets = frame->n_vectors;

  ethernet_input_trace (vm, node, frame);

  if (frame->flags & ETH_INPUT_FRAME_F_SINGLE_SW_IF_IDX)
{
  ethernet_input_frame_t *ef = vlib_frame_scalar_args (frame);
  int ip4_cksum_ok = (frame->flags & ETH_INPUT_FRAME_F_IP4_CKSUM_OK) != 0;
  vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm, ef->hw_if_index);
  eth_input_single_int (vm, node, hi, from, n_packets, ip4_cksum_ok);
}
  else
ethernet_input_inline (vm, node, from, n_packets,
ETHERNET_INPUT_VARIANT_ETHERNET);
  return n_packets;
}

That's the actual graph node dispatch function. At that point, it's a matter of 
"using the Force and reading the Source..."

HTH... Dave


From: vpp-dev@lists.fd.io  On Behalf Of hemant via 
lists.fd.io
Sent: Thursday, September 24, 2020 8:06 PM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] pkt validation

Does VPP, in its ethernet, IP, and IPv6 input, include stock code to check for 
malformed packet? Any pointer to such code would help so that I can look at 
other code as well.

Thanks,

Hemant

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17507): https://lists.fd.io/g/vpp-dev/message/17507
Mute This Topic: https://lists.fd.io/mt/77070037/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] a minor error in function nat44_ed_get_worker_out2in_cb of vpp 20.09

2020-09-25 Thread Dengfeng Liu

Hi folks,
I found a minor error in function nat44_ed_get_worker_out2in_cb of vpp 20.09

diff --git a/src/plugins/nat/nat.c b/src/plugins/nat/nat.c
index f4147f2..e3e1068 100644
--- a/src/plugins/nat/nat.c
+++ b/src/plugins/nat/nat.c
@@ -3598,7 +3598,7 @@ nat44_ed_get_worker_out2in_cb (vlib_buffer_t * b, 
ip4_header_t * ip,
/* try static mappings with port */
if (PREDICT_FALSE (pool_elts (sm->static_mappings)))
{
-      init_nat_k (, ip->dst_address, proto, 0, port);
+      init_nat_k (, ip->dst_address, port, 0, proto);
if (!clib_bihash_search_8_8
(>static_mapping_by_external, , ))
{

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17506): https://lists.fd.io/g/vpp-dev/message/17506
Mute This Topic: https://lists.fd.io/mt/77075963/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized

[vpp-dev] vnet_classify_add_del_table API?

Re: [vpp-dev] [vpp-committers] VPP committers: VPP PTL vote

[vpp-dev] Silly programmer trick #47...

Re: [vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized

[vpp-dev] wireguard_handoff.c:112:12: error: 'peeri' may be used uninitialized

Re: [vpp-committers] [vpp-dev] VPP committers: VPP PTL vote

Re: [vpp-dev] VPP committers: VPP PTL vote

Re: [vpp-dev] VPP committers: VPP PTL vote

Re: [vpp-dev] VPP committers: VPP PTL vote

Re: [vpp-dev] VPP committers: VPP PTL vote

Re: [vpp-dev] VPP committers: VPP PTL vote

Re: [vpp-dev] [EXTERNAL] [vpp-committers] VPP committers: VPP PTL vote

Re: [vpp-dev] VPP committers: VPP PTL vote

[vpp-dev] VPP committers: VPP PTL vote

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

Re: [vpp-dev] Possible missing build dependency on debian testing distributions?

[vpp-dev] Possible missing build dependency on debian testing distributions?

Re: [vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

Re: [vpp-dev] The gratuitous ARP issue

[vpp-dev] Reminder: VPP 20.09 Release date is 30 september 2020

[vpp-dev] ACL- IN and OUT interface

[vpp-dev] ACL- IN and OUT interface

[vpp-dev] range match

Re: [vpp-dev] pkt validation

[vpp-dev] Distributing VPPCOM TX sessions to different worker thread #vnet #vppcom #TxBuff

Re: [vpp-dev] pkt validation

[vpp-dev] a minor error in function nat44_ed_get_worker_out2in_cb of vpp 20.09

30 matches

Site Navigation

Mail list logo

Footer information