[vpp-dev] ping failed with p2p type interface due to fib_sas4_get not dealing with p2p interface case #vpp

2020-12-13 Thread jiangxiaoming
Hi guys: I create two vpp instance and create two ipsec tunnel, when ping 10.0.0.1 on vpp1, I get a ping error for p2p type interface on vpp master (21.01-rc0~548-g5e6d54779). vpp0 start with vpp0.cli and vpp1 with vpp1.cli. The following is the test netowrk topology and vpp1 console output: >

Re: [vpp-dev] move to clang-format

2020-12-13 Thread Dave Barach
Let me help with a sales pitch for pool_foreach2(): in this form one can set gdb breakpoints in the loop body. All by itself, that's a good enough reason to switch... Thanks for this one! Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io

[vpp-dev] move to clang-format

2020-12-13 Thread Damjan Marion via lists.fd.io
Hi, I was playing a bit with clang-format as replacement to gnu indent which we use today[1]. While it is impossible to render exact same result like gnu indent, good thing is that clang-format can be used only on lines which are changed in the diff so no major reformat is needed. My patch

Re: [vpp-dev] Please review https://gerrit.fd.io/r/c/vpp/+/29754

2020-12-13 Thread Damjan Marion via lists.fd.io
I reverted that patch. — Damjan > On 13.12.2020., at 05:23, Paul Vinciguerra wrote: > > It looks like this change is causing vpp-verify-master-ubuntu1804-aarch64 > jobs to fail in the CI. > > Can someone take a look? > >