Re: [vpp-dev] Regarding DPDK's rte_timer api's usage with VPP

2023-03-27 Thread Dave Barach
How about replacing this part of rte_timer_subsystem_init(): mz = rte_memzone_lookup(mz_name); if (mz == NULL) { mz = rte_memzone_reserve_aligned(mz_name, mem_size, SOCKET_ID_ANY, 0, RTE_CACHE_LINE_SIZE); if (mz ==

Re: [vpp-dev] How to check stack size of process node

2023-03-25 Thread Dave Barach
Find the current process index: vlib_node_main_t *nm = >node_main; current_process_index = nm->current_process_index; Find the process object: vlib_process_t *p = vec_elt (nm->processes, current_process_index); Find the stack base: p->stack Take the address of a local variable in a

Re: [vpp-dev] Race condition between bihash deletion and searching - misuse or bug?

2023-03-16 Thread Dave Barach
ts.fd.io> mailto:vpp-dev@lists.fd.io> > on behalf of Dave Barach mailto:v...@barachs.net> > Sent: Thursday, March 16, 2023 7:02 AM To: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] Race condition between bihash deletion and searching -

Re: [vpp-dev] Race condition between bihash deletion and searching - misuse or bug?

2023-03-15 Thread Dave Barach
I'm doing a bit of work to straighten out the template, hopefully without causing a measurable performance regression. Hao's test code is a bit of a corner-case: there is exactly one record in the database which the code thrashes as hard as possible. D. -Original Message- From:

Re: [vpp-dev] Race condition between bihash deletion and searching - misuse or bug?

2023-03-15 Thread Dave Barach
Doubling the number of atomic ops was expected to cause a severe performance regression. This hack demonstrates that the test code wasn't responsible. A bit of extra suspicion in clib_bihash_search_inline_2_with_hash() will likely solve the problem without the huge performance regression. D.

Re: [vpp-dev] Race condition between bihash deletion and searching - misuse or bug?

2023-03-14 Thread Dave Barach
Quick experiment: in src/vppinfra/bihash_template.h:clib_bihash_search_inline_2_with_hash(), replace this: if (PREDICT_FALSE (b->lock)) { volatile BVT (clib_bihash_bucket) * bv = b; while (bv->lock) CLIB_PAUSE (); } With: BV(clib_bihash_lock_bucket(b)); and make

Re: [vpp-dev] process node suspended indefinitely

2023-03-10 Thread Dave Barach
o crash. Thanks, Chetan On Mon, Feb 20, 2023, 18:24 Sudhir CR via lists.fd.io <http://lists.fd.io> mailto:rtbrick@lists.fd.io> > wrote: Hi Dave, Thank you very much for your inputs. I will try this out and get back to you with the results. Regards, Sudhir On M

Re: [vpp-dev] FW: Bug: DHCP Client not sending DHCP REQUEST using VPP v22.02

2023-03-02 Thread Dave Barach
dev@lists.fd.io> on behalf of Dave Barach via lists.fd.io <vpp=barachs@lists.fd.io>Sent: Thursday, 2 March 2023, 19:15To: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io>Subject: Re: [vpp-dev] FW: Bug: DHCP Client not sending DHCP REQUEST using VPP v22.02Do you see a response to the DHCP Discov

Re: [vpp-dev] FW: Bug: DHCP Client not sending DHCP REQUEST using VPP v22.02

2023-03-02 Thread Dave Barach
Do you see a response to the DHCP Discover packets? What does the vpp packet tracer show? Thanks... Dave > On Mar 2, 2023, at 7:03 AM, Thakur, Anagha wrote: > >  > > Hello, > > I am testing DHCP client feature from VPP stack (v22.02) onto our system. > > My setup is: I run k8s cluster

Re: [vpp-dev] process node suspended indefinitely

2023-02-20 Thread Dave Barach
Please try something like this, to eliminate the possibility that some bit of code is sending this process an event. It’s not a good idea to skip the vec_reset_length (event_data) step. while (1) { uword event_type, * event_data = 0; int i;

Re: [vpp-dev] process node suspended indefinitely

2023-02-18 Thread Dave Barach
Process is a bit of a misnomer, “cooperative multitasking thread” would be more accurate. Src/vlib/main.c makes no effort to interrupt process nodes. If a process runs forever vpp will have a bad day. Recitations: which version of vpp is involved? Please send “show run” output for the

Re: [vpp-dev] sigsegv and its handler

2023-02-01 Thread Dave Barach
This seems consistent with a SIGSEGV compounded by a worker-thread stack overflow situation. In hopes of obtaining a clean core file, you might want to modify the SIGSEGV handler to simply abort() instead of trying to write a post-mortem API dump, syslog’ing a backtrace, etc. Best of luck

Re: [vpp-dev] Possible VPP deadlock

2023-01-08 Thread Dave Barach
It looks like the root-cause is a corrupted heap. See also mspace_free()->check_top_chunk()->do_check_top_chunk(). One of the assertions is failing. Once the heap is pickled, all bets are off in terms of getting a useful API trace. Since you have a couple of (possibly) useful

Re: [vpp-dev] Outdated home gateway script for NAT?

2022-12-25 Thread Dave Barach
The “service restart isc-dhcp-server” command is a hack which only knows how to restart the isc-dhcp-server, not dnsmasq. You’ll need to tinker with it to restart dnsmasq, which almost certainly needs to deal with the lstack interface. HTH... Dave From: vpp-dev@lists.fd.io On

Re: [vpp-dev] Outdated home gateway script for NAT?

2022-12-25 Thread Dave Barach
I think that you just need to create an L3 vlan subinterface: vpp# create sub-interface 300 At that point, .300 should be an L3 subinterface which will strip vlan tag 300 for RX packets, and add vlan tag 300 for TX packets. Strikes me that that’s exactly what you need. if

Re: [vpp-dev] Outdated home gateway script for NAT?

2022-12-25 Thread Dave Barach
I've updated the doc, please see https://gerrit.fd.io/r/c/vpp/+/37859 HTH... Dave -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22383): https://lists.fd.io/g/vpp-dev/message/22383 Mute This Topic: https://lists.fd.io/mt/95859254/21656 Group

Re: [vpp-dev] Outdated home gateway script for NAT?

2022-12-24 Thread Dave Barach
Thanks for the report. I’ll update the doc… > On Dec 24, 2022, at 3:45 AM, pepijn de vos wrote: > >  > Hello, > > I'm quite new to VPP and trying to follow the "VPP as a Home Gateway" setup. > After following the installation instructions and copying the configuration > files, NAT does not

Re: [vpp-dev] Bug report - IP6 ND RA default route disappear from host device

2022-11-06 Thread Dave Barach
Merged... This patch addresses similar issues with iOS devices which appear to pay attention to the router flag... Thanks... Dave From: vpp-dev@lists.fd.io On Behalf Of Petr Boltík Sent: Sunday, November 6, 2022 4:09 AM To: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Bug report - IP6 ND

Re: [vpp-dev] maintainer's email

2022-11-04 Thread Dave Barach
I cleaned up my Linux Foundation profile. Hopefully the problem won't recur. Thanks for the report... Dave Barach -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22129): https://lists.fd.io/g/vpp-dev/message/22129 Mute This Topic: https

Re: [vpp-dev] pcap_write error: bad address #pcap

2022-10-17 Thread Dave Barach
Use gdb to inspect the pcap_main_t. In particular, determine vec_len(pm->pcap_data) [“(gdb) vl(pm->pcap_data)”] and pm->n_pcap_data_written. For reasonable N pcap_write(...) is known to work. D. From: vpp-dev@lists.fd.io On Behalf Of aihua1...@163.com Sent: Sunday, October 16, 2022

Re: [vpp-dev] vlib_log assert in dataplane workers

2022-09-02 Thread Dave Barach
A single printf() costs more clock cycles than processing a packet through the entire forwarding graph. It's not OK to call vlib_log() in data plane code. D. From: vpp-dev@lists.fd.io On Behalf Of Vadim Platonov via lists.fd.io Sent: Friday, September 2, 2022 8:14 AM To:

Re: [vpp-dev] vlib buffer allocate/free consumes too many CPU cycles

2022-08-23 Thread Dave Barach
+1, Ben has it exactly right... Dave On 8/23/22, 4:04 AM, "Benoit Ganne (bganne) via lists.fd.io" wrote: vlib_buffer_validate_alloc_free() should only be called with debug builds to debug buffer allocation issues. Debug builds are slow, because there is no optimizations and lots of

Re: [vpp-dev] Free a vlib buffer from out a VPP worker thread

2022-08-13 Thread Dave Barach
ev@lists.fd.io> mailto:vpp-dev@lists.fd.io> > On Behalf Of Dave Barach via lists.fd.io Sent: Thursday, August 11, 2022 12:07 PM To: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> Subject: [EXTERNAL] Re: [vpp-dev] Free from a vlib buffer from out a VPP worker thread

Re: [vpp-dev] Free from a vlib buffer from out a VPP worker thread

2022-08-11 Thread Dave Barach
As long as the thread has an associated vlib_main_t / vlib_buffer_pool_thread_t not accidentally shared with another thread, you shouldn't have any problems... FWIW... Dave From: vpp-dev@lists.fd.io On Behalf Of Simon Barber via lists.fd.io Sent: Thursday, August 11, 2022 6:42 AM To:

Re: [vpp-dev] VPP 2106 Main thread is 99% CPU

2022-05-21 Thread Dave Barach
Attach to the process in gdb, switch to the main thread (if necessary), and type “backtrace” or “bt”. You may need to type “continue” a few times to build a picture of what’s going on. D. From: vpp-dev@lists.fd.io On Behalf Of chetan bhasin Sent: Saturday, May 21, 2022 2:50 AM To:

Re: [vpp-dev] Change how "unix exec" executes cli scripts

2022-05-12 Thread Dave Barach
The define command consumes the rest of the input line, on purpose. Try this: define IP1 192.168.1.1 show macro show macro From: vpp-dev@lists.fd.io On Behalf Of jiangxiaom...@outlook.com Sent: Wednesday, May 11, 2022 10:34 PM To: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Change

[vpp-dev] New g2 standalone and vpp plugin Debian packages updated

2022-04-18 Thread Dave Barach
Tested the vpp plugin w/ master/latest as of a few minutes ago. See https://github.com/dbarach/vpp-event-viewer HTH... Dave -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#21272): https://lists.fd.io/g/vpp-dev/message/21272 Mute This

Re: [vpp-dev] Query Regarding Bihash (VPP 2106)

2022-04-07 Thread Dave Barach
Not enough buckets for the number of active key/value pairs. Buckets are cheap. Start with nBuckets = nActiveSessions / (BIHASH_KVP_PER_PAGE / 2) or some such and increase the number of buckets as necessary... HTH... Dave From: vpp-dev@lists.fd.io On Behalf Of chetan bhasin Sent:

Re: [vpp-dev] linux-cp + nat44 possible?

2022-01-17 Thread Dave Barach
https://s3-docs.fd.io/vpp/22.02/usecases/home_gateway.html - I've used vpp as a home gateway for years. HTH... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of René Weiss Sent: Monday, January 17, 2022 12:47 PM To: vpp-dev Subject: [vpp-dev] linux-cp + nat44 possible?

[vpp-dev] "make pkg-deb-debug" strips plugin / library symbols

2022-01-15 Thread Dave Barach
I decided to do a bit of leak-finding by building debug Debian packages and installing the results. The leakfinder output is approximately useless. Here's why, courtesy of gdbserver: Reading symbols from target:/usr/lib/x86_64-linux-gnu/vpp_plugins/dpdk_plugin.so... Reading

Re: [vpp-dev] feature arc node is NOT hitting

2021-12-13 Thread Dave Barach
A few minutes in gdb working with a debug image should make it obvious what’s going on. Start at the input node which implements the “device-input” arc and look at the data structures. E.g. dpdk_device_input(), or whatever. FWIW... D. From: vpp-dev@lists.fd.io On Behalf Of Satya Murthy

Re: [vpp-dev] Question on api-trace

2021-12-09 Thread Dave Barach
See https://lists.fd.io/g/vpp-dev/message/20578 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#20611): https://lists.fd.io/g/vpp-dev/message/20611 Mute This Topic: https://lists.fd.io/mt/87611500/21656 Group Owner: vpp-dev+ow...@lists.fd.io

Re: [vpp-dev] Question on api-trace

2021-12-09 Thread Dave Barach
See https://lists.fd.io/g/vpp-dev/message/20578?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Capi+trace%2C20%2C2%2C0%2C87467150 From: vpp-dev@lists.fd.io On Behalf Of Akash S R Sent: Thursday, December 9, 2021 8:26 AM To: vpp-dev ; Dave Barach ; Ole Troan Subject: [vpp-dev

Re: [vpp-dev] Question on api-trace

2021-12-09 Thread Dave Barach
See https://lists.fd.io/g/vpp-dev/message/20578 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#20609): https://lists.fd.io/g/vpp-dev/message/20609 Mute This Topic: https://lists.fd.io/mt/87611500/21656 Group Owner: vpp-dev+ow...@lists.fd.io

[vpp-dev] View api_post_mortem files

2021-12-03 Thread Dave Barach
See the "api trace" debug CLI command. For example: DBGvpp# api trace on # start tracing, typically configured in /etc/vpp/startup.com DBGvpp# bin create_loopback # create a loopback interface DBGvpp# bin sw_interface_set_flags sw_if_index 1 admin-up # set the interface admin-up

Re: [vpp-dev] [ip punt redirect] redirect ssh traffic on vpp interface to linux host

2021-11-29 Thread Dave Barach
One scheme which works well places a Linux tap interface into a NAT "inside network" bridge group. See https://s3-docs.fd.io/vpp/22.02/usecases/home_gateway.html This may not be appropriate for your use-case, but it will work perfectly if you can use it. HTH... Dave From:

Re: [vpp-dev] Bihash is considered thread-safe but probably shouldn't

2021-11-02 Thread Dave Barach
Dear Nick, As the code comment suggests, we tiptoe right up to the line to extract performance. Have you tried e.g. ISOLCPUS, thread priority, or some other expedients to make the required assumptions true? It’s easy enough to change the code in various ways so this use-case cannot

Re: [vpp-dev] vlib_get_plugin_symbol returning null after upgrading to 21.06 version

2021-09-29 Thread Dave Barach
+1... From: vpp-dev@lists.fd.io On Behalf Of Mohammed Hawari Sent: Wednesday, September 29, 2021 8:46 AM To: Dave Barach Cc: Satya Murthy ; vpp-dev Subject: Re: [vpp-dev] vlib_get_plugin_symbol returning null after upgrading to 21.06 version Hi, Please note that starting

Re: [vpp-dev] vlib_get_plugin_symbol returning null after upgrading to 21.06 version

2021-09-29 Thread Dave Barach
It’s worth checking that the symbol in question is actually exported. As part of upgrading, you may have started using a different toolchain. $ nm -go .o | grep From: vpp-dev@lists.fd.io On Behalf Of Satya Murthy Sent: Wednesday, September 29, 2021 6:43 AM To: vpp-dev@lists.fd.io

Re: [vpp-dev] #vpp #vnet os_panic for failed barrier timeout

2021-09-27 Thread Dave Barach
This is the key bit from thread 1: #3 0x7f000c0ab051 in unix_signal_handler (signum=6, si=, uc=) at /usr/src/debug/vpp-21.01/src/vlib/unix/main.c:187 #4 0x7f000a8995f0 in __funlockfile (stream=0x10af) at ../nptl/sysdeps/pthread/funlockfile.c:28 The thread barrier timeout is a

Re: [vpp-dev] Rejecting large frequency change

2021-09-17 Thread Dave Barach
, 2021 2:02 AM To: Dave Barach Cc: lgudi...@ciena.com; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Rejecting large frequency change Hi Dave, I am seeing this with VPP 21.01. Yes NTP is on and the print starts filling up the log. I see fixes made in this area in time.h and time.c addressing

Re: [vpp-dev] VPP 2106 How to enable Pcap trace of 2 interfaces out of 4

2021-09-06 Thread Dave Barach
Short answer: not as the code stands today. It would be simple to augment pcap_sw_if_index with a bitmap to solve “n choose k” problems. Making the scheme multi-instance would involve a significant rework, and effectively discards packet processing order information. I wouldn’t be in

Re: [vpp-dev] VPp 2101 (pcap trace)

2021-08-31 Thread Dave Barach
The following configuration works as expected: set term pag off loop create loop create set int ip address loop0 10.20.36.1/24 set int ip address loop1 10.20.37.1/24 set int state loop0 up set int state loop1 up packet-generator new { name s0 limit 10 size 128-128

Re: [vpp-dev] VPP plugins in C++

2021-08-31 Thread Dave Barach
It’s possible, modulo a bunch of easily anticipated header-file and build system issues. FWIW… Dave > On Aug 31, 2021, at 9:23 AM, Satya Murthy wrote: > > Hi , > > Is it possible to develop a vpp plugin in C++ (or) does VPP framework pose > any restrictions ? > > Appreciate your inputs

Re: [vpp-dev] vpp-plugin-devtools

2021-08-27 Thread Dave Barach
Makes sense to me... + oddbuf, perhaps? -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Friday, August 27, 2021 9:08 AM To: vpp-dev Subject: [vpp-dev] vpp-plugin-devtools Hello, We have more and more plugins which are intended to be

Re: [vpp-dev] vpp 2101 , we have to reduce the frame size to 128 for our use case

2021-08-27 Thread Dave Barach
Changing VLIB_FRAME_SIZE “should just work” but you could consider adjusting whichever input node(s) you’re using to limit the inbound frame size. Just to ask: why do you want to reduce the frame-size? D. From: vpp-dev@lists.fd.io On Behalf Of chetan bhasin Sent: Friday, August 27,

Re: [vpp-dev] Rejecting large frequency change

2021-08-06 Thread Dave Barach
Which version of vpp are you running? Which Linux kernel is involved? What kind of hardware? Lastly, did you just start running NTP on the system? Yes, of course it means something: every N seconds, vpp calculates its idea of the current clock frequency by asking the kernel [via the

Re: [vpp-dev] Having trouble disabling optimization

2021-07-28 Thread Dave Barach
Take a hard look at the startup config / command-line arguments passed by “make run”. The Python client isn’t hooking up with vpp correctly, most likely due to permission issues on the binary api segment. Make sure that the python client runs as root, or as a member of the “vpp” group,

Re: [vpp-dev] Event Logs Memory

2021-07-26 Thread Dave Barach
Before anyone invests in integrating LTTNG with vpp: it’s critical to understand the per-logged-event cost. I may be able to make some time to look at that. The vppinfra event logger costs O(100 clocks) per logged event. Even at that, we can’t afford to record per-packet events in

Re: [vpp-dev] Event Logs Memory

2021-07-26 Thread Dave Barach
Simply configure “vlib { elog-post-mortem-dump }” and look for the event log in /tmp/elog_post_mortem.. If vpp crashes in a horrifying way, the post mortem dump may fail. HTH... Dave From: vpp-dev@lists.fd.io On Behalf Of Varun Rapelly Sent: Monday, July 26, 2021 4:28 AM To:

Re: [vpp-dev] Having trouble disabling optimization

2021-07-22 Thread Dave Barach
>From the root of your workspace, “make build” will generate -g -o0 binaries… > On Jul 22, 2021, at 8:56 AM, Ivaylo Handjiiski wrote: > >  > Hello, > > I am trying to debug the VPP code using gdb but when I am examining or > printing variables most of them are . > > I've built vpp with -O0

Re: [vpp-dev] : Worker Thread Deadlock Detected from vl_api_clnt_node

2021-07-09 Thread Dave Barach
None that I know of. Without more data – see https://fd.io/docs/vpp/master/troubleshooting/reportingissues/reportingissues.html - it’s hard to imagine helping to solve the problem. Dave From: vpp-dev@lists.fd.io On Behalf Of Satya Murthy Sent: Friday, July 9, 2021 12:49 AM To:

Re: [vpp-dev] how to use span api in c code?

2021-07-07 Thread Dave Barach
That doc URL is from 17.04. See span_add_delete_entry() in span.[ch]. HTH... Dave From: vpp-dev@lists.fd.io On Behalf Of hemant via lists.fd.io Sent: Wednesday, July 7, 2021 5:40 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] how to use span api in c code? I see

Re: [vpp-dev] Prefetches improvement for VPP Arm generic image

2021-07-05 Thread Dave Barach
“Going across the whole codebase and replacing prefetch macros is something we should definitely avoid.” +1, for sure... FWIW... Dave From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Monday, July 5, 2021 4:50 AM To: Lijian Zhang Cc: vpp-dev ; nd ; Honnappa

Re: [vpp-dev] #vpp #vnet os_panic for failed barrier timeout

2021-06-24 Thread Dave Barach
Given the reported MTBF of 9 months and nearly 2-year-old software, switching to 21.01 [and then to 21.06 when released] seems like the only sensible next step. >From the gdb info provided, it looks like there is one worker thread. Is that correct? If so, the "workers_at_barrier" count seems

Re: [vpp-dev] "unix-cli-local" node corruption in node_by_name hash #vpp #vpp-dev

2021-06-18 Thread Dave Barach
This is a different code path which might need the same sort of fix. Looks likely that you sent a VL_API_DELETE_LOOPBACK message. AFAICT that message is not marked thread-safe, so it will be processed on thread 0 with the thread barrier held. D. From: vpp-dev@lists.fd.io On Behalf

Re: [vpp-dev] "unix-cli-local" node corruption in node_by_name hash #vpp #vpp-dev

2021-06-14 Thread Dave Barach
Ack, thanks... See https://gerrit.fd.io/r/c/vpp/+/32688; merged in master/latest. Cherry-picked into stable/2106, should cherry-pick into older releases if needed. D. From: vpp-dev@lists.fd.io On Behalf Of sontu mazumdar Sent: Sunday, June 13, 2021 1:35 PM To: Dave Barach Cc: vpp-dev

Re: [vpp-dev] "unix-cli-local" node corruption in node_by_name hash #vpp #vpp-dev

2021-06-11 Thread Dave Barach
Please try these diffs and report results. diff --git a/src/vlib/unix/cli.c b/src/vlib/unix/cli.c index 6c9886725..ce29e0723 100644 --- a/src/vlib/unix/cli.c +++ b/src/vlib/unix/cli.c @@ -2863,6 +2863,7 @@ unix_cli_file_add (unix_cli_main_t * cm, char *name, int fd) { unix_main_t *um

Re: [vpp-dev] Quick question on VPP on : How to Embed VPP as library

2021-06-11 Thread Dave Barach
to continue down the path of building vpp into your application: fabricate a plugin which creates a custom device class and interface to handle packet I/O to/from the application. FWIW... Dave From: Akash S R Sent: Thursday, June 10, 2021 11:06 AM To: Dave Barach Cc: vpp-dev@lists.fd.io

Re: [vpp-dev] Quick question on VPP on : How to Embed VPP as library

2021-06-10 Thread Dave Barach
Vpp seems to be its dispatch loop, waiting for an input node to inject work into the forwarding graph. What you call cust_main() is the moral equivalent of a while(1) loop. It won’t return. D. From: Akash S R Sent: Thursday, June 10, 2021 7:38 AM To: Akash S R Cc: v...@barachs.net;

Re: [vpp-dev] subinterface's ip did not deleted after subinterface deleted

2021-05-28 Thread Dave Barach
To: vpp-dev@lists.fd.io Subject: [vpp-dev] subinterface's ip did not deleted after subinterface deleted Hi Dave Barach: Subinterface's ip did not deleted after subinterface deleted. Hrere is the test command set interface state eth0 up create sub-interface eth0 1 set interface ip addr

Re: [vpp-dev] unformat_vnet_uri not implemented following RFC 3986

2021-05-27 Thread Dave Barach
IIRC it's exactly because ipv6 addresses use ':' (and "::") as chunk separators. If you decide to change unformat_vnet_uri please test ipv6 cases carefully. D. -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Florin Coras Sent: Thursday, May 27, 2021 1:05 AM To: 江 晓明 Cc:

Re: [vpp-dev] "make install-ext-deps" failing w/ master/latest?

2021-05-12 Thread Dave Barach
m: vpp-dev@lists.fd.io On Behalf Of Dave Barach Sent: Wednesday, May 12, 2021 10:13 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] "make install-ext-deps" failing w/ master/latest? Any clue what this is all about? --- validating quicly 0.1.3-vpp checksum --- extracting quicly 0.1

[vpp-dev] "make install-ext-deps" failing w/ master/latest?

2021-05-12 Thread Dave Barach
Any clue what this is all about? --- validating quicly 0.1.3-vpp checksum --- extracting quicly 0.1.3-vpp --- patching quicly 0.1.3-vpp Applying patch: 0001-cmake-install.patch patching file CMakeLists.txt Applying patch: 0002-cmake-install-picotls.patch patching file

Re: [vpp-dev] What is the relationship between "struct vlib_frame_t" , "struct vlib_pending_frame_t" and "struct vlib_next_frame_t"? #vpp-dev

2021-05-12 Thread Dave Barach
The graph dispatch engine isn’t particularly mysterious. That having been written, it would be perfectly OK to assume that it works, save questions for later, and move on to learning how to use vpp to solve problems. If you want or need to understand the graph dispatcher in minute detail,

Re: [vpp-dev] Clock time in pcap

2021-04-16 Thread Dave Barach
I wasn’t clear enough: your proposal uses a single clock object across multiple threads. The counters returned by the x86_64 rdtsc instruction are per-core, and differ by a noticeable fraction of a second... HTH... Dave From: vpp-dev@lists.fd.io On Behalf Of srinimurth...@gmail.com

Re: [vpp-dev] Feature Arcs

2021-04-15 Thread Dave Barach
Vnet_feature_arc_start initializes b->current_config_index and next0 if and only if features are active on the arc. Take a look at src/vnet/ip/ip_punt_drop.h, which explicitly (and correctly!) sets next0...next3 to zero, or src/vnet/dpo/dvr_dpo.c which sets next0..1 to zero. As in: if no

Re: [vpp-dev] Clock time in pcap

2021-04-15 Thread Dave Barach
The proposed fix won’t work correctly with multiple threads. Instead, please address the issue in pcap_write(...) by adding an offset argument and passing the required offset as f64 seconds since the epoch: f64 seconds_since_vpp_started = vlib_time_now(vm); f64

Re: [vpp-dev] Feature Arcs

2021-04-15 Thread Dave Barach
Please see https://fd.io/docs/vpp/master/gettingstarted/developers/featurearcs.html. Also, see inline below From: vpp-dev@lists.fd.io On Behalf Of Catalin Vasile Sent: Thursday, April 15, 2021 6:17 AM To: vpp-dev@lists.fd.io Subject: [vpp-dev] Feature Arcs Hi, I'm trying to grasp how

Re: [vpp-dev] New Committer Proposal

2021-03-31 Thread Dave Barach
+1... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Wednesday, March 31, 2021 1:58 PM To: vpp-dev Cc: Zhang, Roy Fan Subject: [vpp-dev] New Committer Proposal Dear VPP Committers, I would like to propose Roy Fan Zhang from Intel

Re: [vpp-dev] VPP 20.09 os_out_of_memory() in clib_bihash_add_del_16_8 in IPv4 Shallow Virtual reassembly code

2021-03-25 Thread Dave Barach
Dear Elias, Glad that you were able to switch, and that you're not seeing the issue anymore... Thanks for letting me know... Dave -Original Message- From: Elias Rudberg Sent: Thursday, March 25, 2021 12:43 PM To: v...@barachs.net; vpp-dev@lists.fd.io Subject: Re: [vpp-dev] VPP 20.09

Re: [vpp-dev] timer_expired_callback is not getting called after sometime

2021-03-17 Thread Dave Barach
Which version of vpp is involved? A while ago, I went to considerable trouble to idiot-proof the vpp timebase code [vlib_time_now()] against huge time jumps, particularly negative time jumps. The ntp daemon is perfectly capable of resetting the kernel’s idea of “now” by an hour or more in

Re: [vpp-dev] Unexpected behavior of Classifier

2021-03-16 Thread Dave Barach
You could try the buffer metadata tracking plugin, which should tell you which buffer metadata fields are touched in the graph trajectory you're using. I haven't tested it in a long time, so "caveat emptor." FWIW... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of

Re: [vpp-dev] RFC: vlib_global_main_t

2021-03-11 Thread Dave Barach
Looks like a win to me... -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Thursday, March 11, 2021 9:36 AM To: vpp-dev Subject: [vpp-dev] RFC: vlib_global_main_t Guys, I found that having both global and thread data in vlib_main_t is

Re: [vpp-dev] VPP 20.09 os_out_of_memory() in clib_bihash_add_del_16_8 in IPv4 Shallow Virtual reassembly code

2021-02-21 Thread Dave Barach
That's right. In 20.09, bihash did its own os-level memory allocation. You could (probably) pick up and port src/vppinfra/bihash*.[ch] to 20.09, or you could add some config knobs to the reassembly code. If switching to 21.01 is an option, that seems like the path of least resistance. HTH...

Re: [vpp-dev] VPP 20.09 os_out_of_memory() in clib_bihash_add_del_16_8 in IPv4 Shallow Virtual reassembly code

2021-02-19 Thread Dave Barach
See ../src/vppinfra/bihash_16_8.h: #define BIHASH_USE_HEAP 1 The the sv reassembly bihash table configuration appears to be hardwired, and complex enough to satisfy the cash customers. If the number of buckets is way too low for your use-case, bihash is capable of wasting a considerable amount

Re: [vpp-dev] Make test failures on ubuntu-20.04 AARCH64

2021-02-10 Thread Dave Barach
: vpp-dev@lists.fd.io On Behalf Of Paul Vinciguerra Sent: Tuesday, February 9, 2021 1:31 PM To: Dave Barach Cc: Benoit Ganne (bganne) ; Ole Troan ; Dave Wallace ; vpp-dev ; Juraj Linkeš Subject: Re: [vpp-dev] Make test failures on ubuntu-20.04 AARCH64 Hi Dave, test_cli.py verifies

Re: [vpp-dev] Make test failures on ubuntu-20.04 AARCH64

2021-02-09 Thread Dave Barach
lease advise... Thanks... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Benoit Ganne (bganne) via lists.fd.io Sent: Tuesday, February 9, 2021 8:06 AM To: Dave Barach ; 'Ole Troan' ; 'Dave Wallace' ; vpp-dev@lists.fd.io Cc: 'Juraj Linkeš' Subject: Re: [vpp-dev] Make test failures on

Re: [vpp-dev] Make test failures on ubuntu-20.04 AARCH64

2021-02-09 Thread Dave Barach
Would be glad to take a look at the aarch64 bihash failure, modulo the fact that the LF data center resources I've used before seem to have had their credentials changed. Please unicast appropriate (ip, userid, password) tuples. Thanks... Dave ssh vppdev@10.30.51.65 Warning: Permanently added

Re: [vpp-dev] vlib_put_frame_to_node to udp-encap causes main-thread crash

2021-02-08 Thread Dave Barach
I’m in the process of adding a few ASSERTs() to catch this issue. Stay tuned... D. From: PRANAB DAS Sent: Sunday, February 7, 2021 1:40 PM To: v...@barachs.net Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] vlib_put_frame_to_node to udp-encap causes main-thread crash Thanks Dave, it

Re: [vpp-dev] vlib_put_frame_to_node to udp-encap causes main-thread crash

2021-02-06 Thread Dave Barach
Make sure that vm = vlib_mains [thread_index], not vm = vlib_mains[0] = _global_main. >From what you wrote, I suspect that’s the problem. D. From: vpp-dev@lists.fd.io On Behalf Of PRANAB DAS Sent: Friday, February 5, 2021 7:38 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev]

Re: [vpp-dev] Jenkins/Gerrit Failure Cause Notifications

2021-02-02 Thread Dave Barach
Thanks very much! Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Dave Wallace Sent: Tuesday, February 2, 2021 8:28 PM To: vpp-dev Subject: [vpp-dev] Jenkins/Gerrit Failure Cause Notifications Folks, Per a request by Dave Barach in the VPP Monthly Community Meeting, I

[vpp-dev] New g2 plugin / standalone viewer images

2021-01-25 Thread Dave Barach
Available at https://github.com/dbarach/vpp-event-viewer.git . Track [golang] compiler / runtime changes -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18593): https://lists.fd.io/g/vpp-dev/message/18593 Mute This Topic:

Re: [vpp-dev] vpp musl integration and CI

2021-01-21 Thread Dave Barach
Ack. Take a look at .../extras/snap/snapcraft.yaml. I haven't built the vpp snap in a while, but this scheme (or the flatpack / appimage equivalent) finesses the multiple libc problem. There's a 0.0% chance that /bin/date will suddenly break. Been there, done that. D. From:

Re: [vpp-dev] vpp musl integration and CI

2021-01-21 Thread Dave Barach
I've been down this path before. s/glibc/musl/ fixes one set of issues, and a small set at that. [Back in the good old days, vpp wasn't even linked against glibc.] Here's a quick library summary: $ ldd /usr/bin/vpp linux-vdso.so.1 (0x7ffef81f2000) libvlibmemory.so.21.06 =>

Re: [vpp-dev] vpp packet generator scripts

2021-01-13 Thread Dave Barach
Here are a couple of relevant configs. HTH... Dave VPP UUT configuration: set int ip address FortyGigabitEthernet1/0/0 192.168.40.1/24 set int ip address FortyGigabitEthernet1/0/1 192.168.41.1/24 set int state FortyGigabitEthernet1/0/0 up set int state FortyGigabitEthernet1/0/1 up

Re: [vpp-dev] latest gerrit vpp build fails?

2020-12-27 Thread Dave Barach
Try "make install-dep install-ext-deps"... From: vpp-dev@lists.fd.io On Behalf Of hemant via lists.fd.io Sent: Sunday, December 27, 2020 7:35 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] latest gerrit vpp build fails? I used the following steps to download latest vpp: git clone

Re: [vpp-dev] Core Load Calculation

2020-12-17 Thread Dave Barach
As the sole remaining original vpp author and the area maintainer, I have abundant experience dealing with src/vlib/{main.c, threads.c}. In every case to date, we’ve been able to leverage existing callback hooks, or to add callback hooks so that folks can do what they need to do (e.g. from

Re: [vpp-dev] move to clang-format

2020-12-17 Thread Dave Barach
+1. Wholesale reformatting of existing files is to be avoided. Support for per-file or per-directory automated code formatting would be great! Religious debates about coding style will be resolved one day after there’s peace in Palestine. Let’s not go there. OK? Thanks... Dave

Re: [vpp-dev] Message posting policy change

2020-12-16 Thread Dave Barach
OK… Done deal... Thanks... Dave > On Dec 16, 2020, at 11:31 AM, Florin Coras wrote: > > +1 > > Florin > >> On Dec 16, 2020, at 4:47 AM, Dave Barach wrote: >> >> Folks, >> >> At the moment, we hold non-list-member posts in the vpp-dev mod

Re: [vpp-dev] move to clang-format

2020-12-16 Thread Dave Barach
Seems like a good time to flip the switch... Thanks... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Wednesday, December 16, 2020 9:12 AM To: vpp-dev Subject: Re: [vpp-dev] move to clang-format Any feedback? Any good reason not to

[vpp-dev] Message posting policy change

2020-12-16 Thread Dave Barach
Folks, At the moment, we hold non-list-member posts in the vpp-dev moderation queue. Unfortunately, spam comprises almost all of the messages in the queue. I've been deleting 10-20 junk emails per day - "want to buy a list of conference attendees?" - and I would like to spend that time doing

Re: [vpp-dev] Core Load Calculation

2020-12-15 Thread Dave Barach
In rough terms, you can model vector size as a function of offered load [and graph trajectory / configured features] with three linear segments. * Dead asleep – single-digit vector sizes * Keeping up – vector sizes up to the no-drop offered load * Hitting the wall – vector

Re: [vpp-dev] move to clang-format

2020-12-13 Thread Dave Barach
Let me help with a sales pitch for pool_foreach2(): in this form one can set gdb breakpoints in the loop body. All by itself, that's a good enough reason to switch... Thanks for this one! Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io

Re: [vpp-dev] New perfmon plugin

2020-12-11 Thread Dave Barach
Looks really cool! Feel free to move the old one to deprecated... ... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via lists.fd.io Sent: Friday, December 11, 2020 11:14 AM To: vpp-dev Subject: [vpp-dev] New perfmon plugin Guys, I just submitted patch

[vpp-dev] New g2 live viewer plugin / standalone image available

2020-12-10 Thread Dave Barach
At https://github.com/dbarach/vpp-event-viewer Changes since last code drop: Improve README.md, best viewed directly on github.com Fix summary-mode toggle Fix dialog "OK" button behavior. Clean up shift-mouse and control-mouse handling a bit Add mouse gestures to the

Re: [vpp-dev] don't see any interface but local0

2020-12-06 Thread Dave Barach
Most likely, the corresponding Linux interface is up. Try running vpp manually from the command-line, and look for messages of this form: vlib_pci_bind_to_uio: Skipping PCI device :00:1f.6 as host interface eno2 is up vlib_pci_bind_to_uio: Skipping PCI device :02:00.0 as host

Re: [vpp-dev]: Worker Thread Deadlock Detected from vl_api_clnt_node

2020-12-03 Thread Dave Barach
Looks like a corrupt binary API segment heap to me. Signal 7 in mspace_malloc(...) is the root cause. The thread hangs due to recursion on the mspace lock trying to print / syslog from the signal handler. It is abnormal to allocate memory in vl_msg_api_alloc[_as_if_client] in the first

Re: [vpp-dev] support of multiple startup-config files in startup.conf

2020-11-30 Thread Dave Barach
If you want a one-minute manager solution, use the “exec” command in /etc/vpp/vpp-startup.conf to source as many files as you like. Here’s one way to exploit that scheme: define HOSTNAME myvppgateway define TRUNK GigabitEthernet3/0/0 comment { inside subnet 192.168..0/24 } define

Re: [vpp-dev] unformat fails processing > 3 variables

2020-11-27 Thread Dave Barach
This will make you sad. Don’t write code line this: if (unformat (line_input, "%s %s %x %hhu %hhu %hu %hu %s %hhu %hu %hu %u %x %x %hu %hhu %hhu", ...)) If you want to parse a bunch of different fields, do it this way, aka the way it’s done elsewhere in the code base:

  1   2   3   4   5   6   7   8   9   10   >