Re: [vpp-dev] cmake is on

2018-09-09 Thread Kingwel Xie
Many thx! From: vpp-dev@lists.fd.io On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Friday, September 07, 2018 4:30 PM To: Damjan Marion Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] cmake is on I just did it: https://gerrit.fd.io/r/#/c/14711/ -- Damjan On 7 Sep 2018, at 09:25, Damjan

Re: [vpp-dev] cmake is on

2018-09-07 Thread John Lo (loj) via Lists.Fd.Io
Subject: Re: [vpp-dev] cmake is on I just did it: https://gerrit.fd.io/r/#/c/14711/ -- Damjan On 7 Sep 2018, at 09:25, Damjan Marion via Lists.Fd.Io mailto:dmarion=me@lists.fd.io>> wrote: Dear Kingwei, That should be easy to fix. Can you just remove it and submit patch, so

Re: [vpp-dev] cmake is on

2018-09-07 Thread Marco Varlese
Please, take a look at my patch just pushed...https://gerrit.fd.io/r/#/c/14716/ On Fri, 2018-09-07 at 10:44 +0200, Damjan Marion wrote: > Folks, > I'm going to revert this change, as it breaks compilation on non-cavium > systems. > That patch wrongly changes default cacheline size for all AArch64

Re: [vpp-dev] cmake is on

2018-09-07 Thread Damjan Marion via Lists.Fd.Io
Folks, I'm going to revert this change, as it breaks compilation on non-cavium systems. That patch wrongly changes default cacheline size for all AArch64 platforms to 128 bytes... -- Damjan > On 6 Sep 2018, at 15:52, Nitin Saxena wrote: > > Thanks Marco, Damjan. Adding cpu id fixes the

Re: [vpp-dev] cmake is on

2018-09-07 Thread Damjan Marion via Lists.Fd.Io
;mailto:vpp-dev@lists.fd.io> > <mailto:vpp-dev@lists.fd.io>> On Behalf Of Damjan Marion via Lists.Fd.Io >> Sent: Sunday, September 02, 2018 8:48 PM >> To: vpp-dev mailto:vpp-dev@lists.fd.io>> >> Cc: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> &g

Re: [vpp-dev] cmake is on

2018-09-07 Thread Damjan Marion via Lists.Fd.Io
.Io > Sent: Sunday, September 02, 2018 8:48 PM > To: vpp-dev > Cc: vpp-dev@lists.fd.io > Subject: [vpp-dev] cmake is on > > > Dear all, > > We just switched from autotools to cmake and retired all autotools related > files in src/. > > All verify j

Re: [vpp-dev] cmake is on

2018-09-06 Thread Kingwel Xie
Lists.Fd.Io Sent: Sunday, September 02, 2018 8:48 PM To: vpp-dev Cc: vpp-dev@lists.fd.io Subject: [vpp-dev] cmake is on Dear all, We just switched from autotools to cmake and retired all autotools related files in src/. All verify jobs are ok, and we also tried it on 3 different x86 and 2

Re: [vpp-dev] cmake is on

2018-09-06 Thread Nitin Saxena
Thanks Marco, Damjan. Adding cpu id fixes the compilation Pushed the patch: https://gerrit.fd.io/r/#/c/14701/ Thanks, Nitin On Thursday 06 September 2018 07:06 PM, Damjan Marion wrote: External Email Dear Nitin, Yes, it is missing.  I took care only for platforms I have access to... —

Re: [vpp-dev] cmake is on

2018-09-06 Thread Damjan Marion via Lists.Fd.Io
Dear Nitin, Yes, it is missing. I took care only for platforms I have access to... — Damjan > On 6 Sep 2018, at 14:04, Nitin Saxena wrote: > > Hi Damjan, > > cmake is making Cavium's OCTEONTx build failure. Following is the failure log > >

Re: [vpp-dev] cmake is on

2018-09-06 Thread Marco Varlese
Hi Nitin, On Thu, 2018-09-06 at 18:34 +0530, Nitin Saxena wrote: > Hi Damjan, > > cmake is making Cavium's OCTEONTx build failure. Following is the > failure log > > > > > > In function ‘dpdk_init’: >

Re: [vpp-dev] cmake is on

2018-09-06 Thread Nitin Saxena
Hi Damjan, cmake is making Cavium's OCTEONTx build failure. Following is the failure log In function ‘dpdk_init’: /home/nsaxena/vpp/src/plugins/dpdk/device/init.c:1802:3: error: static assertion failed: "DPDK RTE CACHE LINE

Re: [vpp-dev] cmake is on

2018-09-05 Thread Naoyuki Mori
Hi Damjan, I've encountered non install-able rpm package was build after this changes. $ make pkg-rpm $ sudo rpm -Uvh vpp-*327_g004869d0*rpm error: Failed dependencies:     libsvm.so.18.10()(64bit) is needed by vpp-18.10-rc0~327_g004869d0.x86_64 Reason is built shared lib naming format was

Re: [vpp-dev] cmake is on

2018-09-05 Thread Yu, Ping
Thanks Damjan. If cloning a brandnew repo, the build is ok. Ping From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Wednesday, September 5, 2018 1:13 AM To: Yu, Ping Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] cmake is on Dear Ping

Re: [vpp-dev] cmake is on

2018-09-04 Thread Damjan Marion via Lists.Fd.Io
lib/libvppcom.so.18.10 lib/libvlibmemoryclient.so.18.10 lib/libvlib.so.18.10 > lib/libsvm.so.18.10 lib/libvppinfra.so.18.10 -lm -ldl -lrt -lpthread && : > lib/libvppcom.so.18.10: undefined reference to `mheap_put' > lib/libvlibmemoryclient.so.18.10: undefined reference to `mheap_get_align

Re: [vpp-dev] cmake is on

2018-09-04 Thread Yu, Ping
d 1 exit status From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Sunday, September 2, 2018 8:48 PM To: vpp-dev Cc: vpp-dev@lists.fd.io Subject: [vpp-dev] cmake is on Dear all, We just switched from autotools to cmake and retired all autoto

[vpp-dev] cmake is on

2018-09-02 Thread Damjan Marion via Lists.Fd.Io
Dear all, We just switched from autotools to cmake and retired all autotools related files in src/. All verify jobs are ok, and we also tried it on 3 different x86 and 2 different ARM Aarch64 machines. Due to blast radius, i will not be surprised that some small issues pop out, but i don't

Re: [vpp-dev] CMake

2018-08-20 Thread Klement Sekera via Lists.Fd.Io
Yes, this causes test-debug target to take the old way (not cmake). This, though, seems a bit counter-intuitive. Shouldn't setting the value to "no" cause the build process to not use cmake? On Mon, 2018-08-20 at 12:15 +0200, Damjan Marion wrote: > > > > On 20 Aug 2018, at 11:55, Klement Sekera

Re: [vpp-dev] CMake

2018-08-20 Thread Damjan Marion via Lists.Fd.Io
> On 20 Aug 2018, at 11:55, Klement Sekera wrote: > > Hi Damjan, > > it seems that the test-debug target is broken with the patch. The build > process triggered by test-debug target jumps on the cmake train, but > that train doesn't bring in the APIGEN and other stuff (e.g. >

Re: [vpp-dev] CMake

2018-08-20 Thread Klement Sekera via Lists.Fd.Io
Hi Damjan, it seems that the test-debug target is broken with the patch. The build process triggered by test-debug target jumps on the cmake train, but that train doesn't bring in the APIGEN and other stuff (e.g. libvppapiclient.so). I don't see vpp-api mentioned in src/CMakeLists.txt. Should it

Re: [vpp-dev] CMake

2018-08-18 Thread Damjan Marion via Lists.Fd.Io
> On 18 Aug 2018, at 17:36, Andrew Pinski wrote: > > On Sat, Aug 18, 2018 at 3:38 AM Damjan Marion via Lists.Fd.Io > mailto:dmarion=me@lists.fd.io>> wrote: >> [snip] >> Feedback, issue reports and contributions to get CMake be a full replacement >> for autotools are welcome. > > I think

Re: [vpp-dev] CMake

2018-08-18 Thread Andrew Pinski
On Sat, Aug 18, 2018 at 3:38 AM Damjan Marion via Lists.Fd.Io wrote: > > > Dear all, > > Yesterday we merged a patch which introduces CMake build system in VPP. > > https://git.fd.io/vpp/commit/?id=612dd6a9 > > It is initial patch, and additional work is needed, but in general it manages > to

[vpp-dev] CMake

2018-08-18 Thread Damjan Marion via Lists.Fd.Io
Dear all, Yesterday we merged a patch which introduces CMake build system in VPP. https://git.fd.io/vpp/commit/?id=612dd6a9 It is initial patch, and additional work is needed, but in general it manages to compile VPP binaries significantly faster than what we have today with autotools. In