Re: [vpp-dev] IPV6 Forwarding error

2017-11-06 Thread Neale Ranns (nranns)
Hi Ewan,

It should never be invalid. These sorts of checks in the data-plane only serve 
to reduce performance.
You should examine the VLIB nodes prior to the ipv6 lookup (multicast or 
unicast) to determine which one is setting the FIB index incorrectly.

Regards,
neale

From: "yug...@telincn.com" <yug...@telincn.com>
Date: Monday, 6 November 2017 at 04:55
To: "Neale Ranns (nranns)" <nra...@cisco.com>, vpp-dev <vpp-dev@lists.fd.io>
Subject: Re: Re: [vpp-dev] IPV6 Forwarding error

Hi  neale,
I add this protection, but other errors come out in many different ways, all 
are ipv6 fib process errors.



fib_node_index_t
ip6_mfib_table_lookup2 (const ip6_mfib_t *mfib,
const ip6_address_t *src,
const ip6_address_t *grp)
{
ip6_mfib_node_t *i6mn;
ip6_mfib_key_t key;
if(!mfib)
return 0; (or  return ~0;)

IP6_MFIB_MK_KEY(grp, src, );

i6mn = (ip6_mfib_node_t*) rn_match(key.key,
   (struct radix_node_head *)mfib->rhead); 
// const cast

ASSERT(NULL != i6mn);

return (i6mn->i6mn_entry);
}


Regards,
Ewan

yug...@telincn.com

From: yug...@telincn.com<mailto:yug...@telincn.com>
Date: 2017-11-06 09:17
To: Neale Ranns (nranns)<mailto:nra...@cisco.com>; 
vpp-dev<mailto:vpp-dev@lists.fd.io>
Subject: Re: Re: [vpp-dev] IPV6 Forwarding error
Hi neale,
I've added a protection on it, but should it be invalid somehow?

Regards,
Ewan

yug...@telincn.com

From: Neale Ranns (nranns)<mailto:nra...@cisco.com>
Date: 2017-11-04 23:01
To: yug...@telincn.com<mailto:yug...@telincn.com>; 
vpp-dev<mailto:vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] IPV6 Forwarding error

Hi Ewan,

I would guess that fib_index0 is invalid.

/neale

From: <vpp-dev-boun...@lists.fd.io> on behalf of "yug...@telincn.com" 
<yug...@telincn.com>
Date: Saturday, 4 November 2017 at 11:11
To: vpp-dev <vpp-dev@lists.fd.io>
Subject: [vpp-dev] IPV6 Forwarding error

Hi all,
Here is ipv6 forwarding error, my version is 17.04.
Any idea?




Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault.
mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
305 mfei0 = ip6_mfib_table_lookup2(ip6_mfib_get(fib_index0),
(gdb) bt
#0  mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
#1  ip6_mfib_forward_lookup (frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:353
#2  ip6_mfib_forward_lookup_avx2 (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, frame=0x7fffb8626f00)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:369
#3  0x77757129 in dispatch_node (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, type=,
dispatch_state=VLIB_NODE_STATE_POLLING, frame=, 
last_time_stamp=10161712619298)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:998
#4  0x7775741d in dispatch_pending_node (vm=vm@entry=0x779aa2a0 
, p=0x7fffb8556de8,
last_time_stamp=) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1144
#5  0x77757e7d in vlib_main_or_worker_loop (is_main=1, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1591
#6  vlib_main_loop (vm=0x779aa2a0 ) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1611
#7  vlib_main (vm=vm@entry=0x779aa2a0 , 
input=input@entry=0x7fffb4cd4fa0)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1739
#8  0x77790f23 in thread0 (arg=140737347494560) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:507
#9  0x75a3dce0 in clib_calljmp () at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vppinfra/longjmp.S:110
#10 0x7fffd410 in ?? ()
#11 0x7779193d in vlib_unix_main (argc=, argv=)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:606

Regards,
Ewan

e...@telincn.com
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] IPV6 Forwarding error

2017-11-05 Thread yug...@telincn.com
Hi  neale,
I add this protection, but other errors come out in many different ways, all 
are ipv6 fib process errors.


fib_node_index_t
ip6_mfib_table_lookup2 (const ip6_mfib_t *mfib,
const ip6_address_t *src,
const ip6_address_t *grp)
{
ip6_mfib_node_t *i6mn;
ip6_mfib_key_t key;
if(!mfib)
return 0; (or  return ~0;)
   
IP6_MFIB_MK_KEY(grp, src, );

i6mn = (ip6_mfib_node_t*) rn_match(key.key,
   (struct radix_node_head *)mfib->rhead); 
// const cast

ASSERT(NULL != i6mn);

return (i6mn->i6mn_entry);
}

Regards,
Ewan


yug...@telincn.com
 
From: yug...@telincn.com
Date: 2017-11-06 09:17
To: Neale Ranns (nranns); vpp-dev
Subject: Re: Re: [vpp-dev] IPV6 Forwarding error
Hi neale,
I've added a protection on it, but should it be invalid somehow?

Regards,
Ewan


yug...@telincn.com
 
From: Neale Ranns (nranns)
Date: 2017-11-04 23:01
To: yug...@telincn.com; vpp-dev
Subject: Re: [vpp-dev] IPV6 Forwarding error
 
Hi Ewan,
 
I would guess that fib_index0 is invalid.
 
/neale
 
From: <vpp-dev-boun...@lists.fd.io> on behalf of "yug...@telincn.com" 
<yug...@telincn.com>
Date: Saturday, 4 November 2017 at 11:11
To: vpp-dev <vpp-dev@lists.fd.io>
Subject: [vpp-dev] IPV6 Forwarding error
 
Hi all,
Here is ipv6 forwarding error, my version is 17.04.
Any idea?
 


Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault.
mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
305 mfei0 = ip6_mfib_table_lookup2(ip6_mfib_get(fib_index0),
(gdb) bt
#0  mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
#1  ip6_mfib_forward_lookup (frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:353
#2  ip6_mfib_forward_lookup_avx2 (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, frame=0x7fffb8626f00)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:369
#3  0x77757129 in dispatch_node (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, type=, 
dispatch_state=VLIB_NODE_STATE_POLLING, frame=, 
last_time_stamp=10161712619298)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:998
#4  0x7775741d in dispatch_pending_node (vm=vm@entry=0x779aa2a0 
, p=0x7fffb8556de8, 
last_time_stamp=) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1144
#5  0x77757e7d in vlib_main_or_worker_loop (is_main=1, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1591
#6  vlib_main_loop (vm=0x779aa2a0 ) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1611
#7  vlib_main (vm=vm@entry=0x779aa2a0 , 
input=input@entry=0x7fffb4cd4fa0)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1739
#8  0x77790f23 in thread0 (arg=140737347494560) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:507
#9  0x75a3dce0 in clib_calljmp () at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vppinfra/longjmp.S:110
#10 0x7fffd410 in ?? ()
#11 0x7779193d in vlib_unix_main (argc=, argv=)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:606
 
Regards,
Ewan


e...@telincn.com
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] IPV6 Forwarding error

2017-11-05 Thread yug...@telincn.com
Hi neale,
I've added a protection on it, but should it be invalid somehow?

Regards,
Ewan


yug...@telincn.com
 
From: Neale Ranns (nranns)
Date: 2017-11-04 23:01
To: yug...@telincn.com; vpp-dev
Subject: Re: [vpp-dev] IPV6 Forwarding error
 
Hi Ewan,
 
I would guess that fib_index0 is invalid.
 
/neale
 
From: <vpp-dev-boun...@lists.fd.io> on behalf of "yug...@telincn.com" 
<yug...@telincn.com>
Date: Saturday, 4 November 2017 at 11:11
To: vpp-dev <vpp-dev@lists.fd.io>
Subject: [vpp-dev] IPV6 Forwarding error
 
Hi all,
Here is ipv6 forwarding error, my version is 17.04.
Any idea?
 


Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault.
mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
305 mfei0 = ip6_mfib_table_lookup2(ip6_mfib_get(fib_index0),
(gdb) bt
#0  mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
#1  ip6_mfib_forward_lookup (frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:353
#2  ip6_mfib_forward_lookup_avx2 (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, frame=0x7fffb8626f00)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:369
#3  0x77757129 in dispatch_node (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, type=, 
dispatch_state=VLIB_NODE_STATE_POLLING, frame=, 
last_time_stamp=10161712619298)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:998
#4  0x7775741d in dispatch_pending_node (vm=vm@entry=0x779aa2a0 
, p=0x7fffb8556de8, 
last_time_stamp=) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1144
#5  0x77757e7d in vlib_main_or_worker_loop (is_main=1, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1591
#6  vlib_main_loop (vm=0x779aa2a0 ) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1611
#7  vlib_main (vm=vm@entry=0x779aa2a0 , 
input=input@entry=0x7fffb4cd4fa0)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1739
#8  0x77790f23 in thread0 (arg=140737347494560) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:507
#9  0x75a3dce0 in clib_calljmp () at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vppinfra/longjmp.S:110
#10 0x7fffd410 in ?? ()
#11 0x7779193d in vlib_unix_main (argc=, argv=)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:606
 
Regards,
Ewan


e...@telincn.com
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] IPV6 Forwarding error

2017-11-04 Thread Neale Ranns (nranns)

Hi Ewan,

I would guess that fib_index0 is invalid.

/neale

From: <vpp-dev-boun...@lists.fd.io> on behalf of "yug...@telincn.com" 
<yug...@telincn.com>
Date: Saturday, 4 November 2017 at 11:11
To: vpp-dev <vpp-dev@lists.fd.io>
Subject: [vpp-dev] IPV6 Forwarding error

Hi all,
Here is ipv6 forwarding error, my version is 17.04.
Any idea?



Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault.
mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
305 mfei0 = ip6_mfib_table_lookup2(ip6_mfib_get(fib_index0),
(gdb) bt
#0  mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
#1  ip6_mfib_forward_lookup (frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:353
#2  ip6_mfib_forward_lookup_avx2 (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, frame=0x7fffb8626f00)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:369
#3  0x77757129 in dispatch_node (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, type=,
dispatch_state=VLIB_NODE_STATE_POLLING, frame=, 
last_time_stamp=10161712619298)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:998
#4  0x7775741d in dispatch_pending_node (vm=vm@entry=0x779aa2a0 
, p=0x7fffb8556de8,
last_time_stamp=) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1144
#5  0x77757e7d in vlib_main_or_worker_loop (is_main=1, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1591
#6  vlib_main_loop (vm=0x779aa2a0 ) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1611
#7  vlib_main (vm=vm@entry=0x779aa2a0 , 
input=input@entry=0x7fffb4cd4fa0)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1739
#8  0x77790f23 in thread0 (arg=140737347494560) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:507
#9  0x75a3dce0 in clib_calljmp () at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vppinfra/longjmp.S:110
#10 0x7fffd410 in ?? ()
#11 0x7779193d in vlib_unix_main (argc=, argv=)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:606

Regards,
Ewan

e...@telincn.com
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] IPV6 Forwarding error

2017-11-04 Thread yug...@telincn.com
Hi all,
Here is ipv6 forwarding error, my version is 17.04.
Any idea?


Thread 1 "vpp_main" received signal SIGSEGV, Segmentation fault.
mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
305 mfei0 = ip6_mfib_table_lookup2(ip6_mfib_get(fib_index0),
(gdb) bt
#0  mfib_forward_lookup (is_v4=0, frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:305
#1  ip6_mfib_forward_lookup (frame=0x7fffb8626f00, node=0x7fffb5cffe80, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:353
#2  ip6_mfib_forward_lookup_avx2 (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, frame=0x7fffb8626f00)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vnet/mfib/mfib_forward.c:369
#3  0x77757129 in dispatch_node (vm=0x779aa2a0 , 
node=0x7fffb5cffe80, type=, 
dispatch_state=VLIB_NODE_STATE_POLLING, frame=, 
last_time_stamp=10161712619298)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:998
#4  0x7775741d in dispatch_pending_node (vm=vm@entry=0x779aa2a0 
, p=0x7fffb8556de8, 
last_time_stamp=) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1144
#5  0x77757e7d in vlib_main_or_worker_loop (is_main=1, 
vm=0x779aa2a0 )
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1591
#6  vlib_main_loop (vm=0x779aa2a0 ) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1611
#7  vlib_main (vm=vm@entry=0x779aa2a0 , 
input=input@entry=0x7fffb4cd4fa0)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/main.c:1739
#8  0x77790f23 in thread0 (arg=140737347494560) at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:507
#9  0x75a3dce0 in clib_calljmp () at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vppinfra/longjmp.S:110
#10 0x7fffd410 in ?? ()
#11 0x7779193d in vlib_unix_main (argc=, argv=)
at 
/home/wangzy/Desktop/VBRASV100R001/vpp1704/build-data/../src/vlib/unix/main.c:606

Regards,
Ewan


e...@telincn.com
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev