Re: [vpp-dev] SNAT hash tables

2017-10-17 Thread Ole Troan
` > > The RELEASE.md says it is for 17.04. But in vppctl, 'show ver' shows I am > using v17.10-rc0~19-g58eb866 > > What is latest version? We have done quite a lot of performance work on the NAT plugin over the last few weeks. By latest, I meant that you would be best off following the git

Re: [vpp-dev] SNAT hash tables

2017-10-17 Thread Yuliang Li
The RELEASE.md says it is for 17.04. But in vppctl, 'show ver' shows I am using v17.10-rc0~19-g58eb866 What is latest version? Thanks, Yuliang On Tue, Oct 17, 2017 at 3:01 AM, Ole Troan wrote: > Yuliang, > > > Get it. It use spinlock (in vppinfra/bihash_template.c): > >

Re: [vpp-dev] SNAT hash tables

2017-10-17 Thread Ole Troan
Yuliang, > Get it. It use spinlock (in vppinfra/bihash_template.c): > > while (__sync_lock_test_and_set (h->writer_lock, 1)) > > On Mon, Oct 16, 2017 at 11:39 AM, Yuliang Li wrote: > Hi all, > > I am curious in the SNAT implementation. I see that SNAT's hash tables are >

Re: [vpp-dev] SNAT hash tables

2017-10-16 Thread Yuliang Li
Get it. It use spinlock (in vppinfra/bihash_template.c): while (__sync_lock_test_and_set (h->writer_lock, 1)) On Mon, Oct 16, 2017 at 11:39 AM, Yuliang Li wrote: > Hi all, > > I am curious in the SNAT implementation. I see that SNAT's hash tables >

[vpp-dev] SNAT hash tables

2017-10-16 Thread Yuliang Li
Hi all, I am curious in the SNAT implementation. I see that SNAT's hash tables are shared by all worker threads. Does SNAT use lock to avoid multiple threads updating the hash table concurrently? If not, how does it avoid race condition? Thanks,