Re: [vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

[guangwei]

Thanks, I have a look at the patch, I think the same action should take at 
state  FIN_WAIT_1 and FIN_WAIT_2 .





At 2019-06-29 00:53:15, "Florin Coras"  wrote:
Hi, 


Well, yes. VPP tcp won’t send out of order fins because it waits for all the 
data to be acked before sending the fin. Still, others may do it, so here’s a 
quick fix for that [1]. 


Thanks,
Florin 


[1] https://gerrit.fd.io/r/c/20403/


On Jun 28, 2019, at 7:25 AM, guangwei  wrote:


I think the FIN is reported to session layer only when it's indeed all the data 
which allowed in SEQ window has received, but from code, when the packet flaged 
with FIN
no matter whether it's a Out-Of-Order segment or not , no matter whether it's 
data all in the allowed window or not, the stack will treat this FIN as normal 
case and notify the session layer. Something I missed in code ? 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13396): https://lists.fd.io/g/vpp-dev/message/13396
Mute This Topic: https://lists.fd.io/mt/32242280/675152
Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480544
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [fcoras.li...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13402): https://lists.fd.io/g/vpp-dev/message/13402
Mute This Topic: https://lists.fd.io/mt/32242280/21656
Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

[Florin Coras]

Hi, 

Well, yes. VPP tcp won’t send out of order fins because it waits for all the 
data to be acked before sending the fin. Still, others may do it, so here’s a 
quick fix for that [1]. 

Thanks,
Florin 

[1] https://gerrit.fd.io/r/c/20403/ 

> On Jun 28, 2019, at 7:25 AM, guangwei  wrote:
> 
> I think the FIN is reported to session layer only when it's indeed all the 
> data which allowed in SEQ window has received, but from code, when the packet 
> flaged with FIN
> no matter whether it's a Out-Of-Order segment or not , no matter whether it's 
> data all in the allowed window or not, the stack will treat this FIN as 
> normal case and notify the session layer. Something I missed in code ? 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#13396): https://lists.fd.io/g/vpp-dev/message/13396
> Mute This Topic: https://lists.fd.io/mt/32242280/675152
> Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480544
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [fcoras.li...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13400): https://lists.fd.io/g/vpp-dev/message/13400
Mute This Topic: https://lists.fd.io/mt/32242280/21656
Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] VPP 19.04 TCP stack issue: I think TCP stack notify the FIN reception immaturely #vnet

[guangwei]

I think the FIN is reported to session layer only when it's indeed all the data 
which allowed in SEQ window has received, but from code, when the packet flaged 
with FIN
no matter whether it's a Out-Of-Order segment or not , no matter whether it's 
data all in the allowed window or not, the stack will treat this FIN as normal 
case and notify the session layer. Something I missed in code ?
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13396): https://lists.fd.io/g/vpp-dev/message/13396
Mute This Topic: https://lists.fd.io/mt/32242280/21656
Mute #vnet: https://lists.fd.io/mk?hashtag=vnet=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-