subject:"\[vpp\-dev\] Build Errors"

Re: [vpp-dev] Build errors

2019-08-16 Thread carlito nueno

Hi Dave,

It worked! Really appreciate the help :)

I learned a lot about git, never new about the bare feature.

On Fri, Aug 16, 2019 at 5:11 AM Dave Barach (dbarach)  wrote:
>
> That setup will cause no end of pain if your git chops aren't up to it. I 
> guess you've already discovered that. If you do things in a more normal way, 
> you won't have to add tags or argue with the build system.
>
> A more straightforward way to work - which I use myself - goes like so:
>
> Create a local bare clone [mirror] of the gerrit.fd.io upstream.
>
> Clone the local mirror into a working tree.
>
> In the working tree, check out the base branch you want to work on - 19.08, 
> master, or one of the other release branches - and create a private branch:
>
> $ git checkout -b mystuff origin/stable/1908 # note that the local bare clone 
> / mirror IS "origin" in this setup
>
> Add code, work, commit locally.
>
> Push your private branch into the local bare clone / mirror:
>
> $ git push origin mystuff
>
> Picking up changes from gerrit.fd.io is simple:
>
> In the local bare clone/mirror, "git fetch" # pulls all new commits on all 
> branches from gerrit.fd.io
>
> In the working tree: "git checkout ; git pull"
>
> To integrate upstream changes into your branch: "git checkout mybranch; git 
> rebase master" or "git checkout mybranch; git merge master". Test, and then 
> "git push origin mybranch".
>
> Make sure to back up the local bare clone / mirror, since that's the single 
> source of "mybranch" truth.
>
> If you want to s/local bare mirror/github/ you can do that, but you'll have 
> to navigate roughly twice the number of tools to get the same result.
>
> FWIW... Dave
>
> -----Original Message-
> From: vpp-dev@lists.fd.io  On Behalf Of carlito nueno
> Sent: Friday, August 16, 2019 12:58 AM
> To: Carlito Nueno 
> Cc: vpp-dev@lists.fd.io
> Subject: Re: [vpp-dev] Build errors
>
> Hi all,
>
> I think I found the problem.
>
> fatal: ambiguous argument 'v1.19-rc0..': unknown revision or path not in the 
> working tree.
>
> Here are steps I did:
> - I forked `stable/1908` branch and added some code to it.
> - Now my branch is `test-stable/1908`
> - I tagged my branch with `v1.19.08`.
> - I pushed the VPP master and my branch to github.
> - On my build server, I cloned my repo `github.com/carnu/vpp.git`
> - I checked out `v1.19.08`
>
> I am not well versed with git. Please let me know how I can compile after 
> adding custom code.
>
> Really appreciate it!
>
> On Thu, Aug 15, 2019 at 5:44 PM carlito nueno via Lists.Fd.Io 
>  wrote:
> >
> > I am getting the same error with: build-root/vagrant/build.sh
> >
> > On Thu, Aug 15, 2019 at 5:21 PM carlito nueno via Lists.Fd.Io
> >  wrote:
> > >
> > > Hi all,
> > >
> > > I am following this guide to build VPP:
> > > https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_
> > > Pushing_VPP_Code
> > >
> > > I added a patch to stable/1908 branch using ubuntu 18.04LTS running
> > > as ROOT user
> > >
> > > I followed these steps:
> > > apt-get update
> > > apt-get install build-essential
> > > make install-dep
> > > make install-ext-deps
> > > make build
> > >
> > > When I do make install-ext-deps, I get these errors:
> > >
> > > dpkg-buildpackage: warning: debian/changelog(l1): version '-0' is
> > > invalid: upstream version cannot be empty
> > > LINE: vpp-ext-deps (-0) unstable; urgency=low
> > > dpkg-buildpackage: info: source package vpp-ext-deps
> > > dpkg-buildpackage: info: source version unknown
> > > dpkg-buildpackage: error: version number does not start with digit
> > > Makefile:72: recipe for target 'vpp-ext-deps_-0_amd64.deb' failed
> > > make[2]: *** [vpp-ext-deps_-0_amd64.deb] Error 255
> > > make[2]: Leaving directory '/root/vpp/build/external'
> > > Makefile:79: recipe for target 'install-deb' failed
> > > make[1]: *** [install-deb] Error 2
> > > make[1]: Leaving directory '/root/vpp/build/external'
> > > Makefile:540: recipe for target 'install-ext-deps' failed
> > > make: *** [install-ext-deps] Error 2
> > >
> > > when I do make build, I get these errors
> > >
> > > -- Configuration:
> > > VPP version :
> > > VPP library version : NOTFOUND
> > > GIT toplevel dir: /root/vpp
> > > Build type  :
> > > C flags : -Wno-address-of-packe

Re: [vpp-dev] Build errors

2019-08-16 Thread Dave Barach via Lists.Fd.Io

That setup will cause no end of pain if your git chops aren't up to it. I guess 
you've already discovered that. If you do things in a more normal way, you 
won't have to add tags or argue with the build system.

A more straightforward way to work - which I use myself - goes like so:

Create a local bare clone [mirror] of the gerrit.fd.io upstream.

Clone the local mirror into a working tree.

In the working tree, check out the base branch you want to work on - 19.08, 
master, or one of the other release branches - and create a private branch:

$ git checkout -b mystuff origin/stable/1908 # note that the local bare clone / 
mirror IS "origin" in this setup

Add code, work, commit locally.

Push your private branch into the local bare clone / mirror:

$ git push origin mystuff

Picking up changes from gerrit.fd.io is simple:

In the local bare clone/mirror, "git fetch" # pulls all new commits on all 
branches from gerrit.fd.io

In the working tree: "git checkout ; git pull"

To integrate upstream changes into your branch: "git checkout mybranch; git 
rebase master" or "git checkout mybranch; git merge master". Test, and then 
"git push origin mybranch".

Make sure to back up the local bare clone / mirror, since that's the single 
source of "mybranch" truth.

If you want to s/local bare mirror/github/ you can do that, but you'll have to 
navigate roughly twice the number of tools to get the same result. 

FWIW... Dave

-Original Message-
From: vpp-dev@lists.fd.io  On Behalf Of carlito nueno
Sent: Friday, August 16, 2019 12:58 AM
To: Carlito Nueno 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] Build errors

Hi all,

I think I found the problem.

fatal: ambiguous argument 'v1.19-rc0..': unknown revision or path not in the 
working tree.

Here are steps I did:
- I forked `stable/1908` branch and added some code to it.
- Now my branch is `test-stable/1908`
- I tagged my branch with `v1.19.08`.
- I pushed the VPP master and my branch to github.
- On my build server, I cloned my repo `github.com/carnu/vpp.git`
- I checked out `v1.19.08`

I am not well versed with git. Please let me know how I can compile after 
adding custom code.

Really appreciate it!

On Thu, Aug 15, 2019 at 5:44 PM carlito nueno via Lists.Fd.Io 
 wrote:
>
> I am getting the same error with: build-root/vagrant/build.sh
>
> On Thu, Aug 15, 2019 at 5:21 PM carlito nueno via Lists.Fd.Io 
>  wrote:
> >
> > Hi all,
> >
> > I am following this guide to build VPP:
> > https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_
> > Pushing_VPP_Code
> >
> > I added a patch to stable/1908 branch using ubuntu 18.04LTS running 
> > as ROOT user
> >
> > I followed these steps:
> > apt-get update
> > apt-get install build-essential
> > make install-dep
> > make install-ext-deps
> > make build
> >
> > When I do make install-ext-deps, I get these errors:
> >
> > dpkg-buildpackage: warning: debian/changelog(l1): version '-0' is
> > invalid: upstream version cannot be empty
> > LINE: vpp-ext-deps (-0) unstable; urgency=low
> > dpkg-buildpackage: info: source package vpp-ext-deps
> > dpkg-buildpackage: info: source version unknown
> > dpkg-buildpackage: error: version number does not start with digit
> > Makefile:72: recipe for target 'vpp-ext-deps_-0_amd64.deb' failed
> > make[2]: *** [vpp-ext-deps_-0_amd64.deb] Error 255
> > make[2]: Leaving directory '/root/vpp/build/external'
> > Makefile:79: recipe for target 'install-deb' failed
> > make[1]: *** [install-deb] Error 2
> > make[1]: Leaving directory '/root/vpp/build/external'
> > Makefile:540: recipe for target 'install-ext-deps' failed
> > make: *** [install-ext-deps] Error 2
> >
> > when I do make build, I get these errors
> >
> > -- Configuration:
> > VPP version :
> > VPP library version : NOTFOUND
> > GIT toplevel dir: /root/vpp
> > Build type  :
> > C flags : -Wno-address-of-packed-member -march=corei7
> > -mtune=corei7-avx -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2 
> > -fstack-protector -fPIC -Wall -Werror -fno-common
> > Linker flags: -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2
> > -fstack-protector -fPIC -Wall -Werror -fno-common
> > Host processor  : x86_64
> > Target processor: x86_64
> > Prefix path :
> > /opt/vpp/external/x86_64;/root/vpp/build-root/install-vpp_debug-native/external
> > Install prefix  : /root/vpp/build-root/install-vpp_debug-native/vpp
> > -- Configuring incomplete, errors occurred!
> > See also 
> > "/root/vpp/build-root/build-vpp_debug-native/vpp/CMakeFiles/CMakeOutput.log".
> >

Re: [vpp-dev] Build errors

2019-08-15 Thread carlito nueno

Hi all,

I think I found the problem.

fatal: ambiguous argument 'v1.19-rc0..': unknown revision or path not
in the working tree.

Here are steps I did:
- I forked `stable/1908` branch and added some code to it.
- Now my branch is `test-stable/1908`
- I tagged my branch with `v1.19.08`.
- I pushed the VPP master and my branch to github.
- On my build server, I cloned my repo `github.com/carnu/vpp.git`
- I checked out `v1.19.08`

I am not well versed with git. Please let me know how I can compile
after adding custom code.

Really appreciate it!

On Thu, Aug 15, 2019 at 5:44 PM carlito nueno via Lists.Fd.Io
 wrote:
>
> I am getting the same error with: build-root/vagrant/build.sh
>
> On Thu, Aug 15, 2019 at 5:21 PM carlito nueno via Lists.Fd.Io
>  wrote:
> >
> > Hi all,
> >
> > I am following this guide to build VPP:
> > https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code
> >
> > I added a patch to stable/1908 branch
> > using ubuntu 18.04LTS
> > running as ROOT user
> >
> > I followed these steps:
> > apt-get update
> > apt-get install build-essential
> > make install-dep
> > make install-ext-deps
> > make build
> >
> > When I do make install-ext-deps, I get these errors:
> >
> > dpkg-buildpackage: warning: debian/changelog(l1): version '-0' is
> > invalid: upstream version cannot be empty
> > LINE: vpp-ext-deps (-0) unstable; urgency=low
> > dpkg-buildpackage: info: source package vpp-ext-deps
> > dpkg-buildpackage: info: source version unknown
> > dpkg-buildpackage: error: version number does not start with digit
> > Makefile:72: recipe for target 'vpp-ext-deps_-0_amd64.deb' failed
> > make[2]: *** [vpp-ext-deps_-0_amd64.deb] Error 255
> > make[2]: Leaving directory '/root/vpp/build/external'
> > Makefile:79: recipe for target 'install-deb' failed
> > make[1]: *** [install-deb] Error 2
> > make[1]: Leaving directory '/root/vpp/build/external'
> > Makefile:540: recipe for target 'install-ext-deps' failed
> > make: *** [install-ext-deps] Error 2
> >
> > when I do make build, I get these errors
> >
> > -- Configuration:
> > VPP version :
> > VPP library version : NOTFOUND
> > GIT toplevel dir: /root/vpp
> > Build type  :
> > C flags : -Wno-address-of-packed-member -march=corei7
> > -mtune=corei7-avx -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2
> > -fstack-protector -fPIC -Wall -Werror -fno-common
> > Linker flags: -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2
> > -fstack-protector -fPIC -Wall -Werror -fno-common
> > Host processor  : x86_64
> > Target processor: x86_64
> > Prefix path :
> > /opt/vpp/external/x86_64;/root/vpp/build-root/install-vpp_debug-native/external
> > Install prefix  : /root/vpp/build-root/install-vpp_debug-native/vpp
> > -- Configuring incomplete, errors occurred!
> > See also 
> > "/root/vpp/build-root/build-vpp_debug-native/vpp/CMakeFiles/CMakeOutput.log".
> > See also 
> > "/root/vpp/build-root/build-vpp_debug-native/vpp/CMakeFiles/CMakeError.log".
> > Makefile:644: recipe for target 'vpp-configure' failed
> > make[1]: *** [vpp-configure] Error 1
> > make[1]: Leaving directory '/root/vpp/build-root'
> > Makefile:367: recipe for target 'build' failed
> > make: *** [build] Error 2
> >
> > CMakeFiles/CMakeOutput.log: https://termbin.com/fhaz
> > CMakeFiles/CMakeError.log: https://termbin.com/pkh7d
> >
> > Thanks
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#13757): https://lists.fd.io/g/vpp-dev/message/13757
> > Mute This Topic: https://lists.fd.io/mt/32893039/675621
> > Group Owner: vpp-dev+ow...@lists.fd.io
> > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [carlitonu...@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#13758): https://lists.fd.io/g/vpp-dev/message/13758
> Mute This Topic: https://lists.fd.io/mt/32893039/675621
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [carlitonu...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13760): https://lists.fd.io/g/vpp-dev/message/13760
Mute This Topic: https://lists.fd.io/mt/32893039/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build errors

2019-08-15 Thread carlito nueno

I am getting the same error with: build-root/vagrant/build.sh

On Thu, Aug 15, 2019 at 5:21 PM carlito nueno via Lists.Fd.Io
 wrote:
>
> Hi all,
>
> I am following this guide to build VPP:
> https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code
>
> I added a patch to stable/1908 branch
> using ubuntu 18.04LTS
> running as ROOT user
>
> I followed these steps:
> apt-get update
> apt-get install build-essential
> make install-dep
> make install-ext-deps
> make build
>
> When I do make install-ext-deps, I get these errors:
>
> dpkg-buildpackage: warning: debian/changelog(l1): version '-0' is
> invalid: upstream version cannot be empty
> LINE: vpp-ext-deps (-0) unstable; urgency=low
> dpkg-buildpackage: info: source package vpp-ext-deps
> dpkg-buildpackage: info: source version unknown
> dpkg-buildpackage: error: version number does not start with digit
> Makefile:72: recipe for target 'vpp-ext-deps_-0_amd64.deb' failed
> make[2]: *** [vpp-ext-deps_-0_amd64.deb] Error 255
> make[2]: Leaving directory '/root/vpp/build/external'
> Makefile:79: recipe for target 'install-deb' failed
> make[1]: *** [install-deb] Error 2
> make[1]: Leaving directory '/root/vpp/build/external'
> Makefile:540: recipe for target 'install-ext-deps' failed
> make: *** [install-ext-deps] Error 2
>
> when I do make build, I get these errors
>
> -- Configuration:
> VPP version :
> VPP library version : NOTFOUND
> GIT toplevel dir: /root/vpp
> Build type  :
> C flags : -Wno-address-of-packed-member -march=corei7
> -mtune=corei7-avx -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2
> -fstack-protector -fPIC -Wall -Werror -fno-common
> Linker flags: -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2
> -fstack-protector -fPIC -Wall -Werror -fno-common
> Host processor  : x86_64
> Target processor: x86_64
> Prefix path :
> /opt/vpp/external/x86_64;/root/vpp/build-root/install-vpp_debug-native/external
> Install prefix  : /root/vpp/build-root/install-vpp_debug-native/vpp
> -- Configuring incomplete, errors occurred!
> See also 
> "/root/vpp/build-root/build-vpp_debug-native/vpp/CMakeFiles/CMakeOutput.log".
> See also 
> "/root/vpp/build-root/build-vpp_debug-native/vpp/CMakeFiles/CMakeError.log".
> Makefile:644: recipe for target 'vpp-configure' failed
> make[1]: *** [vpp-configure] Error 1
> make[1]: Leaving directory '/root/vpp/build-root'
> Makefile:367: recipe for target 'build' failed
> make: *** [build] Error 2
>
> CMakeFiles/CMakeOutput.log: https://termbin.com/fhaz
> CMakeFiles/CMakeError.log: https://termbin.com/pkh7d
>
> Thanks
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#13757): https://lists.fd.io/g/vpp-dev/message/13757
> Mute This Topic: https://lists.fd.io/mt/32893039/675621
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [carlitonu...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13758): https://lists.fd.io/g/vpp-dev/message/13758
Mute This Topic: https://lists.fd.io/mt/32893039/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Build errors

2019-08-15 Thread carlito nueno

Hi all,

I am following this guide to build VPP:
https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code

I added a patch to stable/1908 branch
using ubuntu 18.04LTS
running as ROOT user

I followed these steps:
apt-get update
apt-get install build-essential
make install-dep
make install-ext-deps
make build

When I do make install-ext-deps, I get these errors:

dpkg-buildpackage: warning: debian/changelog(l1): version '-0' is
invalid: upstream version cannot be empty
LINE: vpp-ext-deps (-0) unstable; urgency=low
dpkg-buildpackage: info: source package vpp-ext-deps
dpkg-buildpackage: info: source version unknown
dpkg-buildpackage: error: version number does not start with digit
Makefile:72: recipe for target 'vpp-ext-deps_-0_amd64.deb' failed
make[2]: *** [vpp-ext-deps_-0_amd64.deb] Error 255
make[2]: Leaving directory '/root/vpp/build/external'
Makefile:79: recipe for target 'install-deb' failed
make[1]: *** [install-deb] Error 2
make[1]: Leaving directory '/root/vpp/build/external'
Makefile:540: recipe for target 'install-ext-deps' failed
make: *** [install-ext-deps] Error 2

when I do make build, I get these errors

-- Configuration:
VPP version :
VPP library version : NOTFOUND
GIT toplevel dir: /root/vpp
Build type  :
C flags : -Wno-address-of-packed-member -march=corei7
-mtune=corei7-avx -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2
-fstack-protector -fPIC -Wall -Werror -fno-common
Linker flags: -O0 -DCLIB_DEBUG -g -DFORTIFY_SOURCE=2
-fstack-protector -fPIC -Wall -Werror -fno-common
Host processor  : x86_64
Target processor: x86_64
Prefix path :
/opt/vpp/external/x86_64;/root/vpp/build-root/install-vpp_debug-native/external
Install prefix  : /root/vpp/build-root/install-vpp_debug-native/vpp
-- Configuring incomplete, errors occurred!
See also 
"/root/vpp/build-root/build-vpp_debug-native/vpp/CMakeFiles/CMakeOutput.log".
See also 
"/root/vpp/build-root/build-vpp_debug-native/vpp/CMakeFiles/CMakeError.log".
Makefile:644: recipe for target 'vpp-configure' failed
make[1]: *** [vpp-configure] Error 1
make[1]: Leaving directory '/root/vpp/build-root'
Makefile:367: recipe for target 'build' failed
make: *** [build] Error 2

CMakeFiles/CMakeOutput.log: https://termbin.com/fhaz
CMakeFiles/CMakeError.log: https://termbin.com/pkh7d

Thanks
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#13757): https://lists.fd.io/g/vpp-dev/message/13757
Mute This Topic: https://lists.fd.io/mt/32893039/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-21 Thread Zhiyong Yang

Neale,

You are so nice to let me know about it. Thanks a lot.

Zhiyong
From: Neale Ranns (nranns) [mailto:nra...@cisco.com]
Sent: Friday, December 21, 2018 3:47 PM
To: Yang, Zhiyong ; Paul Vinciguerra 

Cc: Ole Troan ; vpp-dev@lists.fd.io; Damjan Marion 

Subject: Re: [vpp-dev] build errors on CenOS 7.5

Hi Zhiyong,

There is :
  make wipe-release
to clear out the files related to build-release

/neale

De : mailto:vpp-dev@lists.fd.io>> au nom de Zhiyong Yang 
mailto:zhiyong.y...@intel.com>>
Date : vendredi 21 décembre 2018 à 06:00
À : Paul Vinciguerra 
mailto:pvi...@vinciconsulting.com>>, "Neale Ranns 
(nranns)" mailto:nra...@cisco.com>>
Cc : Ole Troan mailto:otr...@employees.org>>, 
"vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>, Damjan Marion 
mailto:dmar...@me.com>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi Neale, Paul,

Neale is right. I try Neale’s method and it works fine. A 
little different from Neale’s method as below.

git checkout fe820689cf56e894ae5fa38f33a48b6960038033
make wipe
make rebuild-release

It works!

If use make build-release instead, the compiling fails again.

So, the code doesn’t need to be changed and I agree to revert the patch too.
Thanks everybody involved to solve my issue. Very great community discussion 
and collaboration!

If we can use make build-release work fine directly, it would be better.

Regards
Zhiyong

From: Paul Vinciguerra [mailto:pvi...@vinciconsulting.com]
Sent: Thursday, December 20, 2018 11:55 PM
To: Neale Ranns (nranns) mailto:nra...@cisco.com>>
Cc: Ole Troan mailto:otr...@employees.org>>; Yang, 
Zhiyong mailto:zhiyong.y...@intel.com>>; 
vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] build errors on CenOS 7.5

Sure. Revert it.  If that's the case, I need to look at why make wipe is 
missing it.

On Thu, Dec 20, 2018 at 10:35 AM Neale Ranns (nranns) 
mailto:nra...@cisco.com>> wrote:

Hi Paul,

I’d like to revert the fix if Zhiyong confirms a clean is all that’s needed.

I think we need to VPP API compiler to generate the necessary dependencies 
(e.g. as the usual .d file) for the imports it sees. This way we can setup the 
necessary dependencies in the makefile.

/neale

De : Paul Vinciguerra 
mailto:pvi...@vinciconsulting.com>>
Date : jeudi 20 décembre 2018 à 16:03
À : "Neale Ranns (nranns)" mailto:nra...@cisco.com>>
Cc : Ole Troan mailto:otr...@employees.org>>, Zhiyong 
Yang mailto:zhiyong.y...@intel.com>>, 
"vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Up until two days ago, make wipe did not clean out .api.json files.  It had to 
be done by hand. https://gerrit.fd.io/r/#/c/16405/
My fix is more likely a workaround that gets me working and I am ok reverting 
if necessary.  I can always cherry pick it with git review -x.

I think Neale is right and my change masks another problem.  My question is 
this:  What unit test can we write that expose the proper and improper 
behaviors?  Something in test_vapi.py maybe?

On Thu, Dec 20, 2018 at 7:33 AM Neale Ranns via Lists.Fd.Io<http://Lists.Fd.Io> 
mailto:cisco@lists.fd.io>> wrote:

/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);

the argument is not of type “struct _vl_api_mac_address”

do you need a ‘make wipe’ to regenerate the files derived from the gbp.api ?

/neale

De : mailto:vpp-dev@lists.fd.io>> au nom de Ole Troan 
mailto:otr...@employees.org>>
Date : jeudi 20 décembre 2018 à 11:07
À : Zhiyong Yang mailto:zhiyong.y...@intel.com>>
Cc : "vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole

On 20 Dec 2018, at 11:04, Zhiyong Yang 
mailto:zhiyong.y...@intel.com>> wrote:
Hi VPP guys,

Could you notice this building errors on CentOs as below? Could 
anybody help fix it?

Regards
Zhiyong

Prefix path : 
/opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
-- Configuring done
-- Generating done
-- Build files have been written to: 
/root/zhiyong/vpp/build-root/build-vpp-native/vpp
[560/1042] Building C object plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Neale Ranns via Lists.Fd.Io


Hi Zhiyong,

There is :
  make wipe-release
to clear out the files related to build-release

/neale


De :  au nom de Zhiyong Yang 
Date : vendredi 21 décembre 2018 à 06:00
À : Paul Vinciguerra , "Neale Ranns (nranns)" 

Cc : Ole Troan , "vpp-dev@lists.fd.io" 
, Damjan Marion 
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi Neale, Paul,

Neale is right. I try Neale’s method and it works fine. A 
little different from Neale’s method as below.

git checkout fe820689cf56e894ae5fa38f33a48b6960038033
make wipe
make rebuild-release

It works!

If use make build-release instead, the compiling fails again.

So, the code doesn’t need to be changed and I agree to revert the patch too.
Thanks everybody involved to solve my issue. Very great community discussion 
and collaboration!

If we can use make build-release work fine directly, it would be better.

Regards
Zhiyong

From: Paul Vinciguerra [mailto:pvi...@vinciconsulting.com]
Sent: Thursday, December 20, 2018 11:55 PM
To: Neale Ranns (nranns) 
Cc: Ole Troan ; Yang, Zhiyong ; 
vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] build errors on CenOS 7.5

Sure. Revert it.  If that's the case, I need to look at why make wipe is 
missing it.

On Thu, Dec 20, 2018 at 10:35 AM Neale Ranns (nranns) 
mailto:nra...@cisco.com>> wrote:

Hi Paul,

I’d like to revert the fix if Zhiyong confirms a clean is all that’s needed.

I think we need to VPP API compiler to generate the necessary dependencies 
(e.g. as the usual .d file) for the imports it sees. This way we can setup the 
necessary dependencies in the makefile.

/neale


De : Paul Vinciguerra 
mailto:pvi...@vinciconsulting.com>>
Date : jeudi 20 décembre 2018 à 16:03
À : "Neale Ranns (nranns)" mailto:nra...@cisco.com>>
Cc : Ole Troan mailto:otr...@employees.org>>, Zhiyong 
Yang mailto:zhiyong.y...@intel.com>>, 
"vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Up until two days ago, make wipe did not clean out .api.json files.  It had to 
be done by hand. https://gerrit.fd.io/r/#/c/16405/
My fix is more likely a workaround that gets me working and I am ok reverting 
if necessary.  I can always cherry pick it with git review -x.

I think Neale is right and my change masks another problem.  My question is 
this:  What unit test can we write that expose the proper and improper 
behaviors?  Something in test_vapi.py maybe?

On Thu, Dec 20, 2018 at 7:33 AM Neale Ranns via Lists.Fd.Io<http://Lists.Fd.Io> 
mailto:cisco@lists.fd.io>> wrote:

/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);


the argument is not of type “struct _vl_api_mac_address”

do you need a ‘make wipe’ to regenerate the files derived from the gbp.api ?

/neale


De : mailto:vpp-dev@lists.fd.io>> au nom de Ole Troan 
mailto:otr...@employees.org>>
Date : jeudi 20 décembre 2018 à 11:07
À : Zhiyong Yang mailto:zhiyong.y...@intel.com>>
Cc : "vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole

On 20 Dec 2018, at 11:04, Zhiyong Yang 
mailto:zhiyong.y...@intel.com>> wrote:
Hi VPP guys,

Could you notice this building errors on CentOs as below? Could 
anybody help fix it?

Regards
Zhiyong

Prefix path : 
/opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
-- Configuring done
-- Generating done
-- Build files have been written to: 
/root/zhiyong/vpp/build-root/build-vpp-native/vpp
[560/1042] Building C object plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
/opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS -I/root/zhiyong/vpp/src 
-I. -Iinclude -I/root/zhiyong/vpp/src/plugins -Iplugins -march=corei7 
-mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror 
-fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c 
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘vl_api_gbp_endpoint_add_t_handler’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Zhiyong Yang

Hi Neale, Paul,

Neale is right. I try Neale’s method and it works fine. A 
little different from Neale’s method as below.

git checkout fe820689cf56e894ae5fa38f33a48b6960038033
make wipe
make rebuild-release

It works!

If use make build-release instead, the compiling fails again.

So, the code doesn’t need to be changed and I agree to revert the patch too.
Thanks everybody involved to solve my issue. Very great community discussion 
and collaboration!

If we can use make build-release work fine directly, it would be better.

Regards
Zhiyong

From: Paul Vinciguerra [mailto:pvi...@vinciconsulting.com]
Sent: Thursday, December 20, 2018 11:55 PM
To: Neale Ranns (nranns) 
Cc: Ole Troan ; Yang, Zhiyong ; 
vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] build errors on CenOS 7.5

Sure. Revert it.  If that's the case, I need to look at why make wipe is 
missing it.

On Thu, Dec 20, 2018 at 10:35 AM Neale Ranns (nranns) 
mailto:nra...@cisco.com>> wrote:

Hi Paul,

I’d like to revert the fix if Zhiyong confirms a clean is all that’s needed.

I think we need to VPP API compiler to generate the necessary dependencies 
(e.g. as the usual .d file) for the imports it sees. This way we can setup the 
necessary dependencies in the makefile.

/neale


De : Paul Vinciguerra 
mailto:pvi...@vinciconsulting.com>>
Date : jeudi 20 décembre 2018 à 16:03
À : "Neale Ranns (nranns)" mailto:nra...@cisco.com>>
Cc : Ole Troan mailto:otr...@employees.org>>, Zhiyong 
Yang mailto:zhiyong.y...@intel.com>>, 
"vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Up until two days ago, make wipe did not clean out .api.json files.  It had to 
be done by hand. https://gerrit.fd.io/r/#/c/16405/
My fix is more likely a workaround that gets me working and I am ok reverting 
if necessary.  I can always cherry pick it with git review -x.

I think Neale is right and my change masks another problem.  My question is 
this:  What unit test can we write that expose the proper and improper 
behaviors?  Something in test_vapi.py maybe?

On Thu, Dec 20, 2018 at 7:33 AM Neale Ranns via Lists.Fd.Io<http://Lists.Fd.Io> 
mailto:cisco@lists.fd.io>> wrote:

/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);


the argument is not of type “struct _vl_api_mac_address”

do you need a ‘make wipe’ to regenerate the files derived from the gbp.api ?

/neale


De : mailto:vpp-dev@lists.fd.io>> au nom de Ole Troan 
mailto:otr...@employees.org>>
Date : jeudi 20 décembre 2018 à 11:07
À : Zhiyong Yang mailto:zhiyong.y...@intel.com>>
Cc : "vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole

On 20 Dec 2018, at 11:04, Zhiyong Yang 
mailto:zhiyong.y...@intel.com>> wrote:
Hi VPP guys,

Could you notice this building errors on CentOs as below? Could 
anybody help fix it?

Regards
Zhiyong

Prefix path : 
/opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
-- Configuring done
-- Generating done
-- Build files have been written to: 
/root/zhiyong/vpp/build-root/build-vpp-native/vpp
[560/1042] Building C object plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
/opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS -I/root/zhiyong/vpp/src 
-I. -Iinclude -I/root/zhiyong/vpp/src/plugins -Iplugins -march=corei7 
-mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror 
-fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c 
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘vl_api_gbp_endpoint_add_t_handler’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (mp->endpoint.mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_addre

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Paul Vinciguerra

Sure. Revert it.  If that's the case, I need to look at why make wipe is
missing it.

On Thu, Dec 20, 2018 at 10:35 AM Neale Ranns (nranns) 
wrote:

>
>
> Hi Paul,
>
>
>
> I’d like to revert the fix if Zhiyong confirms a clean is all that’s
> needed.
>
>
>
> I think we need to VPP API compiler to generate the necessary dependencies
> (e.g. as the usual .d file) for the imports it sees. This way we can setup
> the necessary dependencies in the makefile.
>
>
>
> /neale
>
>
>
>
>
> *De : *Paul Vinciguerra 
> *Date : *jeudi 20 décembre 2018 à 16:03
> *À : *"Neale Ranns (nranns)" 
> *Cc : *Ole Troan , Zhiyong Yang <
> zhiyong.y...@intel.com>, "vpp-dev@lists.fd.io" 
> *Objet : *Re: [vpp-dev] build errors on CenOS 7.5
>
>
>
> Up until two days ago, make wipe did not clean out .api.json files.  It
> had to be done by hand. https://gerrit.fd.io/r/#/c/16405/
>
> My fix is more likely a workaround that gets me working and I am ok
> reverting if necessary.  I can always cherry pick it with git review -x.
>
>
>
> I think Neale is right and my change masks another problem.  My question
> is this:  What unit test can we write that expose the proper and improper
> behaviors?  Something in test_vapi.py maybe?
>
>
>
> On Thu, Dec 20, 2018 at 7:33 AM Neale Ranns via Lists.Fd.Io  cisco@lists.fd.io> wrote:
>
>
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_decode (const u8 * in, mac_address_t * out);
>
>
>
>
>
> the argument is not of type “struct _vl_api_mac_address”
>
>
>
> do you need a ‘make wipe’ to regenerate the files derived from the gbp.api
> ?
>
>
>
> /neale
>
>
>
>
>
> *De : * au nom de Ole Troan 
> *Date : *jeudi 20 décembre 2018 à 11:07
> *À : *Zhiyong Yang 
> *Cc : *"vpp-dev@lists.fd.io" 
> *Objet : *Re: [vpp-dev] build errors on CenOS 7.5
>
>
>
> Hi,
>
>
>
> Paul also noticed that, and provided a fix in
> https://gerrit.fd.io/r/#/c/16562/
>
>
>
> Just merged.
>
> Can you confirm that fixes the issue?
>
> Also which compiler and version do you use?
>
>
>
> Cheers
>
> Ole
>
>
> On 20 Dec 2018, at 11:04, Zhiyong Yang  wrote:
>
> Hi VPP guys,
>
>
>
> Could you notice this building errors on CentOs as below?
> Could anybody help fix it?
>
>
>
> Regards
>
> Zhiyong
>
>
>
> Prefix path :
> /opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
>
> Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
>
> -- Configuring done
>
> -- Generating done
>
> -- Build files have been written to:
> /root/zhiyong/vpp/build-root/build-vpp-native/vpp
>
> [560/1042] Building C object
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
>
> FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
>
> /opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS
> -I/root/zhiyong/vpp/src -I. -Iinclude -I/root/zhiyong/vpp/src/plugins
> -Iplugins -march=corei7 -mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2
> -fstack-protector -fPIC -Werror -fPIC   -Wno-address-of-packed-member -Wall
> -MD -MT plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘vl_api_gbp_endpoint_add_t_handler’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible
> type for argument 1 of ‘mac_address_decode’
>
>mac_address_decode (mp->endpoint.mac, );
>
>^~
>
> In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_decode (const u8 * in, mac_address_t * out);
>
>  ^~
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘gbp_endpoint_send_details’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:263:44: error: incompatible
> type for argument 2 of ‘mac_address_encode’
>
>mac_address_encode (>ge_key.gek_mac, mp->endpoint.mac);
>
> ^~
>
>

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Neale Ranns via Lists.Fd.Io


Hi Paul,

I’d like to revert the fix if Zhiyong confirms a clean is all that’s needed.

I think we need to VPP API compiler to generate the necessary dependencies 
(e.g. as the usual .d file) for the imports it sees. This way we can setup the 
necessary dependencies in the makefile.

/neale


De : Paul Vinciguerra 
Date : jeudi 20 décembre 2018 à 16:03
À : "Neale Ranns (nranns)" 
Cc : Ole Troan , Zhiyong Yang , 
"vpp-dev@lists.fd.io" 
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Up until two days ago, make wipe did not clean out .api.json files.  It had to 
be done by hand. https://gerrit.fd.io/r/#/c/16405/
My fix is more likely a workaround that gets me working and I am ok reverting 
if necessary.  I can always cherry pick it with git review -x.

I think Neale is right and my change masks another problem.  My question is 
this:  What unit test can we write that expose the proper and improper 
behaviors?  Something in test_vapi.py maybe?

On Thu, Dec 20, 2018 at 7:33 AM Neale Ranns via Lists.Fd.Io<http://Lists.Fd.Io> 
mailto:cisco@lists.fd.io>> wrote:

/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);


the argument is not of type “struct _vl_api_mac_address”

do you need a ‘make wipe’ to regenerate the files derived from the gbp.api ?

/neale


De : mailto:vpp-dev@lists.fd.io>> au nom de Ole Troan 
mailto:otr...@employees.org>>
Date : jeudi 20 décembre 2018 à 11:07
À : Zhiyong Yang mailto:zhiyong.y...@intel.com>>
Cc : "vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" 
mailto:vpp-dev@lists.fd.io>>
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole

On 20 Dec 2018, at 11:04, Zhiyong Yang 
mailto:zhiyong.y...@intel.com>> wrote:
Hi VPP guys,

Could you notice this building errors on CentOs as below? Could 
anybody help fix it?

Regards
Zhiyong

Prefix path : 
/opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
-- Configuring done
-- Generating done
-- Build files have been written to: 
/root/zhiyong/vpp/build-root/build-vpp-native/vpp
[560/1042] Building C object plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
/opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS -I/root/zhiyong/vpp/src 
-I. -Iinclude -I/root/zhiyong/vpp/src/plugins -Iplugins -march=corei7 
-mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror 
-fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c 
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘vl_api_gbp_endpoint_add_t_handler’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (mp->endpoint.mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘gbp_endpoint_send_details’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:263:44: error: incompatible type 
for argument 2 of ‘mac_address_encode’
   mac_address_encode (>ge_key.gek_mac, mp->endpoint.mac);
^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:26:13: note: expected 
‘u8 * {aka unsigned char *}’ but argument is of type ‘vl_api_mac_address_t {aka 
struct _vl_api_mac_address}’
extern void mac_address_encode (const mac_address_t * in, u8 * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function ‘gbp_next_hop_decode’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:824:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (in->mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {ak

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Paul Vinciguerra

Up until two days ago, make wipe did not clean out .api.json files.  It had
to be done by hand. https://gerrit.fd.io/r/#/c/16405/
My fix is more likely a workaround that gets me working and I am ok
reverting if necessary.  I can always cherry pick it with git review -x.

I think Neale is right and my change masks another problem.  My question is
this:  What unit test can we write that expose the proper and improper
behaviors?  Something in test_vapi.py maybe?

On Thu, Dec 20, 2018 at 7:33 AM Neale Ranns via Lists.Fd.Io  wrote:

>
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_decode (const u8 * in, mac_address_t * out);
>
>
>
>
>
> the argument is not of type “struct _vl_api_mac_address”
>
>
>
> do you need a ‘make wipe’ to regenerate the files derived from the gbp.api
> ?
>
>
>
> /neale
>
>
>
>
>
> *De : * au nom de Ole Troan 
> *Date : *jeudi 20 décembre 2018 à 11:07
> *À : *Zhiyong Yang 
> *Cc : *"vpp-dev@lists.fd.io" 
> *Objet : *Re: [vpp-dev] build errors on CenOS 7.5
>
>
>
> Hi,
>
>
>
> Paul also noticed that, and provided a fix in
> https://gerrit.fd.io/r/#/c/16562/
>
>
>
> Just merged.
>
> Can you confirm that fixes the issue?
>
> Also which compiler and version do you use?
>
>
>
> Cheers
>
> Ole
>
>
> On 20 Dec 2018, at 11:04, Zhiyong Yang  wrote:
>
> Hi VPP guys,
>
>
>
> Could you notice this building errors on CentOs as below?
> Could anybody help fix it?
>
>
>
> Regards
>
> Zhiyong
>
>
>
> Prefix path :
> /opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
>
> Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
>
> -- Configuring done
>
> -- Generating done
>
> -- Build files have been written to:
> /root/zhiyong/vpp/build-root/build-vpp-native/vpp
>
> [560/1042] Building C object
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
>
> FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
>
> /opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS
> -I/root/zhiyong/vpp/src -I. -Iinclude -I/root/zhiyong/vpp/src/plugins
> -Iplugins -march=corei7 -mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2
> -fstack-protector -fPIC -Werror -fPIC   -Wno-address-of-packed-member -Wall
> -MD -MT plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘vl_api_gbp_endpoint_add_t_handler’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible
> type for argument 1 of ‘mac_address_decode’
>
>mac_address_decode (mp->endpoint.mac, );
>
>^~
>
> In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_decode (const u8 * in, mac_address_t * out);
>
>  ^~
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘gbp_endpoint_send_details’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:263:44: error: incompatible
> type for argument 2 of ‘mac_address_encode’
>
>mac_address_encode (>ge_key.gek_mac, mp->endpoint.mac);
>
> ^~
>
> In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:26:13: note:
> expected ‘u8 * {aka unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_encode (const mac_address_t * in, u8 * out);
>
>  ^~
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘gbp_next_hop_decode’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:824:23: error: incompatible
> type for argument 1 of ‘mac_address_decode’
>
>mac_address_decode (in->mac, );
>
>^~
>
> In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
>

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Neale Ranns via Lists.Fd.Io


Hi Zhiyong,

Works for me with a good clean

[vagrant@localhost vpp]$ lsb_release -a
LSB Version:
:core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID:CentOS
Description: CentOS Linux release 7.3.1611 (Core)
Release:   7.3.1611
Codename:  Core
[vagrant@localhost vpp]$ gcc -v
…
gcc version 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC)

[vagrant@localhost vpp]$ git checkout fe820689cf56e894ae5fa38f33a48b6960038033
[vagrant@localhost vpp]$ git clean -fdx
[vagrant@localhost vpp]$ make build
…
[1287/1287] Creating library symlink lib/libvapiclient.so
 Installing vpp 
[0/1] Install the project...
-- Install configuration: ""
make[1]: Leaving directory `/vpp/build-root'
[vagrant@localhost vpp]$


/neale


De :  au nom de "Neale Ranns via Lists.Fd.Io" 

Répondre à : "Neale Ranns (nranns)" 
Date : jeudi 20 décembre 2018 à 13:33
À : Ole Troan , Zhiyong Yang 
Cc : "vpp-dev@lists.fd.io" 
Objet : Re: [vpp-dev] build errors on CenOS 7.5


/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);


the argument is not of type “struct _vl_api_mac_address”

do you need a ‘make wipe’ to regenerate the files derived from the gbp.api ?

/neale


De :  au nom de Ole Troan 
Date : jeudi 20 décembre 2018 à 11:07
À : Zhiyong Yang 
Cc : "vpp-dev@lists.fd.io" 
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole

On 20 Dec 2018, at 11:04, Zhiyong Yang 
mailto:zhiyong.y...@intel.com>> wrote:
Hi VPP guys,

Could you notice this building errors on CentOs as below? Could 
anybody help fix it?

Regards
Zhiyong

Prefix path : 
/opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
-- Configuring done
-- Generating done
-- Build files have been written to: 
/root/zhiyong/vpp/build-root/build-vpp-native/vpp
[560/1042] Building C object plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
/opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS -I/root/zhiyong/vpp/src 
-I. -Iinclude -I/root/zhiyong/vpp/src/plugins -Iplugins -march=corei7 
-mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror 
-fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c 
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘vl_api_gbp_endpoint_add_t_handler’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (mp->endpoint.mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘gbp_endpoint_send_details’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:263:44: error: incompatible type 
for argument 2 of ‘mac_address_encode’
   mac_address_encode (>ge_key.gek_mac, mp->endpoint.mac);
^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:26:13: note: expected 
‘u8 * {aka unsigned char *}’ but argument is of type ‘vl_api_mac_address_t {aka 
struct _vl_api_mac_address}’
extern void mac_address_encode (const mac_address_t * in, u8 * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function ‘gbp_next_hop_decode’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:824:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (in->mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka const struct _vl_api_mac_address}

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Neale Ranns via Lists.Fd.Io


/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);


the argument is not of type “struct _vl_api_mac_address”

do you need a ‘make wipe’ to regenerate the files derived from the gbp.api ?

/neale


De :  au nom de Ole Troan 
Date : jeudi 20 décembre 2018 à 11:07
À : Zhiyong Yang 
Cc : "vpp-dev@lists.fd.io" 
Objet : Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole

On 20 Dec 2018, at 11:04, Zhiyong Yang 
mailto:zhiyong.y...@intel.com>> wrote:
Hi VPP guys,

Could you notice this building errors on CentOs as below? Could 
anybody help fix it?

Regards
Zhiyong

Prefix path : 
/opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
-- Configuring done
-- Generating done
-- Build files have been written to: 
/root/zhiyong/vpp/build-root/build-vpp-native/vpp
[560/1042] Building C object plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
/opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS -I/root/zhiyong/vpp/src 
-I. -Iinclude -I/root/zhiyong/vpp/src/plugins -Iplugins -march=corei7 
-mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror 
-fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c 
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘vl_api_gbp_endpoint_add_t_handler’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (mp->endpoint.mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
‘gbp_endpoint_send_details’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:263:44: error: incompatible type 
for argument 2 of ‘mac_address_encode’
   mac_address_encode (>ge_key.gek_mac, mp->endpoint.mac);
^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:26:13: note: expected 
‘u8 * {aka unsigned char *}’ but argument is of type ‘vl_api_mac_address_t {aka 
struct _vl_api_mac_address}’
extern void mac_address_encode (const mac_address_t * in, u8 * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function ‘gbp_next_hop_decode’:
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:824:23: error: incompatible type 
for argument 1 of ‘mac_address_decode’
   mac_address_decode (in->mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
‘const u8 * {aka const unsigned char *}’ but argument is of type 
‘vl_api_mac_address_t {aka const struct _vl_api_mac_address}’
extern void mac_address_decode (const u8 * in, mac_address_t * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: At top level:
cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ 
[-Werror]
cc1: all warnings being treated as errors
[633/1042] Building C object 
plugins/acl/CMakeFiles/acl_plugin_avx2.dir/dataplane_node.c.o
ninja: build stopped: subcommand failed.
make[1]: *** [vpp-build] Error 1
make[1]: Leaving directory `/root/zhiyong/vpp/build-root'
make: *** [build-release] Error 2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11725): https://lists.fd.io/g/vpp-dev/message/11725
Mute This Topic: https://lists.fd.io/mt/28810001/675193
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[otr...@employees.org<mailto:otr...@employees.org>]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11732): https://lists.fd.io/g/vpp-dev/message/11732
Mute This Topic: https://lists.fd.io/mt/28810001/21656
Group Owne

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Zhiyong Yang

Ole,
In addition,  the compiler that I’m using is gcc version 4.8.5 
20150623 (Red Hat 4.8.5-36) (GCC)

Zhiyong
From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Zhiyong Yang
Sent: Thursday, December 20, 2018 6:15 PM
To: Ole Troan ; Damjan Marion 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] build errors on CenOS 7.5

Ole, Damjan,

It works well now. Thank you guys. I believe there should be no 
problem for other OSes as well. ☺

Regards
Zhiyong
From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> 
[mailto:vpp-dev@lists.fd.io] On Behalf Of Ole Troan
Sent: Thursday, December 20, 2018 6:08 PM
To: Yang, Zhiyong mailto:zhiyong.y...@intel.com>>
Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11729): https://lists.fd.io/g/vpp-dev/message/11729
Mute This Topic: https://lists.fd.io/mt/28810001/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Zhiyong Yang

Ole, Damjan,

It works well now. Thank you guys. I believe there should be no 
problem for other OSes as well. ☺

Regards
Zhiyong
From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Ole Troan
Sent: Thursday, December 20, 2018 6:08 PM
To: Yang, Zhiyong 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] build errors on CenOS 7.5

Hi,

Paul also noticed that, and provided a fix in https://gerrit.fd.io/r/#/c/16562/

Just merged.
Can you confirm that fixes the issue?
Also which compiler and version do you use?

Cheers
Ole


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11728): https://lists.fd.io/g/vpp-dev/message/11728
Mute This Topic: https://lists.fd.io/mt/28810001/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Damjan Marion via Lists.Fd.Io



> On 20 Dec 2018, at 11:04, Zhiyong Yang  wrote:
> 
> Hi VPP guys,
>  
> Could you notice this building errors on CentOs as below? 
> Could anybody help fix it?
>  
> Regards
> Zhiyong
> 

Does https://gerrit.fd.io/r/#/c/16562/  
helps?

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11726): https://lists.fd.io/g/vpp-dev/message/11726
Mute This Topic: https://lists.fd.io/mt/28810001/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Zhiyong Yang

Hi VPP guys,

Could you notice this building errors on CentOs as below? Could 
anybody help fix it?

Regards
Zhiyong

Prefix path : 
/opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
Install prefix  : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
-- Configuring done
-- Generating done
-- Build files have been written to: 
/root/zhiyong/vpp/build-root/build-vpp-native/vpp
[560/1042] Building C object plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
/opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS -I/root/zhiyong/vpp/src 
-I. -Iinclude -I/root/zhiyong/vpp/src/plugins -Iplugins -march=corei7 
-mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2 -fstack-protector -fPIC -Werror 
-fPIC   -Wno-address-of-packed-member -Wall -MD -MT 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o 
plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o   -c 
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
'vl_api_gbp_endpoint_add_t_handler':
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible type 
for argument 1 of 'mac_address_decode'
   mac_address_decode (mp->endpoint.mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
'const u8 * {aka const unsigned char *}' but argument is of type 
'vl_api_mac_address_t {aka struct _vl_api_mac_address}'
extern void mac_address_decode (const u8 * in, mac_address_t * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 
'gbp_endpoint_send_details':
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:263:44: error: incompatible type 
for argument 2 of 'mac_address_encode'
   mac_address_encode (>ge_key.gek_mac, mp->endpoint.mac);
^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:26:13: note: expected 
'u8 * {aka unsigned char *}' but argument is of type 'vl_api_mac_address_t {aka 
struct _vl_api_mac_address}'
extern void mac_address_encode (const mac_address_t * in, u8 * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function 'gbp_next_hop_decode':
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:824:23: error: incompatible type 
for argument 1 of 'mac_address_decode'
   mac_address_decode (in->mac, );
   ^~
In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
/root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note: expected 
'const u8 * {aka const unsigned char *}' but argument is of type 
'vl_api_mac_address_t {aka const struct _vl_api_mac_address}'
extern void mac_address_decode (const u8 * in, mac_address_t * out);
 ^~
/root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: At top level:
cc1: error: unrecognized command line option '-Wno-address-of-packed-member' 
[-Werror]
cc1: all warnings being treated as errors
[633/1042] Building C object 
plugins/acl/CMakeFiles/acl_plugin_avx2.dir/dataplane_node.c.o
ninja: build stopped: subcommand failed.
make[1]: *** [vpp-build] Error 1
make[1]: Leaving directory `/root/zhiyong/vpp/build-root'
make: *** [build-release] Error 2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11725): https://lists.fd.io/g/vpp-dev/message/11725
Mute This Topic: https://lists.fd.io/mt/28810001/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build Errors

2016-10-13 Thread Billy McFall

Long, but below are the three types of errors I hit. I am writing a Jira
now and will submit a patch to fix them later today.

*1) There is a semi-colon at the end of the if statement. Fix was merged
yesterday.*

*vnet/vnet/fib/fib_entry_src_interface.c*

starting at line 54

  if (IP_LOOKUP_NEXT_GLEAN == adj->lookup_next_index);
 {

My Error Output:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/fib/fib_entry_src_interface.c: In function
‘fib_entry_src_interface_path_swap’:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/fib/fib_entry_src_interface.c:54:2: error: this ‘if’
clause does not guard... [-Werror=misleading-indentation]
  if (IP_LOOKUP_NEXT_GLEAN == adj->lookup_next_index);
  ^~
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/fib/fib_entry_src_interface.c:55:9: note: ...this
statement, but the latter is misleadingly indented as if it is guarded by
the ‘if’
 {
 ^

*2) Couple of "defined but not used" errors:*

*/vnet/vnet/mpls/interface.c*
starting on line 535

 static const int dpo_next_2_mpls_post_rewrite[DPO_LAST] = {
   [DPO_LOAD_BALANCE] = IP_LOOKUP_NEXT_LOAD_BALANCE,

My Error Output:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/mpls/interface.c:536:18: error:
‘dpo_next_2_mpls_post_rewrite’ defined but not used [-Werror=unused-const-
variable=]
 static const int dpo_next_2_mpls_post_rewrite[DPO_LAST] = {
  ^~~~
cc1: all warnings being treated as errors

*/vnet/vnet/dpo/lookup_dpo.c*
starting on line 797

const static char* const lookup_dst_from_interface_ip4_nodes[] =
{
"lookup-ip4-dst-itf",
NULL,
};
const static char* const lookup_dst_from_interface_ip6_nodes[] =
{
"lookup-ip6-dst-itf",
NULL,
};
const static char* const lookup_dst_from_interface_mpls_nodes[] =
{
"lookup-mpls-dst-itf",
NULL,
};
const static char* const * const lookup_dst_from_interface_nodes[DPO_PROTO_NUM]
=
{
[DPO_PROTO_IP4]  = lookup_dst_from_interface_ip4_nodes,
[DPO_PROTO_IP6]  = lookup_dst_from_interface_ip6_nodes,
[DPO_PROTO_MPLS] = lookup_dst_from_interface_mpls_nodes,
};

My Error Output:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/dpo/lookup_dpo.c:813:34: error:
‘lookup_dst_from_interface_nodes’ defined but not used
[-Werror=unused-const-variable=]
 const static char* const * const
lookup_dst_from_interface_nodes[DPO_PROTO_NUM]
=
  ^~~
cc1: all warnings being treated as errors

*3) va_arg() parameter issue:*

There are multiple instances of this. The first example is in
/vnet/vnet/lisp-gpe/lisp_gpe_adjacency.c, but around 9 other files hit the
same issue.

starting at line 358

  lisp_gpe_adjacency_format_flags_t flags =
va_arg (args, lisp_gpe_adjacency_format_flags_t);

I looked around the code, and other calls to va_arg() de-reference the
pointer to the variable 'args'. 'man va_arg()' indicates that the first
parameter is of type va_list. When I did this it compiled clean.

  lisp_gpe_adjacency_format_flags_t flags =
va_arg (*args, lisp_gpe_adjacency_format_flags_t);

My Error Output:
  CC   vnet/dpo/lookup_dpo.lo
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/lisp-gpe/lisp_gpe_adjacency.c: In function
‘format_lisp_gpe_adjacency’:
/home/bmcfall/dev/2016_10_11_VPP_286_ip_doxygen/vpp/build-
data/../vnet/vnet/lisp-gpe/lisp_gpe_adjacency.c:359:5: internal compiler
error: in build_va_arg, at c-family/c-common.c:5812
 va_arg (args, lisp_gpe_adjacency_format_flags_t);
 ^~
Please submit a full bug report,
with preprocessed source if appropriate.
See  for instructions.
Preprocessed source stored into /tmp/ccVa8tTa.out file, please attach this
to your bugreport.

On Thu, Oct 13, 2016 at 10:08 AM, Damjan Marion (damarion) <
damar...@cisco.com> wrote:

>
> Hi Bill,
>
> Error output copy/pasted here or to pastebin will be a good start.
>
> Thanks,
>
> Damjan
>
> > On 13 Oct 2016, at 15:55, Billy McFall  wrote:
> >
> > I am getting build errors from a newly created sandbox based off master.
> The build errors are coming from a patch submitted 3 weeks ago. One of the
> errors was fixed yesterday as a Coverity warning. So my question is, what
> is different on my system that these are treated as errors but I haven't
> anyone else on the message board seeing the errors? Do I have an old or new
> compiler? Some additional setting? What can I dump to provide more
> information?
> >
> > Host OS: Fedora 24
> > # gcc --version
> > gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3)
> > Copyright (C) 2016 Free Software Foundation, Inc.
> > This is free software; see the source for copying conditions.  There is
> NO
> > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
> PURPOSE.
> >
> > Thanks,
>

Re: [vpp-dev] Build Errors

2016-10-13 Thread Damjan Marion (damarion)


Hi Bill,

Error output copy/pasted here or to pastebin will be a good start.

Thanks,

Damjan

> On 13 Oct 2016, at 15:55, Billy McFall  wrote:
> 
> I am getting build errors from a newly created sandbox based off master. The 
> build errors are coming from a patch submitted 3 weeks ago. One of the errors 
> was fixed yesterday as a Coverity warning. So my question is, what is 
> different on my system that these are treated as errors but I haven't anyone 
> else on the message board seeing the errors? Do I have an old or new 
> compiler? Some additional setting? What can I dump to provide more 
> information?
> 
> Host OS: Fedora 24
> # gcc --version
> gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3)
> Copyright (C) 2016 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> 
> Thanks,
> Billy McFall
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] Build Errors

2016-10-13 Thread Billy McFall

I am getting build errors from a newly created sandbox based off master.
The build errors are coming from a patch submitted 3 weeks ago. One of the
errors was fixed yesterday as a Coverity warning. So my question is, what
is different on my system that these are treated as errors but I haven't
anyone else on the message board seeing the errors? Do I have an old or new
compiler? Some additional setting? What can I dump to provide more
information?

Host OS: Fedora 24
# gcc --version
gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3)
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Thanks,
Billy McFall
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Build errors

Re: [vpp-dev] Build errors

Re: [vpp-dev] Build errors

Re: [vpp-dev] Build errors

[vpp-dev] Build errors

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] build errors on CenOS 7.5

[vpp-dev] build errors on CenOS 7.5

Re: [vpp-dev] Build Errors

Re: [vpp-dev] Build Errors

[vpp-dev] Build Errors

20 matches

Site Navigation

Mail list logo

Footer information