Re: [vpp-dev] VPP S-NAT rename
On Wed, Aug 23, 2017 at 2:56 PM, Ole Troan wrote:
> Does that work for you?
Ole,
So, I have renamed SNAT --> NAT/NAT44 as needed now.
That's all fine.
Got caught by this failure mode, though
I now have this code:
plugin_name = format(0, "nat_%08x%c", nat_api_version, 0);
base_msg_id = vl_client_get_first_plugin_msg_id((char *)plugin_name);
Which produced this failure:
vl_client_get_first_plugin_msg_id:500: plugin 'nat_72bb6883' not registered
But we renamed "snat" as "nat" for all the module names, etc., right?
Except this lingers in src/plugins/nat/nat_api.c:
snat_api_init (vlib_main_t * vm, snat_main_t * sm)
{
u8 *name;
clib_error_t *error = 0;
name = format (0, "snat_%08x%c", api_version, 0);
and correspondingly this in src/plugins/nat/nat_test.c:
name = format (0, "snat_%08x%c", api_version, 0);
Naturally, changing this is effectively the *real* commitment of the
rename effort, so it *could* be that this was a conscious choice to wait
until next release to do this particular name change.
I'm guessing there is no way to register both names ...
That's likely to be icky, right?
jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
I’ve fixed link in jira. Matus From: Jim Thompson [mailto:j...@netgate.com] Sent: Wednesday, August 23, 2017 11:40 PM To: Matus Fabian -X (matfabia - PANTHEON TECHNOLOGIES at Cisco) Cc: vpp-dev Subject: Re: [vpp-dev] VPP S-NAT rename there is also some impact in jira https://jira.fd.io/browse/VPP-441 https://jira.fd.io/browse/VPP-707 I don't think I have access to that level, or I'd attempt to fix it. Jim On Wed, Aug 23, 2017 at 9:02 AM, Matus Fabian -X (matfabia - PANTHEON TECHNOLOGIES at Cisco) mailto:matfa...@cisco.com>> wrote: Hi, I’ve updated NAT plugin wiki page https://wiki.fd.io/view/VPP/NAT after renaming. Regards, Matus From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> [mailto:vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io>] On Behalf Of Ed Warnicke Sent: Monday, August 21, 2017 6:03 PM To: Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) mailto:mgrad...@cisco.com>> Cc: vpp-dev mailto:vpp-dev@lists.fd.io>> Subject: Re: [vpp-dev] VPP S-NAT rename Overall, I think the rename is a good idea. The Linux guys are used to thinking of SNAT as source NAT and DNAT as destination NAT. Ed On Mon, Aug 21, 2017 at 12:53 AM, Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) mailto:mgrad...@cisco.com>> wrote: Hi, Hc2vpp uses SNAT API. The rename you suggest is very simple (I guess snat->nat44), so we will not mind if there will be no parallel API. Regards, Marek -Original Message- From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> [mailto:vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io>] On Behalf Of Ole Troan Sent: 21 sierpnia 2017 09:40 To: vpp-dev mailto:vpp-dev@lists.fd.io>> Subject: [vpp-dev] VPP S-NAT rename Hi, The 'S' in VPP's S-NAT plugin name has often been confused with Linux' "Source NAT". The 'S' originally stood for "Simple", implying that it was a less complex implementation of NAT than the previous VCGN implementation. Because of this confusion (and possibly valid arguments that it isn't so simple anymore) we'd like to rename it. The feature supports all flavours of NAT44 and NAT64. The suggested new name is simply NAT. I.e. "VPP NAT". The proposal is to change the name in the wiki, documentation, folder/files and CLI. I am unsure if it is possible to change the API at this point. We might have to put in the new message names and allow those to live in parallel with the old ones for a release or two. Does anyone use the SNAT API? Opinions? Best regards, Ole ___ vpp-dev mailing list vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> https://lists.fd.io/mailman/listinfo/vpp-dev ___ vpp-dev mailing list vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> https://lists.fd.io/mailman/listinfo/vpp-dev ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
there is also some impact in jira https://jira.fd.io/browse/VPP-441 https://jira.fd.io/browse/VPP-707 I don't think I have access to that level, or I'd attempt to fix it. Jim On Wed, Aug 23, 2017 at 9:02 AM, Matus Fabian -X (matfabia - PANTHEON TECHNOLOGIES at Cisco) wrote: > Hi, > > > > I’ve updated NAT plugin wiki page https://wiki.fd.io/view/VPP/NAT after > renaming. > > > > Regards, > > Matus > > > > > > *From:* vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] *On > Behalf Of *Ed Warnicke > *Sent:* Monday, August 21, 2017 6:03 PM > *To:* Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) < > mgrad...@cisco.com> > *Cc:* vpp-dev > *Subject:* Re: [vpp-dev] VPP S-NAT rename > > > > Overall, I think the rename is a good idea. The Linux guys are used to > thinking of SNAT as source NAT and DNAT as destination NAT. > > > > Ed > > > > On Mon, Aug 21, 2017 at 12:53 AM, Marek Gradzki -X (mgradzki - PANTHEON > TECHNOLOGIES at Cisco) wrote: > > Hi, > > Hc2vpp uses SNAT API. The rename you suggest is very simple (I guess > snat->nat44), > so we will not mind if there will be no parallel API. > > Regards, > Marek > > > -Original Message----- > From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On > Behalf Of Ole Troan > Sent: 21 sierpnia 2017 09:40 > To: vpp-dev > Subject: [vpp-dev] VPP S-NAT rename > > Hi, > > The 'S' in VPP's S-NAT plugin name has often been confused with Linux' > "Source NAT". The 'S' originally stood for "Simple", implying that it was a > less complex implementation of NAT than the previous VCGN implementation. > > Because of this confusion (and possibly valid arguments that it isn't so > simple anymore) we'd like to rename it. > The feature supports all flavours of NAT44 and NAT64. > > The suggested new name is simply NAT. I.e. "VPP NAT". > > The proposal is to change the name in the wiki, documentation, > folder/files and CLI. > I am unsure if it is possible to change the API at this point. We might > have to put in the new message names and allow those to live in parallel > with the old ones for a release or two. Does anyone use the SNAT API? > > Opinions? > > Best regards, > Ole > > ___ > vpp-dev mailing list > vpp-dev@lists.fd.io > https://lists.fd.io/mailman/listinfo/vpp-dev > > > > ___ > vpp-dev mailing list > vpp-dev@lists.fd.io > https://lists.fd.io/mailman/listinfo/vpp-dev > ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
On Wed, Aug 23, 2017 at 2:56 PM, Ole Troan wrote: > They are now both there in parallel. With a warning in the wiki that the old > one will be removed after 17.10. > https://wiki.fd.io/view/VPP/NAT#API_.28new_after_renaming.29 > > Does that work for you? Yep! jdl ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
Jon, > >> Opinions? > > Changing its name would be good. > > I can track the name changes if you just want to slam them out there. They are now both there in parallel. With a warning in the wiki that the old one will be removed after 17.10. https://wiki.fd.io/view/VPP/NAT#API_.28new_after_renaming.29 Does that work for you? Best regards, Ole signature.asc Description: Message signed with OpenPGP ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
On Mon, Aug 21, 2017 at 2:39 AM, Ole Troan wrote: > Hi, > > The 'S' in VPP's S-NAT plugin name has often been confused with Linux' > "Source NAT". The 'S' originally stood for "Simple", implying that it was a > less complex implementation of NAT than the previous VCGN implementation. > > Because of this confusion (and possibly valid arguments that it isn't so > simple anymore) we'd like to rename it. > The feature supports all flavours of NAT44 and NAT64. > > The suggested new name is simply NAT. I.e. "VPP NAT". > > The proposal is to change the name in the wiki, documentation, folder/files > and CLI. > I am unsure if it is possible to change the API at this point. We might have > to put in the new message names and allow those to live in parallel with the > old ones for a release or two. > Does anyone use the SNAT API? Yes! > Opinions? Changing its name would be good. I can track the name changes if you just want to slam them out there. jdl ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
Hi, I’ve updated NAT plugin wiki page https://wiki.fd.io/view/VPP/NAT after renaming. Regards, Matus From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Ed Warnicke Sent: Monday, August 21, 2017 6:03 PM To: Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) Cc: vpp-dev Subject: Re: [vpp-dev] VPP S-NAT rename Overall, I think the rename is a good idea. The Linux guys are used to thinking of SNAT as source NAT and DNAT as destination NAT. Ed On Mon, Aug 21, 2017 at 12:53 AM, Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) mailto:mgrad...@cisco.com>> wrote: Hi, Hc2vpp uses SNAT API. The rename you suggest is very simple (I guess snat->nat44), so we will not mind if there will be no parallel API. Regards, Marek -Original Message- From: vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io> [mailto:vpp-dev-boun...@lists.fd.io<mailto:vpp-dev-boun...@lists.fd.io>] On Behalf Of Ole Troan Sent: 21 sierpnia 2017 09:40 To: vpp-dev mailto:vpp-dev@lists.fd.io>> Subject: [vpp-dev] VPP S-NAT rename Hi, The 'S' in VPP's S-NAT plugin name has often been confused with Linux' "Source NAT". The 'S' originally stood for "Simple", implying that it was a less complex implementation of NAT than the previous VCGN implementation. Because of this confusion (and possibly valid arguments that it isn't so simple anymore) we'd like to rename it. The feature supports all flavours of NAT44 and NAT64. The suggested new name is simply NAT. I.e. "VPP NAT". The proposal is to change the name in the wiki, documentation, folder/files and CLI. I am unsure if it is possible to change the API at this point. We might have to put in the new message names and allow those to live in parallel with the old ones for a release or two. Does anyone use the SNAT API? Opinions? Best regards, Ole ___ vpp-dev mailing list vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> https://lists.fd.io/mailman/listinfo/vpp-dev ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
Overall, I think the rename is a good idea. The Linux guys are used to thinking of SNAT as source NAT and DNAT as destination NAT. Ed On Mon, Aug 21, 2017 at 12:53 AM, Marek Gradzki -X (mgradzki - PANTHEON TECHNOLOGIES at Cisco) wrote: > Hi, > > Hc2vpp uses SNAT API. The rename you suggest is very simple (I guess > snat->nat44), > so we will not mind if there will be no parallel API. > > Regards, > Marek > > -Original Message- > From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On > Behalf Of Ole Troan > Sent: 21 sierpnia 2017 09:40 > To: vpp-dev > Subject: [vpp-dev] VPP S-NAT rename > > Hi, > > The 'S' in VPP's S-NAT plugin name has often been confused with Linux' > "Source NAT". The 'S' originally stood for "Simple", implying that it was a > less complex implementation of NAT than the previous VCGN implementation. > > Because of this confusion (and possibly valid arguments that it isn't so > simple anymore) we'd like to rename it. > The feature supports all flavours of NAT44 and NAT64. > > The suggested new name is simply NAT. I.e. "VPP NAT". > > The proposal is to change the name in the wiki, documentation, > folder/files and CLI. > I am unsure if it is possible to change the API at this point. We might > have to put in the new message names and allow those to live in parallel > with the old ones for a release or two. Does anyone use the SNAT API? > > Opinions? > > Best regards, > Ole > ___ > vpp-dev mailing list > vpp-dev@lists.fd.io > https://lists.fd.io/mailman/listinfo/vpp-dev > ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
Re: [vpp-dev] VPP S-NAT rename
Hi, Hc2vpp uses SNAT API. The rename you suggest is very simple (I guess snat->nat44), so we will not mind if there will be no parallel API. Regards, Marek -Original Message- From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Ole Troan Sent: 21 sierpnia 2017 09:40 To: vpp-dev Subject: [vpp-dev] VPP S-NAT rename Hi, The 'S' in VPP's S-NAT plugin name has often been confused with Linux' "Source NAT". The 'S' originally stood for "Simple", implying that it was a less complex implementation of NAT than the previous VCGN implementation. Because of this confusion (and possibly valid arguments that it isn't so simple anymore) we'd like to rename it. The feature supports all flavours of NAT44 and NAT64. The suggested new name is simply NAT. I.e. "VPP NAT". The proposal is to change the name in the wiki, documentation, folder/files and CLI. I am unsure if it is possible to change the API at this point. We might have to put in the new message names and allow those to live in parallel with the old ones for a release or two. Does anyone use the SNAT API? Opinions? Best regards, Ole ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
[vpp-dev] VPP S-NAT rename
Hi, The 'S' in VPP's S-NAT plugin name has often been confused with Linux' "Source NAT". The 'S' originally stood for "Simple", implying that it was a less complex implementation of NAT than the previous VCGN implementation. Because of this confusion (and possibly valid arguments that it isn't so simple anymore) we'd like to rename it. The feature supports all flavours of NAT44 and NAT64. The suggested new name is simply NAT. I.e. "VPP NAT". The proposal is to change the name in the wiki, documentation, folder/files and CLI. I am unsure if it is possible to change the API at this point. We might have to put in the new message names and allow those to live in parallel with the old ones for a release or two. Does anyone use the SNAT API? Opinions? Best regards, Ole signature.asc Description: Message signed with OpenPGP ___ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
