Re: [vpp-dev] Patches for 18.04

2018-04-06 Thread Thomas F Herbert

Chris and John

Thanks. will do.

--Tom


On 04/06/2018 03:53 PM, Chris Luke wrote:


You can cherry pick them to the stable branch, though preferably with 
a Jira ID in the first line (you can amend the commit message after 
you cherry pick it).


Chris.

*From:*vpp-dev@lists.fd.io  *On Behalf Of *Thomas 
F Herbert

*Sent:* Friday, April 6, 2018 14:38
*To:* vpp-dev@lists.fd.io
*Cc:* vpp-dev ; Billy McFall 
*Subject:* [vpp-dev] Patches for 18.04

Chris,

I submitted two patches to master that should be in stable/18.04.

11556: Merged in Master: https://gerrit.fd.io/r/11556

11551: Submitted but not merged yet in master: 
https://gerrit.fd.io/r/11551 


What should I do?

Should I resubmit both patches direct to stable/18.04?

--Tom

--
*Thomas F Herbert*
NFV and Fast Data Planes
Networking Group Office of the CTO
*Red Hat*




--
*Thomas F Herbert*
NFV and Fast Data Planes
Networking Group Office of the CTO
*Red Hat*


Re: [vpp-dev] Patches for 18.04

2018-04-06 Thread Chris Luke
You can cherry pick them to the stable branch, though preferably with a Jira ID 
in the first line (you can amend the commit message after you cherry pick it).

Chris.

From: vpp-dev@lists.fd.io  On Behalf Of Thomas F Herbert
Sent: Friday, April 6, 2018 14:38
To: vpp-dev@lists.fd.io
Cc: vpp-dev ; Billy McFall 
Subject: [vpp-dev] Patches for 18.04


Chris,

I submitted two patches to master that should be in stable/18.04.

11556: Merged in Master: https://gerrit.fd.io/r/11556

11551: Submitted but not merged yet in master: https://gerrit.fd.io/r/11551

What should I do?

Should I resubmit both patches direct to stable/18.04?

--Tom
--
Thomas F Herbert
NFV and Fast Data Planes
Networking Group Office of the CTO
Red Hat



Re: [vpp-dev] Patches for 18.04

2018-04-06 Thread John Lo (loj)
Hi Tom,

On your gerrit page for these patches, you can just click the "Cherry Pick" 
bottom and choose stable/1804 branch.

Regards,
John

From: vpp-dev@lists.fd.io  On Behalf Of Thomas F Herbert
Sent: Friday, April 06, 2018 2:38 PM
To: vpp-dev@lists.fd.io
Cc: vpp-dev ; Billy McFall 
Subject: [vpp-dev] Patches for 18.04


Chris,

I submitted two patches to master that should be in stable/18.04.

11556: Merged in Master: https://gerrit.fd.io/r/11556

11551: Submitted but not merged yet in master: https://gerrit.fd.io/r/11551

What should I do?

Should I resubmit both patches direct to stable/18.04?

--Tom
--
Thomas F Herbert
NFV and Fast Data Planes
Networking Group Office of the CTO
Red Hat