Re: [W3af-develop] HistoryItem improvements

2012-04-13 Thread Taras
Yes, I plan look on it in the nearest days. On 04/13/2012 04:27 PM, Andres Riancho wrote: > Great, thanks! > > PS: did you had the time to look at the commit/retry issue with the > history items? > > El abr 13, 2012 7:29 a.m., "Taras" > escribió: > > Andres, > > >

Re: [W3af-develop] HistoryItem improvements

2012-04-13 Thread Andres Riancho
Great, thanks! PS: did you had the time to look at the commit/retry issue with the history items? El abr 13, 2012 7:29 a.m., "Taras" escribió: > Andres, > > >> Reviewed the idea, plugins that use this, etc. It should be all fine. >> Merge this change into trunk please. Remember to run the follow

Re: [W3af-develop] HistoryItem improvements

2012-04-13 Thread Taras
Andres, > > Reviewed the idea, plugins that use this, etc. It should be all fine. > Merge this change into trunk please. Remember to run the following > before commiting the change to trunk: > > nosetests --doctest-result-variable=_test_res_ --rednose > --with-doctest --doctest-tests Done! -- T

Re: [W3af-develop] HistoryItem improvements

2012-04-11 Thread Andres Riancho
Taras, On Mon, Apr 9, 2012 at 5:30 PM, Taras wrote: > Andres, > >>> * /tmp/ directory usually has a disk partition quota, which might be >>> filled very quickly >>> >>> >>> Now,tmp is ~/.w3af/tmp/PID >>> >>> https://sourceforge.net/apps/trac/w3af/changeset/4857 >> >> >> Oh, you changed it

Re: [W3af-develop] HistoryItem improvements

2012-04-09 Thread Taras
Andres, >> * /tmp/ directory usually has a disk partition quota, which might be >> filled very quickly >> >> Now,tmp is ~/.w3af/tmp/PID >> >> https://sourceforge.net/apps/trac/w3af/changeset/4857 > > Oh, you changed it at THAT level, which affects every other part of > the code that uses th

Re: [W3af-develop] HistoryItem improvements

2012-04-09 Thread Andres Riancho
Taras, On Mon, Apr 9, 2012 at 5:11 PM, Taras wrote: > Andres, > Agree, but in any case we need to change mode for w3af's temp dir to drwx--. It will fix this issue. >>> >>> >>> Ok, can you do this? > > Fixed > >> > * /tmp/ directory usually has a disk partition quota, which migh

Re: [W3af-develop] HistoryItem improvements

2012-04-09 Thread Taras
Andres, >>> Agree, but in any case we need to change mode for w3af's temp dir to >>> drwx--. It will fix this issue. >> >> Ok, can you do this? Fixed > * /tmp/ directory usually has a disk partition quota, which might be filled very quickly Now,tmp is ~/.w3af/tmp/PID https://sourcefo

Re: [W3af-develop] HistoryItem improvements

2012-04-09 Thread Taras
Andres, >>> * I also see that in a multi-user environment user A running a w3af >>> scan would be exposing to all the other users which targets he's >>> scanning >> >> Agree, but in any case we need to change mode for w3af's temp dir to >> drwx--. It will fix this issue. > > Ok, can you do this

Re: [W3af-develop] HistoryItem improvements

2012-04-09 Thread Andres Riancho
Taras, On Mon, Apr 9, 2012 at 8:56 AM, Taras wrote: > Andres, > > >>> * moved sessions dir to w3af's tmp dir (currently /tmp/w3af/PID/). This >>> change makes possible to clean up these unnecessary files after w3af >>> finish its work. >> >> >>     I'm not 100% sure about this change, let me expl

Re: [W3af-develop] HistoryItem improvements

2012-04-09 Thread Taras
Andres, >> * moved sessions dir to w3af's tmp dir (currently /tmp/w3af/PID/). This >> change makes possible to clean up these unnecessary files after w3af >> finish its work. > > I'm not 100% sure about this change, let me explain why: > > * I see the great benefit in having this in the /tmp/

Re: [W3af-develop] HistoryItem improvements

2012-04-09 Thread Andres Riancho
Taras, On Sun, Apr 8, 2012 at 3:54 PM, Taras wrote: > Andres, > > I just have made some improvements in HistoryItem class [0]: > > * moved whole DB initialization from gtkOutput plugin to HistoryItem > because it's bad when core thing is depended on one plugin method That looks nice, > * mo