[waffle] [PATCH] android: Don't specify -std=gnu99 for C++ builds -- it breaks clang

2015-04-09 Thread Emil Velikov
From: Bernhard Rosenkränzer bernhard.rosenkran...@linaro.org Signed-off-by: Bernhard Rosenkränzer bernhard.rosenkran...@linaro.org [Emil Velikov: Apply the workaround for kitkat and older] Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- Android.mk | 9 - 1 file changed, 8

Re: [waffle] [PATCH 01/10] api/core: annotate structs/functions for C linkage

2015-04-09 Thread Tapani
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 03/24/2015 05:56 PM, Emil Velikov wrote: Annotate as extern C when included in C++ files to prevent issues due to conflicting linkage - C vs C++. With follow up commits we'll remove the extern C { #include header.h } pattern which we currently

Re: [waffle] [PATCH v2 07/10] nacl: untangle header inclusions

2015-04-09 Thread Tapani
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 03/25/2015 03:56 PM, Emil Velikov wrote: Use direct inclusion of the header providing the symbol. This improves the overall readability and allows us to easily track which headers are actually included via C++ files. This way we can add the

Re: [waffle] [PATCH 00/10] nacl dl rework and header cleanups et all

2015-04-09 Thread Chad Versace
On Tue 24 Mar 2015, Emil Velikov wrote: Hi all, Was pondering on the trivial nacl_dl* nitpick I was talking about earlier and I've noticed something more interesting along the way. Namely: in some places in waffle we include headers explicitly wrapped for C linkage (extern C { #include foo.h