Re: [waffle] [PATCH 04/10] nacl: rework nacl_dl functions

2015-03-26 Thread Tapani Pälli
On 03/25/2015 04:07 PM, Emil Velikov wrote: On 25 March 2015 at 06:10, Tapani tapani.pa...@intel.com wrote: 2 small things below .. On 03/24/2015 05:56 PM, Emil Velikov wrote: [...] +static bool +nacl_dl_check_enum(int32_t waffle_dl) +{ +switch (waffle_dl) { +case

Re: [waffle] [PATCH 04/10] nacl: rework nacl_dl functions

2015-03-25 Thread Tapani
2 small things below .. On 03/24/2015 05:56 PM, Emil Velikov wrote: This is a direct copy from cgl with the following tweaks - s/cgl/nacl/ - s/cgl_dl_gl_path/NACL_GLES2_LIBRARY/ - Add move the nacl_prefix function from nacl_platform.c Doing this allows us to have more consistent codebase

Re: [waffle] [PATCH 04/10] nacl: rework nacl_dl functions

2015-03-25 Thread Tapani
On 03/25/2015 08:10 AM, Tapani wrote: 2 small things below .. Found some more, there is no dl_gl in nacl_platform struct, it is gl_dl, also no ‘nacl_dl_gl_path’ so this won't compile. Also stdio.h include needs to be added for snprintf usage. On 03/24/2015 05:56 PM, Emil Velikov wrote:

Re: [waffle] [PATCH 04/10] nacl: rework nacl_dl functions

2015-03-25 Thread Emil Velikov
On 25 March 2015 at 06:10, Tapani tapani.pa...@intel.com wrote: 2 small things below .. On 03/24/2015 05:56 PM, Emil Velikov wrote: [...] +static bool +nacl_dl_check_enum(int32_t waffle_dl) +{ +switch (waffle_dl) { +case WAFFLE_DL_OPENGL: +

[waffle] [PATCH 04/10] nacl: rework nacl_dl functions

2015-03-24 Thread Emil Velikov
This is a direct copy from cgl with the following tweaks - s/cgl/nacl/ - s/cgl_dl_gl_path/NACL_GLES2_LIBRARY/ - Add move the nacl_prefix function from nacl_platform.c Doing this allows us to have more consistent codebase and additional error messages for the user. As a bonus it squashes a bug