Re: [waffle] [PATCH 4/8] cmake: use the relative path in the install targets

Committed to master. On Sat, May 24, 2014 at 11:51:31PM +0100, Emil Velikov wrote: Otherwise make DESTDIR=... install will not function properly. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- CMakeLists.txt| 4 ++-- doc/CMakeLists.txt| 4 ++--

Re: [waffle] [PATCH 5/8] cmake: reformat/update install targets

On 31/05/14 01:43, Chad Versace wrote: On Sat, May 24, 2014 at 11:51:32PM +0100, Emil Velikov wrote: Cleanup the formatting and add component for each build target. The latter will allow us to use CPack to create a component based installer for Windows. I've never used CPack, so my review

Re: [waffle] [PATCH 6/8] waffle: move WAFFLE_API out of the API header

On Sat, May 24, 2014 at 11:51:33PM +0100, Emil Velikov wrote: WAFFLE_API is used to define the symbol visibility and all functions provided by the API must be non-hidden. Thus the define should be used internally in conjunction with the compiler used in order to properly annotate the symbols.

Re: [waffle] [PATCH 0/8] Move WAFFLE_API out of the public header + misc patches

Patch 7 is committed to master. I added an r-b tag for Jose. On Thu, May 29, 2014 at 11:17:55AM -0700, Jose Fonseca wrote: The Windows specifc change (patch 7) looks good. The rest looks sensible too FWIW, but I'm not the best person to comment, as I'm not yet familiar with the code base.

Re: [waffle] [PATCH 8/8] core: update wcore_enum_to_string()

On Sat, May 24, 2014 at 11:51:35PM +0100, Emil Velikov wrote: Add a couple of missing cases - PLATFORM_GBM and DL_OPENGL_ES3. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/waffle/core/wcore_util.c | 2 ++ 1 file changed, 2 insertions(+) Committed to master.

[waffle] [PATCH 08/10] cgl: avoid leaking the PixelFormat

According to apple developer page, starting with OS X v10.5 the pixelformat is reference counted. The object is created at CGLChoosePixelFormat and should be unrefeferenced via CGLReleasePixelFormat/CGLDestroyPixelFormat. The latter two are identical accoring to the documentation. Signed-off-by:

[waffle] [PATCH 04/10] cmake: add autodetection for waffle_has_egl, glx...

Silence the pkg_check_modules and check set the default options depending on the packages found. Error out if the user has selected an option and it's requirements are not met. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- CMakeLists.txt | 2 +-

[waffle] [PATCH 05/10] waffle: remove found_platform from waffle_init_parse_attrib_list

Whenever a platform is missing a case statement, the default will kick in throwing an error and exiting the function. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/waffle/api/waffle_init.c | 9 - 1 file changed, 9 deletions(-) diff --git a/src/waffle/api/waffle_init.c

[waffle] [PATCH 03/10] waffle: remove restrict keyword from public API

We should have never defined the restrict keyword in the waffle.h header. The word is used as a hint to the compiler to provide optimisations re: pointer aliasing. Keep the symbol around, so that the compiler can still optimise the library. v2: Move the symbol definition to its user and update

[waffle] [PATCH 10/10] glx: glx_context_create_native returns GLXContext not bool

Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/waffle/glx/glx_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/waffle/glx/glx_context.c b/src/waffle/glx/glx_context.c index c7a7d91..62573dc 100644 --- a/src/waffle/glx/glx_context.c +++