Re: [waffle] [PATCH 16/33] third_party/threads: import c11 threads emulation wrappers

Emil, I'm finished reviewing for today, and am stopping here at patch 16. I'll resume reviewing tomorrow. I see that you're collecting reviewed-by tags and cleanups on versioned brancehs (for-upstream-3.*). I will defer cherry-picking patches off the mailing list onto master; and instead will wai

Re: [waffle] [PATCH 15/33] c99: use strerror_s over strerror_r under Windows

On 07/07/2014 10:28 AM, Emil Velikov wrote: > +/* > + * strerror_r (strictly speaking not C99) ^^ You documented what's wrong with defining strerror_r in a C99 compatibility header. But it would be nice to also document what's *right*. Maybe say "Not in C9

Re: [waffle] [PATCH 14/33] c99: add snprintf and strcasecmp

On 07/07/2014 10:28 AM, Emil Velikov wrote: > +#define strcasecmp _stricmp > +#define snprintf c99_snprintf ... > +static inline int > +c99_vsnprintf(char* str, size_t size, const char* format, va_list ap) Did you intentionally omit `#define vsnprintf c99_vsnprintf`? If so, then please document w

Re: [waffle] [PATCH 13/33] c99: define inline keyword and use it across waffle core

Patches 12 and 13 are Reviewed-by: Chad Versace ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 11/33] waffle_test: build as a static library

Makes sense to me. Patch 11/33 is Reviewed-by: Chad Versace ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 10/33] cmake: build with fPIC when possible

On 07/15/2014 07:44 AM, Jose Fonseca wrote: > On 07/07/14 18:28, Emil Velikov wrote: >> Some of our third_party libraries may be build without it thus we'll >> fail at >> link tim. >> >> Signed-off-by: Emil Velikov >> --- >> cmake/Modules/WaffleDefineCompilerFlags.cmake | 2 ++ >> 1 file change

Re: [waffle] [PATCH 08/33] core: return false on failure in waffle_window_resize

Patch 8/33 is Reviewed-by: Chad Versace ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 09/33] wflinfo: silence signed/unsigned comparison warning

On 07/07/2014 10:28 AM, Emil Velikov wrote: > The variable i is used as and compared vs unsigned int. > Change it's type so silcence the compiler warning. > > Signed-off-by: Emil Velikov > --- > src/utils/wflinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/uti

Re: [waffle] [PATCH 07/33] linux: plug a memory leak

Patch 7/33 is Reviewed-by: Chad Versace ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 07/33] linux: plug a memory leak

On 07/07/2014 10:28 AM, Emil Velikov wrote: > Chad, do you have a plan/idea how to handle this ? I'm assuming that > your plan is to tackle this once waffle_init is gone/replaced with a > better solution (issue #7). There appears to be a straightforward solution: add a new API call waffle_finish(

Re: [waffle] Some new and old fixes

On 15 July 2014 19:09, Jose Fonseca wrote: > On 15/07/14 18:14, Emil Velikov wrote: >> >> On 15/07/14 17:30, Jose Fonseca wrote: [snip] >> I would appreciate if you can find out where SDKDDKVer.h and windows.h are >> located for the v120 toolset and which program provided them. > > > Here it is: >