Re: [waffle] [PATCH] x11: fix for a non-zero default screen

2014-08-20 Thread Marek Olšák
Thanks. I've been experimenting with 2 GPUs and 2 monitors, each GPU having its own monitor and using a different DRI driver. Having 2 screens seems to be the only way to make both GPUs work independently while having full OpenGL on both. I have no other choice (Prime has a huge performance cost in

Re: [waffle] [PATCH] wgl: s/glX/wgl/ in error message

2014-08-20 Thread Chad Versace
On 08/20/2014 07:23 AM, Emil Velikov wrote: > Spotted while running through piglits and the test required OGL 4.0 > context on my OGL 3.3 card. > > Signed-off-by: Emil Velikov LGTM. Reviewed-by: Chad Versace ___ waffle mailing list waffle@lists.freed

Re: [waffle] Final (GSoCwise) waffle WGL release

2014-08-20 Thread Chad Versace
On 08/20/2014 06:55 AM, Emil Velikov wrote: > waffle works like a champ with WGL, even piglit approves :P > > With branches 'yet-another-round-of-msvc-fixes-1.2' [1] and 'waffle-WGL-1.2' I > can run piglit+waffle+wgl on my Windows 7 machine and even crash the drivers > on a non-concurrent run :)

Re: [waffle] [PATCH 4/4] wgl: attempt to fix the final test

2014-08-20 Thread Chad Versace
On 08/19/2014 11:42 AM, Jose Fonseca wrote: > On 19/08/14 18:44, Emil Velikov wrote: >> On 19 August 2014 16:51, Jose Fonseca wrote: >>> On 19/08/14 16:41, Jose Fonseca wrote: > I'm sure it overflows on Linux too. valgrind might complain. > > But MSVC emits code to check for stack overflow -- so

Re: [waffle] [PATCH] x11: fix for a non-zero default screen

2014-08-20 Thread Chad Versace
On 08/20/2014 07:11 AM, Emil Velikov wrote: > On 19/08/14 23:10, Marek Olšák wrote: >> From: Marek Olšák >> > Marek you have my vote if you ever run for a president, going through mesa and > waffle to fix this - you're a star :) > > Must admit that I don't have much experience with xcb but the pa

Re: [waffle] [PATCH 0/8] make check cleanup & windows support

2014-08-20 Thread Chad Versace
On 08/20/2014 05:58 AM, Emil Velikov wrote: > On 20/08/14 00:38, Chad Versace wrote: >> On 08/04/2014 07:34 AM, Emil Velikov wrote: > TEST_RUN2(gl_basic, glx_gl20, all_gl20); TEST_RUN2(gl_basic, > glx_gl21, all_gl21); > > Note that this still gives us a ton of duplication, yet I feel that > any

Re: [waffle] [PATCH 13/18] api: make dl_can_open() dl_sym() display dependent

2014-08-20 Thread Chad Versace
On 08/19/2014 11:15 AM, Emil Velikov wrote: > Actually with my rant aside [snip] I ranted too :) > we should be safe with just opening > opengl32 and returning the function pointer regardless of the API > requested. I haven't checked with the specifications but I would > assume that ES* would pro

Re: [waffle] [PATCH 13/18] api: make dl_can_open() dl_sym() display dependent

2014-08-20 Thread Chad Versace
On 08/18/2014 05:35 PM, Emil Velikov wrote: > On 18/08/14 22:40, Chad Versace wrote: >> On 08/13/2014 03:47 PM, Emil Velikov wrote: >>> On 13/08/14 23:23, Chad Versace wrote: On 07/22/2014 08:31 PM, Emil Velikov wrote: > This will allow us to correctly work around waffle design which >

[waffle] [PATCH] wgl: s/glX/wgl/ in error message

2014-08-20 Thread Emil Velikov
Spotted while running through piglits and the test required OGL 4.0 context on my OGL 3.3 card. Signed-off-by: Emil Velikov --- src/waffle/wgl/wgl_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/waffle/wgl/wgl_context.c b/src/waffle/wgl/wgl_context.c index da783

Re: [waffle] [PATCH] x11: fix for a non-zero default screen

2014-08-20 Thread Emil Velikov
On 19/08/14 23:10, Marek Olšák wrote: > From: Marek Olšák > Marek you have my vote if you ever run for a president, going through mesa and waffle to fix this - you're a star :) Must admit that I don't have much experience with xcb but the patch looks straightforward enough. Reviewed-by: Emil Vel

[waffle] Final (GSoCwise) waffle WGL release

2014-08-20 Thread Emil Velikov
Hello list, Some of you may have noticed me spamming the list recently. I would like to assure you that those days are not over, but I'm planning to tone it down. So in case you've missed it - waffle works like a champ with WGL, even piglit approves :P With branches 'yet-another-round-of-msvc-fi

Re: [waffle] [PATCH 0/8] make check cleanup & windows support

2014-08-20 Thread Emil Velikov
On 20/08/14 00:38, Chad Versace wrote: > On 08/04/2014 07:34 AM, Emil Velikov wrote: >> So it seems like I've completely missed out to send this series last >> week, so here it goes. >> >> The series covers >> - Consolidates the duplicating gl_basic_test(s) into two >> groups - all and all_but_c

[waffle] [PATCH] cmake: ensure waffle-static name differs from the shared one

2014-08-20 Thread Emil Velikov
In our current state 'make check/check-func' will succeed, but plain 'make all' will fail. This is due to naming colision when building for Windows, as RUNTIME, LIBRARY and ARCHIVE have different meanings between Windows and everyone else. Essentially the waffle.lib from the shared library will cla

[waffle] [PATCH 2/2] core/tests: silence the final MSVC warning

2014-08-20 Thread Emil Velikov
Avoid forcing intptr_t down a variable of type int. Signed-off-by: Emil Velikov --- src/waffle/core/wcore_error_unittest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/waffle/core/wcore_error_unittest.c b/src/waffle/core/wcore_error_unittest.c index b63df3b..0ac667b 1

[waffle] [PATCH 1/2] core/tests: correctly store the threads exit codes

2014-08-20 Thread Emil Velikov
The exit codes are defined as ints, while we were using an bool array. This resulted in stack corruption due to the difference of the size in the two types. Huge thanks to Jose for spotting this one. Spotted-by: Jose Fonseca Signed-off-by: Emil Velikov --- This is a replacement for [PATCH 4/4]