Re: [waffle] [PATCH] egl: Support robust access contexts with EGL 1.5.

2016-04-15 Thread Emil Velikov
Hi Bas, On 15 April 2016 at 22:04, Bas Nieuwenhuizen wrote: > EGL 1.5 also supports the EGL_CONTEXT_OPENGL_ROBUST_ACCESS > attribute without any extensions for both ES and non-ES. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/waffle/egl/wegl_config.c | 9 ++--- > src/waffle/egl/wegl_con

Re: [waffle] [PATCH] egl: correctly set the attrib/bits for robust contexts

2016-04-15 Thread Emil Velikov
On 16 April 2016 at 00:34, Emil Velikov wrote: > The EXT_create_context_robustness extension covers only GLES contexts, > while the latter EGL_KHR_create_context works for both GL and GLES ones. > Actually the second extension seems a bit inconsistent. The following section clearly lists GLES

[waffle] [PATCH] egl: correctly set the attrib/bits for robust contexts

2016-04-15 Thread Emil Velikov
The EXT_create_context_robustness extension covers only GLES contexts, while the latter EGL_KHR_create_context works for both GL and GLES ones. Cc: Bas Nieuwenhuizen Signed-off-by: Emil Velikov --- Seems like these lovely extensions managed to confused most of us. Although in all honestly, chan

[waffle] [PATCH v2] wgl: don't use ARB_create_context with pre 3.2 contexts

2016-04-15 Thread Emil Velikov
Direct port of previous commit. v2: The version should be 3.2 and not 3.0 as originally. Cc: Jose Fonseca Cc: Ilia Mirkin Signed-off-by: Emil Velikov --- src/waffle/wgl/wgl_config.c | 7 --- src/waffle/wgl/wgl_context.c | 12 +++- src/waffle/wgl/wgl_context.h | 15 ++

[waffle] [PATCH v2] glx: don't use ARB_create_context with pre 3.2 contexts

2016-04-15 Thread Emil Velikov
This way if the user requests GL pre 3.2 context which lacks the flags/extra bits which require ARB_create_context one can safely fall back to the normal/legacy entry point. This resolves piglits on non 3.2 capable drivers such as classic swrast, nouveau_vieux and alike. v2: The version should be

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 20:04, Chad Versace wrote: > On 04/06/2016 02:12 AM, Jose Fonseca wrote: >> On 05/04/16 22:45, Emil Velikov wrote: >>> This way if the user requests GL pre 3.0 context which lacks the >>> flags/extra bits which require ARB_create_context one can safely fall >>> back to the norm

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 21:56, Chad Versace wrote: > On 04/15/2016 09:36 AM, Jason Ekstrand wrote: >> On Fri, Apr 15, 2016 at 3:03 AM, Emil Velikov > > wrote: >> >> On 15 April 2016 at 03:32, Michel Dänzer > > wrote: >> > On 15.04.201

[waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Emil Velikov
From: Michel Dänzer Fixes build failure due to wl_proxy_marshal_constructor_versioned being unresolved when building against current wayland. This API was introduced in wayland 1.9.91 by commit 557032e3 ("Track protocol object versions inside wl_proxy."). The waffle code doesn't reference wl_pro

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Jason Ekstrand
On Fri, Apr 15, 2016 at 1:56 PM, Chad Versace wrote: > On 04/15/2016 09:36 AM, Jason Ekstrand wrote: > > On Fri, Apr 15, 2016 at 3:03 AM, Emil Velikov > wrote: > > > > On 15 April 2016 at 03:32, Michel Dänzer > wrote: > > > On

[waffle] [PATCH] egl: Support robust access contexts with EGL 1.5.

2016-04-15 Thread Bas Nieuwenhuizen
EGL 1.5 also supports the EGL_CONTEXT_OPENGL_ROBUST_ACCESS attribute without any extensions for both ES and non-ES. Signed-off-by: Bas Nieuwenhuizen --- src/waffle/egl/wegl_config.c | 9 ++--- src/waffle/egl/wegl_context.c | 9 +++-- src/waffle/egl/wegl_display.c | 3 +-- src/waffle/egl

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-15 Thread Chad Versace
On 04/15/2016 12:30 PM, Jose Fonseca wrote: > On 15/04/16 20:04, Chad Versace wrote: >> On 04/06/2016 02:12 AM, Jose Fonseca wrote: >>> On 05/04/16 22:45, Emil Velikov wrote: This way if the user requests GL pre 3.0 context which lacks the flags/extra bits which require ARB_create_context

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Chad Versace
On 04/15/2016 09:36 AM, Jason Ekstrand wrote: > On Fri, Apr 15, 2016 at 3:03 AM, Emil Velikov > wrote: > > On 15 April 2016 at 03:32, Michel Dänzer > wrote: > > On 15.04.2016 11:14, Michel Dänzer wrote: > >> On 14.04.2016 22

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-15 Thread Jose Fonseca
On 15/04/16 20:04, Chad Versace wrote: On 04/06/2016 02:12 AM, Jose Fonseca wrote: On 05/04/16 22:45, Emil Velikov wrote: This way if the user requests GL pre 3.0 context which lacks the flags/extra bits which require ARB_create_context one can safely fall back to the normal/legacy entry point.

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-15 Thread Chad Versace
On 04/06/2016 02:12 AM, Jose Fonseca wrote: > On 05/04/16 22:45, Emil Velikov wrote: >> This way if the user requests GL pre 3.0 context which lacks the >> flags/extra bits which require ARB_create_context one can safely fall >> back to the normal/legacy entry point. >> >> This resolves piglits on

Re: [waffle] [PATCH 3/3] tests/gl_basic_test: query context flags only for desktop GL 3.0 or later

2016-04-15 Thread Chad Versace
On 04/05/2016 02:45 PM, Emil Velikov wrote: > Spotted while attemting to use classic swrast with waffle. > > Signed-off-by: Emil Velikov > --- > tests/functional/gl_basic_test.c | 36 +++- > 1 file changed, 27 insertions(+), 9 deletions(-) Emil, I pushed this pat

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Jason Ekstrand
On Fri, Apr 15, 2016 at 3:03 AM, Emil Velikov wrote: > On 15 April 2016 at 03:32, Michel Dänzer wrote: > > On 15.04.2016 11:14, Michel Dänzer wrote: > >> On 14.04.2016 22:16, Emil Velikov wrote: > >>> On 14 April 2016 at 09:23, Michel Dänzer wrote: > From: Michel Dänzer > > Fixe

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Emil Velikov
On 15 April 2016 at 03:32, Michel Dänzer wrote: > On 15.04.2016 11:14, Michel Dänzer wrote: >> On 14.04.2016 22:16, Emil Velikov wrote: >>> On 14 April 2016 at 09:23, Michel Dänzer wrote: From: Michel Dänzer Fixes build failure due to wl_proxy_marshal_constructor_versioned being >