Re: [waffle] [PATCH 0/4] Implement gbm window_resize

2016-08-18 Thread Emil Velikov 
On 16 May 2016 at 11:48, Emil Velikov  wrote:
> Hi all,
>
> This is a respin of Emmanuel (linkmauve)'s work [1] without all the
> unneeded coping. On gbm one needs to teardown the old window (which this
> series does only if we can create the new one and make it current).
>
> Note: this adds a rather hacky looking link to the config in struct
> wgbm_window, so I'm open to suggestions how to resolve/remove it.
>
> https://github.com/evelikov/waffle/tree/for-upstream/gbm-window_resize
>
> Thanks
> Emil
>
> [1] https://github.com/waffle-gl/waffle/pull/32
>
Humble ping ?

Note: Since the patch queue is quite large and I have even more
patches that I haven't sent out, I'm planning to start pushing the
less controversial patches.
The idea is:
 * "ping"
 * wait 3 days/a week
 * run the tests (to double check for regressions)
 * push

Hope I'll get a pair of eyes to check/confirm things beforehand ;-)

Thanks
Emil
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 00/13] Core waffle cleanups

2016-08-18 Thread Emil Velikov 
On 21 June 2016 at 11:33, Emil Velikov  wrote:
> On 16 May 2016 at 11:57, Emil Velikov  wrote:
>> On 16 May 2016 at 11:54, Emil Velikov  wrote:
>>> Hi all,
>>>
>>> While looking at the gbm/egl I've noticed a few interesting bits.
>>>  - We do NULL checking for values that are guaranteed by API to be
>>> non-NULL.
>>>  - wcore_*_init does not need a return type, plus in some places we were
>>> not calling it in the correct time.
>>>  - wcore_*_teardown is a simple wrapper around assert, which (at the
>>> time the function should be called) is too late/not needed.
>>>
>>> So this series simplifies these, giving us a nice -350 line count ;-)
>>>
>>> The whole thing can be found in
>>> https://github.com/evelikov/waffle/tree/for-upstream/core-cleanups
>>>
>> For some reason git send-email seems to be choking on patches 08/13
>> and 09/13. Please check those out via the above repo or let me know if
>> you'd prefer them in other format.
>>
> I might have gone overboard (too much) folding the error label(s) in
> 09/13 "core: remove wcore_*_init() return type". I can split those up
> if people prefer.
>
Humble poke.

Emil
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

2016-08-18 Thread Emil Velikov 
On 20 July 2016 at 17:27, Emil Velikov  wrote:
> In some cases (like building on Android) the headers might not have the
> 1.5 definitions, leading to a build failures like the one in github
> issue #41.
>
> Since the ABI is baked in stone, add a local define to resolve that.
>
> Cc: Chad Versace 
> Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on
> EGL 1.5")
> Issue: https://github.com/waffle-gl/waffle/issues/41
> Signed-off-by: Emil Velikov 
> ---
>  src/waffle/egl/wegl_context.c | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/waffle/egl/wegl_context.c b/src/waffle/egl/wegl_context.c
> index 0e59231..97931fc 100644
> --- a/src/waffle/egl/wegl_context.c
> +++ b/src/waffle/egl/wegl_context.c
> @@ -34,6 +34,11 @@
>  #include "wegl_platform.h"
>  #include "wegl_util.h"
>
> +// Pre EGL 1.5 headers lack the definition.
> +#ifndef EGL_CONTEXT_OPENGL_ROBUST_ACCESS
> +#define EGL_CONTEXT_OPENGL_ROBUST_ACCESS  0x31B2
> +#endif
> +
Humble poke ?

-Emil
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle