Re: [waffle] [PATCH 1/2] Revert "wegl: add EGL image create/destroy"
On Thu 21 Jul 2016, Emil Velikov wrote: > This reverts commit 1a8e8ef3b8072fa1135dbe2a04dc6bb9f8e3a12f. > > The symbols were added as they are required by the null/surfaceless > platform. Since that one hasn't landed yet, just remove the patch. > > Furthermore, using dlsym is non-compatible (according to the spec) since > the symbols are part of an extension. eglGetProcAddress should be used. > > Feel free to bring it back, when needed. > > Cc: Frank Henigman > Cc: Chad Versace > --- > Hi all, this is weird a reminder about getting null/surfaceless updated. I started working on this recently. There's also a pile of *new* patches in the CrOS tree that need upstreaming. > As with the GBM symbols a while back - getting these back in is should > be a piece of pie. But until we need them, let's remove the dead code. Yep, I agree. For the series, Reviewed-by: Chad Versace And pushed. ___ waffle mailing list waffle@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/waffle
Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers
On Fri 19 Aug 2016, Tapani Pälli wrote:
>
>
> On 08/18/2016 01:27 PM, Emil Velikov wrote:
> > On 20 July 2016 at 17:27, Emil Velikov wrote:
> > > In some cases (like building on Android) the headers might not have the
> > > 1.5 definitions, leading to a build failures like the one in github
> > > issue #41.
> > >
> > > Since the ABI is baked in stone, add a local define to resolve that.
> > >
> > > Cc: Chad Versace
> > > Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on
> > > EGL 1.5")
> > > Issue: https://github.com/waffle-gl/waffle/issues/41
> > > Signed-off-by: Emil Velikov
> > > ---
> > > src/waffle/egl/wegl_context.c | 5 +
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/src/waffle/egl/wegl_context.c b/src/waffle/egl/wegl_context.c
> > > index 0e59231..97931fc 100644
> > > --- a/src/waffle/egl/wegl_context.c
> > > +++ b/src/waffle/egl/wegl_context.c
> > > @@ -34,6 +34,11 @@
> > > #include "wegl_platform.h"
> > > #include "wegl_util.h"
> > >
> > > +// Pre EGL 1.5 headers lack the definition.
> > > +#ifndef EGL_CONTEXT_OPENGL_ROBUST_ACCESS
> > > +#define EGL_CONTEXT_OPENGL_ROBUST_ACCESS 0x31B2
> > > +#endif
> > > +
> > Humble poke ?
>
> LGTM (checked that the values is correct):
>
> Reviewed-by: Tapani Pälli
Thanks and pushed.
___
waffle mailing list
waffle@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/waffle
