[waffle] Test Message

2012-05-21 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Just a test. - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPuqdHAAoJEAIvNt057x8ioAoP

[waffle] [PATCH 1/2] readme: Fix Chad\'s mail address

2012-05-21 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks, pushed. - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPuqiZAAoJEAIvNt057x8ifsAP

Re: [waffle] [PATCH 2/2] include: Only use restricted keyword with C99

2012-05-21 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Pauli, I think the problem with the 'restrict' keyword was fixed with commit 592129cd60f9f20d0cd3f51017b8f434bf6d55c4 Author: Chad Versace Date: Fri May 18 13:11:12 2012 -0700 include: Fix headers for C versions < C99 Could yo

[waffle] Goals for 0.4

2012-05-21 Thread Chad Versace
nded scope. Actions like setting X window manager hints. Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

[waffle] Getting started with Waffle and Piglit

2012-05-22 Thread Chad Versace
X11/EGL by setting the environment variable PIGLIT_PLATFORM=x11_egl. If you wish to experiment with something simpler than Piglit, there is a small example program at $WAFFLE_TOP/examples/gl_basic.c. [1] git://people.freedesktop.org/~chadversary/piglit.git ; waffle-v8 Chad Versace chad.vers.

[waffle] [ANNOUNCE] waffle-0.3.1

2012-05-23 Thread Chad Versace
piglit_glx_window_set_no_input() in Piglit. Changes - --- Chad Versace (4): readme: Fix typo in example code glx: Fix glx_window, don't use glXCreateWindow cmake: Bump version to 0.3.1 doc: Update release notes to 0.3.1 Pauli Nieminen (1): readme: Fix Chad's ma

Re: [waffle] [PATCH 0/2] Test and fix for EGL configs with alpha

2012-05-25 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/24/2012 07:33 AM, Pauli Nieminen wrote: > Only EGL configs [1] that are available with alpha are using 32bit composite > visual. To create a window with that visual requires a bit more parameters > than waffle is currently providing. The fix is

Re: [waffle] [PATCH 1/2] gl_basic_test: Add test that config with alpha works

2012-05-25 Thread Chad Versace
ate a separate test for "with-alpha" and "without-alpha". Perhaps they can be named like this: gl_basic.glx_gl_with_alpha gl_basic.glx_gl_without_alpha or maybe like this: gl_basic.glx_gl_alpha0 gl_basic.glx_gl_alpha1 Whatever. The name is not that important, as long as

Re: [waffle] [PATCH 2/2] x11: Support visuals that don't match root visual

2012-05-25 Thread Chad Versace
, colormap, 0}; > > xcb_void_cookie_t create_cookie = xcb_create_window_checked( > conn, > -XCB_COPY_FROM_PARENT, // depth > + x11_get_depth_for_visual(conn, screen, visual_id), // depth > window, > screen->root, // parent >

Re: [waffle] [PATCH v2 2/3] x11: Support visuals that don't match root visual

2012-05-30 Thread Chad Versace
f-by: Pauli Nieminen > --- > src/waffle/x11/x11.c | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletions(-) Thanks. Patches 1 and 2 are pushed. - Chad Versace chad.vers...@linux.intel.com -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comm

Re: [waffle] [PATCH v2 3/3] wcore_error_unittest: Fix race condition leading to forever loop

2012-05-30 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/30/2012 08:52 AM, Pauli Nieminen wrote: > Reading non-volatile value in loop without function calls allows C > compiler to generate forever loop without checking the memory value. To > avoid the problem locking or atomic operations could be used.

Re: [waffle] [PATCH v3] wcore_error_unittest: Fix race condition leading to forever loop

2012-05-31 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/31/2012 09:49 AM, Pauli Nieminen wrote: > Reading non-volatile value in loop without function calls allows C > compiler to generate forever loop without checking the memory value. To > avoid compiler optimization causing trouble take lock when re

[waffle] [PATCH] wcore_error_unittest: Fix non-terminating loop

2012-05-31 Thread Chad Versace
NUM_THREADS) ;; assembly: 5ac movl$0x0,0x94(%rsp) ... 670 cmpl$0x3,0x94(%rsp) 674 noop 678 jl 670 CC: Justen Jordan CC: Pauli Nieminen Signed-off-by: Chad Versace --- tests/unittests/waffle/core/wcore_error_unittest.c |4 ++-- 1 file

Re: [waffle] [PATCH] Enabling Waffle library for Android.

2012-06-27 Thread Chad Versace
On 06/26/2012 04:18 AM, Juha-Pekka Heikkilä wrote:> This quite big patch will enable Waffle for Android ICS, it currently use > Android make files. I tested it with the examples/gl_basic test which also > has the Android make file now. > > Most of the stuff in the src/waffle/android folder is very

Re: [waffle] Getting started with Waffle and Piglit

2012-06-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/29/2012 05:45 AM, Heikkila, Juha-pekka wrote: > Hi, > > I did check the comments you had on the patch I posted. I started some > work to fix the issues but I don't yet have anything to post. > > Couple of the issues were such where I was not th

Re: [waffle] [PATCH] glx: fix attrib list end token

2012-07-31 Thread Chad Versace
irs > terminated by the value None (0)." > > Signed-off-by: Jordan Justen Thanks, pushed. Chad Versace chad.vers...@linux.intel.com ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH] linux_dl: Use libGL.so.1 for WAFFLE_DL_OPENGL

2012-07-31 Thread Chad Versace
On 07/30/2012 06:10 PM, Jordan Justen wrote: > Use libGL.so.1 rather than libGL.so to lock down the > library ABI version. > > Signed-off-by: Jordan Justen Thanks, pushed. Chad Versace chad.vers...@linux.intel.com ___ waffle mailing

[waffle] waffle 0.3 branch created

2012-07-31 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 If you build piglit with waffle, then please begin using waffle's 0.3 branch. That branch has a stable API and receives bug fixes. The master branch currently has an unstable API and Piglit fails to build against it. - -Chad -BEGIN PGP SIGNATURE--

Re: [waffle] Piglit on Android

2012-08-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [CC'ing to the waffle list]. Hi Juha-Pekka, On 08/03/2012 04:48 AM, Heikkila, Juha-pekka wrote: > I have been back to office now and I this week posted new version of the > patch to enable Waffle on Android onto Waffle list, I don't know if you had

Re: [waffle] [PATCH] Enabling Waffle library for Android.

2012-08-07 Thread Chad Versace
context.h:android_context_destroy to the top of android_context.c. The same applies to android_config_destroy, android_display_disconnect, and android_window_destroy. - Apologies for taking 7 days to respond to your patch. I'll try to be quicker next time. If you have any objections or questions to

Re: [waffle] [PATCH 1/3] examples/gl_basic: add WINDOW_WIDTH/WINDOW_HEIGHT defines

2012-08-09 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patches 1 and 2 are pushed. Comments on patch 3. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQI9uiAAoJEAIvNt057x8inYcP/j2cHX4/DCup18BPvEGnC2D5 bebv+k0R

Re: [waffle] [PATCH 3/3] examples/gl_basic: use glReadPixels to verify correct drawing

2012-08-09 Thread Chad Versace
On 08/08/2012 04:18 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > examples/gl_basic.c | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/examples/gl_basic.c b/examples/gl_basic.c > index 628c25d..940d651 100644 > --- a/examples/gl_ba

Re: [waffle] [PATCH v2] examples/gl_basic: use glReadPixels to verify correct drawing

2012-08-09 Thread Chad Versace
Thanks, pushed. I made a small change, replacing 3-space indent with 4-indent. Perhaps you are using a Mesa formatting config for Waffle? -Chad ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH v2 3/4] gbm: initial functional gbm support

2012-08-20 Thread Chad Versace
On 08/13/2012 05:11 PM, Jordan Justen wrote: > src/waffle/gbm is based on src/waffle/wayland, and then heavily > modified. > > Tested as functional with: examples/gl_basic gbm gl|gles2 > > Signed-off-by: Ben Widawsky > Signed-off-by: Jordan Justen > --- > CMakeLists.txt | 2

Re: [waffle] [PATCH v2 1/4] CMakeLists: print includedir

2012-08-20 Thread Chad Versace
I commited this patch to master. On 08/13/2012 05:11 PM, Jordan Justen wrote:> Signed-off-by: Jordan Justen > --- > CMakeLists.txt |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 6fb8023..a4a48cb 100644 > --- a/CMakeLists.txt >

Re: [waffle] [PATCH v2 2/4] gl_basic: print a message if gl_basic is successful

2012-08-20 Thread Chad Versace
I committed this patch to master. On 08/13/2012 05:11 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > examples/gl_basic.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/examples/gl_basic.c b/examples/gl_basic.c > index 800756a..ea9243d 100644 > --- a/examples/gl_bas

Re: [waffle] [PATCH] .gitignore: add ignore filters for a built tree on linux

2012-08-20 Thread Chad Versace
Thanks. Committed to master. On 08/16/2012 02:50 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > .gitignore | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/.gitignore b/.gitignore > index e69de29..e764a27 100644 > --- a/.gitignore > +++ b/.gitignore > @@

[waffle] [ANNOUNCE] waffle-1.0.0

2012-08-23 Thread Chad Versace
rs to implement interactions with the native objects, such as keyboard input, that lie outside Waffle's scope. Acknowledgements - Contributors to this release: Ben Widawski Chad Versace Jordan Justen Pauli Nieminen Testers: Kenneth Graunke D

[waffle] [ANNOUNCE] waffle-1.0.1

2012-08-29 Thread Chad Versace
#1.0.1 Changes - --- The full set changes can be viewed with `git log waffle-1.0.0..waffle-1.0.1`. Chad Versace (4): include: Fix #include's in waffle_glx.h api: Fix return values waffle: Fix waffle_*_get_native functions waffle: Bump version to 1.0.1 -BEGI

Re: [waffle] [PATCH] Enabling Waffle library for Android.

2012-08-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thanks for incorporating the requested changes. I just commited the patch to master. I made a few cleanups to the patch, which I noted in the commit message. The code is nearly identical to your original patch, except that I had to rename some symbols

Re: [waffle] Waffle Mac Patches

2012-09-25 Thread Chad Versace
[CC'ing waffle list] On 09/24/2012 09:50 PM, Jeff wrote: > Hi Chad, > > Nice presentation on waffle at XDC! I was trying to build it on OSX and ran > into some issues with the current git master. I made some patches that fix > the build and attached them if you are interested in applying them (al

Re: [waffle] [PATCH v3 1/4] waffle: add GBM platform enumeration value

2012-09-25 Thread Chad Versace
Patches 1-3 look good. Comments on patch 4. On 09/13/2012 10:04 AM, Jordan Justen wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > include/waffle/waffle_enum.h |1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/waffle/waffle_enum.h b/include/waffle/waffle_e

Re: [waffle] [PATCH v3 4/4] gbm: initial functional gbm support

2012-09-25 Thread Chad Versace
[Apologies for long lines. Thunderbird is misbehaving today.] On 09/13/2012 10:04 AM, Jordan Justen wrote: > src/waffle/gbm is based on src/waffle/wayland, and then heavily > modified. > > Tested as functional with: examples/gl_basic gbm gl|gles2 > > Signed-off-by: Ben Widawsky > Signed-off-by:

[waffle] [PATCH 1/4] core: Emit error if an integral waffle_config attr is < -1

2012-09-25 Thread Chad Versace
For integral waffle_config attributes (such as WAFFLE_RED_SIZE and WAFFLE_SAMPLES), the only valid negative value is -1, WAFFLE_DONT_CARE. Signed-off-by: Chad Versace --- src/waffle/core/wcore_config_attrs.c | 42 ++-- 1 file changed, 21 insertions(+), 21

[waffle] [PATCH 2/4] core: Add unittests for negative integral waffle_config attributes

2012-09-25 Thread Chad Versace
This patch adds unittests for the previous commit. All tests pass. Signed-off-by: Chad Versace --- src/waffle/core/wcore_config_attrs_unittest.c | 105 ++ 1 file changed, 105 insertions(+) diff --git a/src/waffle/core/wcore_config_attrs_unittest.c b/src/waffle/core

[waffle] [PATCH 3/4] core: Emit error if boolean waffle_config attr has bad value

2012-09-25 Thread Chad Versace
That is, emit WAFFLE_ERROR_BAD_ATTRIBUTE if the value of any boolean waffle_config attribute, such as WAFFLE_DOUBLE_BUFFERED, is neither true nor false. Waffle was already checking WAFFLE_DOUBLE_BUFFERED and WAFFLE_ACCUM_BUFFER, but failed to check WAFFLE_SAMPLE_BUFFERS. Signed-off-by: Chad

[waffle] [PATCH 4/4] core: Add unittests for boolean waffle_config attrs

2012-09-25 Thread Chad Versace
unittest exist that checked that an error was thrown on bad values. This patch adds such a test for the other two. Signed-off-by: Chad Versace --- src/waffle/core/wcore_config_attrs_unittest.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a/src/waffle/core

[waffle] [PATCH 0/4] Check values of some waffle_config attrs

2012-09-25 Thread Chad Versace
wcore_config_attrs_parse() neglected to check the values of some attributes. This series adds checks and accompanying unittests. Chad Versace (4): core: Emit error if an integral waffle_config attr is < -1 core: Add unittests for negative integral waffle_config attributes core: Emit er

[waffle] Trello board

2012-09-27 Thread Chad Versace
For anyone interested, I've created a Trello board [1] for Waffle. It lists bugs and sundry tasks. There is also a link to the Trello board on Waffle's homepage. Ping me if you want write access. [1] https://trello.com/board/waffle/4f3d5a187864df3c3343c1a6 _

Re: [waffle] [PATCH v4 0/4] waffle: add gbm support

2012-10-04 Thread Chad Versace
Thanks, patches are pushed. I also bumped the version to 1.1.0 on master. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

[waffle] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Chad Versace
EADME for build requirements). Acknowledgements Contributors to this release: Chad Versace Jeff Bland Jordan Justen ` ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Chad Versace
On 10/15/2012 07:57 AM, Brian Paul wrote: > On 10/15/2012 02:37 AM, Chad Versace wrote: > > I unpacked the .xz file, then > > $ cd waffle-1.1.0 > $ export WAFFLE_SOURCE_DIR=$PWD/src > $ cmake \ > -DCMAKE_LIBRARY_PATH=$(echo $LIBRARY_PATH | sed 's/:/;/g

Re: [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Chad Versace
On 10/15/2012 11:20 AM, Brian Paul wrote: > On 10/15/2012 12:13 PM, Chad Versace wrote: >> On 10/15/2012 07:57 AM, Brian Paul wrote: >>> On 10/15/2012 02:37 AM, Chad Versace wrote: >> >>> >>> I unpacked the .xz file, then >>> >>&g

Re: [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Chad Versace
On 10/15/2012 08:59 AM, Marek Olšák wrote: > Hi Chad, > > waffle and/or piglit create an RGBA framebuffer even in the case where > only RGB is requested, which breaks these piglit tests: > - clearbuffer-display-lists (not sure > - fs-texelFetchOffset-2D > - fdo25614-genmipmap Thanks for finding t

Re: [waffle] [Mesa-dev] [ANNOUNCE] waffle-1.1.0

2012-10-15 Thread Chad Versace
On 10/15/2012 11:46 AM, Brian Paul wrote: > Got something different this time: > > $ cmake -DCMAKE_LIBRARY_PATH=$(echo $LIBRARY_PATH | sed 's/:/;/g') > -Dwaffle_has_glx=1 -Dwaffle_has_x11_egl=1 $WAFFLE_SOURCE_DIR > > -- The C compiler identification is GNU > -- Check for working C compiler: /usr/

[waffle] [ANNOUNCE] waffle-1.1.1

2012-10-16 Thread Chad Versace
ple build instructions in README.txt. Changes --- The full set changes can be viewed with `git log waffle-1.1.0..waffle-1.1.1`. Chad Versace (4): doc/building: Remove duplicate instructions found in README readme: Clarify build instructions cmake: Bundle the GNUInstallDirs module from cm

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.1.1

2012-10-17 Thread Chad Versace
On 10/17/2012 07:01 AM, Brian Paul wrote: > On 10/16/2012 04:40 PM, Chad Versace wrote: > Chad, this version seems to work fine. Thanks. > > One little thing: on your waffle web page, s/1.1.0/1.1.1/ Thanks for finding the typo. ___ wa

Re: [waffle] [PATCH] RFC: add FindWAFFLE.cmake

2012-10-17 Thread Chad Versace
By the way, in addition to Android, MS Windows will also require a FindWaffle module. Problems: - There's a lot of cruft left from the original FindPNG.cmake. All references to png and "WAFFLE images" and zlib need to be removed. - PNG is an acronym, Waffle is not. The module should be na

Re: [waffle] [PATCH] add FindWaffle.cmake,v2

2012-10-18 Thread Chad Versace
Adrian, Thanks for the patch! It's now committed to master ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

[waffle] [ANNOUNCE] waffle-1.1.2

2012-10-29 Thread Chad Versace
#1.1.2 Bugfixes - Fix segfault when tearing down an X11 window [chadv]. - Fix the Archlinux PKGBUILD [kenneth]. - Small fixes to the man pages [chadv]. Changes --- To see the full set of changes, run `git log waffle-1.1.1..waffle-1.1.2`. Chad Versace (5): pkg/archlinux: Rename pkg

Re: [waffle] [PATCH 1/2] pkg/archlinux: Explicitly set /usr/lib as the library directory.

2012-10-30 Thread Chad Versace
Thanks for the patches. They're on master now. On 10/28/2012 12:41 PM, Kenneth Graunke wrote: > By default CMake uses /usr/lib64, which is non-standard on Arch and > results in nothing being able to find the library. > > Signed-off-by: Kenneth Graunke > --- > pkg/archlinux/PKGBUILD.template | 1

Re: [waffle] [PATCH] android: include path for EGL and KHR headers

2012-10-31 Thread Chad Versace
On 10/31/2012 05:39 AM, gro...@gmail.com wrote: > From: Adrian Marius Negreanu > > add third_party directory to the include paths. > The contents of this dir were added by > e8cdc409d75d8908973316a9e9826781918cfdf7 > > Signed-off-by: Adrian Marius Negreanu Thanks. Committed to master. __

Re: [waffle] Hi just found out about this project.

2012-11-05 Thread Chad Versace
On 11/05/2012 03:17 AM, mortdeus wrote: > Hi, I just found out about this, and it is perfect for my gocos2d project > im working on. Nice. > I wanted to know if you guys have looked into google's angle > project at all and what your guys opinion is for using it for windows? I've never used ANGLE

Re: [waffle] [PATCH] Fix for Android EGL_BAD_NATIVE_WINDOW at surface creation.

2012-11-08 Thread Chad Versace
On 11/07/2012 12:57 AM, Juha-Pekka Heikkilä wrote: > From: Juha-Pekka Heikkila > > On Android Waffle always fails with EGL_BAD_NATIVE_WINDOW, this fixes that > problem. > > Signed-off-by: Juha-Pekka Heikkila Thanks, pushed. ___ waffle mailing list w

Re: [waffle] Hi just found out about this project.

2012-11-11 Thread Chad Versace
cool comes out of it. > > https://github.com/mortdeus/egles/tree/master/waffle > > On Thu, Nov 8, 2012 at 12:47 PM, Chad Versace <mailto:chad.vers...@linux.intel.com>> wrote: > > I think those two subjects---translating GL to D3D and translating among > GL

[waffle] [ANNOUNCE] waffle-1.2.0

2012-11-15 Thread Chad Versace
README for build requirements). - Added a CMake "find" module, FindWaffle.cmake, for use on platforms such as Android that lack pkg-config. Acknowledgements Contributors to this release: Adrian Marius Negreanu Chad Versace Juha-Pekka Heikkila Kenne

[waffle] [ANNOUNCE] waffle-1.2.1

2012-11-15 Thread Chad Versace
-1.2.0..waffle-1.2.1`. Chad Versace (3): doc/html: Fix fatal typo 'wafffle' in url include: #define restrict for C language < c99 doc: Add waffle-1.2.1 release notes signature.asc Description: OpenPGP digital signature ___ waffle mailin

Re: [waffle] [PATCH] android: Fold nearly all headers into waffle.h

2012-11-18 Thread Chad Versace
Adrian, I split this into two patches and committed it to the master and the 1.2 branch. Like I said in IRC, apologies for the broken 1.2 release. Waffle is now at the point where I can't decide alone that it's time to tag a release and publish the tarball. For waffle-1.3, I'll pull you and Juha

Re: [waffle] [PATCH 1/3] cmake: Add to CMAKE_MODULE_PATH before project() to allow Platform cmake modules

2012-11-27 Thread Chad Versace
Josh, I've committed patches 1 and 2 to master. Comments on patch 3. On 11/27/2012 10:43 AM, Josh Triplett wrote: > The project() command normally includes the platform-specific module > Platform/${CMAKE_SYSTEM_NAME}.cmake. To support loading that module > from the project's cmake module directo

Re: [waffle] [PATCH 3/3] Define _XOPEN_SOURCE on non-Linux platforms too

2012-11-27 Thread Chad Versace
On 11/27/2012 10:43 AM, Josh Triplett wrote: > Non-Linux platforms also respect _XOPEN_SOURCE, and require it for some > functions, such as strdup. Define it unconditionally, rather than only > when defined(__linux__). > > Signed-off-by: Josh Triplett > --- > src/waffle/core/wcore_error_unittes

[waffle] [ANNOUNCE] waffle-1.2.2

2012-11-27 Thread Chad Versace
-1.2.2`. Adrian Marius Negreanu (2): android: Fold nearly all headers into waffle.h android: Fix c99-ism in wcore_config_attrs.c Chad Versace (1): egl: Fix call to eglBindAPI for WAFFLE_OPENGL_ES3 Android.mk | 13 + src/waffle/core/wcore_config_attrs.c

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-28 Thread Chad Versace
On 11/27/2012 07:47 PM, Marek Olšák wrote: > HI Chad, > > FYI, the core GL support in the GLX backend of waffle and/or piglit > seems to be broken. All piglit tests that specify the core GL version > and are run on a driver which cannot create a core GL context (that is > any open driver except i9

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-28 Thread Chad Versace
On 11/28/2012 10:40 AM, Marek Olšák wrote: > On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace > wrote: >> On 11/27/2012 07:47 PM, Marek Olšák wrote: >>> HI Chad, >>> >>> FYI, the core GL support in the GLX backend of waffle and/or piglit >>> seems to b

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-28 Thread Chad Versace
On 11/28/2012 12:22 PM, Marek Olšák wrote: > On Wed, Nov 28, 2012 at 8:42 PM, Chad Versace > wrote: >> On 11/28/2012 10:40 AM, Marek Olšák wrote: >>> On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace >>> wrote: >>>> On 11/27/2012 07:47 PM, Marek Olšák wrote

Re: [waffle] [PATCH] glx: make unsuccessful context creation not terminate the whole process

2012-11-29 Thread Chad Versace
Marek, thanks. Until I figure out how waffle clients should register error handlers, this fix looks like a good workaround. I committed it to the master and 1.2 branch. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [waffle] [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-29 Thread Chad Versace
On 11/29/2012 01:35 PM, Eric Anholt wrote: > Chad Versace writes: > >> On 11/28/2012 12:22 PM, Marek Olšák wrote: >>> On Wed, Nov 28, 2012 at 8:42 PM, Chad Versace >>> wrote: >>>> On 11/28/2012 10:40 AM, Marek Olšák wrote: >>>>> O

Re: [waffle] Found the problem with context creation on nVidia

2012-12-19 Thread Chad Versace
On 12/18/2012 10:43 AM, Paul Berry wrote: > The nVidia driver violates these parts of the ARB_glx_create_context > extension: > > specifies a list of attributes for the context. The > list consists of a sequence of pairs terminated by the > value None (0). If an attribute is not spec

[waffle] [PATCH] glx: Add glXCreateContextAttribs workaround for NVidia bug

2012-12-19 Thread Chad Versace
explicitly requested an OpenGL 1.0 context. Reported-by: Paul Berry Signed-off-by: Chad Versace --- src/waffle/glx/glx_context.c | 37 - 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/src/waffle/glx/glx_context.c b/src/waffle/glx/glx_context.c index

Re: [waffle] Bad parameters passed to glXChooseFBConfig

2012-12-28 Thread Chad Versace
On 12/26/2012 03:25 PM, Brian Paul wrote: > In glx_config.c we're passing -1 for GLX_DEPTH_SIZE and/or > GLX_STENCIL_SIZE when those buffers are not requested. The negative > values seem to be the defaults in the wcore_config_attrs object, > coming from WAFFLE_DONT_CARE=-1. > > Per the glXGetFBCo

[waffle] [PATCH] core, man: Fix range and default value of WAFFLE_*_SIZE attrs

2012-12-28 Thread Chad Versace
L 1.4 spec (2011.04.06), Table 3.4 [3] https://developer.apple.com/library/mac/documentation/graphicsimaging/reference/CGL_OpenGL/Reference/reference.html#//apple_ref/c/func/CGLChoosePixelFormat Reported-by: Brian Paul Signed-off-by: Chad Versace --- man/waffle_config.3.xml | 6 +

Re: [waffle] [PATCH] core, man: Fix range and default value of WAFFLE_*_SIZE attrs

2013-01-03 Thread Chad Versace
On 01/03/2013 09:13 AM, Paul Berry wrote: > After this commit, I get the following errors from "make check": > > test: failed tests: > wcore_config_attrs.gl_defaults > wcore_config_attrs.gles1_defaults > wcore_config_attrs.gles2_defaults > wcore_config_attrs.gles3_defaults > wcore_confi

[waffle] [PATCH] glx: Fix gles regression

2013-01-21 Thread Chad Versace
ouble negatives are confusing.] Signed-off-by: Tom Gall Signed-off-by: Chad Versace --- Tom, I made a slight change to improve the if-condition's readability. Does this look good to you? src/waffle/glx/glx_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/

Re: [waffle] [PATCH] glx: Fix gles regression

2013-01-21 Thread Chad Versace
Thanks. Patch is committed to master and 1.2. On 01/21/2013 02:29 PM, Tom Gall wrote: > Looks good, thanks! > > On Mon, Jan 21, 2013 at 4:09 PM, Chad Versace > wrote: >> From: Tom Gall >> >> In glx_context_fill_attrib_list, recently a check was added to >&g

Re: [waffle] [PATCH] android: Fix createSurface compiler error

2013-01-28 Thread Chad Versace
Thanks, committed to master. On 01/24/2013 05:00 AM, gro...@gmail.com wrote: > From: Adrian Marius Negreanu > > it looks like createSurface changed signature: > > waffle/src/waffle/android/droid_surfaceflingerlink.cpp:113:36: > error: no matching function for call to > android::SurfaceComposerC

Re: [waffle] [PATCH] Android: Fix surface setup segfault

2013-02-20 Thread Chad Versace
On 02/18/2013 04:20 AM, Juha-Pekka Heikkila wrote: > Seems like compiling with latest Android tree malloc/free did not work > with structures in droid_surfaceflingerlink.cpp, some members > in structures become strange causing segfault. Using new/delete fix > this. > > Signed-off-by: Juha-Pekka He

Re: [waffle] shader_runner_gles3

2013-02-27 Thread Chad Versace
aw_something(); > > But, I'm not sure if something like would be functional: > waffle_init(GLX); > draw_something(); > waffle_destroy(); > waffle_init(X11_EGL); > draw_something(); > waffle_destroy(); > > What are your thoughts about this? > > -Jordan >

Re: [waffle] Minor fixes

2013-03-06 Thread Chad Versace
On 03/03/2013 03:07 AM, Jeff Bland wrote: > Patched a few minor things while testing the latest build on mac. Thanks. Patches are committed to master. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waf

[waffle] Test, please ignore (v7)

2013-04-10 Thread Chad Versace
Test, please ignore. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

[waffle] Test, please ignore (v7)

2013-04-10 Thread Chad Versace
Test, please ignore. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH] glx: Query proper extension string for ARB_create_context etc.

2013-06-03 Thread Chad Versace
Thanks. Pushed to master and 1.2. On 06/03/2013 10:55 AM, Paul Berry wrote: Previously we were using glXQueryExtensionsString() to see whether the implementation supported ARB_create_context, ARB_create_context_profile, and EXT_create_context_es_profile. This is the wrong query--those extension

Re: [waffle] [PATCH] core: Zero-initialize wcore_info struct.

2013-08-20 Thread Chad Versace
On 08/20/2013 08:55 AM, Paul Berry wrote: Without this, it's possible that the garbage memory returned by malloc will have wcore_info::is_init == true, causing wcore_tinfo_init() to skip initialization. That in turn causes a likely segfault the first time wcore_info::error is accessed. Fixes pi

[waffle] [PATCH] cmake: Fix test for thread-local storage

2013-08-20 Thread Chad Versace
es the compiler with '-Werror=missing-prototypes'. Fix the regex to more closely match gcc and clang error messages. Reported-by: Paul Berry Signed-off-by: Chad Versace --- cmake/Modules/WaffleCheckThreadLocalStorage.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[waffle] [ANNOUNCE] waffle-1.3.rc1

2013-09-19 Thread Chad Versace
A new pre-release has been tagged, waffle-1.3.rc1. The real waffle-1.3.0 will get released on Thu 26 Sept. I request your assistance in testing it on your favorite platform. Specifically, I need assistance in testing Android and Mac OS < 10.7. As long as the test application "examples/gl_basic" w

Re: [waffle] [PATCH] Android: fix examples/gl_basic for android

2013-09-20 Thread Chad Versace
On 09/20/2013 12:59 AM, Juha-Pekka Heikkila wrote: Android.mk needed few path changes and -c99 flag to allow examples/gl_basic to be compiled for android. Signed-off-by: Juha-Pekka Heikkila --- examples/Android.mk | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Thanks. Committ

[waffle] [ANNOUNCE] waffle-1.3.0

2013-09-30 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Waffle 1.3.0 (30 Sept 2013) === Waffle 1.3.0 is now available. This release introduces the ability create forward-compatible and debug contexts as well as improved support for Mac OS. Details below. As usual, the release is av

Re: [waffle] Waffle GBM support

2013-10-15 Thread Chad Versace
On 10/12/2013 12:28 PM, Barracuda wrote: Hi! I have some trouble getting GBM Waffle backend to work. I'm trying gl_basic example from sources. I start it from VT (X isn't running) as "./gl_basic --platform=gbm --api=gl", it runs OK and says "gl_basic: run was successful", however, NOTHING happe

Re: [waffle] [PATCH] gbm: try to open a render node before the card device

2013-11-14 Thread Chad Versace
On 11/12/2013 08:36 PM, Jordan Justen wrote: Since render nodes allow rendering which should not interact with the window system, we attempt to use render nodes first when a gbm device is not directly specified. The main difference as far as gbm is concerned is that render nodes don't require dr

Re: [waffle] [PATCH] waffle: use enum waffle_error instead of int

2013-11-22 Thread Chad Versace
On 11/15/2013 11:30 AM, Brian Paul wrote: Using the enum type instead of int makes debugging a little easier. It just seems like the right thing to do anyway. Thanks for the improvement, Brian. This is one of my perennical annoyances with OpenGL --- that GLenum is really an int --- so I'm surp

Re: [waffle] [PATCH] android: Fix Android Kitkat build issue

2013-12-02 Thread Chad Versace
Thanks Juha. Committed to master. Is this worth cherry-picking to the 1.3 stable branch and cutting a new release sometime soon? On 11/27/2013 11:50 PM, Juha-Pekka Heikkila wrote: Changes in Android Kitkat required one extra include file to allow using ANativeWindow. Signed-off-by: Juha-Pekka

Re: [waffle] waffle build error

2013-12-02 Thread Chad Versace
27fff73d Author: Chad Versace Date: Sun Dec 1 21:55:44 2013 -0800 cmake: Don't build unittests when waffle_build_tests=0 Return early from add_unittest() if waffle_build_tests=0, making the function a no-op. Signed-off-by: Chad Versace __

Re: [waffle] waffle build error

2013-12-02 Thread Chad Versace
On 12/02/2013 01:32 PM, Chad Versace wrote: On 12/02/2013 04:16 AM, Shazia Rahman wrote: Get these errors while building waffle after syncing latest code from git repo. [ 90%] Built target waffle_static [ 91%] Building C object src/waffle/CMakeFiles/wcore_attrib_list_unittest.dir/core

[waffle] [PATCH] cmake: Fix dependency on cmocka

2013-12-02 Thread Chad Versace
arget in Unix Makefiles. To guarantee that libcmocka.so gets built, CMake must declare that the .PHONY 'cmocka' target depends on another .PHONY target, which does the actual building. Making 'cmocka' depend on a non-PHONY target doesn't work. Reported-by: Shazia Rahman Repo

Re: [waffle] [PATCH] cmake: Fix dependency on cmocka

2013-12-02 Thread Chad Versace
On 12/02/2013 02:53 PM, Paul Berry wrote: On 2 December 2013 14:46, Chad Versace wrote: This fixes an error in the Makefile-dependency of unittests, introduced in commit ad40427a864a7436953b319fbfdb2c04ccb7bdab. From the perspective of Waffle's CMake, libcmocka.so is an *imported* li

Re: [waffle] [PATCH] cmake: Fix dependency on cmocka

2013-12-03 Thread Chad Versace
On 12/03/2013 04:41 AM, Shazia Rahman wrote: Hi, Sorry for late update. I could immediately get this working after sending my last email. Waffle builds fine now but somehow piglit fails to find it although it resides in /usr/local/lib64 directory. make install for waffle threw this: -- Install

Re: [waffle] [PATCH] waffle utils: add wflinfo utility

2013-12-20 Thread Chad Versace
On 12/19/2013 11:31 AM, Jordan Justen wrote: glxinfo for waffle, but using the command line interface of waffle's gl_basic test. This is great. I've wanted to write a windowsystem-indepent utility like this for a long time. Thanks for submitting it. Comments below. Signed-off-by: Jordan Just

[waffle] Upcoming Waffle release

2013-12-20 Thread Chad Versace
I plan to release waffle-1.4 after the following: - Jordan's new utility, wflinfo, is working on all supported platforms (including Android and Mac) - Jordan fixes any issues regarding Debian packaging Taking into account possible interruptions from winter vacation in the US, that should tak

Re: [waffle] [PATCH v2 1/4] waffle utils: add wflinfo utility

2014-01-06 Thread Chad Versace
On Mon, Dec 23, 2013 at 09:48:33PM -0800, Jordan Justen wrote: > glxinfo for waffle, but using the command line interface > of waffle's gl_basic test. > > v2: > * Various cleanups suggested by Chad > * Print context flags rather than verifying them. > * Only print extensions when --verbose is u

Re: [waffle] [PATCH v2 2/4] waffle utils: add Android.mk

2014-01-06 Thread Chad Versace
On Mon, Dec 23, 2013 at 09:48:34PM -0800, Jordan Justen wrote: > This should allow wflinfo to get built for android. > > Note: This patch has not been tested. > > Signed-off-by: Jordan Justen > --- > src/utils/Android.mk | 20 > 1 file changed, 20 insertions(+) > create mo

Re: [waffle] [PATCH v2 3/4] waffle utils: add wflinfo man page

2014-01-06 Thread Chad Versace
gt; + > +Required Parameters > + > +Options > + > +Description to > + > +Description > + > + Required Parameters > + > +Options With that change, Reviewed-by: Chad Versace ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] ldd libwaffle

2014-01-08 Thread Chad Versace
+waffle@lists.freedesktop.org On Wed, Jan 08, 2014 at 11:35:49AM -0800, Jordan Justen wrote: > Chad, > > What do you see when you use ldd on libwaffle? > > Since it dlopens libraries, I thought we might not see many libraries > in ldd, but I see: > > $ ldd /usr/lib/x86_64-linux-gnu/libwaffle-1.

  1   2   3   4   5   6   >