Re: [waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible (v2)

2016-10-27 Thread Chad Versace
On Tue 25 Oct 2016, Emil Velikov wrote: > On 24 October 2016 at 22:57, Chad Versace <chadvers...@chromium.org> wrote: > > Before EGL_EXT_platform_base and EGL 1.5, when using Mesa the best way > > to select the EGL platform was to set the EGL_PLATFORM environment > > va

[waffle] [PATCH 5/8] egl: Optionally query for eglGetPlatformDisplay (v2)

2016-10-24 Thread Chad Versace
Not yet used. v2: Use eglGetProcAddress, not dlsym, due the EGL 1.5 spec. (for emil) Cc: Emil Velikov --- src/waffle/egl/wegl_imports.h | 4 src/waffle/egl/wegl_platform.c | 23 +++ src/waffle/egl/wegl_platform.h | 4 3 files changed,

[waffle] [PATCH 2/8] egl: Update wegl_platform_init signature

2016-10-24 Thread Chad Versace
No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay. Add an `EGLenum egl_platform` parameter to wegl_platform_init() and store it at wegl_platform::egl_platform. Reviewed-by: Emil Velikov --- src/waffle/egl/wegl_platform.c| 5

[waffle] [PATCH 6/8] egl: Update wegl_display_init signature

2016-10-24 Thread Chad Versace
Change the type of parameter 'native_display' from intptr_t to void*. No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay, whose 'native_display' parameter has type void*. Reviewed-by: Emil Velikov --- src/waffle/android/droid_display.c

[waffle] [PATCH 3/8] egl: Move each platform's setenv("EGL_PLATFORM") into core EGL code (v2)

2016-10-24 Thread Chad Versace
Each EGL platform 'foo' calls setenv("EGL_PLATFORM", "foo") during foo_platform_create(), and calls unsetenv("EGL_PLATFORM") during foo_platform_destroy(). Move the setenv/unsetenv into the core EGL code, into wegl_platform_init() and wegl_platform_finish(). This prepares for eventually using

[waffle] [PATCH 1/8] egl: Define EGL_PLATFORM_* enums

2016-10-24 Thread Chad Versace
Prepares for use of eglGetPlatformDisplay. Define the enums to prevent the Waffle build from breaking against old headers... like Ubuntu LTS. Reviewed-by: Emil Velikov --- src/waffle/egl/wegl_imports.h | 26 ++ src/waffle/egl/wegl_platform.h |

[waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible (v2)

2016-10-24 Thread Chad Versace
for EGL_MESA_platform_surfaceless. This branch lives at https://github.com/chadversary/waffle/commits/review/eglGetPlatformDisplay-v02 v2: - Fix bugs found by Emil. - Don't set EGL_PLATFORM=android. - Last patch, add fallback to use eglGetPlatformDisplayEXT. Chad Versace (8): egl: Define

Re: [waffle] [PATCH 7/7] egl: Use eglGetPlatformDisplay when possible

2016-10-19 Thread Chad Versace
On Wed 19 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 17:58, Chad Versace <chadvers...@chromium.org> wrote: > > Tested against Mesa master@8c78fdb with `ninja check-func` on Linux. > > --- > > src/waffle/egl/wegl_display.c | 22 ++ > >

Re: [waffle] [PATCH 5/7] egl: Optionally dlsym eglGetPlatformDisplay

2016-10-19 Thread Chad Versace
On Tue 18 Oct 2016, Emil Velikov wrote: > On 18 October 2016 at 17:58, Chad Versace <chadvers...@chromium.org> wrote: > > +#define RETRIEVE_EGL_SYMBOL_OPTIONAL(function) \ > > +self->function = dlsym(self->eglHandle, #function); > >

[waffle] [PATCH 3/7] egl: Allow pbuffers to back wegl_surface

2016-10-18 Thread Chad Versace
Add function wegl_pbuffer_init(), which initializes a struct wegl_surface with eglCreatePbufferSurface(). Not yet used, but will be used later by the new surfaceless platform. Cc: Gurchetan Singh Cc: Haixia Shi --- src/waffle/egl/wegl_platform.c

[waffle] [PATCH 6/7] wflinfo: Support --platform=surfaceless_egl

2016-10-18 Thread Chad Versace
Cc: Gurchetan Singh Cc: Haixia Shi --- man/wflinfo.1.xml | 1 + src/utils/wflinfo.c | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/man/wflinfo.1.xml b/man/wflinfo.1.xml index a1c2589..2f54aaa 100644 ---

[waffle] [PATCH 4/7] cmake: Add option waffle_has_surfaceless_egl

2016-10-18 Thread Chad Versace
This patch contains just the CMake changes for the new surfaceless_egl platform. Code will come in the following patches. Cc: Gurchetan Singh Cc: Haixia Shi --- Options.cmake | 3 +++

[waffle] [PATCH 7/7] tests/gl_basic_test: Support platform surfaceless_egl

2016-10-18 Thread Chad Versace
Run with `bin/gl_basic_test --platform=surfaceless_egl`. All the tests fail! The rgba pixels returned by glReadPixels are black (0x0, 0x0, 0x0, 0xff), but the test expects magenta (0xff, 0x0, 0xff, 0xff). I don't know why. Cc: Gurchetan Singh Cc: Haixia Shi

[waffle] [PATCH 2/7] egl: Rename struct wegl_window -> wegl_surface

2016-10-18 Thread Chad Versace
Today, the EGLSurface belonging to struct wegl_window (and, post-patch, struct wegl_surface) is always created with eglCreateWindowSurface. But future patches will extend it to allow the EGLSurface to be a pbuffer. Hence the rename, to reduce confusion. --- src/waffle/android/droid_platform.c |

[waffle] [PATCH 1/7] egl: Rename files wegl_window.* -> wegl_surface.*

2016-10-18 Thread Chad Versace
Today, the EGLSurface belonging to struct wegl_window (and, post-patch, struct wegl_surface) is always created with eglCreateWindowSurface. But future patches will extend it to allow the EGLSurface to be a pbuffer. Hence the rename, to reduce confusion. This patch renames the files. The next

[waffle] [PATCH 7/7] egl: Use eglGetPlatformDisplay when possible

2016-10-18 Thread Chad Versace
Tested against Mesa master@8c78fdb with `ninja check-func` on Linux. --- src/waffle/egl/wegl_display.c | 22 ++ src/waffle/egl/wegl_platform.c | 35 +-- src/waffle/egl/wegl_platform.h | 8 3 files changed, 59 insertions(+), 6

[waffle] [PATCH 2/7] egl: Update wegl_platform_init signature

2016-10-18 Thread Chad Versace
No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay. Add an `EGLenum egl_platform` parameter to wegl_platform_init() and store it at wegl_platform::egl_platform. --- src/waffle/egl/wegl_platform.c| 5 - src/waffle/egl/wegl_platform.h| 5 -

[waffle] [PATCH 1/7] egl: Define EGL_PLATFORM_* enums

2016-10-18 Thread Chad Versace
Prepares for use of eglGetPlatformDisplay. Define the enums to prevent the Waffle build from breaking against old headers... like Ubuntu LTS. --- src/waffle/egl/wegl_imports.h | 26 ++ src/waffle/egl/wegl_platform.h | 2 ++ 2 files changed, 28 insertions(+) diff --git

[waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible

2016-10-18 Thread Chad Versace
for EGL_MESA_platform_surfaceless. This branch lives at https://github.com/chadversary/waffle/commits/review/eglGetPlatformDisplay-v01 Chad Versace (7): egl: Define EGL_PLATFORM_* enums egl: Update wegl_platform_init signature egl: Move each platform's setenv("EGL_PLATFORM") into core EGL

[waffle] [PATCH 4/7] egl: Query client extensions string

2016-10-18 Thread Chad Versace
Query and store the EGL client extensions string as wegl_platform::client_extensions. Prepares for eventual use of eglGetPlatformDisplay. --- src/waffle/egl/wegl_platform.c | 3 +++ src/waffle/egl/wegl_platform.h | 3 +++ 2 files changed, 6 insertions(+) diff --git

[waffle] [PATCH 6/7] egl: Update wegl_display_init signature

2016-10-18 Thread Chad Versace
Change the type of parameter 'native_display' from intptr_t to void*. No intended change in behavior. Prepares for eventual use of eglGetPlatformDisplay, whose 'native_display' parameter has type void*. --- src/waffle/android/droid_display.c | 3 +-- src/waffle/egl/wegl_display.c| 2

[waffle] [PATCH 3/7] egl: Move each platform's setenv("EGL_PLATFORM") into core EGL code

2016-10-18 Thread Chad Versace
Each EGL platform 'foo' calls setenv("EGL_PLATFORM", "foo") during foo_platform_create(), and calls unsetenv("EGL_PLATFORM") during foo_platform_destroy(). Move the setenv/unsetenv into the core EGL code, into wegl_platform_init() and wegl_platform_finish(). This prepares for eventually using

Re: [waffle] [PATCH 1/2] Revert "wegl: add EGL image create/destroy"

2016-10-12 Thread Chad Versace
On Wed 12 Oct 2016, Emil Velikov wrote: > On 11 October 2016 at 18:23, Chad Versace <chadvers...@chromium.org> wrote: > > On Thu 21 Jul 2016, Emil Velikov wrote: > >> Hi all, this is weird a reminder about getting null/surfaceless updated. > > > > I started wo

Re: [waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

2016-10-11 Thread Chad Versace
efinitions, leading to a build failures like the one in github > > > issue #41. > > > > > > Since the ABI is baked in stone, add a local define to resolve that. > > > > > > Cc: Chad Versace <chad.vers...@intel.com> > > > Fixes: f8a485e7cc7

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-06-21 Thread Chad Versace
On Thu 14 Apr 2016, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes build failure due to wl_proxy_marshal_constructor_versioned being > unresolved when building against current wayland. > > This API was introduced in wayland 1.9.91 by commit 557032e3 ("Track >

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-06-21 Thread Chad Versace
On Mon 20 Jun 2016, Chad Versace wrote: > On Sun 17 Apr 2016, Emil Velikov wrote: > > On 17 April 2016 at 01:41, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > > On Sat, Apr 16, 2016 at 4:12 PM, Emil Velikov <emil.l.veli...@gmail.com> > > > wrote: > &g

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-06-20 Thread Chad Versace
On Sun 17 Apr 2016, Emil Velikov wrote: > On 17 April 2016 at 01:41, Jason Ekstrand wrote: > > On Sat, Apr 16, 2016 at 4:12 PM, Emil Velikov > > wrote: > >> > >> On 16 April 2016 at 22:06, Jason Ekstrand wrote: > >> > >> >>

Re: [waffle] [PATCH 06/12] wflinfo: add option for JSON output

2016-06-14 Thread Chad Versace
On Thu 21 Apr 2016, Frank Henigman wrote: > On Fri, Apr 8, 2016 at 8:14 PM, Chad Versace <chad.vers...@intel.com> wrote: > > On 01/06/2016 11:56 AM, Frank Henigman wrote: > I really hope we can keep this simple. > > I mentioned in the cover letter to this series that t

Re: [waffle] json, approach 2, version 2

2016-06-14 Thread Chad Versace
On Thu 21 Apr 2016, Frank Henigman wrote: > Thanks Emil and Chad for reviewing my json series. All suggestions > implemented in v2, except where I replied inline. I'll hold off > sending in case there's more back-and-forth over the first set of > comments. Would also be nice if Chad merged his

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Chad Versace
Again, with Emil's real email. On Tue 14 Jun 2016, Chad Versace wrote: > Emil, this patch fixes the regressions caused by your patch (still > uncommitted): > > [PATCH 07/13] wegl: untangle dl_can_open() and support_api() > > On Tue 14 Jun 2016, Chad Versace wrote: > >

Re: [waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Chad Versace
Emil, this patch fixes the regressions caused by your patch (still uncommitted): [PATCH 07/13] wegl: untangle dl_can_open() and support_api() On Tue 14 Jun 2016, Chad Versace wrote: > The rules that dictate how to properly query a GL symbol are complex. > The rules depend on

[waffle] [PATCH 1/2] tests/gl_basic: Make GL symbol queries more robust

2016-06-14 Thread Chad Versace
didn't try very hard when querying a GL symbol. It tried only dlsym. If dlsym failed, then the test failed. Make gl_basic_test more robust by falling back to waffle_get_proc_address() whenever dlsym fails. Suggested-by: Emil Velikov <emil.l.veli...@collabora.co.uk> Signed-off-by: Chad V

Re: [waffle] [PATCH 00/13] Do less validation of the context version

2016-06-14 Thread Chad Versace
On Tue 26 Apr 2016, Emil Velikov wrote: > Humble ping ? And an embarrasedly late reply... This year, I've taken nearly 4 months off (paternity leave + vacation + sabbatical) and was in a Vulkan crunch for the 3 months before that. My schedule has finally returned to normal. > On 5 April 2016 at

Re: [waffle] [PATCH 00/29] Rework the functionality test(s)

2016-06-14 Thread Chad Versace
On Tue 26 Apr 2016, Emil Velikov wrote: > Humble ping ? And an embarassedly late merge. Thanks for all the cleanups. All the patches in the series, except patch 1, are merged. I skipped patch 1 because it introduced a single symbol, but that symbol was never used.

Re: [waffle] json, approach 2, version 2

2016-06-14 Thread Chad Versace
On Thu 21 Apr 2016, Frank Henigman wrote: > Thanks Emil and Chad for reviewing my json series. All suggestions > implemented in v2, except where I replied inline. I'll hold off > sending in case there's more back-and-forth over the first set of > comments. Would also be nice if Chad merged his

[waffle] [PATCH] egl: Improve support for robust GLES contexts on EGL 1.5

2016-05-02 Thread Chad Versace
Allow the creation of robust GLES contexts when EGL 1.5 is available, even when EGL_EXT_create_context_robustness is not. Cc: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> Cc: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Chad Versace <chad.vers...@intel.com> -

Re: [waffle] json, approach 2, version 2

2016-05-02 Thread Chad Versace
On Thu 21 Apr 2016, Frank Henigman wrote: [snip] > When comparing my json output to the landed json output I noticed that > the landed version omits the context flags found in the old format. > Was that deliberate? If so I'll remove it from my json. The JSON should list the context flags. It's

Re: [waffle] [PATCH 07/12] waffle: support platform-specific information

2016-05-02 Thread Chad Versace
On Sun 24 Apr 2016, Frank Henigman wrote: > On Sun, Apr 24, 2016 at 6:36 AM, Emil Velikov > wrote: > > On 21 April 2016 at 21:26, Frank Henigman wrote: > >> On Fri, Jan 8, 2016 at 7:44 AM, Emil Velikov > >> wrote: >

Re: [waffle] [PATCH v2] wgl: don't use ARB_create_context with pre 3.2 contexts

2016-04-22 Thread Chad Versace
On 04/17/2016 01:55 AM, Jose Fonseca wrote: > On 15/04/16 23:48, Emil Velikov wrote: >> Direct port of previous commit. >> >> v2: The version should be 3.2 and not 3.0 as originally. >> >> Cc: Jose Fonseca >> Cc: Ilia Mirkin >> Signed-off-by: Emil

Re: [waffle] [PATCH v2] glx: don't use ARB_create_context with pre 3.2 contexts

2016-04-22 Thread Chad Versace
On 04/15/2016 03:45 PM, Emil Velikov wrote: > This way if the user requests GL pre 3.2 context which lacks the > flags/extra bits which require ARB_create_context one can safely fall > back to the normal/legacy entry point. > > This resolves piglits on non 3.2 capable drivers such as classic

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-15 Thread Chad Versace
On 04/15/2016 12:30 PM, Jose Fonseca wrote: > On 15/04/16 20:04, Chad Versace wrote: >> On 04/06/2016 02:12 AM, Jose Fonseca wrote: >>> On 05/04/16 22:45, Emil Velikov wrote: >>>> This way if the user requests GL pre 3.0 context which lacks the >&

Re: [waffle] [PATCH] wayland: Wrap wl_proxy_marshal_constructor_versioned v2

2016-04-15 Thread Chad Versace
On 04/15/2016 09:36 AM, Jason Ekstrand wrote: > On Fri, Apr 15, 2016 at 3:03 AM, Emil Velikov > wrote: > > On 15 April 2016 at 03:32, Michel Dänzer > wrote: > > On 15.04.2016

Re: [waffle] [PATCH 1/3] glx: don't use ARB_create_context with pre 3.0 contexts

2016-04-15 Thread Chad Versace
On 04/06/2016 02:12 AM, Jose Fonseca wrote: > On 05/04/16 22:45, Emil Velikov wrote: >> This way if the user requests GL pre 3.0 context which lacks the >> flags/extra bits which require ARB_create_context one can safely fall >> back to the normal/legacy entry point. >> >> This resolves piglits on

Re: [waffle] [PATCH 3/3] tests/gl_basic_test: query context flags only for desktop GL 3.0 or later

2016-04-15 Thread Chad Versace
On 04/05/2016 02:45 PM, Emil Velikov wrote: > Spotted while attemting to use classic swrast with waffle. > > Signed-off-by: Emil Velikov > --- > tests/functional/gl_basic_test.c | 36 +++- > 1 file changed, 27 insertions(+), 9

Re: [waffle] [PATCH 4/6] egl: Add support for robust access contexts.

2016-04-11 Thread Chad Versace
On 04/06/2016 08:59 AM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/waffle/egl/wegl_config.c | 16 > src/waffle/egl/wegl_context.c | 9 + > src/waffle/egl/wegl_display.c | 1 + > src/waffle/egl/wegl_display.h | 1

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

2016-04-11 Thread Chad Versace
Thanks Bas. I pushed the patches to master. ___ waffle mailing list waffle@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

2016-04-11 Thread Chad Versace
On 04/11/2016 01:11 PM, Emil Velikov wrote: > On 6 April 2016 at 16:59, Bas Nieuwenhuizen wrote: >> Signed-off-by: Bas Nieuwenhuizen >> --- >> include/waffle/waffle.h | 4 >> man/waffle_config.3.xml | 24

Re: [waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

2016-04-11 Thread Chad Versace
low-up commit. By the way, the series is Reviewed-by: Chad Versace <chad.vers...@intel.com> There are some problems with the EGL patch, but those problems can be fixed in follow-up work. I'll send my comments to that patch soon. ___ waffle mailing

Re: [waffle] [PATCH 6/6] nacl: Add an error when trying to use a robust access context.

2016-04-11 Thread Chad Versace
On 04/06/2016 09:59 PM, Tapani Pälli wrote: > This looks correct to me; > > Reviewed-by: Tapani Pälli > > Note that following patch is required to build waffle nacl support on any > recent nacl sdk versions: > >

Re: [waffle] [PATCH 06/12] wflinfo: add option for JSON output

2016-04-08 Thread Chad Versace
On 01/06/2016 11:56 AM, Frank Henigman wrote: > With "-f json" wflinfo will now print the result of > waffle_display_info_json(). > > Signed-off-by: Frank Henigman > --- > src/utils/wflinfo.c | 40 > 1 file changed, 36

Re: [waffle] [PATCH 04/12] core: add JSON library

2016-04-08 Thread Chad Versace
On 01/08/2016 04:17 AM, Emil Velikov wrote: > On 6 January 2016 at 21:56, Frank Henigman wrote: >> A small library for building JSON strings. >> >> Signed-off-by: Frank Henigman >> --- >> src/waffle/CMakeLists.txt | 1 + >> src/waffle/core/json.c

Re: [waffle] [PATCH v3] wflinfo: Add a --format flag that prints json or the classic output

2016-04-07 Thread Chad Versace
On 01/14/2016 04:42 PM, baker.dyla...@gmail.com wrote: > From: Dylan Baker > > Adds a JSON formatted output. > > This format doesn't honor the --verbose flag, it always provides all > relevant information. > > The option parsing code is a slightly adapted version of

Re: [waffle] [PATCH] cmake: use the EGL CFLAGS in the waffle CFLAGS

2016-04-06 Thread Chad Versace
On 02/11/2016 03:21 PM, Mircea Gherzan wrote: > Without them, the build will fail with a recent Mesa from the master > branch on a system without the X headers: > > include/EGL/eglplatform.h:119:22: fatal error: X11/Xlib.h: No such file > or directory > > Signed-off-by: Mircea Gherzan

[waffle] I'm back from paternity leave

2016-04-06 Thread Chad Versace
Hi everyone, I abruptly left for paternity leave in early February, and now I'm a father! My little boy is named Lucas, and he's incredible. While on leave, I had little time to spare for non-baby activities, so it's been over two months since I read any code-related mail. I returned from

[waffle] Review Latency

2016-01-20 Thread Chad Versace
Hi everyone, I'm aware there are a few dozen patches on the mailing list awaiting review. I apologize for the latency. In my other role as a driver developer, I'm occupied trying to hit a major milestone before end of month. I expect that I'll continue to have too little time to dedicate to

Re: [waffle] [PATCH v2 4/4] wflinfo.c: Add a --json flag that prints json

2016-01-11 Thread Chad Versace
On 01/05/2016 11:46 AM, baker.dyla...@gmail.com wrote: > From: Dylan Baker Please use 'wflinfo', not 'wflinfo.c', as the commit's subject prefix. > > This adds some code to print a JSON formatted version of data provided > by wflinfo. > > Signed-off-by: Dylan Baker

Re: [waffle] [RFC 3/3] wflinfo.c: Add a --json flag that prints json

2016-01-05 Thread Chad Versace
On 12/31/2015 09:51 AM, Dylan Baker wrote: > > > On Wed, Dec 30, 2015 at 4:32 PM, Chad Versace <chad.vers...@intel.com > <mailto:chad.vers...@intel.com>> wrote: > > On 12/27/2015 07:49 AM, Frank Henigman wrote: > > On Wed, Dec 16, 2015 a

Re: [waffle] [RFC 2/3] wflinfo.c: split version, renderer, and vendor checks

2015-12-30 Thread Chad Versace
On 12/29/2015 02:37 PM, Dylan Baker wrote: > Okay, I can fix that too. > > On Sun, Dec 27, 2015 at 7:43 AM, Frank Henigman > wrote: > > On Wed, Dec 16, 2015 at 8:37 PM, >

Re: [waffle] [RFC 1/3] wflinfo.c: split out flags struct

2015-12-30 Thread Chad Versace
On 12/16/2015 05:37 PM, baker.dyla...@gmail.com wrote: > From: Dylan Baker > > This is groundwork for adding a json interface to wflinfo. > --- > src/utils/wflinfo.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git

Re: [waffle] [RFC 3/3] wflinfo.c: Add a --json flag that prints json

2015-12-30 Thread Chad Versace
On 12/27/2015 07:49 AM, Frank Henigman wrote: > On Wed, Dec 16, 2015 at 8:37 PM, wrote: >> From: Dylan Baker >> >> This adds some code to print a JSON formatted version of data provided >> by wflinfo. >> >> Signed-off-by: Dylan Baker

Re: [waffle] [PATCH 3/4] glx: remove dl_can_open restriction for supports_context_api()

2015-11-10 Thread Chad Versace
On Tue 01 Sep 2015, Emil Velikov wrote: > This seems like unnecessary book-keeping which makes the topic > "supported by the display" vs "there is a library that one can manage" > more convoluted than needed. > > One can safely assume that if the GLX implementation exposes the > extension(s) then

Re: [waffle] [PATCH 1/4] wcore: do not use get_with_default() when default_value is the same as value

2015-11-10 Thread Chad Versace
On Tue 01 Sep 2015, Emil Velikov wrote: > Signed-off-by: Emil Velikov > --- > src/waffle/core/wcore_config_attrs.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) Thanks. This patch is pushed to the master branch.

Re: [waffle] [PATCH] glx: provide our own GLX_ARB_create_context_profile defines

2015-11-09 Thread Chad Versace
On Tue 01 Sep 2015, Emil Velikov wrote: > As of recently the official Nvidia driver does provide its own GL > headers. Although they seem to be missing the defines needed to manage > desktop GL contexts. > > Include them for now to fix the build as mentioned in github issue #31. > Tested against

Re: [waffle] CI, static analisys, tests and waffle

2015-09-03 Thread Chad Versace
On Tue 01 Sep 2015, Emil Velikov wrote: > Hello all, > > Not too long ago I had the crazy idea of using some of the free > utilities out there with waffle. > > For example Coverity provides a free scan to open-source projects, > which nicely integrates with Travis-CI, > The latter of which

[waffle] [ANNOUNCE] Waffle 1.5.2

2015-08-25 Thread Chad Versace
. (See 8d20f3a). Changes since 1.5.1 --- Bernhard Rosenkränzer (1): android: Don't specify -std=gnu99 for C++ builds -- it breaks clang Chad Versace (3): gbm: Fix crash when eglChooseConfig fails gbm: Allow user to provide device path in environment waffle

Re: [waffle] [PATCH] linux: Use full libGLES*.so.[12] SONAMEs

2015-06-02 Thread Chad Versace
there. * Remove stale comment line Signed-off-by: Michel Dänzer michel.daen...@amd.com Emil, does this patch look good to you? It looks good to me. Reviewed-by: Chad Versace chad.vers...@intel.com ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-05-12 Thread Chad Versace
On Wed 06 May 2015, Jordan Justen wrote: On 2015-05-05 21:18:52, Chad Versace wrote: Since the only dynamically generated portion of waffle.h (for now, at least) will be the enum definitions, there's no reason to use XML if you feel it's overkill. (I'm also not opposed to XML, if you do

[waffle] [PATCH] examples/gl_basic: Add --fullscreen option

2015-05-05 Thread Chad Versace
This exercises Frank's recent patch that added the WAFFLE_WINDOW_FULLSCREEN attribute to waffle_window_create2(). Cc: Frank Henigman fjhenig...@google.com Signed-off-by: Chad Versace chad.vers...@intel.com --- examples/gl_basic.c | 35 +-- 1 file changed, 29

Re: [waffle] [PATCH 2/4] waffle: use enum list in waffle_enum_to_string()

2015-05-05 Thread Chad Versace
On Thu 23 Apr 2015, Emil Velikov wrote: On 22 April 2015 at 19:03, Frank Henigman fjhenig...@google.com wrote: Use the new WAFFLE_ENUM_LIST macro to implement waffle_enum_to_string() instead of specifying all the enums again. Now it will no longer be necessary to update

Re: [waffle] [PATCH 1/4] waffle: put waffle_enum items in a macro

2015-05-05 Thread Chad Versace
On Thu 23 Apr 2015, Emil Velikov wrote: On 23 April 2015 at 02:07, Frank Henigman fjhenig...@google.com wrote: On Wed, Apr 22, 2015 at 8:09 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-04-22 11:03:47, Frank Henigman wrote: List all waffle_enum items in a big #define to avoid

Re: [waffle] [PATCH 2/4] waffle: use enum list in waffle_enum_to_string()

2015-05-05 Thread Chad Versace
On Wed 22 Apr 2015, Frank Henigman wrote: Use the new WAFFLE_ENUM_LIST macro to implement waffle_enum_to_string() instead of specifying all the enums again. Now it will no longer be necessary to update waffle_enum_to_string() when adding an enum. Use bsearch() instead of a case statement, not

Re: [waffle] [PATCH 3/4] waffle: add waffle_string_to_enum()

2015-05-05 Thread Chad Versace
On Thu 23 Apr 2015, Emil Velikov wrote: On 22 April 2015 at 19:03, Frank Henigman fjhenig...@google.com wrote: From: Frank Henigman fjhenig...@gmail.com Add waffle_string_to_enum() which, given a string, returns the corresponding enum value. Since the main use is expected to be parsing

Re: [waffle] [PATCH 07/10] waffle: add full screen window request

2015-04-24 Thread Chad Versace
On Thu 23 Apr 2015, Emil Velikov wrote: On 22 April 2015 at 20:26, Chad Versace wrote: On Fri 10 Apr 2015, Emil Velikov wrote: On 09/04/15 22:48, Chad Versace wrote: On Mon 30 Mar 2015, Frank Henigman wrote: diff --git a/include/waffle/waffle.h b/include/waffle/waffle.h index

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-04-22 Thread Chad Versace
On Fri 10 Apr 2015, Jordan Justen wrote: On 2015-04-10 07:05:32, Frank Henigman wrote: Sorry I let this thread get stale. I apologise too for letting it go stale. On 02/20/2015 01:49 PM, Jordan Justen wrote: My idea was just to define a one-time API that left presentation of the

Re: [waffle] [PATCH 07/10] waffle: add full screen window request

2015-04-22 Thread Chad Versace
On Thu 16 Apr 2015, Frank Henigman wrote: On Thu, Apr 9, 2015 at 6:48 PM, Chad Versace chad.vers...@intel.com wrote: On Mon 30 Mar 2015, Frank Henigman wrote: You can now put WAFFLE_WINDOW_FULLSCREEN in the attribute list passed to waffle_window_create2() and get a full screen window

Re: [waffle] [PATCH v2] waffle: add full screen window request

2015-04-22 Thread Chad Versace
wcore_enum_to_string() - update documentation Reviewed-by: Chad Versace chad.vers...@intel.com I'll commit this to master today. ___ waffle mailing list waffle@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/waffle

Re: [waffle] [PATCH 07/10] waffle: add full screen window request

2015-04-22 Thread Chad Versace
On Fri 10 Apr 2015, Emil Velikov wrote: On 09/04/15 22:48, Chad Versace wrote: On Mon 30 Mar 2015, Frank Henigman wrote: You can now put WAFFLE_WINDOW_FULLSCREEN in the attribute list passed to waffle_window_create2() and get a full screen window. Only glx and x11_egl implemented so far

Re: [waffle] [PATCH] android: Don't specify -std=gnu99 for C++ builds -- it breaks clang

2015-04-22 Thread Chad Versace
On Thu 09 Apr 2015, Emil Velikov wrote: From: Bernhard Rosenkränzer bernhard.rosenkran...@linaro.org Signed-off-by: Bernhard Rosenkränzer bernhard.rosenkran...@linaro.org [Emil Velikov: Apply the workaround for kitkat and older] Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [waffle] [PATCH 00/10] nacl dl rework and header cleanups et all

2015-04-09 Thread Chad Versace
missing pragma once guards. Patch 6 is slightly on the bikeshed side, so I won't object it people want to take it out the back and shoot it :-P Emil, these cleanups look good to me. And I agree that bike-sheddy patch 6 does make the code a bit more readable. All patches are Reviewed-by: Chad Versace

Re: [waffle] [PATCH v2 2/3] wcore: rework non-compatible mutex initialization

2015-03-27 Thread Chad Versace
Quoting Emil Velikov (2015-03-26 19:24:21) On 26 March 2015 at 14:50, Chad Versace chad.vers...@intel.com wrote: Quoting Emil Velikov (2015-03-25 07:30:00) Indeed you're bang on the spot. id_counter should be locked throughout a series of display_{connect, disconnect}, thus we should push

Re: [waffle] [PATCH v3 4/4] wayland: resolve wayland-client symbols at runtime (via libdl)

2015-03-26 Thread Chad Versace
Quoting Emil Velikov (2015-03-18 13:03:08) On 17 March 2015 at 19:54, Chad Versace chad.vers...@intel.com wrote: Hey Emil, The patches look good to me, though I haven't tested them yet. I'm going to run the patches through a Piglit run and, if I find no regressions, I'll push them

Re: [waffle] [PATCH 1/3] third_party/threads: Use PTHREAD_MUTEX_RECURSIVE by default

2015-03-26 Thread Chad Versace
-- 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Chad Versace chad.vers...@intel.com This patch looks safe to land before the others in the series, so I'll go ahead and commit it. ___ waffle mailing list waffle@lists.freedesktop.org http

Re: [waffle] [PATCH] gl_basic: request alpha planes

2015-03-26 Thread Chad Versace
Thanks. I'll merge this to stable branches and master. Quoting Frank Henigman (2015-03-23 18:34:44) Alpha planes are written and read, so we should ask for them in the config. Signed-off-by: Frank Henigman fjhenig...@google.com --- examples/gl_basic.c | 2 ++ 1 file changed, 2

Re: [waffle] [PATCH v2 2/3] wcore: rework non-compatible mutex initialization

2015-03-26 Thread Chad Versace
Quoting Emil Velikov (2015-03-25 07:30:00) On 24 March 2015 at 17:37, Jose Fonseca jfons...@vmware.com wrote: Is wcore_display_teardown called only once, or when destroying each display? If the latter, then it's not safe to call `mtx_destroy(mutex)` on `wcore_display_teardown`. Otherwise

Re: [waffle] [PATCH v3 4/4] wayland: resolve wayland-client symbols at runtime (via libdl)

2015-03-17 Thread Chad Versace
Hey Emil, The patches look good to me, though I haven't tested them yet. I'm going to run the patches through a Piglit run and, if I find no regressions, I'll push them. ___ waffle mailing list waffle@lists.freedesktop.org

Re: [waffle] [PATCH 0/4] Remove link-time dependency of libwayland*

2015-03-03 Thread Chad Versace
On 03/03/2015 08:30 AM, Emil Velikov wrote: On 26 February 2015 at 21:26, Chad Versace chad.vers...@intel.com wrote: On 02/23/2015 12:32 PM, Emil Velikov wrote: Hello list, Second to last part of removing all the window specific bits from link-time to run-time (hail libdl). Note

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-26 Thread Chad Versace
On 02/20/2015 01:49 PM, Jordan Justen wrote: On 2015-02-20 12:58:07, Chad Versace wrote: On 02/17/2015 11:30 PM, Jordan Justen wrote: For the sake of apps who want to dump the info to a log file or to the console and get on with their lives, I think the default output format should

Re: [waffle] [PATCH] gbm: Use EGLConfig to select the correct gbm format

2015-02-26 Thread Chad Versace
On 02/24/2015 10:43 AM, Tom Stellard wrote: --- I think this is better than my original patch: http://lists.freedesktop.org/archives/waffle/2015-February/001070.html However, piglit tests still fail because the alpha channel is always 1.0. The gbm format being selected by

Re: [waffle] [PATCH] gbm: Use EGLConfig to select the correct gbm format

2015-02-26 Thread Chad Versace
By the way, I wrote a little Python script to ease the debugging of GBM formats. You may find it useful too. Here's the example usage: $ gbm-format GBM_FORMAT_BGRA1010102 0x30334142 $ gbm-format 0x30334142 GBM_FORMAT_BGRA1010102 $ gbm-format B A 3 0 GBM_FORMAT_BGRA1010102 -8- file:

Re: [waffle] [PATCH 0/4] Remove link-time dependency of libwayland*

2015-02-26 Thread Chad Versace
On 02/23/2015 12:32 PM, Emil Velikov wrote: Hello list, Second to last part of removing all the window specific bits from link-time to run-time (hail libdl). Note that the last patch looks a bit messy, mostly due to the wayland design approach to have a handful of functions defined as

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-20 Thread Chad Versace
On 02/17/2015 11:30 PM, Jordan Justen wrote: On 2015-02-10 12:09:05, Chad Versace wrote: On Sun, Feb 08, 2015 at 07:50:15PM -0500, Frank Henigman wrote: I'd like to extend wflinfo so it can print platform-specific information and eventually be able to replace glxinfo, eglinfo and the like (I

Re: [waffle] [PATCH] man: fix waffle_teardown description

2015-02-17 Thread Chad Versace
On 02/16/2015 02:41 PM, Emil Velikov wrote: Seems like I've used a bit too many tags, which caused some issues while generating the man/html page. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- man/waffle_teardown.3.xml | 39 ++- 1 file

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-11 Thread Chad Versace
On 02/10/2015 01:20 PM, Frank Henigman wrote: On Tue, Feb 10, 2015 at 4:08 PM, Frank Henigman fjhenig...@google.com wrote: Looks like Issue #3 is the format of the information. I thought it was given we should duplicate existing glxinfo/eglinfo/etc as closely as possible, in order to be a

Re: [waffle] [PATCH] gbm: Don't use a config that mesa's gbm doesn't support

2015-02-11 Thread Chad Versace
On 02/11/2015 09:53 AM, Tom Stellard wrote: Using GBM_FORMAT_ABGR was causing the B and G components to be swapped for some piglit tests. --- I have no idea if this fix is correct, but based on an IRC discussion:

Re: [waffle] [PATCH v3] nacl: add implementation for waffle_window_swap_buffers

2015-02-11 Thread Chad Versace
On 02/09/2015 06:22 AM, Tapani Pälli wrote: Implementation for nacl is somewhat different as for other platforms, platform needs to ensure that the previous swap has finished before issuing GL commands or more swaps. This is done by introducing a worker thread that does buffer swaps from a

[waffle] EGL null platform

2015-02-11 Thread Chad Versace
Frank, I see in your Github repo that you're working on support for Chrome OS's null platform. I'm looking forward to it, because some of us in Intel would like to use it too. Do you have an idea when it will be ready for upstreaming? signature.asc Description: OpenPGP digital signature

Re: [waffle] [PULL] Add the waffle_teardown API

2015-02-10 Thread Chad Versace
On 02/03/2015 05:14 PM, Emil Velikov wrote: Hi Chad, Here is to another waffle API - waffle_teardown In summary: - It pairs up with waffle_init - Cleans up some memory leaks - Allows one to switch between platforms without the need to exit the program. Let me know if you'd like me

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-10 Thread Chad Versace
On 02/10/2015 10:31 AM, Dylan Baker wrote: I like this idea, it would be convenient for piglit to be able to assume waffle info can provide all of the information we currently call out to multiple binaries for. Yes, Piglit wants this. I imagine more users will begin using it too. On Sun,

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-10 Thread Chad Versace
On 02/08/2015 04:50 PM, Frank Henigman wrote: I'd like to extend wflinfo so it can print platform-specific information and eventually be able to replace glxinfo, eglinfo and the like (I only know what's on linux). There would be a new flag to request the platform-specific output in addition

Re: [waffle] [wflinfo] [RFC] platform-specific info from wflinfo

2015-02-10 Thread Chad Versace
On 02/10/2015 01:08 PM, Frank Henigman wrote: On Tue, Feb 10, 2015 at 3:09 PM, Chad Versace chad.vers...@intel.com wrote: I see two significant design decisions that need to be made: Issue #1: Should Waffle provide a query mechanism for the native platform info? Or should it just dump

  1   2   3   >